From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 888B1E77182 for ; Thu, 12 Dec 2024 23:18:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F13448D0002; Thu, 12 Dec 2024 18:18:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC3AA8D0001; Thu, 12 Dec 2024 18:18:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8B438D0002; Thu, 12 Dec 2024 18:18:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B8A348D0001 for ; Thu, 12 Dec 2024 18:18:15 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5C687A0110 for ; Thu, 12 Dec 2024 23:18:15 +0000 (UTC) X-FDA: 82887871374.08.24FD767 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf29.hostedemail.com (Postfix) with ESMTP id CAAA3120018 for ; Thu, 12 Dec 2024 23:17:38 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="IZkO/Vp1"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734045470; a=rsa-sha256; cv=none; b=e+f91u2AS7XuYFbrLdDD6LvY+Y3YA+6RkXTQNJuFCNvpTnk+6f68TwdVuAbkaTI/EshM/u fCqnWyCATWt/zwAogIepGqXa+WH/D8QrbRYRHWkLVHW2xyUKyaXqMKgZsTdY9/9PbGy5Ib FG5X5yLQG8BRTQHE6RAc+2aGSNVLZLI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="IZkO/Vp1"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734045470; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G37KeGVU6MeLruI7xGjEHGxgNFoI6KkR5tULmzViKWE=; b=eTDWdLze/5T7BZiw281ynHFj11KOXgCkKdhZ/o93ZCNvU5ygwUf/5DVJsAQ6UIBmAjMzmS 6RZktSuFwY5dAxtp8zp/nwDkEu54E4LHzp0npQ14wWZf6VY4QCepRfrEdDQ76GwfE3MC/B aSzElk0nM4Bw2aammFmA5hlETHfOiQo= Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-4679b5c66d0so35771cf.1 for ; Thu, 12 Dec 2024 15:18:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1734045493; x=1734650293; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=G37KeGVU6MeLruI7xGjEHGxgNFoI6KkR5tULmzViKWE=; b=IZkO/Vp1PPPBquv9k9lW1DcP1o+JdXkHonkfoamVV4RhNIOn0xGSpuG5rvSPxv86Ri ZNYU6sA7HyFtxHYSQ59qUXDqvS+/PxSTIT++ygCuNxVNpigVE24nGNDHXWXEVJxKqMnC p+/LwwpJfypUrQMLgJ8JU5T9qISR+0k94GkZ/aMjdJql78/Wk1sTldvl5NCz1k4biDPO 1q0BKEXez8/lDmSB+9eZP3gLw1tSKVLuO47fxOi6fFKlpjg9R3wqWMIKNi6duCpcVPzs w9du5XErxEFf0J2+/ZyJHdqjGjJSKvCAG2pbksZK2TzejUJSDo/nGjKCptC9j/FLE+U7 Y01w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734045493; x=1734650293; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G37KeGVU6MeLruI7xGjEHGxgNFoI6KkR5tULmzViKWE=; b=IwyKc5lCMUxg/s/6ysD3Z063psM5kLRxVwFgsqD4idw5Hru+YDB/GvVllecC59Q0om 54jjlwe5VsqQ0EQzKrkkK7tJNUjtBiDGdGHsXiw2F8TvC6GyJRhqcgNhkRYyJdLsg3wX CLgYSibUT09LuKlWt4vNQcuCcaCRfBKpNDmLwR0ccf6SRg5NyzQSQvLMUNhxxkHm4g4l QUTrsELgLcIEzuQJRcGSo+65eJl9evSgzRc6OcNAlhS3PyWziPYGhp7ijmybSLXxHc4a QAy6Kd4j2Kz9saBpbbvDcnph6YMVR6YY9ZmVWZ+YOKA62aMsPLXpKUmXwd3/t9SD1/Y1 vViQ== X-Forwarded-Encrypted: i=1; AJvYcCXKhDbPueAphHOCi6okzjwi6vaZNcRlBxEw/owRnNR/dgF6sEAQGfykHg3hXyrYSdFFR10CUQ+3rg==@kvack.org X-Gm-Message-State: AOJu0Yw8hdVQ+M+Zmbbx0mOpTnpuDTk+FRu+mSKY4f3x+5X/tajZyW7n W3LVBgjEZmXahoq+Oqh7YxeNM/IsNBXgh3gk4kfdr9on9uEExSvJYT3FfofDxluN1wMtNmUZ0Pl +zOZzLG8RVkXOYXe6qnHUNtTs+8eMONFDrp1+ X-Gm-Gg: ASbGncsx2U/0Y5OM5CYet/Jlxrrqnpt6Dk8xD6mgTm0tYHaMvpH5/3f75mXLKg7hfKr yANA6Lb/pXQy/vPjvBeZrwd1LArp4kdUOPYNJnJuCJA35H+ijdNbll4E57lYTYCC6h4KH X-Google-Smtp-Source: AGHT+IHXbfzaYFKE9ku+DcAM7Ci5nnWCXllAeHKK+6mWf5Oyzgov9oKeDhH5wen2fbJZH5ZdLmfgxld+nyBk3WZixDA= X-Received: by 2002:a05:622a:258a:b0:467:8416:d99e with SMTP id d75a77b69052e-467a59d2e1emr411601cf.21.1734045492400; Thu, 12 Dec 2024 15:18:12 -0800 (PST) MIME-Version: 1.0 References: <20241212082910.30826-1-00107082@163.com> In-Reply-To: <20241212082910.30826-1-00107082@163.com> From: Suren Baghdasaryan Date: Thu, 12 Dec 2024 15:18:01 -0800 Message-ID: Subject: Re: [PATCH v2] mm/codetag: clear tags before swap To: David Wang <00107082@163.com> Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lkp@intel.com, oe-lkp@lists.linux.dev, oliver.sang@intel.com, yuzhao@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: y8gh6igmb444kym47h1j8k7usf8jf6ad X-Rspam-User: X-Rspamd-Queue-Id: CAAA3120018 X-Rspamd-Server: rspam08 X-HE-Tag: 1734045458-575287 X-HE-Meta: U2FsdGVkX1+FqV65gqXC8aXxFOfGkPdTMVee9jAK89oXlKlZeBwC03XvJ/kIZeS/mOQahqYLdgNJoOK1poxQygrYGyCxc052CARsEnq2smC4fPY1V+tjnUZhPgbPW+w6Zif0L4gIb+HXXuGjqB4hHamlNHH/ZpiNR/Wjw2m/BxmSKevWQoKkvXL3w+wOwIvSVTjRYxjBts444ZWjQSIZhZfioGVbiDe8DVCsv8/ZFn1hoUoXaE/87oaS3PSX7k2MpKBGU6zTZMy7WER/umGi+numZLaoRXiWhF0kmEnzT1hayiHj2qoguDTW5BD+ZLYS3RuP3QlZa5EkAtH27Qo4VYTf+w0AndCBxI7mKliq39SS3JV48Gjbgp6E1CRcy3kdFdqrFL1ee0XRjJZJrQx1oSEiW1FsQNgQ8tUld3yQ7UyVefWO0r+0Gvn1JfOpgHIiwXIIIErAUopqGatEgBcTzPUPiauAxlSkAKaNQDd++v+7RXznmDwkAoGYugL8fQgLQ99toFzf3zer3DXItQwyIu/06R+lGNREVFCq8KKgmGTF4J6/13BI3TNyr6AKTWajOJb+ZKDMimHVxrnZDK23iVv2qtxXIMjkaKcR7RjC+xGkZrjbGYH5AXxhbyF1fGwrXDMSBK1tQ4TGFvxYPLMlErKQDYAEBXKbISkJm1wbew+OFoCyak2GRSdNHE1nXJr4Axa9vzYpQnFYF5Jwp0ZAxnba0swJ7drlYaZJqB54UXAVhX4/xs4nRbBZ58nxWYg5klIxVSm+p9xMBC6t2jF1Xkzd12dlTSY5uQfPJpnH9OBFc43QcjiVUGuMg+cEyuWJOtvNxQ4wbiP0q8kCIaNbUKKlovX5EK89mX7CMXSK1nXi3JUrUTMlbx9t/4dvqo41/TcKvUYSNU02lcvTF8iOAQh9SO2z5dxlV4ZDw6FSMwsVfIiPPO7Azud5BFsmxBipzg27V4qPoQ/EJ4bSQd0 o6wJwMQw 1Jw3F4WDm3Hk4HA1zB1PziZEiW66nusYigKMG/ckbH5mxY2JAC1KS3WU0E/XMvjGOM2eo/BeDBBt3RwHANpTQq414BA5o1vyb+AmKQozC9PE8iRJZUqNSs69WTHABJeos31Rxy+mTf5djvm5uV2tWlDkFCuN2Get8yDEFrpokr36olAV8PFxpENl+ggZMn9AuF/lQb6NLxu08EH3mNCOIrCHbPbIOR5EGPSYjlTgJFQbn3ZvXcRmT4izVs9rry6NHv/8FCKQ4XmoHkNZP8M5Sj8PqOK3yqc8tRBBOh4Y5pZ01Ule89nIQNrCHi5lWkVHBIU3JMta8XYXLzRwryQggjm/QgVphSZDee6Y4ZkUHgHkldAFFNwy4T7nn+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.293518, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 12, 2024 at 12:29=E2=80=AFAM David Wang <00107082@163.com> wrot= e: > > When CONFIG_MEM_ALLOC_PROFILING_DEBUG is set, kernel WARN would be > triggered when calling __alloc_tag_ref_set() during swap: > > alloc_tag was not cleared (got tag for mm/filemap.c:1951) > WARNING: CPU: 0 PID: 816 at ./include/linux/alloc_tag.h... > > Clear code tags before swap can fix the warning. And this patch also fix > a potential invalid address dereference in alloc_tag_add_check() when > CONFIG_MEM_ALLOC_PROFILING_DEBUG is set and ref->ct is CODETAG_EMPTY, > which is defined as ((void *)1). > > Signed-off-by: David Wang <00107082@163.com> > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202412112227.df61ebb-lkp@intel.com > Suggested-by: Suren Baghdasaryan I didn't really suggest much in this patch, so please replace above Suggested-by with: Acked-by: Suren Baghdasaryan Thanks for fixing this! > --- > include/linux/alloc_tag.h | 2 +- > lib/alloc_tag.c | 7 +++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/include/linux/alloc_tag.h b/include/linux/alloc_tag.h > index 7c0786bdf9af..cba024bf2db3 100644 > --- a/include/linux/alloc_tag.h > +++ b/include/linux/alloc_tag.h > @@ -135,7 +135,7 @@ static inline struct alloc_tag_counters alloc_tag_rea= d(struct alloc_tag *tag) > #ifdef CONFIG_MEM_ALLOC_PROFILING_DEBUG > static inline void alloc_tag_add_check(union codetag_ref *ref, struct al= loc_tag *tag) > { > - WARN_ONCE(ref && ref->ct, > + WARN_ONCE(ref && ref->ct && !is_codetag_empty(ref), > "alloc_tag was not cleared (got tag for %s:%u)\n", > ref->ct->filename, ref->ct->lineno); > > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > index 35f7560a309a..3a0413462e9f 100644 > --- a/lib/alloc_tag.c > +++ b/lib/alloc_tag.c > @@ -209,6 +209,13 @@ void pgalloc_tag_swap(struct folio *new, struct foli= o *old) > return; > } > > + /* > + * Clear tag references to avoid debug warning when using > + * __alloc_tag_ref_set() with non-empty reference. > + */ > + set_codetag_empty(&ref_old); > + set_codetag_empty(&ref_new); > + > /* swap tags */ > __alloc_tag_ref_set(&ref_old, tag_new); > update_page_tag_ref(handle_old, &ref_old); > -- > 2.39.2 >