From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5EF6C27C76 for ; Thu, 26 Jan 2023 00:51:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30D386B0071; Wed, 25 Jan 2023 19:51:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 296636B0072; Wed, 25 Jan 2023 19:51:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1139B6B0073; Wed, 25 Jan 2023 19:51:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F03806B0071 for ; Wed, 25 Jan 2023 19:51:58 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B5C13120EF8 for ; Thu, 26 Jan 2023 00:51:58 +0000 (UTC) X-FDA: 80395123116.16.7FCEE66 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf28.hostedemail.com (Postfix) with ESMTP id 05970C0005 for ; Thu, 26 Jan 2023 00:51:56 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hw634KVE; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674694317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=erqaH/f6aiKK2Y2revDVg8Kw4fhimJKEevbWpDvyDBg=; b=jHt8qI4j2WLPLZ3QMvfi6nxrurrmoMFgXKk4FFmrfLeZJXqg/Ozrvgj8XwdGYhZC7DOlRv bfEhus1hkLRDFYElRV+FGFzZUENUE9mo1M5Rp0iS27uAPXq/fqDWjVPJVnd0mSKtqUW3VE 8J74dFJ9nka+pMcDXr5FFwiftZX/vjs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hw634KVE; spf=pass (imf28.hostedemail.com: domain of surenb@google.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674694317; a=rsa-sha256; cv=none; b=Z6PRtQxKnhsM1ALKX+Swo1aLgohwseG0AnfoRAy9nPh9BmG1kJTn9bKkHgZCVfjEd5D0XP C6YZDQ57IhBtOtYcwBWOnBD/q5ZvOgH1+tuLbZDW7K1IP5N6M0k9XteQOx44FEM4QnGV8Y m/bDkO87M9kQHmV15V06zB8ppadUeUM= Received: by mail-yb1-f170.google.com with SMTP id c124so265376ybb.13 for ; Wed, 25 Jan 2023 16:51:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=erqaH/f6aiKK2Y2revDVg8Kw4fhimJKEevbWpDvyDBg=; b=hw634KVELmZovB0koBFlTAd5HhJuv9a7pYcJyRWRKHoGtoQdRC7yF8vjOQ2U0bypmG bxJMDOSqi6YCIMq0O0u7h7DlvsucKb2iKlM/NvE7Dmx0WmnHc7FtctOsvR0ZSG7Pdi/c RIAivTP216iTEOjdE9b7cFfM4NXSuPy059FKCQhl9h+cH8k+Q2vVGluOc8e9Sq0ojcpT 3LP64M2kOZduDnYP/DTPERa7qITWr9LoSvGDwwlcByzhMus0GTtyhtr99lMEUJLUgkVM Nvw0hslXpJWDqz1wU+kVDqiaq4XhMZ7lGAb1fmx6jFLYgoaep29ldxo9/UK06Uu6JPcS mLDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=erqaH/f6aiKK2Y2revDVg8Kw4fhimJKEevbWpDvyDBg=; b=xj1YlFx5Sb4CIX2Pu3ebLyjEUDQ5C6zWkgg4QuVoVHA3CwQVaQDUznb7Yqp/MYRTMy k6JHXrDP8K/TXbG7uRo8ehlD00HsZus7ik9LcJiNXd+2tVndsd0wnV76Rq2wgnWpw1p5 jfcKQU9Qvm+oU/TXSzNgWysqhkZEJR4cOo/0k/8weVDDExB6qr9Ulu+rlVuXYu34s1d0 FS0mBPoGrALu9Jd5vFhgWz2MPZOQnkU99RvHQ48d0rUIoInMfBzX5Ffy/X4DcZQ0nxhl JjeqNznTh9dykUIiFIMJLjziF1bfVyvHPO5gcsDEoI0GCvKCEdFzlmeg7piMvxP8Gcbf qYzQ== X-Gm-Message-State: AFqh2korMvuZDviFUFk1ZyEKL0kX5LbDj4Wonb0tPzjCwqZm5NUSjdXr r+/txH+2Xq6UFdFGnCXUlro9TJFm9DanWi6MZv4mCA== X-Google-Smtp-Source: AMrXdXuWS62n/voZpqLFx7lY106TWS0DFfvcP0at+KMVcEseFA31+u6DR/UW+7IKRl7uOX0L8iaQWbLpM1VsRjvwvbM= X-Received: by 2002:a25:f305:0:b0:7b8:6d00:ef23 with SMTP id c5-20020a25f305000000b007b86d00ef23mr3939970ybs.119.1674694315876; Wed, 25 Jan 2023 16:51:55 -0800 (PST) MIME-Version: 1.0 References: <20230125233554.153109-1-surenb@google.com> <20230125233554.153109-3-surenb@google.com> <20230125162419.13379944d6c0d4253d7bc88c@linux-foundation.org> In-Reply-To: <20230125162419.13379944d6c0d4253d7bc88c@linux-foundation.org> From: Suren Baghdasaryan Date: Wed, 25 Jan 2023 16:51:44 -0800 Message-ID: Subject: Re: [PATCH v3 2/7] mm: introduce vma->vm_flags wrapper functions To: Andrew Morton Cc: michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 05970C0005 X-Rspam-User: X-Stat-Signature: q1qeoeemztsrgspgf47nhfz1tux8zmpn X-HE-Tag: 1674694316-69366 X-HE-Meta: U2FsdGVkX1/g2ktL0aTcuyvxTcYCb4ddo9OC+tvw0/tA6zq9oraJXXvHkkXYqzXTN+zxqXc5BYoQqHEf0jKVH9MPQploQhAGtvhxC1q6cqBI5xcTsZE9NpuYFpTcRtTV0QKG83BjTgJicOaaccrW/Bxq6FXj8kJdZgMz7Mlk+VrO98yHWcB3BUYvNwfzT8tYqmKvk9NGS+AGkYfveyi/XFGkh/UIn0vObjsDrekPF+6BAmrs1EQiLCrrSKV3X67HWW2A61YYYJIBY72kVOFK6f7xojT4JFv2d+xwX7c7UdruSgHi0dh6PxqL1dw1je4Ov2bLdspshRlbspF7npq7ErONPX6Vnht0wRu5R8mMsWCq0rGKWqdPri7Zlab6vzKRXGaLauiZjx57TN47TYU2pLXUQhd4XVhkOzhdsTQwut26bwG3UBy5tYHvQSgeVmmwwep/y7+QG0rX0PefcN5kOtrDpsQA93C7NBuU0vYOCo6wY6i9k1XLirKpw3QTXGj6IJhTuqEgLnRAPukI7fUzp6HUTE4UduEcsepmw93siLv/AZIn+mpJF//SLbWVuDpoacSG2p2YiRrC/cKvMR37UrsrSQpStYUUeBYz1Db+wcBvYhyeZs0b+wfp8yiTr8cGmkSZhhHjWBwkOOlc1SS+P9FJiqJTUfwzyaodjvt5wEmVJbwGnBAEqB4GaQ+nkBPmiSyPLOws7s7wWbzfXNdC3BF7x5kKn2oCPpc/MrD2oUwyiQ0FQUNQpOJ50RRsFNzbG/jacvP5Fr03SqdisZsP29yeAOqkBef15NSPLbEOwo67ZS748JWM29NdGsGwpM/R8Q7w09xKY3WOHSRHEkUS7aytvkTrWAjALSFAH2OItqhdedKnFh4n3MKY1ODPr6hr3AjA8ZQWihcqhb3vyrTrZQAQFJNuAYrjyf1M1Raeu5j6G6xmyA5FdWgbRRkCArDy+74P+n+lngpcsERKAHV MJ2QRdz4 KKh8e+O8N73XWG+5sOSYGYMvXf7bVVp2V/kKaG9Ed0ccfJJRWE4+hd2pysRNMrhoCCA4NgQUZOSoX+Xb0siHc/uywilaF8tPeCZRoTHwBp0quLRiYPorwya6js3eWLOCCK7wNklRnfmDaaqAK2DNl9yzesS3phe5ckF4m7faS8N4imq+CSzH64VjdfWg54Hrbb9hZSXh5jew/YcIFQTjaQ2VxGjbIDg+A1NFLkm6ZzEB7j6kG5BGPL9vjykxwOcQYuO/Hko+Cji+yE5NqTDRiPQD5K0S9ZYJhCC8P4Sc7SzCHp70v4RKhijrJJ3AGwMaifaBsAwm/CF5vss6Ufo0eodH+k2isqa2LQEJgeIClj7p94CUnYiFizl6pUDOj2Pzv7EDnN/PQCKB/NrqMfkKuVp5fDfTbBCH4B4PgjmXrrjcnjjc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 25, 2023 at 4:24 PM Andrew Morton wrote: > > On Wed, 25 Jan 2023 15:35:49 -0800 Suren Baghdasaryan wrote: > > > vm_flags are among VMA attributes which affect decisions like VMA merging > > and splitting. Therefore all vm_flags modifications are performed after > > taking exclusive mmap_lock to prevent vm_flags updates racing with such > > operations. Introduce modifier functions for vm_flags to be used whenever > > flags are updated. This way we can better check and control correct > > locking behavior during these updates. > > > > ... > > > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > +static inline void init_vm_flags(struct vm_area_struct *vma, > > +static inline void reset_vm_flags(struct vm_area_struct *vma, > > +static inline void set_vm_flags(struct vm_area_struct *vma, > > +static inline void clear_vm_flags(struct vm_area_struct *vma, > > +static inline void mod_vm_flags(struct vm_area_struct *vma, > > vm_flags_init(), vm_flags_reset(), etc? > > This would be more idiomatic and I do think the most-significant-first > naming style is preferable. Thanks for the suggestion! I will rename them in the next version. > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >