From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9022ECAAD3 for ; Mon, 5 Sep 2022 18:08:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44113801F7; Mon, 5 Sep 2022 14:08:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F01D801E6; Mon, 5 Sep 2022 14:08:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26990801F7; Mon, 5 Sep 2022 14:08:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 181DE801E6 for ; Mon, 5 Sep 2022 14:08:34 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E113B4057D for ; Mon, 5 Sep 2022 18:08:33 +0000 (UTC) X-FDA: 79878816906.16.D86D651 Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by imf29.hostedemail.com (Postfix) with ESMTP id 70BF31200A7 for ; Mon, 5 Sep 2022 18:08:33 +0000 (UTC) Received: by mail-il1-f170.google.com with SMTP id s3so2976738ilv.4 for ; Mon, 05 Sep 2022 11:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=hbTvjCqXtfZwCNAPDugxhLvbO4tPW4uXsytclFMPf88=; b=BWl6tEU0Jv/5Ok7izOy2X+2XFHIjW2yJwE8yMIwADusWnEOeQC8si1U6iks3IFTXtR 5tbbeyYCmyTiKFNMcU3D2cV+gb/s5ohOcUII9kU6FU7ji/Zh8BrlwKsCQaRcerXV6BGZ 8PlGGmZZYHPvdH+WgSsyR10w9r/j2bW/3D0lAGkx1tIn87fB5RB3pcjDyqMnvPGCsyas uH/yoycyrf5kaO5p9L7J37V/vDYJvxKCrEBpA8AorAMThecIv/vXA5VLdyTk9mhWPhlm xhk4J8Awk+fBDhqAh5Kc3xuDELqvWV7xGoRQ08TJNeQzRqgNOVW6ruxsZF0Lyj7+Dw3B m0Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=hbTvjCqXtfZwCNAPDugxhLvbO4tPW4uXsytclFMPf88=; b=s7pAlZwSm25fpgXZO/hEhsoebH0fWXei4wWyAOAuEcHukvRMBkc5HHG2PebGLkwToW Bi4vnpCSU/8xsE9e9dYzyowjJXLVa+JiVAaMS/OC6hD84N/hWheQtFUewTy0HKZbwjsi I2Fx24uJHpQtSNF2BSU7pjz0IsFRLS8GpiYLLQUT6qjDhFhfJPQfzeq6EN0XViOmXQ+/ R5pgw5gmC84GBfEtD9SZqqSK6C0vf3xUIpELQ2Ul15N0Uu3xLDT1x4VL1IywouXvCTWn BBX/TtHd5KUsVBYcAlWZqp0RojzzOo3tpQlU7q6MqRaJ/30ziAcZTYUrlzQnn15js+/u k3PQ== X-Gm-Message-State: ACgBeo27du+cySzpI7GijV2tBwIdjMKvPuNky004Y6hc/gUPZIwx2KxP KS7ouTGhKxQbbL7PvnO3LNXmA43jHgic9/WWtHPcHA== X-Google-Smtp-Source: AA6agR4Rv/lC85vS43o4ySf3NvmJunla0lbszDaoWXhv+p4vulk9P6WBBoE0T5B+Wry+ZoXPm1CE94n4VZxipIKzyxQ= X-Received: by 2002:a92:ca06:0:b0:2eb:391a:a2a4 with SMTP id j6-20020a92ca06000000b002eb391aa2a4mr16719486ils.199.1662401312639; Mon, 05 Sep 2022 11:08:32 -0700 (PDT) MIME-Version: 1.0 References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <20220905110713.27304149@gandalf.local.home> In-Reply-To: <20220905110713.27304149@gandalf.local.home> From: Suren Baghdasaryan Date: Mon, 5 Sep 2022 11:08:21 -0700 Message-ID: Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications To: Steven Rostedt Cc: Michal Hocko , Kent Overstreet , Mel Gorman , Peter Zijlstra , Andrew Morton , Vlastimil Babka , Johannes Weiner , Roman Gushchin , Davidlohr Bueso , Matthew Wilcox , "Liam R. Howlett" , David Vernet , Juri Lelli , Laurent Dufour , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Daniel Bristot de Oliveira , Valentin Schneider , Christopher Lameter , Pekka Enberg , Joonsoo Kim , 42.hyeyoo@gmail.com, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Shakeel Butt , Muchun Song , arnd@arndb.de, jbaron@akamai.com, David Rientjes , Minchan Kim , Kalesh Singh , kernel-team , linux-mm , iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662401313; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hbTvjCqXtfZwCNAPDugxhLvbO4tPW4uXsytclFMPf88=; b=yes27TIV2iZ3uUS5dyClItxOHjp4AMVE8o+BGsgCFqFZGc3DIwtpXWFExkM8P0/BNFPAof Ut8Faw7KhuLgzxwXw9F4cxmR6A6+9oqrcvumK6jF9UztgL+9nfRSepoXspzVUQ1W97PQrX XwB1Tm/04B8lRyaQRJb+at0qyrk4EHU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=BWl6tEU0; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.166.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662401313; a=rsa-sha256; cv=none; b=J03MpNif7GbZoKCuJNnamBGSYw+wFk5L/bPWZ8BHKTdFhf/os8L1yql2D5o0nC5k3LpQuO bhUn+HxsmiX7pvmlBvvz4USb/V7+RX8R8fPbAONTegfaiN4ZOv5w1uXwzRhZEp3KEAt+2W KISUm27qsECR7Qb9O8OfwR63NTqlrWA= X-Stat-Signature: 8b89obr3rtpfbziy5k7iig6cyow51jks X-Rspamd-Queue-Id: 70BF31200A7 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=BWl6tEU0; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.166.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1662401313-80400 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 5, 2022 at 8:06 AM Steven Rostedt wrote: > > On Sun, 4 Sep 2022 18:32:58 -0700 > Suren Baghdasaryan wrote: > > > Page allocations (overheads are compared to get_free_pages() duration): > > 6.8% Codetag counter manipulations (__lazy_percpu_counter_add + __alloc_tag_add) > > 8.8% lookup_page_ext > > 1237% call stack capture > > 139% tracepoint with attached empty BPF program > > Have you tried tracepoint with custom callback? > > static void my_callback(void *data, unsigned long call_site, > const void *ptr, struct kmem_cache *s, > size_t bytes_req, size_t bytes_alloc, > gfp_t gfp_flags) > { > struct my_data_struct *my_data = data; > > { do whatever } > } > > [..] > register_trace_kmem_alloc(my_callback, my_data); > > Now the my_callback function will be called directly every time the > kmem_alloc tracepoint is hit. > > This avoids that perf and BPF overhead. Haven't tried that yet but will do. Thanks for the reference code! > > -- Steve