From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D873D18148 for ; Mon, 14 Oct 2024 20:48:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3C8E6B0083; Mon, 14 Oct 2024 16:48:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEC986B0085; Mon, 14 Oct 2024 16:48:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB3C46B0088; Mon, 14 Oct 2024 16:48:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9CE206B0083 for ; Mon, 14 Oct 2024 16:48:39 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D4E6A1A0511 for ; Mon, 14 Oct 2024 20:48:24 +0000 (UTC) X-FDA: 82673396106.03.C93A578 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf20.hostedemail.com (Postfix) with ESMTP id 9C9581C001D for ; Mon, 14 Oct 2024 20:48:29 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=u3nebdxn; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728938774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oLiOJMlbQiOQsxhqpnja9W8p5wjHHPLRN1lJCefWKIQ=; b=e6VfocsE7zAUsagKtfVs89OtXvZb0GorptirNJWFSGrXOgkM4QzDxlpws2bqOfq4cjlZfA cvM9F15G65FqORq1L+eNMfOyEjkobLyrMmp2b1dPh8aEhPypmFNX0hNKaCgtcx/hmXEXYE T6KSEy7evjHzbhYzxbFbv7LzAgekPbo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728938774; a=rsa-sha256; cv=none; b=044j9Puuku1C6xPndaOqbWLbwuVuAGwSO2ddCZ2ePoe0taHELvNSAHQ3cVeaZrkhV3K4vf Td5azlEjhAsMHdZI83YcJM/AezWwZkoXvgVGmPmKqdNR82aHmG5z2FbX0tJi33BpJ5z+F2 vJs81bQESToU6oY2jET5k7Z0krQqhng= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=u3nebdxn; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-20c87b0332cso313925ad.1 for ; Mon, 14 Oct 2024 13:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728938916; x=1729543716; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oLiOJMlbQiOQsxhqpnja9W8p5wjHHPLRN1lJCefWKIQ=; b=u3nebdxn3OpRumI4peYisB3j+O8ytzv5+PGi20S0YZusoW4dSFLS1PC2ydcUfQ5gXD eCPktV0v4spra7vrnI/zPZTFwhpZRIsn3+g5lWgIpPy9Bu5CjatbrNPInHK8MDHOS/k5 4uTcnWNb2/Z1yUo3Du1W6BApaNPdMEiMEdFwMxV8W1LqOcAY0wKkU5Jbki4OdgHEqfYO x/dgRAMM2uwTcFzwYGM11Ys+MBU2oVckz/8bramfbZuvtkmBBRFHbiGKKWItDSqTtBup rQ/vXgPXl/9klvyNisb5hytV3TGRGYuhFqde/+8sXO8e/KxZ21NLbnCzFLCjWU/MDLaA 7N6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728938916; x=1729543716; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oLiOJMlbQiOQsxhqpnja9W8p5wjHHPLRN1lJCefWKIQ=; b=TABMcz/ZUgAf/1sNUO4NnaUW4IWf4eLxaYDDUXmxrUeNlDCbXCeSNtRoy9+m/pIhhc wDIVj37DDAm/I5B3KyX9NUVOm52pkGaIFAR7ehSedDq3KoFnjObkce4ZLAezmvVdaSar n8GUAy5KmoyaapSd3z2WKqXnY5PX0SexU6RGtOAQOCI9uvc3+A5eoZ8ibIphVFhMuSJ1 gYMDgNEYUfUcDsBkxvxE71mbPZPmiRrZ/fmTHwIMN56zz9YRey2dKD/hmgFqsJ5s61/M XREVEiQueVNySKob+QqDV0ZaZLca7FdQKHKDsMXvYMeVvV0xgd2JDM/0WU9kOTMLVCL3 tyzg== X-Forwarded-Encrypted: i=1; AJvYcCU0GYsD7bzFaCYyToOKstEXD1Obj+J2wMyoXSOZhS+OMgZYGVsPpxYC+GepsCzFpNhwI39f1pT5gg==@kvack.org X-Gm-Message-State: AOJu0YwU1HYRU/xAXmAutA0Rd2RTcJzPy5MrsiFEYTInadUzt2cjrw6B I0qVJLYxYNGZ/mQ0T83WHitoHmcQtBK0Ip6eYvBNo6Zr0R1LNE7IZiwg1KGypHtfU2ZnCheAw0K s9kCcowrozW1ZHOPpXbmEngOou/Ew9nHcor+A X-Google-Smtp-Source: AGHT+IElWbl5AVByUDgVhkR4DJhOP0D4H2xXZYriU+tuWxs0dxelbS2co5cCS0cZFwpG8zDMPaW/VapnM4qXE+UzLNw= X-Received: by 2002:a17:902:ea0d:b0:20b:a6f5:2770 with SMTP id d9443c01a7336-20cbce0d691mr4772125ad.6.1728938915788; Mon, 14 Oct 2024 13:48:35 -0700 (PDT) MIME-Version: 1.0 References: <20241010205644.3831427-1-andrii@kernel.org> <20241010205644.3831427-2-andrii@kernel.org> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 14 Oct 2024 13:48:23 -0700 Message-ID: Subject: Re: [PATCH v3 tip/perf/core 1/4] mm: introduce mmap_lock_speculation_{start|end} To: Andrii Nakryiko Cc: Shakeel Butt , Andrii Nakryiko , linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, peterz@infradead.org, oleg@redhat.com, rostedt@goodmis.org, mhiramat@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, paulmck@kernel.org, willy@infradead.org, akpm@linux-foundation.org, mjguzik@gmail.com, brauner@kernel.org, jannh@google.com, mhocko@kernel.org, vbabka@suse.cz, hannes@cmpxchg.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 9yppz15cgqc68473gtrt4jsgiekdw7oj X-Rspamd-Queue-Id: 9C9581C001D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1728938909-577905 X-HE-Meta: U2FsdGVkX1+zz9YuQ/fbpH/m3gkGDSk4VJjQfpbkwM8yUEJN/++koUaq/Jg/9rTz2OkbgWxcrboZAPLjNNoSk78fnTe4OC/118TiSQMk/nY+wrEUJJxxSuCBL6Iu383gTj8Il0JC8Fo8kdIRmuGk/smkB0jfvZvKWtBK6MyVQCz7tLx4xRf4hubY9UDtoPAJ6xLOJwiVKsv90F04Qvlj0OWJhuaApB1Pcwiaa4/S5CAANcORHZecK4Z8GY0ZJgaT2FFJNk4gBkPLLWpQbe6+hBfHd8/iV8EYKo7B2fIOMQ8emWsttClygizw4ba+mrmqoLGTIQgmoRnJk4bJCsfisjwyNcOs+C5gh6gsk3y3NyVnAWhprPLnBJDE9fRuaz7hlbeMwLEMlVrdRV8drlfVPJVnxeKPQD9k65f0jsyIYip7xVdzUuslHsXKWuFF031VMULDPNwt+BqWdJ3MTLbsqOvii3DVrT5UyBQdINUUP89wO0UzE+X/FFB77blDQ4N+yg7kTcdgtXmqg1XwAoSAG3AQyVMbzqRgZdkl3bdR7kdMYTL8A6+EzGHh5Ls7/dpJHCvX6iSCcmx/0H880J8eY3xBtrujC/uUajoEaW/0AdWNB0vX2fteDPOzjoBqwTL5uhJJf0j60uCsPz6uelH/E5q3+x7MlDr2NwWfgmM/XVjtymVswc6N36qLT2ciwqj7q1tQlzbVbeBxmLxXSQc6pYGBErCYcqisYVBy5cSqFwXvfUGDWEk2+RkqeKlrzvHLvTJC1R3nHezb6pl9ylohxYmfMLkwzVhKUdhaxr9Bvt/oBrhR5DTorNxS8JJcTa7qOOE8p0Xqiz0N81UjD7zdc4jKTE9yQSZgvG5ie04lm9e7fr7P5kkQvYQGZUQz2GrUBpD9wdOyszyuka6aDWZx4+EPCYQQPvR8HZZAfxDQRleo1B4goMytPHcY/bt+upP539cITmjwSFANxMX/d3A eFOfjq2m xHak46czLR2ZbcPz7wvlOgslAVywBGxF6ehOjya0LWgso7TIpIkPgcpV6w6Bwz9k6i7MlZ2LWFpBNBG4ms+FKz0Sep/6ww/KwB/Thq4pREpqjn1RbazYAO63q5VD0lBsVRR6R3FhEaVTfq8GUQyXcAP8w9KQ0VcvJAcOu5jeDUiQfuVfL1eNe7X6qhIxQOeFhZ9D9rSTT7kgkFmBpApBdVH2tlkVxGBGEcgtZRRFw0oPjXEU+G/ue9xpEoCBE0AVH8TdUmRh4ZOXh4Jw0uJmphPZkHQCgHsdzskBNAsAQkp3eAYaPVvS3Y9YXlA/misVH3QpXPfDlYBdcBmQFChUcSyAQHzdr6KTQHNMFcOGfkBZIzUfZvz3XesjZH/pz46W9Tn/GxYNlHdK7xlUSL1ADy68GvSiQa9OJodZS6WmpNbmdCct0hBxpZXc5z6jAe8NT6h9Z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 1:27=E2=80=AFPM Andrii Nakryiko wrote: > > On Sun, Oct 13, 2024 at 12:56=E2=80=AFAM Shakeel Butt wrote: > > > > On Thu, Oct 10, 2024 at 01:56:41PM GMT, Andrii Nakryiko wrote: > > > From: Suren Baghdasaryan > > > > > > Add helper functions to speculatively perform operations without > > > read-locking mmap_lock, expecting that mmap_lock will not be > > > write-locked and mm is not modified from under us. > > > > > > Suggested-by: Peter Zijlstra > > > Signed-off-by: Suren Baghdasaryan > > > Signed-off-by: Andrii Nakryiko > > > Link: https://lore.kernel.org/bpf/20240912210222.186542-1-surenb@goog= le.com > > > > Looks good to me. mmap_lock_speculation_* functions could use kerneldoc > > but that can be added later. > > Yep, though probably best if Suren can do that in the follow up, as he > knows all the right words to use :) Will add to my TODO list. > > > > > Reviewed-by: Shakeel Butt > > > > Thanks! > > >