From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94534C3DA6D for ; Tue, 20 May 2025 23:26:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 159C86B0085; Tue, 20 May 2025 19:26:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10B126B0089; Tue, 20 May 2025 19:26:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3DC86B008A; Tue, 20 May 2025 19:26:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CCAB26B0085 for ; Tue, 20 May 2025 19:26:42 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6DB6AC1813 for ; Tue, 20 May 2025 23:26:42 +0000 (UTC) X-FDA: 83464873044.11.1287E92 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf03.hostedemail.com (Postfix) with ESMTP id BD36C20005 for ; Tue, 20 May 2025 23:26:40 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tnZzc3Km; spf=pass (imf03.hostedemail.com: domain of surenb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747783600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4HHtawmhPaENN0DEAVnLAXYRZmmNd4h+JyE33PQj454=; b=H9eRBMl54L5FSHs1QKtVmLobJUkVtSa7n5aohl/e8Kgy5A+Zx7W/J563Za+lb6/35g8smY a0cCgd7hJ+MYUV1dPqLnDTr6WZ+O4YCFS+HnDOauVPWdaeOgPZ5BDJgPKGU5Mtl9oIPoGA eeRh6znAc+LNkVYR30L8VtEMytUa7vE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tnZzc3Km; spf=pass (imf03.hostedemail.com: domain of surenb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747783600; a=rsa-sha256; cv=none; b=SvoYa590j8OJU1npkt0CDXrGBkNmxmXTK6R1wlGZM0ZQhNIc02vLGn3T4N/oWqg7df7B2L UwzqdummswyZkpdmSz+yxbp9u2A5Fb7WPzLJn4w75d2DDdN1rtt+mLUizimUcULSw/+wig hezisorlUjUZi8ZdtiwdE2KL63uenc4= Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4774611d40bso991071cf.0 for ; Tue, 20 May 2025 16:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747783600; x=1748388400; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4HHtawmhPaENN0DEAVnLAXYRZmmNd4h+JyE33PQj454=; b=tnZzc3KmkNJxq7JFbDNLk9vyKnzJVaCeMp+8zOdg/hvhk8JwInTqumAsjPbHMARQJN N2N8GGvWnootYd9g8MVKGUrwbdXFYw36sAmpgUcMqJDMka2BxhrIMX9t+WKYtQ52+e5l hDWflY2UHeRITgShgZeNzRpjKPKoB4yYLIhZ5j2rYmXg8Btu08aodSHL+4O7QPg2Ubtd pOGDQdfo9pmxWgRTmxRZV9OgLSdpz+CLaj7tAR6gF3tpDggHOKqtF9xPqVM1afjVBTQH RE/aT6zBwH/nYJHALkYIsecftSys0LJaxuJDmdbMALq07dqrGFMAdVyiMjCGTAB0vnDP N0VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747783600; x=1748388400; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4HHtawmhPaENN0DEAVnLAXYRZmmNd4h+JyE33PQj454=; b=tnkYz96WXLIPJl7jDda+hdXJuiiHQTiI7/Pzk3o2vqURMUKih8ZeihYHa1miM1ILKd wdz6y+Q/DM0nlU1aaaD6PFY5uwlV8mLEoIoQZEc7Lp2rzwu0N7YctxYQrSC9OWszqGvd j6ZywsrqcRigbSp2yuEOeUrSvJKzyhrYtkuqTgb1uz4EmNxvN/vKxXZB4exyRkooqnJo eoJAZZTaWzXDtMtAoK/MSpd0pWwhFXy8KF40tC36E2W2ePXEqcIKg95czf76Zv2yUEoI cjgqjJ9GGzSAS4C+awgHhC9+sTJiBHB5fe/wCAkJJwWUGlIhjiCNE8UNoeawOMiDlG1O rwhQ== X-Forwarded-Encrypted: i=1; AJvYcCWiPlHoh/YE2oWUz2nDdC+fMoPabLK+vetRnamBlK3RS29sYeqUyOm/9Nu0mO5XhvXgiDH9u779WA==@kvack.org X-Gm-Message-State: AOJu0YwJK6OaZ4x6hqP19ZWUeXqttLGBbMUTEv9ztqboRqvh62gLB149 JbZTlhssVuLVNuoDPHtXl3SQ2fZ7xL0Uxavhhxr4+7TAU+6CGadYTfeVxpIizICljF9mWbGTxTa LB1seLFk2ZvlKKQNYhPrlc7eduUcf9X7YX285R7AZ X-Gm-Gg: ASbGncvLZ/ApyP3iODfEOgJXugw/qDwurs3FTiKU3GZOZIXmiIYB4ZtSB2Fcjnr847m o6WN5qcwt2+Cwz5oD4o0on0GWKg9uz8gk8NfChgAxk0NfbqC13ORyIDCkX0h8Qbd7DeRjyySLFE vZpabC2KjPSH0YIQY3iEjP9GiW02j7u0158CCaDcfYEnas4V8I70Es X-Google-Smtp-Source: AGHT+IG6f/1+5EDykJHVQFWvj7ab2qAzshRhYmuFVlegdyB2FPxNKVWoB/pR1RBhAppiBlV1eNq+vPG3iRDtLh+90po= X-Received: by 2002:a05:622a:3c7:b0:47d:c9f0:da47 with SMTP id d75a77b69052e-49601173654mr12820621cf.19.1747783599516; Tue, 20 May 2025 16:26:39 -0700 (PDT) MIME-Version: 1.0 References: <20250517000739.5930-1-surenb@google.com> <20250520231620.15259-1-cachen@purestorage.com> In-Reply-To: <20250520231620.15259-1-cachen@purestorage.com> From: Suren Baghdasaryan Date: Tue, 20 May 2025 16:26:28 -0700 X-Gm-Features: AX0GCFs5vr76oHaRPnZcZCmedwZcMQVKloWyYdWtBs1obCTSjTQJMrTZ0D0EEjg Message-ID: Subject: Re: comments on patch "alloc_tag: allocate percpu counters for module tags dynamically" To: Casey Chen Cc: 00107082@163.com, akpm@linux-foundation.org, cl@gentwo.org, dennis@kernel.org, kent.overstreet@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, pasha.tatashin@soleen.com, tj@kernel.org, yzhong@purestorage.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: BD36C20005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: groa6huacs51mod9ka3ixrgpyy1edzxy X-HE-Tag: 1747783600-759471 X-HE-Meta: U2FsdGVkX1+WgUZ/p0luZzIcjpo0O5V5YQhhgtiwXNgZk/09t6FLlmHocKMEocWNaWPgy/oNIvY6kgKcDiU2H7bvLBei1VkuC+943W1RKWpk0fY6yThOOybfOPKl3gkxXowceuUAopCiJyg1D1vVviPfUfp68vMqf6tOYPWAqMr7A8HgjBOVUgAgDw/Ry4tndzeS2Np2vsneP8WClBWFFXd0yC7vMxM43FW/j34SANoSdxe+vZUHVOER9ZenRwN8zoIpGu1RIxhPHKc62TBG2vP8Vuy8xL/xryyGPvtPmYAgQj/SF6NnRzKuh2nAQUSzTZE6EAc2OvmK/uAnp+UsSA+inrXjv+Q6aq31hxq+EE+xFBVLQjrhGjyrABLYUQEhGnX/XzCAXaKHxZfbE2NcTBzr2KjSfLyOsFM1yX5g0alx/DE6Knh+YVXgk9Nj7Pf5fiA0MAxG9aH07mRxpmr8QSdwkH0Nu4m6n7wTFsxW22CvpjBqfnXsaNZk4uIKLBzATFfirxFd4NgmAQ7p7nDdGBUYSqqtpBcaPx9C8TmgzBnJhbwrEFYKCme2VcDuTWktL1HyO0ofsTT3ssbKM3gn4eVe2X1BHgLMa7phULdeqUC45Exk1NP/ZLZWSa7VPstMgo9bgQlYBAePwBeXNvxFJn5kXZDCxNh6VHDYlOmFcO7qekuSwBF+j1LDkZruP75h9/uo/KepngVbzKobo9E4qOJWCiUr2M4OiTNvH0PxyjpWWixR4r+uoNDaVG+1ZxXqA0rlKGsEBdo1Yf376cCEZke++DhA84CmftPwMZCojNPxW5EUogghJdUV5qql2LSGBcKm13YV0J85X6gb8qNRe2pCwtzv5Gd1xMCpR+kE/wddfuOLDwx0GSALhx/up/ywNJv0RVrAFsJ2pNZMfl1TbZ0lb+6ggm2HmPyr1ubm6TihoC+ewXxy1SLwItcMPRisAOJie9oLQt4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 20, 2025 at 4:16=E2=80=AFPM Casey Chen = wrote: > > Hi Suren, Hi Casey, > > I have two questions on this patch. > 1. If load_module() fails to allocate memory for percpu counters, should = we call codetag_free_module_sections() to clean up module tags memory ? Does this address your question: https://lore.kernel.org/all/20250518101212.19930-1-00107082@163.com/ > 2. How about moving percpu counters allocation to move_module() where cod= etag_alloc_module_section() is called ? So they can be cleaned up together. That would not work because tag->counters are initialized with NULL after move_module() executes, so if we allocate there our allocations will be overridden. We have to do that at the end of load_module() where codetag_load_module() is. Thanks, Suren. > > Thanks, > Casey