From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABAE5E77197 for ; Thu, 9 Jan 2025 15:59:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 402FF6B0096; Thu, 9 Jan 2025 10:59:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B3306B0098; Thu, 9 Jan 2025 10:59:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 253AF6B0099; Thu, 9 Jan 2025 10:59:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 086BE6B0096 for ; Thu, 9 Jan 2025 10:59:39 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BBEB642D06 for ; Thu, 9 Jan 2025 15:59:38 +0000 (UTC) X-FDA: 82988373636.28.4D021A9 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf16.hostedemail.com (Postfix) with ESMTP id C9009180012 for ; Thu, 9 Jan 2025 15:59:36 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JWJpaI1U; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of surenb@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736438376; a=rsa-sha256; cv=none; b=NLQADqR9SipGOIUylKw7NX6Qxrb10FhKJIk+Aqc2rDKOYto/o99yY0wHUQvOHIdVHZN0gR ATBX1WTc00NhBiuaiOoSXXTuIinyEwIIUjiTQQ4LKQbtOc4z+75/NW9BAQV2IB9jJS4DgB GVxDEBTa5wgpyOX9J6lAaj7+zIlOiP4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JWJpaI1U; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of surenb@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736438376; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oQ5Jfa6yJs7jfMnlDSg6VPUcr4hCBZuDyKrxBZGiXXc=; b=GSWOjNGmVap4d5l4uDk6NKPvXW+RePNIJY227kLy9q8Cc7Jz+r2PMuT+0kEftZE7ZIN5Vf HfljcmyverErfQTrRGdeYnwXXKfa2U27+kvPiLzHbi0yxXgifvByk0q4EVxp4B6O9jrjxq CnGsvuoaHW79K9RGdFk7uTPiucJc0ic= Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4679b5c66d0so244161cf.1 for ; Thu, 09 Jan 2025 07:59:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736438376; x=1737043176; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oQ5Jfa6yJs7jfMnlDSg6VPUcr4hCBZuDyKrxBZGiXXc=; b=JWJpaI1UenaDsEhbQ8UhDp3PcM8vnG3tdPOGKjATa7GNJKFViPExFmon4/xBiKcdRZ T/jokosJj/xPdi68Ot1wXKI9I9bXglwOcpORim0FWAD2ZIdvX68YL3JvnZl510pkAJn7 EKkAUZeKOTxhuTeVs3vhhq/rSqRrKWezMu3wzhCXg9bpCcaHYIAkXZJ6+2UFKOaNfNDb C7pYyp4HfHZIYAMQCCvDk0glqE3z3fcs+Sln8hIcap4Oal24wBXiJKCS/Iwp3TqtT7w0 tHCLtZGFM/sWGyKv0QKUbNHZttEFztu2vMWX22Ak5Qnb8yjh+XEEbJgsi0HJzpV6NkTF A8Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736438376; x=1737043176; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oQ5Jfa6yJs7jfMnlDSg6VPUcr4hCBZuDyKrxBZGiXXc=; b=p73KaSX9ia2VFw+m8tkVEv/3rfzLL1+AKaKW3rE3GO2mt5KYTp9c8apkpC5yejJrPz nx6vkOW3yiXDsuQfH47Psr+uaMTPYzm4eYenIImYl2tXyVyZlGL6vVSZVYDNFuNB5J3f 7vMjVODleqYHpE2spj/XTI4x/GCJd6ZnoThlkul+A6japrtTL487acT8GhOj34N8pZgE i5MMHCx/mO1viypO5KerdpSbMohjWHh+757dJuhwQLW7t/8xLcMiBAnXOUk+2fyYJd9X oM5zEc7V3Ygo+87twJtfkxuqx5yduIXW07aXqUCgLTWKI/ZngIjcax4WfBdoioWDLn8h ytnw== X-Forwarded-Encrypted: i=1; AJvYcCWvsofJDmReIp39yKSN6npdvuGzY42bZWjo2HhDc7zKVMQy+m37l86qHbtc+uAJOusgz0ZHWS1BvA==@kvack.org X-Gm-Message-State: AOJu0YwKhA5NAxg0ewQBHx7AglD1sDL7MqKgqmVxEolw9eTa1bh86U2S DE3SCL8YsmBTsj1soAGWRZSFyfowIH8FeBDiNT4xK/7088pj5MUnmb8hMURZm8MwFrEodnJmkSd HPjK4PIDApjDGoCpuUFAZQshjw5Ob1VXNWgb5 X-Gm-Gg: ASbGncvdFFknPpvKm/BvYf2NZhSzx48my0yeL7Nu95gLj5SQp1rIc/3NlIMNd86kpqr wDU3fYNJFutTzdxu6G98v0EIbn1+t/XwwhOq8jA== X-Google-Smtp-Source: AGHT+IFbE3SeEccWxfnXtdn6KqtzTi123gdRUj3JwdZsdTJwW/j6DVioWu5BS4mPtH+WOOf2BoEr0pxuAA/hjT+Q+JU= X-Received: by 2002:ac8:7c4c:0:b0:46c:726a:14dc with SMTP id d75a77b69052e-46c7bda7657mr4888951cf.28.1736438375624; Thu, 09 Jan 2025 07:59:35 -0800 (PST) MIME-Version: 1.0 References: <20250109023025.2242447-1-surenb@google.com> <52ecd3fa-5978-4f4b-b969-c42b00a5b885@suse.cz> In-Reply-To: <52ecd3fa-5978-4f4b-b969-c42b00a5b885@suse.cz> From: Suren Baghdasaryan Date: Thu, 9 Jan 2025 07:59:24 -0800 X-Gm-Features: AbW1kvalvhfQuAc0MXMuPaqroEtXL5qkz1EwFB3F7sJl51UcD4m-zeoB0z5Fluc Message-ID: Subject: Re: [PATCH v8 00/16] move per-vma lock into vm_area_struct To: Vlastimil Babka Cc: akpm@linux-foundation.org, peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, richard.weiyang@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C9009180012 X-Stat-Signature: 8yadxsabo31cq8hffsichg4pi547fpea X-Rspam-User: X-HE-Tag: 1736438376-35185 X-HE-Meta: U2FsdGVkX1+VobkCNlXNfPg29KekcWifyIRV+GYRl6RAMoM9+qsUUbv61eraTsZCvn71R3uxPT4MztWxVBFU+3qhleiK0RfUzNsJKNx1fclXpsphyhEBV7QZ3YKIVIzwUNnuwTO54fLirXnIq31yYp9vDw1yFOSg3fB2Zc/q6enm4HXY9ujZEsFMXQYdqUJ40DIhcOpLimhhYj1tPcTk0ZyBahNdFXoL4uzUSTVU8eHJ9iHRZvMvfOcE3C6LRWGrfLUkXBCf2Cb60sLKGjQ1gFi775SZMuh4KxWk24LUX1ONUpdlfaWaB7z9kpTTXls5E2800s8FwS/XQLhBD7qKqqlfq88EAPe7CJK/jI2EctOKzvb2887GVRVKiZyH8TbSCvA9lKrgAHY1gAQGByTylTROuXyXXnwE2WLsxMFUYEOZLoU1Wo9dn+4j91qQ1R+E6dDVMKHYbimZbqh3lgBmerPNNIcCzyvnQkSqn4HIeIGDgi6qv/NMop2F9Hxg5m2dVHAXXqp1AuvOotCxV6IhCEIB/XNfDrZgGIURo9YVxRZDCBjcrqJ2FaZTYdddtm/GuST5TtuDW5uOFNu51finPtyVH0q+lbf/f9wVZt0XLZ1TtHySWx7JkQ1WCGLZlbma+89Zf8DTovkxYrQV+zLjLHiAlen1PjYPkA5FmDG4HCABuHITLFHzkUX5yCa5Z0PcL+jo4Ae2Oq9OuqYjM3NOKL4JbWQoxMe0DFAKR3WtxbDd2w8XCcA6dL3QVCbU5KTHhiZFPJfG0byn7IZ2WZbx2UPf95yg4luuHXfune5gaaUQQ5JQrh7erLerJz/d5TcgAQcT3bvFKpC5bnuGmjwj9kC1DJEPGoW3pJWYFU2VX+LbIwD5dELGvGtICORq1zadfxMaMHjoWxgM08Qf1hP28iCv6IYiEK4XZiF3ZbXfxtqBJgeC3PHEsP7DIbNd/nybEOs0jumI55bOgFcYuUK qLGxpnM0 1TE0UvU8EEYQ3QddFbehwBPtllaTmRraHGk2MkCVJJkCdxgGY6aT8HoRwza4p3feXBGcojxM1AY0/t8cCkMakKvMxgIlOAHWGwd9chb+WCuon1JStD0WWAy07GB+4hdIYmulRG0j3bXwwcggPf9EfscxDEZ2I0rZHuZC66wxlnkdX2rAyzhsjLfzhE5KOqIN33h7HfHwD0B17Fraii8n9ra+X99K4GZ6arEkIPMbhJgfF1YM2BUp2wPECL/731mjaAHxlAHBX2HhSbDPrIKOwz1c5f4DjUEfl4RUNKYOXQkfug9g9S2cFsChyEZIrZsgrK5DzMLLiH7pWlg93YFeqd/KzHpCiWaOHjH8joxB1ygt//GXhppMavEr9iLVhtFOBnpIL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 9, 2025 at 5:40=E2=80=AFAM Vlastimil Babka wro= te: > > Btw the subject became rather incomplete given all the series does :) Missed this one. What do you think is worth mentioning here? It's true, the patchset does many small things but I wanted to outline the main conceptual changes. Please LMK if you think there are more changes big enough to be mentioned here. > > On 1/9/25 3:30 AM, Suren Baghdasaryan wrote: > > Back when per-vma locks were introduces, vm_lock was moved out of > > vm_area_struct in [1] because of the performance regression caused by > > false cacheline sharing. Recent investigation [2] revealed that the > > regressions is limited to a rather old Broadwell microarchitecture and > > even there it can be mitigated by disabling adjacent cacheline > > prefetching, see [3]. > > Splitting single logical structure into multiple ones leads to more > > complicated management, extra pointer dereferences and overall less > > maintainable code. When that split-away part is a lock, it complicates > > things even further. With no performance benefits, there are no reasons > > for this split. Merging the vm_lock back into vm_area_struct also allow= s > > vm_area_struct to use SLAB_TYPESAFE_BY_RCU later in this patchset. > > This patchset: > > 1. moves vm_lock back into vm_area_struct, aligning it at the cacheline > > boundary and changing the cache to be cacheline-aligned to minimize > > cacheline sharing; > > 2. changes vm_area_struct initialization to mark new vma as detached un= til > > it is inserted into vma tree; > > 3. replaces vm_lock and vma->detached flag with a reference counter; > > 4. changes vm_area_struct cache to SLAB_TYPESAFE_BY_RCU to allow for th= eir > > reuse and to minimize call_rcu() calls. > > > > Pagefault microbenchmarks show performance improvement: > > Hmean faults/cpu-1 507926.5547 ( 0.00%) 506519.3692 * -0.28= %* > > Hmean faults/cpu-4 479119.7051 ( 0.00%) 481333.6802 * 0.46= %* > > Hmean faults/cpu-7 452880.2961 ( 0.00%) 455845.6211 * 0.65= %* > > Hmean faults/cpu-12 347639.1021 ( 0.00%) 352004.2254 * 1.26= %* > > Hmean faults/cpu-21 200061.2238 ( 0.00%) 229597.0317 * 14.76= %* > > Hmean faults/cpu-30 145251.2001 ( 0.00%) 164202.5067 * 13.05= %* > > Hmean faults/cpu-48 106848.4434 ( 0.00%) 120641.5504 * 12.91= %* > > Hmean faults/cpu-56 92472.3835 ( 0.00%) 103464.7916 * 11.89= %* > > Hmean faults/sec-1 507566.1468 ( 0.00%) 506139.0811 * -0.28= %* > > Hmean faults/sec-4 1880478.2402 ( 0.00%) 1886795.6329 * 0.34= %* > > Hmean faults/sec-7 3106394.3438 ( 0.00%) 3140550.7485 * 1.10= %* > > Hmean faults/sec-12 4061358.4795 ( 0.00%) 4112477.0206 * 1.26= %* > > Hmean faults/sec-21 3988619.1169 ( 0.00%) 4577747.1436 * 14.77= %* > > Hmean faults/sec-30 3909839.5449 ( 0.00%) 4311052.2787 * 10.26= %* > > Hmean faults/sec-48 4761108.4691 ( 0.00%) 5283790.5026 * 10.98= %* > > Hmean faults/sec-56 4885561.4590 ( 0.00%) 5415839.4045 * 10.85= %* > > Given how patch 2 discusses memory growth due to moving the lock, should > also patch 11 discuss how the replacement with refcount reduces the > memory footprint? And/or the cover letter could summarize the impact of > the whole series in that aspect? Perhaps the refcount doesn't reduce > anything as it's smaller but sits alone in the cacheline? Could it be > grouped with some non-hot fields instead as a followup, so could we get > to <=3D192 (non-debug) size without impacting performance? > > > Changes since v7 [4]: > > - Removed additional parameter for vma_iter_store() and introduced > > vma_iter_store_attached() instead, per Vlastimil Babka and > > Liam R. Howlett > > - Fixed coding style nits, per Vlastimil Babka > > - Added Reviewed-bys and Acked-bys, per Vlastimil Babka > > - Added Reviewed-bys and Acked-bys, per Liam R. Howlett > > - Added Acked-by, per Davidlohr Bueso > > - Removed unnecessary patch changeing nommu.c > > - Folded a fixup patch [5] into the patch it was fixing > > - Changed calculation in __refcount_add_not_zero_limited() to avoid > > overflow, to change the limit to be inclusive and to use INT_MAX to > > indicate no limits, per Vlastimil Babka and Matthew Wilcox > > - Folded a fixup patch [6] into the patch it was fixing > > - Added vm_refcnt rules summary in the changelog, per Liam R. Howlett > > - Changed writers to not increment vm_refcnt and adjusted VMA_REF_LIMIT > > to not reserve one count for a writer, per Liam R. Howlett > > - Changed vma_refcount_put() to wake up writers only when the last read= er > > is leaving, per Liam R. Howlett > > - Fixed rwsem_acquire_read() parameters when read-locking a vma to matc= h > > the way down_read_trylock() does lockdep, per Vlastimil Babka > > - Folded vma_lockdep_init() into vma_lock_init() for simplicity > > - Brought back vma_copy() to keep vm_refcount at 0 during reuse, > > per Vlastimil Babka > > > > What I did not include in this patchset: > > - Liam's suggestion to change dump_vma() output since it's unclear to m= e > > how it should look like. The patch is for debug only and not critical f= or > > the rest of the series, we can change the output later or even drop it = if > > necessary. > > > > [1] https://lore.kernel.org/all/20230227173632.3292573-34-surenb@google= .com/ > > [2] https://lore.kernel.org/all/ZsQyI%2F087V34JoIt@xsang-OptiPlex-9020/ > > [3] https://lore.kernel.org/all/CAJuCfpEisU8Lfe96AYJDZ+OM4NoPmnw9bP53cT= _kbfP_pR+-2g@mail.gmail.com/ > > [4] https://lore.kernel.org/all/20241226170710.1159679-1-surenb@google.= com/ > > [5] https://lore.kernel.org/all/20250107030415.721474-1-surenb@google.c= om/ > > [6] https://lore.kernel.org/all/20241226200335.1250078-1-surenb@google.= com/ > > > > Patchset applies over mm-unstable after reverting v7 > > (current SHA range: 588f0086398e - fb2270654630) > > > > Suren Baghdasaryan (16): > > mm: introduce vma_start_read_locked{_nested} helpers > > mm: move per-vma lock into vm_area_struct > > mm: mark vma as detached until it's added into vma tree > > mm: introduce vma_iter_store_attached() to use with attached vmas > > mm: mark vmas detached upon exit > > types: move struct rcuwait into types.h > > mm: allow vma_start_read_locked/vma_start_read_locked_nested to fail > > mm: move mmap_init_lock() out of the header file > > mm: uninline the main body of vma_start_write() > > refcount: introduce __refcount_{add|inc}_not_zero_limited > > mm: replace vm_lock and detached flag with a reference count > > mm/debug: print vm_refcnt state when dumping the vma > > mm: remove extra vma_numab_state_init() call > > mm: prepare lock_vma_under_rcu() for vma reuse possibility > > mm: make vma cache SLAB_TYPESAFE_BY_RCU > > docs/mm: document latest changes to vm_lock > > > > Documentation/mm/process_addrs.rst | 44 +++++---- > > include/linux/mm.h | 152 ++++++++++++++++++++++------- > > include/linux/mm_types.h | 36 ++++--- > > include/linux/mmap_lock.h | 6 -- > > include/linux/rcuwait.h | 13 +-- > > include/linux/refcount.h | 20 +++- > > include/linux/slab.h | 6 -- > > include/linux/types.h | 12 +++ > > kernel/fork.c | 128 +++++++++++------------- > > mm/debug.c | 12 +++ > > mm/init-mm.c | 1 + > > mm/memory.c | 94 +++++++++++++++--- > > mm/mmap.c | 3 +- > > mm/userfaultfd.c | 32 +++--- > > mm/vma.c | 23 ++--- > > mm/vma.h | 15 ++- > > tools/testing/vma/linux/atomic.h | 5 + > > tools/testing/vma/vma_internal.h | 93 ++++++++---------- > > 18 files changed, 435 insertions(+), 260 deletions(-) > > >