From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD435C52D7C for ; Tue, 13 Aug 2024 14:28:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53C2F6B008C; Tue, 13 Aug 2024 10:28:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EA096B0092; Tue, 13 Aug 2024 10:28:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B17C6B0095; Tue, 13 Aug 2024 10:28:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1D66C6B008C for ; Tue, 13 Aug 2024 10:28:02 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 896101408B2 for ; Tue, 13 Aug 2024 14:28:01 +0000 (UTC) X-FDA: 82447451562.08.476981C Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by imf05.hostedemail.com (Postfix) with ESMTP id B810D100007 for ; Tue, 13 Aug 2024 14:27:59 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TrfNWe6e; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723559185; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J9XaW33utQWkxaHgKfkoizdJFqJGFa4Kya6woGbcGpQ=; b=OHjY6IP0xZzIHQR9bqlgptopk+bLe5cJHLwPgnd8Gq4wgA/2WAK/mJygT+GDosJ8059plK UpHYlLp+3TDO1sTqHGW9Xgj/GHZYMEHVzxsWnDJlZSF4BYc5d7kIC17ozQ/KgOhhMBbjEq a1kf9rNBcDYe9iWsQaISI1ThaeOhrQ8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TrfNWe6e; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723559185; a=rsa-sha256; cv=none; b=0QUelQVIvA45SRE4hK7PhCCmGchIh3fXTEM7u56uiMIPP8it6OxnLfECrgt03Nl9rIBPOs +GEhsrlmFcSWESDTiNls1igHp3NUN353z7xCzeJWeZqMOu0wk7r3fISGYukJH9Qc0S+IPV dnC/akMyIxW4Lk2LAMCiJeoF8ILxWIU= Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-66ca5e8cc51so53354057b3.1 for ; Tue, 13 Aug 2024 07:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723559278; x=1724164078; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=J9XaW33utQWkxaHgKfkoizdJFqJGFa4Kya6woGbcGpQ=; b=TrfNWe6e4bhnqW8qVfr7rjmr6RJOgSEORmc/P2+5NZH6s1Gistg4QDPo0r6mbmBRTc +lTZVA4riMovJapnGKCN8Tr2ycbWrR6XEL5dkPFHv1pEII8NwrPTPZ+USL4tevrTAXpE /v9XQi/6X/US7ohJBC4aTPujhs7utNc20GU9+fT8Kilm5ITloxWzIid/Mw+bu3nSrXNJ p0Dhk0LsD1sYPCzIDjRk+Z9GZshl2oBajUDqZuz4ikHH7D//7q6FUVSCCcfqTarP6diV b3hi0xqDVAG0JBrchIfyarII0BfuLGWDNqzQyN6VLjhIdm/6CAbotWFlBGhJQAC0CGtZ 2U/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723559278; x=1724164078; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J9XaW33utQWkxaHgKfkoizdJFqJGFa4Kya6woGbcGpQ=; b=vucgTdtRrkx3PteTHlGThwLbhUeExHo/2/OdFnHBHClG3ngM4ppe9hyPRsi6rVCsIE 6w2XGR5LJNYG0gZXoy9OP1zCJM+V+aFGTZFdcRQqwp8a6HQjdm9QoVUaGvoXKDO0MH+F oigTDaKvOAYvBeREL/mlqnPDh1aGZ9eI9/iavtH7L2tzt+QFGzRwI4Iuie9ZRm0wgUu4 D3ejL8xIs1m3uML3jPRAI6klYqMiFMF3AimoFaNDniCZOmmlCr4tHBVD2NG7Zy1gjreM U945PkVGmhifK16aMUpxqBmJ8IBq22x0bHznSSKJJmK3Sr18Z7ehpOntPyfWyw+FdAvR oS/A== X-Forwarded-Encrypted: i=1; AJvYcCXOOe2MhYaT84dWn/oRmq9qZpRAAXXHNDRm8BMQm3qZZ1yzLkIViEso7U64R0cERQKdEMwpFYEOdXOpqGzfUIlw3R0= X-Gm-Message-State: AOJu0YzpPaK7/NIFumox+s9Q/4Wk4mHXjuNmMJPxEAEx/yTaW3CvnfKs xlavVaPcClG2tRIWgmvY5YM4tbXr8pnkN4KYdhvWGyhv7xtDBztmTponeGIqUZjZAS1eTXRYNix fN6BfmFVshjg+KC6ZhChvVxo7DGJVzX3ThaAK X-Google-Smtp-Source: AGHT+IFGCRKANvH4yro0riVKSiJgV/hErH8P3ghOvKIlIw38M8A5+86ZG0mL5CZ6ZYkY+g7RPr4lUQGROSh6loh32zQ= X-Received: by 2002:a05:690c:c0d:b0:64b:2cf2:391c with SMTP id 00721157ae682-6a97285f833mr49095967b3.18.1723559278254; Tue, 13 Aug 2024 07:27:58 -0700 (PDT) MIME-Version: 1.0 References: <20240812192428.151825-1-surenb@google.com> <471af0a8-92fc-4fe0-85e4-193d713d4e57@redhat.com> In-Reply-To: <471af0a8-92fc-4fe0-85e4-193d713d4e57@redhat.com> From: Suren Baghdasaryan Date: Tue, 13 Aug 2024 07:27:44 -0700 Message-ID: Subject: Re: [PATCH v2 1/1] alloc_tag: mark pages reserved during CMA activation as not tagged To: David Hildenbrand Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, vbabka@suse.cz, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B810D100007 X-Stat-Signature: pqa6c1cukazbzyte9w15455ykfz5jc7w X-Rspam-User: X-HE-Tag: 1723559279-216778 X-HE-Meta: U2FsdGVkX1+Rm0i1928iNuNdaz8CokVAERZima20YVPE3ZFtYdCnwcPtRM6Qs6kOw2lX4qLzcc5xwhrjPrJvqBEKcTmMxQI8yR0/UOTNxNldBL8phY8Y7ePBvqKspYAdIHKiN02/IIgJ+epvvhaQjP2GnTah8KF7h82y5O8WrErNbVndxyIzu2ZfsKASEtiAH5DhsempNvxCqtBZggPosneJz1j4oOLyURwgZ5OCY5UjcCydBHBg+zXfpnxy9LbOJYllcqaeujXZz41e3Gk6sarbhmVy40Q3T9b1Xrnwg10FkkPzxxu/vU0dO0sQpsRJGVZxIbiN5qqPm/NVfGlg+omedHfQjV12B8SuB+KHbhL9exV5NwEK5QfHt+W3goBIUAMFDQxAn5zYS2F+a6/Y/4b9PQKq8TBQLBwOyTaPQpfgPmzTstwrmAg++c5hh2NVWBm+rSjC5Z6Y8aMciAeQ0XK3LcWNnUPutK7f5MlvrQ0JYSwQH92qyk3Dj4bKZ4wtCj4KnO4zxh7kSwRkz2YwUi+xfz3wRuatBcQtBhGSGYJlVJFwk9/PJpGjSDOqmn6Bgj2uFFx8/USTN7tNd8zgbDQW+TDlLnNSKuoA4v+KpWytz4dyTzQAFODo2QURhuQumysSO4FMbkGxb3bfytm/yQDmg0gxy7v4kEXnOunKcGqbXMvL/UNbK12GkAsg+q6SAkWFStwpcWcaH8+r6WsWXehmQ40/+uMVJpaRh+0cR5DeB7NG2u9VJNu4rZYvLnyRY6z+tCbm/GpsME96ZruXBYjynh8RrRMExHbCo1HYtlu/gkEssypKzNbiJGwvywCtHI70lM0AVD0RoKRB99NOgFalO4pRqfnZnNL6D8/5YI2304qJoyrHzOxVHVwDKWwRgcn8sgfTcfodnd3fSO5MHpXynLJz4vrTzD5KFkWIhXm55pxpd8fXptr7V2ye9ZdiusBHhtEIyVagwN+JICg qLc5z/+D bx1rqKyZlg+EwMX6pZzn3FLtJNLY1av4KpqRO/wtxZ/pXiWq5hpTl/KlRW30usfE/ie1Hke5SuwQiBoHADLNSMeDUQsdvSkAuT8txMGSWrmqz9YHhdCN7y+VJ+nKuPysaFXUbXyCTEztfwb8yrzeXQx/CNe8SuoaN3/dtZG31QoV6taEZfRRCcNmlhOvWFjS57Tafa2iRgqk4ynvOzNlB0lbkfW7nwF+3c95gFHaAzqKCdVV7QYy8EUCQgdmNOy/3MMCZPZ7rdQdx8lCwaAtsGRaPV7TGV1Nts3ZTdkbQ3ZzGSCsSgP97GZHgrVDcRVwFpdrL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000345, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 13, 2024 at 2:25=E2=80=AFAM David Hildenbrand wrote: > > On 12.08.24 21:24, Suren Baghdasaryan wrote: > > During CMA activation, pages in CMA area are prepared and then freed > > without being allocated. This triggers warnings when memory allocation > > debug config (CONFIG_MEM_ALLOC_PROFILING_DEBUG) is enabled. Fix this > > by marking these pages not tagged before freeing them. > > > > Fixes: d224eb0287fb ("codetag: debug: mark codetags for reserved pages = as empty") > > Signed-off-by: Suren Baghdasaryan > > Cc: stable@vger.kernel.org # v6.10 > > --- > > changes since v1 [1] > > - Added Fixes tag > > - CC'ed stable > > > > [1] https://lore.kernel.org/all/20240812184455.86580-1-surenb@google.co= m/ > > > > mm/mm_init.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/mm/mm_init.c b/mm/mm_init.c > > index 75c3bd42799b..ec9324653ad9 100644 > > --- a/mm/mm_init.c > > +++ b/mm/mm_init.c > > @@ -2245,6 +2245,16 @@ void __init init_cma_reserved_pageblock(struct p= age *page) > > > > set_pageblock_migratetype(page, MIGRATE_CMA); > > set_page_refcounted(page); > > + > > + /* pages were reserved and not allocated */ > > + if (mem_alloc_profiling_enabled()) { > > + union codetag_ref *ref =3D get_page_tag_ref(page); > > + > > + if (ref) { > > + set_codetag_empty(ref); > > + put_page_tag_ref(ref); > > + } > > + } > > Should we have a helper like clear_page_tag_ref() that wraps this? With this one we have 3 instances of this sequence, so it makes sense to have a helper. I'm going to send a v3 with 2 patches - one introducing clear_page_tag_ref() and the next one adding this instance. Thanks for the suggestion, David! > > -- > Cheers, > > David / dhildenb >