From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33497C0218A for ; Sat, 1 Feb 2025 19:21:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70CA46B0082; Sat, 1 Feb 2025 14:21:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BB856B0083; Sat, 1 Feb 2025 14:21:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58D086B0085; Sat, 1 Feb 2025 14:21:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3B4816B0082 for ; Sat, 1 Feb 2025 14:21:49 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C3EEC1A1B62 for ; Sat, 1 Feb 2025 19:21:48 +0000 (UTC) X-FDA: 83072345496.29.29D95AB Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf16.hostedemail.com (Postfix) with ESMTP id E828D180003 for ; Sat, 1 Feb 2025 19:21:46 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fxENf6Mp; spf=pass (imf16.hostedemail.com: domain of surenb@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738437706; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0Q4abMtFigScZcn+bs2Q2T1g/EWKhoP7a7r42KNczLk=; b=g6PHkRvgZZoalZodjN+TY6xldvdI2S9sm169wtJXFWp5f1vhA8quwFoczbY3OGzw/HIKve wIExuDob6etZeC1MKcsk3ScmZe2CHLDyXeCsMzSjLeBpgyhgDqndzN6nFR1z8UkZ3UOMR6 UINw4P7u81tUTWWeUYR7OGAhW1N43GI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fxENf6Mp; spf=pass (imf16.hostedemail.com: domain of surenb@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738437707; a=rsa-sha256; cv=none; b=3TAY+8dEnfSn3I4/S0Kst167v45E5EycmlSgCIslXIJk8UJwm5T2b0NbPumTKeztHXS6ap 8uBsTzmQiYzPQSsjjsoJoEuvKB3eor8H+5DFBwkwzcvGICExMdDtiOuDJOGDtnR6Zew8Dz QkhbVsA5lIKXyNDN3mb0N5KRAiKAkng= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-4678c9310afso169721cf.1 for ; Sat, 01 Feb 2025 11:21:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738437706; x=1739042506; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0Q4abMtFigScZcn+bs2Q2T1g/EWKhoP7a7r42KNczLk=; b=fxENf6MpLaU+M2tqHA6ltxd4VYghsaqSCIeNPACNE974EYhbSC4nbYJnVpuFW4YfNL BLjvxEEdmBXq+FEZc2XDzBPBsOttHe14SFBS4ew96GLESDwCB76tvcKGWyf70udP0gLI syrWigIwK+v8aK1icQmjdZrNuYWIzeg/s3VT7bCkvOdoisZUdlz+52bY4Oun+tu8T2b8 R5jLzOW3nq/i7mYAmG3wTFKVcDuOGkfSlOkt0QGnfyEfF6TyESpVWUrO+2nbWpqDsyUH Q+6jbiUhB5Gn91w2+JMLHif6Q/l9s8dYt9taz57JWjG7l39GsCwWJt5pFx+Zg03RW403 CAuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738437706; x=1739042506; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0Q4abMtFigScZcn+bs2Q2T1g/EWKhoP7a7r42KNczLk=; b=OSEH57U1/16/4bv+SKGbkh21W6MLvfiCd7qaVccNyZHtabyRkyhPCLMnr56U8TjQRT 8RaxWHFIatDJ3X+bMJIY5HBYnKb3ZxB1CqWC19mMisoAiJ1N2+J3jUnBIcHxIzGE+cKc O/NQY1xZPG6QoA/XcsMzNhxwXZzH3DHcaMWjG4casTSbYRVoiHRbv3NEs/GEBsEQmV4c KOF3GAuP3HPhY+qyIV9xV0SkInLdQ89kRulnXzufdEH9FDbfu7wmoRsFH7AYypJbbCuK +kYU7JXedkFTCAfYZmhuiB7Zj98IyA5KnltzmTDfygafpmHUgodelALiOIuy1OzaugAu 7XOg== X-Forwarded-Encrypted: i=1; AJvYcCVdC6Por65+BjTU3Ghaa5oWWqp5T7lh5B8y1tj1r7wqiDBGbwPssA5BHPvEc97cP9DLvRrU5860Cg==@kvack.org X-Gm-Message-State: AOJu0YzsqUO9tMdBLagibDAnjVcsIN64exR5U/+3nr9p/I1wx3iTf3tZ W14EkJjpszNtdI/5iyBy8AE1lIWSXLrE5cnUcgiJmXxL1kNkC9j5IFoMR/pOHuJmvdxPFJ79LOc 2eRHpqqzdu6U0CTa7cwD9HoX3PC0VYHlSaElR X-Gm-Gg: ASbGncvwIcJ8zalRQ900K3m3nimVMeSBWXZjBPBtWAXhvgGC2e4+44ItGYy7f3kEqSs h4cYkLs7g17/mm4y8kPekQJLBQJlOY0y8lrCGwOZxrfuijbz4gmE0FehbiaRqsH7PUnMbF87p X-Google-Smtp-Source: AGHT+IH6iU7oK11joDMO6qr0cc+4zoE84MbudCftX0eHkm9Wab8JGiZzC5yRPPAaY3LrkBPoh9sQJsZJldHWbFL5a1g= X-Received: by 2002:a05:622a:6098:b0:46c:7d66:557f with SMTP id d75a77b69052e-46ff8713f96mr1834641cf.8.1738437705448; Sat, 01 Feb 2025 11:21:45 -0800 (PST) MIME-Version: 1.0 References: <202501310832.kiAeOt2z-lkp@intel.com> In-Reply-To: From: Suren Baghdasaryan Date: Sat, 1 Feb 2025 11:21:34 -0800 X-Gm-Features: AWEUYZnHN5eMAAaN6d5V0pKMqCk98IC6fVNOKYum3DnDnjgJPVRAT21sISprZro Message-ID: Subject: Re: drivers/auxdisplay/panel.c:1454:2: error: call to __compiletime_assert_309 declared with 'error' attribute: BUILD_BUG_ON failed: !__builtin_constant_p(_dest_len) || _dest_len == (size_t)-1 To: kernel test robot , Nathan Chancellor , Nick Desaulniers , Andrew Morton Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Linux Memory Management List , Kent Overstreet , Kees Cook , llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E828D180003 X-Stat-Signature: q7ymnbgyzheufa7nixaodp13n875348q X-Rspam-User: X-HE-Tag: 1738437706-993009 X-HE-Meta: U2FsdGVkX18BxA9hGtYQXzcdLPyN/HNO0K2GoYo83Lp6XhWV1yel0xa7ccGCpKZPa4WJxPYXl3cMobHrUwO5YKunS2d2F//JRupd9JxALxCnloxF2KXw4KOnjbjJewD0AqEy3odBSgwwlVixpwdI82lpWstBBp5f2zTe3fWPrVyuPBOrCklHhQdaB9+tse05DRyJZ+lLgZqcbyHo7ef52VxP3hwhuNbLj8+WDiq1LHqQFOiat2nxJJdb3lS+X4eoDx8bMPxvT/ChORALL0CYRFzHs+zyggd9LGM0dDzpN313tgxUsuJSLDqi55vT0T2Toyszc4yZE6GuZg9ajQwmF56c73obHxyjX8f3C3iCUR4RU1SE3UVCcYXrmS7IkbBl45yirPGxfz0zy+4U32jtmg6aplrekJCC5hkOpOUWbQnbkb5X3XBaSn0CCo5cAukCn910Bg2EQdxaQVOQ4oyE+NOrOniavGLctgQO4rDbbR/j1PkxPbS4OI4b7IqKjhsCet5ta6ecIEVCxxGlFqecmK8fpwqOUFRpmWC3l70/l8He5D1TKj1u9R9p/aI+PMVKKMDdCautTdaAHMCNkqfbUlRWh2Tb6bai9BgXyA03BSKb4Z0wiBnVDEocnxuWu3x4j3BhWL31/4Dfa+0PLUFgLdcATwubnfY6IFstZ2hD7Jb/emltNBGCxbhzUDIguAeQvQTLKH+WO1rbIi2iwjSByW9SjjT2czFjn4qci0Jsm0HIzCYsEzstrUtoaAAXYZ1mNQIp9qxcsI/sKXrw05ODMGANvauxiB90AzWvadhTlA9/n3ZepeCH++jEdG91AanNFZM3Uc2bb05SOWP7on+RetH73+LQ8VkP+vUAmDa8tJDXfVvk/OotDf/GPpz/LOrIDXiVRcz2GGHA6ps2vR5wfHmZiniodeN9Bei6Dgam6pzXXNujgqZ/QI0wEs5yb91E/h66Xu32q4jlFOTpOjC +s1ieA7Q iqv7Ktp81MegTnUm/IE8YhAXa34ANOy0FyrKDZc+56l8t14nYMyWPQQ24MvKrM20nl4bNSXCHhAYtNW+8YoxBtkCgBeCQ9lZd0FrN0OSW25y8o/Dui0qYysiPtsp2FtWE3OiQoHLOfsWjaJFa8dnLUDBOEH1feIEHsj4fOn+ssuz3ykZhs7JWH0ta649p2vHxEx7QGG0LPOwDaZDohNMpCHgGIl6aiIsjqvEs4kVvn0S5ZnaFYvne9iFcjCzrbstLiZSey3RoiFf13PzsndJOtlbeOMue1puOlcd7zE1dITDIuuov8DCUyNNXoegWE0Sg5qdFjeTYDmITm4hciWRQRT+wlGYMAOO+bPCC9398zsvHNJzSI+KJpp27q4I99IUC7jD8VFH/nx/dHxi51Mdy9wotZp6o+VJlG9C9b8I89TLHkwPIZTlx0Ff8Ww8Cp/tzgTSWK6/Kxzj1jF4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 31, 2025 at 2:51=E2=80=AFPM Suren Baghdasaryan wrote: > > On Fri, Jan 31, 2025 at 8:55=E2=80=AFAM Suren Baghdasaryan wrote: > > > > On Thu, Jan 30, 2025 at 4:06=E2=80=AFPM kernel test robot wrote: > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linu= x.git master > > > head: b4b0881156fb8209bf5ef6cb63211bb0ad6e1a6b > > > commit: 07438779313caafe52ac1a1a6958d735a5938988 alloc_tag: avoid cur= rent->alloc_tag manipulations when profiling is disabled > > > date: 5 days ago > > > config: hexagon-randconfig-r133-20250131 (https://download.01.org/0da= y-ci/archive/20250131/202501310832.kiAeOt2z-lkp@intel.com/config) > > > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project = f28c006a5895fc0e329fe15fead81e37457cb1d1) > > > reproduce: (https://download.01.org/0day-ci/archive/20250131/20250131= 0832.kiAeOt2z-lkp@intel.com/reproduce) > > > > Just saw this report (was on vacation). Will try to figure out what's g= oing on. > > I confirmed that my change at > https://lore.kernel.org/all/20241226211639.1357704-1-surenb@google.com > indeed causes this. > Looks like due to the additional mem_alloc_profiling_enabled() check, > the compiler considers allocation size as unknown at compile time > (__builtin_object_size(obj) returns -1) even though both branches of > that condition make the same exact allocation. > I tried changing it to: > > #define alloc_hooks_tag(_tag, _do_alloc) \ > ({ \ > typeof(_do_alloc) _res; \ > struct alloc_tag * __maybe_unused _old; \ > if (mem_alloc_profiling_enabled()) \ > _old =3D alloc_tag_save(_tag); \ > _res =3D _do_alloc; \ > if (mem_alloc_profiling_enabled()) \ > alloc_tag_restore(_tag, _old); \ > _res; \ > }) > > and that fixes the problem, however this would require two static key > checks... I wonder if there is a way to tell the compiler that both > branches cause the same result. Let me dig around. CC'ing Nathan Chancellor, Nick Desaulniers and llvm@lists.linux.dev Looks like this error happens only with clang version 14 (more specifically CONFIG_CLANG_VERSION=3D140006). I tested with clang-13, clang-15 and clang-17 and all of them build this code fine. Same thing for other archs (clang-14 fails, others don't). I tried hexagon, x86 and arm64. To fix the build I can add: #if defined(CONFIG_CC_IS_CLANG) && CONFIG_CLANG_VERSION >=3D 140000 && CONFIG_CLANG_VERSION < 150000 // do this the old way #else // do this the new way #endif but I'm not sure if that's the right fix. Andrew, while compiler folks investigate this issue, I'll post the above fix in case we need to deal with this build error urgently. Thanks, Suren. > > > > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new = version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202501310832.kiAeOt2z= -lkp@intel.com/ > > > > > > All errors (new ones prefixed by >>): > > > > > > >> drivers/auxdisplay/panel.c:1454:2: error: call to __compiletime_as= sert_309 declared with 'error' attribute: BUILD_BUG_ON failed: !__builtin_c= onstant_p(_dest_len) || _dest_len =3D=3D (size_t)-1 > > > strtomem_pad(key->u.kbd.release_str, release, '\0'); > > > ^ > > > include/linux/string.h:417:2: note: expanded from macro 'strtomem_= pad' > > > BUILD_BUG_ON(!__builtin_constant_p(_dest_len) || = \ > > > ^ > > > include/linux/build_bug.h:50:2: note: expanded from macro 'BUILD_B= UG_ON' > > > BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condi= tion) > > > ^ > > > include/linux/build_bug.h:39:37: note: expanded from macro 'BUILD_= BUG_ON_MSG' > > > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), ms= g) > > > ^ > > > note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-l= imit=3D0 to see all) > > > include/linux/compiler_types.h:530:2: note: expanded from macro '_= compiletime_assert' > > > __compiletime_assert(condition, msg, prefix, suffix) > > > ^ > > > include/linux/compiler_types.h:523:4: note: expanded from macro '_= _compiletime_assert' > > > prefix ## suffix(); = \ > > > ^ > > > :127:1: note: expanded from here > > > __compiletime_assert_309 > > > ^ > > > 1 error generated. > > > > > > > > > vim +/error +1454 drivers/auxdisplay/panel.c > > > > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1426 > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1427 /* tries to bind a key to the signal name . The ke= y will send the > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1428 * strings , , for these respec= tive events. > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1429 * Returns the pointer to the new key if ok, NULL if the= key could not be bound. > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1430 */ > > > 36d2041a3d57b9 drivers/staging/panel/panel.c Peter Huewe = 2013-02-15 1431 static struct logical_input *panel_bind_key(const char *= name, const char *press, > > > 36d2041a3d57b9 drivers/staging/panel/panel.c Peter Huewe = 2013-02-15 1432 const char *= repeat, > > > 36d2041a3d57b9 drivers/staging/panel/panel.c Peter Huewe = 2013-02-15 1433 const char *= release) > > > 698b1515f03914 drivers/staging/panel/panel.c Willy Tarreau = 2008-11-22 1434 { > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1435 struct logical_input *key; > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1436 > > > fdf4a4948ca8a1 drivers/staging/panel/panel.c Dominique van den Broeck= 2014-05-21 1437 key =3D kzalloc(sizeof(*key), GFP_KERNEL); > > > eb073a9bf2b6ed drivers/staging/panel/panel.c Toshiaki Yamane = 2012-07-12 1438 if (!key) > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1439 return NULL; > > > eb073a9bf2b6ed drivers/staging/panel/panel.c Toshiaki Yamane = 2012-07-12 1440 > > > 698b1515f03914 drivers/staging/panel/panel.c Willy Tarreau = 2008-11-22 1441 if (!input_name2mask(name, &key->mask, &key->val= ue, &scan_mask_i, > > > cb46f472cbb08c drivers/staging/panel/panel.c Kulikov Vasiliy = 2010-07-12 1442 &scan_mask_o)) { > > > cb46f472cbb08c drivers/staging/panel/panel.c Kulikov Vasiliy = 2010-07-12 1443 kfree(key); > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1444 return NULL; > > > cb46f472cbb08c drivers/staging/panel/panel.c Kulikov Vasiliy = 2010-07-12 1445 } > > > 698b1515f03914 drivers/staging/panel/panel.c Willy Tarreau = 2008-11-22 1446 > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1447 key->type =3D INPUT_TYPE_KBD; > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1448 key->state =3D INPUT_ST_LOW; > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1449 key->rise_time =3D 1; > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1450 key->fall_time =3D 1; > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1451 > > > a952abcdaa2211 drivers/auxdisplay/panel.c Justin Stitt = 2023-09-11 1452 strtomem_pad(key->u.kbd.press_str, press, '\0'); > > > a952abcdaa2211 drivers/auxdisplay/panel.c Justin Stitt = 2023-09-11 1453 strtomem_pad(key->u.kbd.repeat_str, repeat, '\0'= ); > > > a952abcdaa2211 drivers/auxdisplay/panel.c Justin Stitt = 2023-09-11 @1454 strtomem_pad(key->u.kbd.release_str, release, '\= 0'); > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1455 list_add(&key->list, &logical_inputs); > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1456 return key; > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1457 } > > > 7005b58458e4be drivers/staging/panel/panel.c Willy Tarreau = 2008-11-13 1458 > > > > > > :::::: The code at line 1454 was first introduced by commit > > > :::::: a952abcdaa22116d940ca9cb9253caad1622ae93 auxdisplay: panel: Re= place deprecated strncpy() with strtomem_pad() > > > > > > :::::: TO: Justin Stitt > > > :::::: CC: Kees Cook > > > > > > -- > > > 0-DAY CI Kernel Test Service > > > https://github.com/intel/lkp-tests/wiki