Andrew, looks like the patch 55405363686e "userfaultfd: UFFDIO_MOVE uABI" in mm-unstable does not correspond to the latest version I posted at https://lore.kernel.org/all/20231206103702.3873743-3-surenb@google.com/. Could you please update it. I'm checking the rest of that series to see if it's correct. Thanks! On Fri, Dec 8, 2023 at 9:27 AM Suren Baghdasaryan wrote: > On Fri, Dec 8, 2023 at 2:00 AM kernel test robot wrote: > > > > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: bc63de6e6ba0b16652c5fb4b9c9916b9e7ca1f23 > > commit: d02321ca0329457d5828a83b82b156e6337c4236 [5469/6165] > selftests/mm: add UFFDIO_MOVE ioctl test > > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > > reproduce (this is a W=1 build): ( > https://download.01.org/0day-ci/archive/20231208/202312081716.LUUhSNS4-lkp@intel.com/reproduce > ) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new > version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: > https://lore.kernel.org/oe-kbuild-all/202312081716.LUUhSNS4-lkp@intel.com/ > > > > All warnings (new ones prefixed by >>): > > Huh. This is strange. I checked linux-next.git and looks like the > patch adding the test [1] is there but the one actually adding new > ioctl [2] is missing (at least I do not see the new definitions in > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/uapi/linux/userfaultfd.h > ). > Patches belong to the same series. I'll check what's going on later > today. > > [1] > https://lore.kernel.org/all/20231206103702.3873743-6-surenb@google.com/ > [2] > https://lore.kernel.org/all/20231206103702.3873743-3-surenb@google.com/ > > > > > uffd-common.c: In function 'move_page': > > uffd-common.c:636:28: error: storage size of 'uffdio_move' isn't known > > 636 | struct uffdio_move uffdio_move; > > | ^~~~~~~~~~~ > > uffd-common.c:643:28: error: 'UFFDIO_MOVE_MODE_ALLOW_SRC_HOLES' > undeclared (first use in this function) > > 643 | uffdio_move.mode = UFFDIO_MOVE_MODE_ALLOW_SRC_HOLES; > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > uffd-common.c:643:28: note: each undeclared identifier is reported > only once for each function it appears in > > uffd-common.c:645:24: error: 'UFFDIO_MOVE' undeclared (first use in > this function); did you mean 'UFFDIO_COPY'? > > 645 | if (ioctl(ufd, UFFDIO_MOVE, &uffdio_move)) { > > | ^~~~~~~~~~~ > > | UFFDIO_COPY > > >> uffd-common.c:636:28: warning: unused variable 'uffdio_move' > [-Wunused-variable] > > 636 | struct uffdio_move uffdio_move; > > | ^~~~~~~~~~~ > > -- > > uffd-unit-tests.c:1323:42: error: 'UFFD_FEATURE_MOVE' undeclared here > (not in a function); did you mean 'UFFD_EVENT_REMOVE'? > > 1323 | .uffd_feature_required = UFFD_FEATURE_MOVE, > > | ^~~~~~~~~~~~~~~~~ > > | UFFD_EVENT_REMOVE > > uffd-common.c: In function 'move_page': > > uffd-common.c:636:28: error: storage size of 'uffdio_move' isn't known > > 636 | struct uffdio_move uffdio_move; > > | ^~~~~~~~~~~ > > uffd-common.c:643:28: error: 'UFFDIO_MOVE_MODE_ALLOW_SRC_HOLES' > undeclared (first use in this function) > > 643 | uffdio_move.mode = UFFDIO_MOVE_MODE_ALLOW_SRC_HOLES; > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > uffd-common.c:643:28: note: each undeclared identifier is reported > only once for each function it appears in > > uffd-common.c:645:24: error: 'UFFDIO_MOVE' undeclared (first use in > this function); did you mean 'UFFDIO_COPY'? > > 645 | if (ioctl(ufd, UFFDIO_MOVE, &uffdio_move)) { > > | ^~~~~~~~~~~ > > | UFFDIO_COPY > > >> uffd-common.c:636:28: warning: unused variable 'uffdio_move' > [-Wunused-variable] > > 636 | struct uffdio_move uffdio_move; > > | ^~~~~~~~~~~ > > > > -- > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests/wiki >