From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D6BDCD4853 for ; Wed, 4 Sep 2024 16:39:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D46EE6B00DB; Wed, 4 Sep 2024 12:39:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFB1C6B00E1; Wed, 4 Sep 2024 12:39:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B70EA6B00E6; Wed, 4 Sep 2024 12:39:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 98BD76B00DB for ; Wed, 4 Sep 2024 12:39:47 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4427481762 for ; Wed, 4 Sep 2024 16:39:47 +0000 (UTC) X-FDA: 82527617214.08.1DE9810 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf19.hostedemail.com (Postfix) with ESMTP id 5EB391A0010 for ; Wed, 4 Sep 2024 16:39:45 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vNa1e9Ru; spf=pass (imf19.hostedemail.com: domain of surenb@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725467890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aVKgBZWcIsT5jzi2Y61F5gCJD2ntfYeuhQqcN6HyFFE=; b=4jRLjtJJvEkHeE9mfDDg6slWbcobQ5nexrvwQgmZ/d525h2J9l4IDBhATcZWtMq4Mt5IcQ PnPYnYYm9c7lyxvmSjDQETj3ze3Cs0GGQdgRALO/l4lHW5JSRmVZ4Aqb7j4Mbk/bsQQUk8 zB/IgR2C23YlMsouJinxjlIZ7a/UdsE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725467890; a=rsa-sha256; cv=none; b=oMZ1WjcxUQoBgfLO0KexQ0b+dJVxUG7KdxR3Cokzk7T51IHlSiEYqulYpF04k1Q+gA0kiY 13vSW+9K8GKGxj7o5X/bNpGE9rcIvowwqY1Na2PIMRMo9pBuu0AsHcjgcP3zDdTSLGfuAp YbHs+slLb74+nlcZbHq8YQl4Hlf+EO0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vNa1e9Ru; spf=pass (imf19.hostedemail.com: domain of surenb@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4567fe32141so3091cf.0 for ; Wed, 04 Sep 2024 09:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725467984; x=1726072784; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aVKgBZWcIsT5jzi2Y61F5gCJD2ntfYeuhQqcN6HyFFE=; b=vNa1e9Ru+kd1Mo3KJ354M3O7lfuOhudbt+cVDlhF6ZW2rCJFZWYePyee+OKCpewt0O yUsqzhJzRMzcplLn5KuFsQkWIOoMYmYsngAmBPrdjr3374J17s4F3zzIYa8kF5WCWPLM Fe8a/XMETXdwbxhCgPO1lkVaLgGdy/khBGBTWzxzBIrjAzhv5A87SERMulgDr01ZCMzC zFJXkYqC4z2MnxCzm6fmrlDCvShhJ6S46BGANkel3lOoupgSHDJpKQPUBKqNJsXdn/E6 mkml5KUvr9q2xrskRh68PiJnxelxsfujf4iMU2l2dOjgZieLNQShDbUPzglxR0+qvErC 76pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725467984; x=1726072784; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aVKgBZWcIsT5jzi2Y61F5gCJD2ntfYeuhQqcN6HyFFE=; b=Narlbf5XzZoWSLSH6c39Abv2+LpTBPzU2te3tUenI6BAb7l1jI/ZwT3PvQe7gUezDU l2XOdEUxexWJmiYGXLIGVe6KvsR2aspQINZqz+nw03cOgnGbHaoqJX+xATbuORdB7RMr r+krArDA86rXmTJMDqULTq7XO0Yvck2umHNCGNr7SURqpTWnocOz1oCVo3dXmjmrAWYb aPizjsSgxxHl+iXba92BIXkwlDn0p9pS2MIUniw8NElVWAQZ8IYnuVx7ssRH0mEvkA4V 7mBDrJEY7ARnVYgrV+klMrm+aLcK0khKPEglXdw6C366neS3M1VR6PRLJ0Jh6pNSpHQk JlcA== X-Forwarded-Encrypted: i=1; AJvYcCVqg7oTwtDYgU2V9SS2bEjmD6SYPupZhSeReWZaj6ztL++ewCBwmgpdfWUh6GCf8xm7Ud6a8RzMdw==@kvack.org X-Gm-Message-State: AOJu0Yx/F0AQON78khWURWIeiCzLTI9mHaOzIGSqX75zccRQK692W/OG bO0HkVKhCS7knmmMC5vre3LUc68CclCxBmlgAePc20pugnfaEeXUETaa5KRENY3nB5iCmHLoNwO gGOSdL8PrU9xScW1UvsE/S/mWGOyNwwP0Nsm5 X-Google-Smtp-Source: AGHT+IGwhDrAQPEAmF0bOfcaTr6MOXUafuS1vP9sMQ9KrAbdAewI1zke0LJG2AKiNDfA445/E3iPPiTzSRTtLdtDDnM= X-Received: by 2002:ac8:5ad3:0:b0:456:7ec0:39a9 with SMTP id d75a77b69052e-457f7a9c517mr3513941cf.5.1725467984034; Wed, 04 Sep 2024 09:39:44 -0700 (PDT) MIME-Version: 1.0 References: <20240902044128.664075-1-surenb@google.com> <20240902044128.664075-7-surenb@google.com> <20240901221636.5b0af3694510482e9d9e67df@linux-foundation.org> <47c4ef47-3948-4e46-8ea5-6af747293b18@nvidia.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 4 Sep 2024 09:39:33 -0700 Message-ID: Subject: Re: [PATCH v2 6/6] alloc_tag: config to store page allocation tag refs in page flags To: Kent Overstreet Cc: Matthew Wilcox , John Hubbard , Andrew Morton , corbet@lwn.net, arnd@arndb.de, mcgrof@kernel.org, rppt@kernel.org, paulmck@kernel.org, thuth@redhat.com, tglx@linutronix.de, bp@alien8.de, xiongwei.song@windriver.com, ardb@kernel.org, david@redhat.com, vbabka@suse.cz, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, liam.howlett@oracle.com, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, dennis@kernel.org, yuzhao@google.com, vvvvvv@google.com, rostedt@goodmis.org, iamjoonsoo.kim@lge.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5EB391A0010 X-Stat-Signature: 3r4tg8k4m7xb9nkz5uubxrz6fzcpttmu X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725467985-438205 X-HE-Meta: U2FsdGVkX1/ZDy8okrxW40UtH0CMmYa5YEB4V1CoW0RFiKLQqbOaJdOonWDZH38kBEfXGUY3dur4iGvB9UYzo94pXxck0mWT4eF+GE7OXdkNs0a/4vwS61q0dpQU+NphpKLZy+BJ+/xVaa5d6ZJuK8WPResbvnbDTvs/pMrjmwi6s4D93j7TUlUAAahFdObiXCsFmI8YXSsqxI/Z4AeZJkTiGUrGVqVOLRInhpPtQDbhoX3j2YcI2xGPwSS1h4oeauMexaq/+d61A/eIzsJSM85j5hi2IxP6UIJPX9O88t/GnK55x//35aHs5tJWLmaWdGAsTOklfYZfkI+czpXKCouDdZ3P1ViuAjSaFek38k5SiQjPmgVM770J6cNEeA3UOzei7ihhA4IqipKP6CxE8WIxyX48BeutKGKBZ5hOl67hTILQFag9JtFYvXmeNJEmcMDQ+kJQJJFom3vfuMchGK9rcJWf0SUjvPRldK2LGj30HEUOKop4ADoKFDu8kmd1NreY/j2T2cNqsbD0AkOH9qBxGeH+Un2O0zjp9TH3PeRksdPYtQuOE7qxHOmkGUfa1DF/VNmY/9FV5h7V2ynaxJFI6rDJW/8L7bKJwxj5sMzOer5IFPmWDeEcUyg07ehlxIf0XQgcbWPo1TER28AVMeFrvaIBWd4viAsPQTyxB01S/etcDfWWwb1kiKBhuv9bGJkh3O5JBc05LKJNhHmW5y6Q5CJKLqqYJP3TF8WYxzi/dHbPL2WLppiAswlZZyc+Kty208Ox9EneTrVKIM17a6Drx39dBznec8F4XUnDTh44dw0bIT0TJpVEuBMaM8nyDQ+l/Z3CTu0TqZTNeLiKJNSaWyDSJ2QjzZtRC9ECa88iQXzunkheA8bVdHfe96ZBbIrrHTybz3epd3IJUxsvO6rImKhnBZDh+31rzyN0JpEIDU0NBUefCyXiCUItISVGhE2hFREXSh30NIL0w23 qy1kYPuA 6TRMwTjPwxi1dVbUER73TY8V+d/EvayLd1qpXvZXKhFYOXZZmHBBIJ51Vrav0HF18p+QQEX+euPCPOQHEvYTDpvRA048t6XoMINN8MhZkhMSZjZbrzSD0+I0pYcUNuq/QUzNjtRkvjS6j2t2kInYrF2nQVW1oC2ugOciQdR4s3jV15bZSnor5hZaJcR3cm0p7OYzHkp6JWNwp6rPZcGKJQ//lgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 4, 2024 at 9:37=E2=80=AFAM Kent Overstreet wrote: > > On Wed, Sep 04, 2024 at 05:35:49PM GMT, Matthew Wilcox wrote: > > On Wed, Sep 04, 2024 at 09:18:01AM -0700, Suren Baghdasaryan wrote: > > > I'm not sure I understand your suggestion, Matthew. We allocate a > > > folio and need to store a reference to the tag associated with the > > > code that allocated that folio. We are not operating with ranges here= . > > > Are you suggesting to use a maple tree instead of page_ext to store > > > this reference? > > > > I'm saying that a folio has a physical address. So you can use a physi= cal > > address as an index into a maple tree to store additional information > > instead of using page_ext or trying to hammer the additional informatio= n > > into struct page somewhere. > > Ah, thanks, that makes more sense. > > But it would add a lot of overhead to the page alloc/free paths... Yeah, inserting into a maple_tree in the fast path of page allocation would introduce considerable performance overhead.