From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7396DC369D5 for ; Mon, 28 Apr 2025 19:57:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AA416B002E; Mon, 28 Apr 2025 15:57:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 367C56B002F; Mon, 28 Apr 2025 15:57:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D5966B0082; Mon, 28 Apr 2025 15:57:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EE83E6B002E for ; Mon, 28 Apr 2025 15:57:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1CBCC1413D8 for ; Mon, 28 Apr 2025 19:57:16 +0000 (UTC) X-FDA: 83384511672.22.4250017 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf05.hostedemail.com (Postfix) with ESMTP id 46CC2100006 for ; Mon, 28 Apr 2025 19:57:14 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ukZWF8+A; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745870234; a=rsa-sha256; cv=none; b=xlnyI9uxRJcY6yHGz0mWDmUCvz6OjlsAENV3VQ7xTHSFmiWSEXFDtYSJFRii2S9R/fLA4s 3304ipkB2s44HJCljLR2/3Y3lxzbhLawgXqJP8huxyDwina248Arh533pCxdVSDGZeVNym 0Cf2ct5HLOvZtj11V+LutbiXbs6Fs3U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745870234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KUGna70WQpCWkTeNNt6g447tdKBI53CPsya1LM9jehw=; b=E2pQft8zA4ebWjhD2aoiLsPWzoqmOMWKnDUjLTMz3UV6p+VZ+LkvXG8N4W5LUeAAAukdEj eo6YYPcJ73y5yAl14Ib5nWKUxKbtPkSlRUewuJnH6yixe46JPjFzu+dDE11QEA6G6sXnny EUMjv2cA+Cnj0pHhJK2UdG9Uv1HrZ7c= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ukZWF8+A; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=surenb@google.com Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-47681dba807so6221cf.1 for ; Mon, 28 Apr 2025 12:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745870233; x=1746475033; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KUGna70WQpCWkTeNNt6g447tdKBI53CPsya1LM9jehw=; b=ukZWF8+A4oBJRv5n7Fkg/l/yRr2pxHsHzOAAOmkZ++3agH7HfiF0+oBJrZT+3cPBvA P+td/bWijxNpwMkbChuvVw2/KN00tgnPGbkA+3MOeuott9BE2LTw3i9LGVbzExEs1pTL RbevTZPY/i8/Kn9m4qfg+up7vLjfRGmD+wLLweXEWwGWE76J3cgEkpfvR0Bbj3/tJDYx md/Lvh+ZxEV+Kh7m2EE8FMZwpcTOZQMu8G7GxSmI8Ky9UXRqWA4BUk/AcwK33ORsiRGt qMlk7UO5MdhaS58Cew6Z/aN64j9RpVrWBcZOTCl/e71QIChuws9+48ANvrH8HuEdGFc4 40lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745870233; x=1746475033; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KUGna70WQpCWkTeNNt6g447tdKBI53CPsya1LM9jehw=; b=w1ExBZKRQuR1AXSda6y3aG0T7in3ydrMXZW7LzEs6Br1NJ5EiwW/J14EQ06jJilXOz uoUm7TGjS15KT+ylx0pogWXp0WbIIJ8CoJ8M/tMCVFIHIn89X6ipU6ek7HhMLbRUWe2Z ll3mtffktQaBUbg5dF4gkhUcM/gzjRpWSIIB/9EpQ8owtgk0705QRpYGm6hBlAXVcnJX /IjZCCeHN/vdpDFBaqcWQPn8pwofey5apOSgSX7LOiUsstinHDi2EDSnd7GsqAU0kpX8 038D8AWk1oW53Kh1fepxPRKdLVJ8INrdpvFdjGa5fpk4AeZP41kmMrv3ASq84/8NXDmG OcCw== X-Forwarded-Encrypted: i=1; AJvYcCUVoGn3QExtCvqJZOCmuH3FdvjuecCpSMTQcet50qboZkGdn89uTA/seH9hGf45Jff9hYMLryNy4A==@kvack.org X-Gm-Message-State: AOJu0YxuNb8vnFYTpFgSQdPhLEiSRxVZdGYmbdeBXXkMeCFxhpnDQju4 sn676zR0u3aT3fGEryxoMXU06g0MQdA8tnBQNafsWASKgfpjxTcUUs+DybWFTIX+Wb+U+DlNkRT GS2JxR1yNHXttRPdqGcrDOhKUFJoJikbzarMN X-Gm-Gg: ASbGncs5sYyjpREKBE8zcZYBboCwTaYZ+PC5JuqVbHKW1NA5IC0Hbm/Er1nQwYsj9U0 qMIPElbFnvnKTT1zfYZtP7Y1CKLPksu/TBeZB2nAXzGJsIpkORfCIV5nmc0eeEBjSSbByULxk5c /CB/8PFLXQucpXCXcCSHfV X-Google-Smtp-Source: AGHT+IEhejaHFThaKwhJCfo8/xHV6yGo88io+XsVdICYQukFeW24MAIkT6Fi1xOMkVwdW/FKQmmwSk2eKpS9NWkWZlM= X-Received: by 2002:a05:622a:452:b0:480:1561:837f with SMTP id d75a77b69052e-4885aacab9cmr871171cf.8.1745870232933; Mon, 28 Apr 2025 12:57:12 -0700 (PDT) MIME-Version: 1.0 References: <20250425081715.1341199-1-david@redhat.com> <20250425081715.1341199-6-david@redhat.com> <7a26e29c-d889-450a-a5e1-ce671f09e4c8@redhat.com> <884fab29-e16a-4663-8e33-885bc70ca2f7@redhat.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 28 Apr 2025 12:57:02 -0700 X-Gm-Features: ATxdqUFN4dSm5xUeBut-iPBeU1VBNXf3LtoK4Lvt9a17IgRXhS8pQBx8VXvr8KE Message-ID: Subject: Re: [PATCH v1 05/11] mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack() To: Lorenzo Stoakes Cc: David Hildenbrand , Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 46CC2100006 X-Stat-Signature: 15xgb1iy4on6yt8d7y53wdihc8syhn41 X-Rspam-User: X-HE-Tag: 1745870234-674158 X-HE-Meta: U2FsdGVkX1/kyM2pWuRUcNueH1i4RLUj1K0xXSzUUDwyZ7LXjAOkm4YRNURWMPrcPlBTzAm2r1RDQPkLxuSzTdK04ATeGjuQoFzHlOZBVJ3t6pwH88o15ug9vt2iO7xXmu3uSWlVF+XkrV+jwhDb3SzeuB7ld3iqv0hrpHt+oCKn4DhArE2MRrpVaHcUUQ9QsYjras2t100R3M0hQ8c+Ppg5cQXoSCn2ssJL2OUbhzH/4s85M342Jd1i52+tsiCjQ9CsU1RbFY1xYLJifh7NunVyFUdArT8hI35ACR7uUnTePjvyFonZedg1727eBOiz+hMGR0SEeL2S/bsP+QHQZWKhdL5HHhItqtmQUcYCE/7QG3I2+E4PwylQ+SLAN2H0U85dN+wT9Joup1iT3XBFAoiKKhOaDqCcGNF6cWu/ngEgBuJBRbAcWMV2FosKNXdq/98ei3RHjdsZxe859EZd6owgUY78hRB1iCAigconXgi3eTya9Z6RydI/9nqXdY087HZ0EsWoLSlHcjCbXhc+aWtMjdOR4vRf7cdyTlu9Fho/sCoVxdpavft9i0nrOFOIs8FVAUS/MKIpgIbBbAx7eHroSVm30Wf+iJkyioZ5o+pb8sFgFuez1UpUmfNaUkOf1x6dgAelNFQx4ph1jPT0LHRKTAS/cIi3lAnWAey9AVHu7IXGIy+76jxTNutMKLFtSj1azyaOnNCDLeEua52V4Zu4zo3AW0YWRDdDKGCwa8OKiyJXH8u60VEm9/D5mFL3yqsCRLrpEtxRhJr6WSTA4Ph2eEpisTV3e+muRc/m6Wgk0zbsQSkaY4t5zdS5++UWk2mEwVpCGvHKYcYoAIx/mv542f5m6XxWPoxs6B8Wj0r9h2j+XiAAVDeeMo/JxXbPt3HdlBDMGj5/pmBcaoXa0BLOgd2gbfp+wrcxwAW3B/pVmcSLdT0L7QpoQ/3wpgGFZaT2zwAIUpDas+TvKWU fi2MCu60 1fAdp0z01jAV974+Qj7c/vH7dJQSeuSHTqZC85TDizLNIvRlbncUShjcDt1TqVNtClAtfrU81914OL06BCBqetbVGheQLiNCeNb6SlV17ihvKKVrfy2vHR9C/3GpIfXb/aMriHsIo7QrOe1xNdcLBB8yO7pgmXtjd45rB5Jt3H1sQt02W3kFb3cBXL84gfehLnXPtRX62uvrsLXQfHG5vciPec0lLntLHCbXGcpEl4lQ5P6cq2+8diB6ioAVIK6wQj5aLZRjZPd2U2pc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 12:37=E2=80=AFPM Lorenzo Stoakes wrote: > > On Mon, Apr 28, 2025 at 07:23:18PM +0200, David Hildenbrand wrote: > > On 28.04.25 18:24, Peter Xu wrote: > > > On Mon, Apr 28, 2025 at 06:16:21PM +0200, David Hildenbrand wrote: > > > > > Probably due to what config you have. E.g., when I'm looking min= e it's > > > > > much bigger and already consuming 256B, but it's because I enable= d more > > > > > things (userfaultfd, lockdep, etc.). > > > > > > > > Note that I enabled everything that you would expect on a productio= n system > > > > (incld. userfaultfd, mempolicy, per-vma locks), so I didn't enable = lockep. > > > > > > I still doubt whether you at least enabled userfaultfd, e.g., your pr= evious > > > paste has: > > > > > > struct vm_userfaultfd_ctx vm_userfaultfd_ctx; /* 176 0 */ > > > > > > Not something that matters.. but just in case you didn't use the expe= cted > > > config file you wanted to use.. > > > > You're absolutely right. I only briefly rechecked for this purpose here= on > > my notebook, and only looked for the existence of members, not expectin= g > > that we have confusing stuff like vm_userfaultfd_ctx. > > > > I checked again and the size stays at 192 with allyesconfig and then > > disabling debug options. > > I think a reasonable case is everything on, except CONFIG_DEBUG_LOCK_ALLO= C and I > don't care about nommu. I think it's safe to assume that production systems would disable lockdep due to the performance overhead. At least that's what we do on Android - enable it on development branches but disable in production. > > So: > > CONFIG_PER_VMA_LOCK > CONFIG_SWAP > CONFIG_MMU (exclude the nommu vm_region field) > CONFIG_NUMA > CONFIG_NUMA_BALANCING > CONFIG_PER_VMA_LOCK > CONFIG_ANON_VMA_NAME > __HAVE_PFNMAP_TRACKING > > So to be clear - allyesconfig w/o debug gives us this yes? And we don't a= dd a > cache line? In which case all good :) > > > > > > -- > > Cheers, > > > > David / dhildenb > > >