From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 319C9C636D4 for ; Wed, 15 Feb 2023 17:39:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB66B6B0074; Wed, 15 Feb 2023 12:39:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B67A96B0075; Wed, 15 Feb 2023 12:39:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2EDB6B0078; Wed, 15 Feb 2023 12:39:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 932CB6B0074 for ; Wed, 15 Feb 2023 12:39:25 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5A555160862 for ; Wed, 15 Feb 2023 17:39:25 +0000 (UTC) X-FDA: 80470237890.10.E397282 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf29.hostedemail.com (Postfix) with ESMTP id A235E12000F for ; Wed, 15 Feb 2023 17:39:23 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=WFAY+kEZ; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676482763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H1TegSQrWWZR8y8DXduRdcFIn2Gv2LGeDQhHy0b7yto=; b=bLRePJiRCB2qOtg0u3uFmovkD/EWeMGduFlZ9uljVIoCrZ8E/vlnLciHtfut9Db8+7pjIv 8KwP+JaOOcbv263pGAj0BjMaeC/w/sDcAi0ntGgeHWjRvAH7CXugcm1flpcPbg3cG7cL6l /ZcLFDfOQ4/pOQuPFPnC6b3Ddq8Zkl0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=WFAY+kEZ; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676482763; a=rsa-sha256; cv=none; b=XrXSrhv/28tuLEjPmt6CY1cgGu4SL+PCJtcoxC37LSwoEfvJtBEfFMe+gFyVrtIbc6FMPS TpdWbiGQQgfZWGh4g0EPYK8zYT5MdGS9OI5jCBZHFjD9NaJRcvaddrAaopGGPUt8elW94a 6NKte4z4zLqKwfZVwbM+pNTgRd6Y+uM= Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-501c3a414acso288784027b3.7 for ; Wed, 15 Feb 2023 09:39:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=H1TegSQrWWZR8y8DXduRdcFIn2Gv2LGeDQhHy0b7yto=; b=WFAY+kEZ4MUdHDMej8sLvtg1NtCcTyLoaa4kCDjumgF1vPSCpCOQp0+SmPTWbbphgv 1qdEB+3c/ZsfI94TpAHvpgnaLXkkGdTp8XwEdrQZlev5nAjGSshe5cXxUXy797Sw4ut1 gX/ad1x9WEbuoDv795bj09rb50PEfKJOBtFgqU6rb0sLGt72Dz1sQphwKeGT21Q8+Qx8 5cEIPSOcV2HFtdiFZ0eANnerOvXt/Em+YWCypMgOZl2VNk5VRH4w48igI78zrl0HI95T PTEvIHWKpPRzvi5TTuAo2VDj5vjGZ8ebBdC1U/wiQmmhOYnpLRXBS/12cTMrvERyYByi Kg7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H1TegSQrWWZR8y8DXduRdcFIn2Gv2LGeDQhHy0b7yto=; b=M6CHm+RxQxyllpgvvj0nOFbqNSVyHK9Z+ZsdYYyk5xO2M0aL1Ky0djAN2cObdaV/We NscuQ8q3CvGoZXs6wYZtnYWgiHd9H+T7MSEFynPtbpGfB441T4/bsM3w/vEAPywN4/Lu zYlGk7LBkh3pJO0LJ3lquowYDVoPNvTv4JpdMC4GhCCuTXWd4Fqr+zpjmomTNlIhm98I 9sx1mbOOkWnkvoSqP7rrozYBgX3RyW5x/EzyMVyAgCOG0mBhxQrpYfnmP9y5DrqjZwHb tQ4jS+uFMfIruhmGqPR4MDuLERmXMaooq99MaAP6Fl3l0dul36yvk0hLZgmU8+e43p+N jmLA== X-Gm-Message-State: AO0yUKU+gGAmcn5BgRSb3eD2A2jWqR4N6JMff6+BXYPNTjauRIUzbDB5 bxZbllNki1S7KElNkuUN+cwZ/0MnqCgc+4xWma9fsw== X-Google-Smtp-Source: AK7set9tj0SuaGqHnOQP442Zg1VoaONJfoFdwtf3ZUGe2VF4FOCBp2d9PHYcB5dmd1FIm9VjS1Fr8aaHX2CzwR1jECs= X-Received: by 2002:a0d:f481:0:b0:52f:6f1:c397 with SMTP id d123-20020a0df481000000b0052f06f1c397mr370391ywf.321.1676482762380; Wed, 15 Feb 2023 09:39:22 -0800 (PST) MIME-Version: 1.0 References: <20230127194110.533103-1-surenb@google.com> <87r0uqq1f9.fsf@stealth> In-Reply-To: <87r0uqq1f9.fsf@stealth> From: Suren Baghdasaryan Date: Wed, 15 Feb 2023 09:39:11 -0800 Message-ID: Subject: Re: [External] [PATCH v2 00/33] Per-VMA locks To: Punit Agrawal Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: n1sozzdzmubkre1osgf4ffn1ata4xfy4 X-Rspam-User: X-Rspamd-Queue-Id: A235E12000F X-Rspamd-Server: rspam06 X-HE-Tag: 1676482763-788157 X-HE-Meta: U2FsdGVkX19K5Q6FXOEVe4e6iCzrr7cMifyRWR2cPwkucciUqDsN0KPI5a1BQdygwNgLfEF+jMp7OFIrBEOBBBOpnEMCpYA3wv7sOFTkTKKlMjz3lK39rzTWmYAprnxo1SYx6/RnwEHJF+YHUMFS/ciaHuiIfBrzN4XFWk5W9XHdOUGbFhfW9Aai8J4b1N6kkjEm25BYcH/770qiDK2pbdjUqeysr7Mmc4pg77ahqCeZ4ykQ2XnUnNx6tqmdT4TEaRzPknU8FtKzf7C+ZkCmMgLrna5PS7Tx8iKzqvhdROboUGzKsH1TNJM24KV40b9XpWBKqPky9Ccq3OETUBmxUEC4LNZPPDCZ+SV6qoUQu9Av2BD0QGqEZ3cwooGgEvJQEM+4vflld2OsmGcVzI8HbcWJhyyaSL6Wu78S++HEJz8iKwqQMxd9ncXDgowsHnq0F1Xd2SOlIUFn7Q/G/8zKyXOv4q43EXRstmqu8nTIBwoxphEICcQSHNLktoaK6yOwplwxLhLUtNksZj424Wrts1ElmYO/vHfPQyOJ2B2dLdGo2jg69CuAFYYE87YMb33gHg43NJfX3vcHYfYd74Vtsv0nZZS/6k1Gup3QkZxAA7frKvgRT1bxf/GKOatnhy+3WSHfSNEfgn+mE2V59MuPUAO9xJ+mdFcLIRLiX0+xI2nd5Z/TAjdUYPvKLWyhO7NdZEdIfaEh1oobiIM1cvyaYUOj946KkhLm6O3Dd1LzWhWHVHYVlmZGm1ZKEOZdSXi01jzvDP+nzUQKHie/UpQ6tZaDHMMRxwthsRRk1GNyCYRyFNPWOtB2giCZIsBM1gW05dVBqM82+rXz40qhJDK2gR0pgUrvy7VKV0fbnY7BqkCPFrra6FjKQtrRwNpLYdsJPKclyRbVkKABTGYMhX0wKjZCzNTK2yVmWEddhLC2NQg5TaRUn9yeWImiXo3ed4OHz/+G7zUK6T8bama7xVg 3JCxiVcG eJ1nw7x7RQCy9jAk7eruS65wC1E0AvnAlvOrfB3WX6tedOLs45UiYObdBkapFzEuT7WyVRRn2GF9Dy3p9eRDbYl59Fg075pZRcftSozA7lIbgyjicNbid0FvjLxyl73Q5S4WV+GQFK1TyXN8MVQkvkP98q9f3kwOJvSf6k36QCBjagvnKhQHdZqIcZbMQedgaTQuxBl2KMmmzLen3vzgarBdzGGoVa5LnjDEvmEB7kdDiZAnCVTJHSgje4OkUa+pr86dx/Fh4PPr2o5ClL7+vjPYCwkDuy2Iq40SLkY9OgL7d17TECUF+1gdyYgE+JRJEwTbOwrS4CVcIh9xc/dHoMXdU164zJiztrOy8w0c8xjGQnLu78WngqB1cTMVWn90L0paDvgiyj9arsr6psfBJzOKgqwRO/s+OZhHpVmAf/pwgJaFAWBkyIvHg5gdiN7ZjzpUM/OgKd617rw0cj1dnyjO+Fg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 15, 2023 at 9:33 AM Punit Agrawal wrote: > > Suren Baghdasaryan writes: > > > Previous version: > > v1: https://lore.kernel.org/all/20230109205336.3665937-1-surenb@google.= com/ > > RFC: https://lore.kernel.org/all/20220901173516.702122-1-surenb@google.= com/ > > > > LWN article describing the feature: > > https://lwn.net/Articles/906852/ > > > > Per-vma locks idea that was discussed during SPF [1] discussion at LSF/= MM > > last year [2], which concluded with suggestion that =E2=80=9Ca reader/w= riter > > semaphore could be put into the VMA itself; that would have the effect = of > > using the VMA as a sort of range lock. There would still be contention = at > > the VMA level, but it would be an improvement.=E2=80=9D This patchset i= mplements > > this suggested approach. > > I took the patches for a spin on a 2-socket 32 core (64 threads) system > with Intel 8336C (Ice Lake) and 512GB of RAM. > > For the initial testing, "pft-threads" from the mm-tests suite[0] was > used. The test mmaps a memory region (~100GB on the test system) and > triggers access by a number of threads executing in parallel. For each > degree of parallelism, the test is repeated 10 times to get a better > feel for the behaviour. Below is an excerpt of the harmonic mean > reported by 'compare_kernel' script[1] included with mm-tests. > > The first column is results for mm-unstable as of 2023-02-10, the second > column is the patches posted here while the third column includes > optimizations to reclaim some of the observed regression. > > From the results, there is a drop in page fault/second for low number of > CPUs but good improvement with higher CPUs. > > 6.2.0-rc4 6.2.0-rc= 4 6.2.0-rc4 > mm-unstable-20230210 pvl-v= 2 pvl-v2+opt > > Hmean faults/cpu-1 898792.9338 ( 0.00%) 894597.0474 * -0.47%= * 895933.2782 * -0.32%* > Hmean faults/cpu-4 751903.9803 ( 0.00%) 677764.2975 * -9.86%= * 688643.8163 * -8.41%* > Hmean faults/cpu-7 612275.5663 ( 0.00%) 565363.4137 * -7.66%= * 597538.9396 * -2.41%* > Hmean faults/cpu-12 434460.9074 ( 0.00%) 410974.2708 * -5.41%= * 452501.4290 * 4.15%* > Hmean faults/cpu-21 291475.5165 ( 0.00%) 293936.8460 ( 0.84%= ) 308712.2434 * 5.91%* > Hmean faults/cpu-30 218021.3980 ( 0.00%) 228265.0559 * 4.70%= * 241897.5225 * 10.95%* > Hmean faults/cpu-48 141798.5030 ( 0.00%) 162322.5972 * 14.47%= * 166081.9459 * 17.13%* > Hmean faults/cpu-79 90060.9577 ( 0.00%) 107028.7779 * 18.84%= * 109810.4488 * 21.93%* > Hmean faults/cpu-110 64729.3561 ( 0.00%) 80597.7246 * 24.51%= * 83134.0679 * 28.43%* > Hmean faults/cpu-128 55740.1334 ( 0.00%) 68395.4426 * 22.70%= * 69248.2836 * 24.23%* > > Hmean faults/sec-1 898781.7694 ( 0.00%) 894247.3174 * -0.50%= * 894440.3118 * -0.48%* > Hmean faults/sec-4 2965588.9697 ( 0.00%) 2683651.5664 * -9.51%= * 2726450.9710 * -8.06%* > Hmean faults/sec-7 4144512.3996 ( 0.00%) 3891644.2128 * -6.10%= * 4099918.8601 ( -1.08%) > Hmean faults/sec-12 4969513.6934 ( 0.00%) 4829731.4355 * -2.81%= * 5264682.7371 * 5.94%* > Hmean faults/sec-21 5814379.4789 ( 0.00%) 5941405.3116 * 2.18%= * 6263716.3903 * 7.73%* > Hmean faults/sec-30 6153685.3709 ( 0.00%) 6489311.6634 * 5.45%= * 6910843.5858 * 12.30%* > Hmean faults/sec-48 6197953.1327 ( 0.00%) 7216320.7727 * 16.43%= * 7412782.2927 * 19.60%* > Hmean faults/sec-79 6167135.3738 ( 0.00%) 7425927.1022 * 20.41%= * 7637042.2198 * 23.83%* > Hmean faults/sec-110 6264768.2247 ( 0.00%) 7813329.3863 * 24.72%= * 7984344.4005 * 27.45%* > Hmean faults/sec-128 6460727.8216 ( 0.00%) 7875664.8999 * 21.90%= * 8049910.3601 * 24.60%* Thanks for summarizing the findings, Punit! So, looks like the latest fixes I sent to you for testing (pvl-v2+opt) bring the regression down quite a bit. faults/sec-4 case is still regressing but the rest look quite good. I'll incorporate those fixes and post v3 shortly. Thanks! > > [0] https://github.com/gormanm/mmtests > [1] https://github.com/gormanm/mmtests/blob/master/compare-kernels.sh