From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E7D8C48260 for ; Tue, 13 Feb 2024 22:30:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 146958D0013; Tue, 13 Feb 2024 17:30:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CFCF8D0001; Tue, 13 Feb 2024 17:30:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E634F8D0013; Tue, 13 Feb 2024 17:30:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D1CCE8D0001 for ; Tue, 13 Feb 2024 17:30:57 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AF64EA0BFC for ; Tue, 13 Feb 2024 22:30:57 +0000 (UTC) X-FDA: 81788226954.10.7E3F4C8 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf07.hostedemail.com (Postfix) with ESMTP id DDD0140019 for ; Tue, 13 Feb 2024 22:30:55 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ldtWeoPU; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of surenb@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707863455; a=rsa-sha256; cv=none; b=7/XFSCGbDufRWodAsRzBiAdfLd6jjuiq9l4dQChVqhEKEGdaJJYv8YcjKvW/1xA+Yo+Dw2 in+FzbzfOqJMU8akVLbQR7kNCvZkwmz5LmwwFidTSOEDv5EueiXvJUyIThqOlpU6Q7BYBo X96+gXFCov5qkQsEWRVVfGOCiMybOVU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ldtWeoPU; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of surenb@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707863455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W3iVhRNI3SJOZTKFO/V2hJvAlU1SxV9FtnbmB6rZ05w=; b=YfzBJ3Kk95Fdv9wzgbVyAyjsK9uxQ41b1bGyd6EH3kOlPjrIMMlP5pbORcL7TmCxPk2fXj td+zxCN1d9ErFZMXKTY35P9NkGzrnGboRb56QEY9Ng8W2k4pXq0TnSARoFRZQalZEKhr55 a3vSKqebPCGwK+VqpuKrOHzmPFZCjAU= Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-dcbcea9c261so2036627276.3 for ; Tue, 13 Feb 2024 14:30:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707863455; x=1708468255; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=W3iVhRNI3SJOZTKFO/V2hJvAlU1SxV9FtnbmB6rZ05w=; b=ldtWeoPUrUcdPe2P4JgO3fpBp/PYlczEXH3Swxgf7mfCo+jhkfnPIWT9vwA9Xw8brF aotdR9DTLmIVHt4D3C30xmZM0f7Eindzlz/7v4stz65jncnWo5jG8BltdCfhYFj1OA2+ 68Mzfw5KTWXObg6Fbc8WFG6XP1WeaKnc8FvY1tagRvg5qumYKaIk45DPHfuOvvXgb4D1 rvtCDOSm5Wx1GR9SlVOVV2rKpful6cQZifdyWlLulZ0kawVFD0hMHliXCX1mh5y5f6+A 7vKDW5P6h7+byGPQffLfDdzDTVV3OhbfofdF6c/H2SYaZvhUd1VjeX7x+uDWzcGJaWbW VcQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707863455; x=1708468255; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W3iVhRNI3SJOZTKFO/V2hJvAlU1SxV9FtnbmB6rZ05w=; b=Vn4Eb5An9ggF7elcAnKl9MzjxSk7LkU72ocgNEQbzlo4H77QCVL4iRIERrugXbhqZp uguUXaZjlfgcLe/dT5CZjeDqjKKyqK65f6AF4dQKkRseBS3n0K4ocdP7KIe3wgcc0xmW nnvABYfpWlH/xK7olmWuFo0xQn8b4sVW0QtF5eLeX0RvmcHd+VI6YcfTLh0uOS7e3/gQ Ndne2fczrAa1oINhGTjhT+lKV/rHqckphAtmQ2VvZ7QK8GHF9vad0+/hvRh4U+FkZeV3 vYGgSIE/cW4z5CeIQYM9uOtGZKx4kZKFCtwyfOEJWGZHXSKNJ1Y4xfqIrGO9roXmoj3o jE7Q== X-Forwarded-Encrypted: i=1; AJvYcCUpLyqCCN8A41jGHnkuUbOeTWiST8K2HqIvCRIRvpEzC2sOwvUogqws2nv3ah9BcZZpW4dH525lMj9GThtPdk4hpR8= X-Gm-Message-State: AOJu0YwO8WCAhfRTLIrdY8m/icZrhx2gAEPMCeEdbiY/GbAb4msS/rsf uZ7al4/1HgJO2aUebY02aVEQm6PNypoq1NqqIRWM3yy4DVDTuJbk/YRHL3X6KvyrCqZUB56lsq/ K3GRT4fPjSLmW2/388ie9Qy8kOptJLhfneEkz X-Google-Smtp-Source: AGHT+IG1FA0jhI08ACtlkU58SUtF8BeY+odMEcGvWTpz8tU2mjZAwusKC+HjyJxosLmKwFVasQmCm2Mj11FO/ftiN4Y= X-Received: by 2002:a25:e0d2:0:b0:dcd:df0:e672 with SMTP id x201-20020a25e0d2000000b00dcd0df0e672mr440832ybg.47.1707863454566; Tue, 13 Feb 2024 14:30:54 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <9e14adec-2842-458d-8a58-af6a2d18d823@redhat.com> <2hphuyx2dnqsj3hnzyifp5yqn2hpgfjuhfu635dzgofr5mst27@4a5dixtcuxyi> <6a0f5d8b-9c67-43f6-b25e-2240171265be@redhat.com> In-Reply-To: <6a0f5d8b-9c67-43f6-b25e-2240171265be@redhat.com> From: Suren Baghdasaryan Date: Tue, 13 Feb 2024 14:30:41 -0800 Message-ID: Subject: Re: [PATCH v3 00/35] Memory allocation profiling To: David Hildenbrand Cc: Kent Overstreet , Michal Hocko , akpm@linux-foundation.org, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DDD0140019 X-Stat-Signature: qgq4p17yasbafpyzd8nhm4zegu7ym3qb X-HE-Tag: 1707863455-841871 X-HE-Meta: U2FsdGVkX1+m9H0zcvmp5My3zXcia+G2xN0eKZeGa4Ul680fCxivXB6i+qmxEq9XYEWgubyCV/OTKAyKDWpqyyN/KHE0hQXmD6lzRWorXY+YpYJ6AyLoCMFMmtAFvDgu/X9XPqrhSmPZpZlY69OItH2IPhLSryqC212IOV5OKT0V4LfY6FO0uO5I3YYq0PSVRgByK0yI5QoZ0mQyr0cvARaTcFhQ/aODRxatWTR7Kd+pimdwEt/OSF8mbq/TgIgE89gXmia3wjRxUbbltWJSTBELpbEEwYKsScQChTEWxjLVVgJLb6dqgB7sYZ10BfWaUx55Kk7dlF8+zXMQZNxSJFxrPDQHNo6+A3WwWy1Zf+U9i+8m3YLuZEikEyN5fVTl3l6LU9cuSBfUGAN19FRrXxWjOc8wNMbI2gZ5PlxRedvXP2+DANZEOElz6nlrvZ4SHeqEN08rIIVaQR1gU1zZ7sV0RoN/sHMHOKXHlxOvxJlktnC81uPjUOGCMIK5OtFec5j/iiT4x7QHI1aWlaYe1eBxJoFKBmZuu+oTrY8u3AsKRbr8Cphvq8xaL7mIZwih0+Jlg+YmVybRb5cWA3da5MyDIBTTR1TX5qwSNP2G5FQJiyhNsOgkrYBhVcja06i588lrqvF+MO+GRtGSzl96x6e4aq4fAel/BGbEXEssfbu4pnYIGXb6eReGhcUZR35C8RGvyLRKbYmYWHDQAISc3J/uumY6dMzSw7iFbJyRirsV5oqWGQVOXgJ9ZCkC6pUitCdAq8T6r/w/AWMydXCvgE9SLY/N3cNh3hn6eG7opG0GweJ4DOHAaYv33zT6Zv7EuczmCsOc8j//ies5mEDHsGJK1H5MLhvHc91+loeP7x2Rpca8UYE8SZHMdbrI2Ybsugxs/uW87ngwYBnVi90TbECg4boSpxg1wNdedgVvJ8NlAmkTElLzWzp5ni1t/HLjur7r/ELvkbW4EtB4sOr EGURkptj LfZI/4aSTR7xk/uQKcnAkhoLXrSS3/pWGaEHsYXsZ0SZbSFTtwU2PYgT3lXh7pWA72Pv5K+t1omH/lcB1eFxqAuejZLVRvB/mP8uG1z8drawZ0c0qCYtmGfvdKByPvmU8mu0XZ6qceSaksv688JO3AU114ycicL8e7sFAS+5Jjg2sVFxogP3+aMLPYAnRowr8s4ROjyspzYJxHtwIREC1TMYzSs+wOgKvWjBKAtkkjfJ7McsDtuNI3MV0kJx8HlSXD7Ffv5v8yi85ttbLuvpKMxHa9ibCCd/7qM/pHcrvCHyGsuKbiJKfK1VHLaSJ6Pbatw45saqLfEt9XCsxj1bDActUmD3hFTsLBrxIgpf+qMmx+r+28Zo1xMMDSoxrjEcro4/BOrjl5pMgk0NN9wpeoxSLL8qvnAs5lu2xBi4aIXqLaSw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 2:17=E2=80=AFPM David Hildenbrand wrote: > > On 13.02.24 23:09, Kent Overstreet wrote: > > On Tue, Feb 13, 2024 at 11:04:58PM +0100, David Hildenbrand wrote: > >> On 13.02.24 22:58, Suren Baghdasaryan wrote: > >>> On Tue, Feb 13, 2024 at 4:24=E2=80=AFAM Michal Hocko wrote: > >>>> > >>>> On Mon 12-02-24 13:38:46, Suren Baghdasaryan wrote: > >>>> [...] > >>>>> We're aiming to get this in the next merge window, for 6.9. The fee= dback > >>>>> we've gotten has been that even out of tree this patchset has alrea= dy > >>>>> been useful, and there's a significant amount of other work gated o= n the > >>>>> code tagging functionality included in this patchset [2]. > >>>> > >>>> I suspect it will not come as a surprise that I really dislike the > >>>> implementation proposed here. I will not repeat my arguments, I have > >>>> done so on several occasions already. > >>>> > >>>> Anyway, I didn't go as far as to nak it even though I _strongly_ bel= ieve > >>>> this debugging feature will add a maintenance overhead for a very lo= ng > >>>> time. I can live with all the downsides of the proposed implementati= on > >>>> _as long as_ there is a wider agreement from the MM community as thi= s is > >>>> where the maintenance cost will be payed. So far I have not seen (m)= any > >>>> acks by MM developers so aiming into the next merge window is more t= han > >>>> little rushed. > >>> > >>> We tried other previously proposed approaches and all have their > >>> downsides without making maintenance much easier. Your position is > >>> understandable and I think it's fair. Let's see if others see more > >>> benefit than cost here. > >> > >> Would it make sense to discuss that at LSF/MM once again, especially > >> covering why proposed alternatives did not work out? LSF/MM is not "to= o far" > >> away (May). > >> > >> I recall that the last LSF/MM session on this topic was a bit unfortun= ate > >> (IMHO not as productive as it could have been). Maybe we can finally r= each a > >> consensus on this. > > > > I'd rather not delay for more bikeshedding. Before agreeing to LSF I'd > > need to see a serious proposl - what we had at the last LSF was people > > jumping in with half baked alternative proposals that very much hadn't > > been thought through, and I see no need to repeat that. > > > > Like I mentioned, there's other work gated on this patchset; if people > > want to hold this up for more discussion they better be putting forth > > something to discuss. > > I'm thinking of ways on how to achieve Michal's request: "as long as > there is a wider agreement from the MM community". If we can achieve > that without LSF, great! (a bi-weekly MM meeting might also be an option) There will be a maintenance burden even with the cleanest proposed approach. We worked hard to make the patchset as clean as possible and if benefits still don't outweigh the maintenance cost then we should probably stop trying. At LSF/MM I would rather discuss functonal issues/requirements/improvements than alternative approaches to instrument allocators. I'm happy to arrange a separate meeting with MM folks if that would help to progress on the cost/benefit decision. > > -- > Cheers, > > David / dhildenb > > -- > To unsubscribe from this group and stop receiving emails from it, send an= email to kernel-team+unsubscribe@android.com. >