From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECC73C48260 for ; Fri, 16 Feb 2024 17:11:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C15D6B009D; Fri, 16 Feb 2024 12:11:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6493F6B00A1; Fri, 16 Feb 2024 12:11:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C31A8D0001; Fri, 16 Feb 2024 12:11:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 382596B009D for ; Fri, 16 Feb 2024 12:11:31 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 02FE91601FF for ; Fri, 16 Feb 2024 17:11:30 +0000 (UTC) X-FDA: 81798308382.22.A80B1AE Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf02.hostedemail.com (Postfix) with ESMTP id 427428000E for ; Fri, 16 Feb 2024 17:11:29 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=S4O3yNC9; spf=pass (imf02.hostedemail.com: domain of surenb@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708103489; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uuBxuiKdZN3KVCrAhLvxlGbAMwEHkyTmKhPVF6pp06o=; b=lqZkLM69jiWL4n0oviqCYgcbZgFDi2fcuU5DiW5ytLshlp87ZO35cp+dlhDdAHtzgG7DZG 5DhX3o7ccoCvVAyknCLw4/kuggg+x9TypaQJkf8hIW+jyoDsKzutjigzKLhYjrC+O85Dln n3DXYtATOYTdJd0kau/OLkQzl6XhOrQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708103489; a=rsa-sha256; cv=none; b=WO8lqUyBLinwwXd8AlI514VzlNd5YfEDlGM9kZ5iJhBDs3JThTeRRlNCPGLR+m/iUd4DHa 4VuSOVDDtt62PR0597Rt7s71prO2QcNL7p5oD7gXIzfr6uvxUq8d14W/fL97s6nxUH2gEH aZg58aVNE/GL8Hk4XKc6Cwe/Tqvy8Y4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=S4O3yNC9; spf=pass (imf02.hostedemail.com: domain of surenb@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-607f8894550so7234217b3.1 for ; Fri, 16 Feb 2024 09:11:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708103488; x=1708708288; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uuBxuiKdZN3KVCrAhLvxlGbAMwEHkyTmKhPVF6pp06o=; b=S4O3yNC9gCzLoWzuSk000aaPOQg7u0SNUsv0TKOiEKRkWZqvDFVgKmFRPgIIlPmrml Tje8waRxEXuOaFoF9K9gaOuENmKCONI84zsjnF7AZ1YKHdBEJaH27ZSKVAfREkHXznw3 REOD0PtpUEbCFrBpPo5bcEbO2Vghg5u+7peI78ek+UoFpYyXo5agHNgorcRgc4kYVPvJ pQLRHehCNFmo8C1K/whT0rb0oXadJHJFJf1ZE5Lt5ga3MbLe0nN5+UYa4KlrImGBDKhB BccnaUoPIBZq282pX6ZKHDNtMIhzVPwMxRO5CaLJUSFd87hfOmfqslfOYi3HSzG+zB3G NVdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708103488; x=1708708288; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uuBxuiKdZN3KVCrAhLvxlGbAMwEHkyTmKhPVF6pp06o=; b=M8oBCml4tyxCmRFacP78ZZJJaVp1BM61a4F7A3Z/5lSoe0aWv+YU0E4XKaVI259wkp 33LeqNL5C6Me1kRqdSXm4oYFXkAkZRSFfPKYxUd1q+V76859TJ1nR7w1Oz4Y5XeR0OHW sClWemIq5kAEElVOMstO5wnGZcAyi3I5V1SOR9A0kxPFZZsH/7qVbXIoPoLJyJG6Mcg2 N1L47eBnoGicP0etqWXczpHvHAAGjyI1HagxOetSJPmjRPf1nyLUZ/1xfcSw5yBxCe+r B2o2/yif/fKSUNl976MgciaXRfHQB6F/bhldNhKWlbJP+SFd+XDLESCzAmHTczw8im3N VUrA== X-Forwarded-Encrypted: i=1; AJvYcCX3wTXUm2yPijdCkZxapNf5gAnlQnyUEHxK8pcHvhROrBsW+i5DVJS2CVlCr8wLeCmEDtG8JYvNh3CrEPGyPrS3Qoc= X-Gm-Message-State: AOJu0YzeOfw4fPew8YcyyaCwYqtWvdamuMJO9/Dw3CyMliW3MNBdMZgI I0D3830GeVxKFr6Mw6DgIFWu0HNjjgmvNwTyPEQAXkCTDM2a6kzOMJoBBnJg2WsT/QxAj/TWdci fAxX3sbEJLUb/r2iSd35duyOQn9Z6rpwTvu2Y X-Google-Smtp-Source: AGHT+IGrTdDphKuPSMMFIAFPJovR9x9JDU4EDFPzTY0y3WFZl7FqMruLomlujQStik0SDQEztF8S9x7Y+PwqmZ025HY= X-Received: by 2002:a81:8391:0:b0:607:e1c0:450b with SMTP id t139-20020a818391000000b00607e1c0450bmr4624095ywf.0.1708103488010; Fri, 16 Feb 2024 09:11:28 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-22-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Fri, 16 Feb 2024 09:11:17 -0800 Message-ID: Subject: Re: [PATCH v3 21/35] mm/slab: add allocation accounting into slab allocation and free paths To: Kent Overstreet Cc: Vlastimil Babka , akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 427428000E X-Rspam-User: X-Stat-Signature: w5tfa8kdhh7gmyywo9wjis34xzodsrxy X-Rspamd-Server: rspam03 X-HE-Tag: 1708103489-937642 X-HE-Meta: U2FsdGVkX19IX+4QzG9sm8DEXoxa09hK+5YqdNnmqmuW4Ulg0S+cvTOwf3kadcwxCqCglFzx9JrBKx3PX0eBpsTOge0cKY9WPXQjVGlBJZbRRGTCCwwRTQ/ibz82yDHNUDG4yqW+NwUbV5+1KOHd86+dQDxw51grlK7Qsz8TcprrOjAxgLdX6X9bpDp9e9g+fC9XuNDG++TsJGuoklFeB+0aMcGIkftYoc/wLB/wkzPbs4brV4NdlVHZpA15pZDEnZKMVhrGymBR8/cvk4KfOYhzxpU7oLkn5boxq+RSE2wmavzK+e8VMDvHeCr5HPlBHwC+eO9XlZrHdqzMWaDmNmZva1poH5+GPkyUQaKrnF6bt7clZY2tX7wn5J6T2DGrRIQ4md1K6+5VCba5Lzzy595KE7QhvBMPm2vZQn9Dj/NFPwxkUQD5YmBOGIiczy0p8X9e8hCSVX9o5DrjbYPa+3lRWeCG+yCzfRE/VnBnY1/GeIZkjGoMTrlZLn8kbmaxP3jkLvQ7e3YtEj2SRu7GrweJEeIOjH8L+gMDFhwJ87D06nlp7B6keuvaHPpSNHy0e1mPRLosEwTJZoz9GtyzTO149j+IFniQchoYkDxFpKrORikgt/lutwZE+a0XDmfX8+I5Q7Rn+ZLa95qA58r9mObtUmm67lyrdOMni4XnnakA/yUlRZ+J8mzUGLnSAi79Kc0/TByLeeysXv62Ej7I/JiXZMKxMOSOSGRnLnON7wfnstDi9v/CLrJPIF+ucAe8+Oph3NnSeRP/3zzPOFrMwVXLuqhY/s93pbEd+E2zPY4T5lK3gF059oMg44NAzciNjAEamm8+/GQKewVulVI6mz/QcPsBED0BDikYB2Cy30q+iDOBTsdDB+ldjA/8smwe6PF1bFzQHGxrDuY857Hf97ZJ/phqZSLhyAD1dKMllaq5/Z+3aAsmsNWCSLaPwuRbDJAcV5DQ7ISDaJ0dgRd 2at6+fTy MiUOYz3bBzhSJrGLiV6Pl1AKfGq8Epf7Fr5nJ17QbufE8u3ZhCyPm57WO++wHh6ILgZwc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 8:39=E2=80=AFAM Kent Overstreet wrote: > > On Fri, Feb 16, 2024 at 05:31:11PM +0100, Vlastimil Babka wrote: > > On 2/12/24 22:39, Suren Baghdasaryan wrote: > > > Account slab allocations using codetag reference embedded into slabob= j_ext. > > > > > > Signed-off-by: Suren Baghdasaryan > > > Co-developed-by: Kent Overstreet > > > Signed-off-by: Kent Overstreet > > > --- > > > mm/slab.h | 26 ++++++++++++++++++++++++++ > > > mm/slub.c | 5 +++++ > > > 2 files changed, 31 insertions(+) > > > > > > diff --git a/mm/slab.h b/mm/slab.h > > > index 224a4b2305fb..c4bd0d5348cb 100644 > > > --- a/mm/slab.h > > > +++ b/mm/slab.h > > > @@ -629,6 +629,32 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s,= gfp_t flags, void *p) > > > > > > #endif /* CONFIG_SLAB_OBJ_EXT */ > > > > > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > > + > > > +static inline void alloc_tagging_slab_free_hook(struct kmem_cache *s= , struct slab *slab, > > > + void **p, int objects) > > > +{ > > > + struct slabobj_ext *obj_exts; > > > + int i; > > > + > > > + obj_exts =3D slab_obj_exts(slab); > > > + if (!obj_exts) > > > + return; > > > + > > > + for (i =3D 0; i < objects; i++) { > > > + unsigned int off =3D obj_to_index(s, slab, p[i]); > > > + > > > + alloc_tag_sub(&obj_exts[off].ref, s->size); > > > + } > > > +} > > > + > > > +#else > > > + > > > +static inline void alloc_tagging_slab_free_hook(struct kmem_cache *s= , struct slab *slab, > > > + void **p, int objects) {} > > > + > > > +#endif /* CONFIG_MEM_ALLOC_PROFILING */ > > > > You don't actually use the alloc_tagging_slab_free_hook() anywhere? I s= ee > > it's in the next patch, but logically should belong to this one. > > I don't think it makes any sense to quibble about introducing something > in one patch that's not used until the next patch; often times, it's > just easier to review that way. Yeah, there were several cases where I was debating with myself which way to split a patch (same was, as you noticed, with prepare_slab_obj_exts_hook()). Since we already moved prepare_slab_obj_exts_hook(), alloc_tagging_slab_free_hook() will probably move into the same patch. I'll go over the results once more to see if the new split makes more sense, if not will keep it here. Thanks!