From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90589C54E58 for ; Tue, 12 Mar 2024 19:57:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03B3A6B02AF; Tue, 12 Mar 2024 15:57:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2E216B02B0; Tue, 12 Mar 2024 15:57:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCE0F6B02B1; Tue, 12 Mar 2024 15:57:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CE09E6B02AF for ; Tue, 12 Mar 2024 15:57:10 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A2AA81A006F for ; Tue, 12 Mar 2024 19:57:10 +0000 (UTC) X-FDA: 81889445820.15.6B72723 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by imf06.hostedemail.com (Postfix) with ESMTP id F29F3180010 for ; Tue, 12 Mar 2024 19:57:08 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WklGh+lJ; spf=pass (imf06.hostedemail.com: domain of surenb@google.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710273429; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wT+2mjCDEB2wrTUTyTKLuab+xNoniRJZtNtidsDDPI8=; b=KWcftsrArLtC4Bx1EDu72WOgtACFj6YKwnfljjXsoW7gPOaACU7k2v335IJy0HBneATVfM xun5RNLdyNBxXpyqYcg8BORtBiI+GFkiJk9sQ/2jRfV64I/NVblj//OVKBOmsEp43XG+pX 6nbWGHYrcy2RiqGlyeBBiEem/OLyQvY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WklGh+lJ; spf=pass (imf06.hostedemail.com: domain of surenb@google.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710273429; a=rsa-sha256; cv=none; b=mqO3ZVjMpZ5Y0F6msjwEls/CbLz8hBtu4h/IQ6XTy6u6v+jfuBPB0LYl45av8XjMCMni8E DndA46zRBfYsJoWrwpA/VE6o4mFyIL3nNMBNThb6oiPz6Fgmm4SmKGehA/F/4+cEYldG2N niiG4u6j/5ANhNkl6YUq31Kc1ueRKgg= Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-6098a20ab22so3034587b3.2 for ; Tue, 12 Mar 2024 12:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710273428; x=1710878228; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wT+2mjCDEB2wrTUTyTKLuab+xNoniRJZtNtidsDDPI8=; b=WklGh+lJ1/6CrImZz34YKGNKkk9fMIm2tslKVyQaCEQs9jzPSpuKo742MupxFT29nr EPZlIqxL4NUSKF6ifhzNuhXPknqaZouQDbp1usfUhHfr6AozonjwUWWv9aAHmCPrXwv6 KRAxuf9nxJ5DmJCzinRCoZuWlcUWT34rPfiWXv/NtvvRe8pzgOWLPENiE5JuCekMmn4B ZjzD8lapupNfUF2jsyE4tJPQkXmz5rKpUfSw9SjxdBuJTQH1LSlRfUuFJlk7ov02Y3rp hrgh/HCnG057BPlUXjYFVcq5GmpAgNMoKl0nfUuzihdhAbqkMdHQWv6+h9BdCVnSf5gP pcqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710273428; x=1710878228; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wT+2mjCDEB2wrTUTyTKLuab+xNoniRJZtNtidsDDPI8=; b=IzE/OzLdCT3SBm0JeMUhvkMyuxfaf3ikM2BQMSlcMDMq0el4rj9I66yumah5/6IRqX 3ck0CGRM0dwIC7utg6pYPKY/KKn/ic3PKoFZLALn49d6XmNFIVNNnl/yHpt671V6HnX3 L4KbjLw5bpqRJjbpWwsy5CK7/D7p9fAvh/mYmTEuGq7M9GZk7C2NtfdPc0DBqXSOeH1F COc3jWE+nE9gqcwv3/BmEthOtTsKWqRrSPNANqhKFc3iXwFzjgyGu2RPEZYEa2FOoFQ/ Ewy8cPG4C5o55Q1Fy7JxcRsRF1F72e6aIz6BmCBJHjbC0C19/+pwaMDtyshxAocZWDVI WjXQ== X-Forwarded-Encrypted: i=1; AJvYcCWoD5ZJ9WC2A0rcEOxH5Fd8pjYXcuKHOEZOqtwUSxNLG9L2kr8uPsr2hiJrVQWMrvRhVNe3QMoZRrG+pTTrp4pIIF0= X-Gm-Message-State: AOJu0YzKmDnatTo5vaWiaM9pqgHDfdxsWoI3R/9G++wlmOJp/09JoD8K B1UtCm2sF1PFup/PnHgkhpKTjPIr8qkQIz1ms2g+smBoswEv37i6C7vZTgR2vJnZAEByrz4EA6I /wiCY4hTyqOtzUkk3KlbIblXDqtnAEUY+7QHZ X-Google-Smtp-Source: AGHT+IFrpwFQf6DsD+MDcouIBUBxz7xm6ZVbTg/EsBFYmgBgqnN4d7DhlPhedvQ2z/xYUtX9OCTiPw5W4WvHfMsUOCA= X-Received: by 2002:a0d:e885:0:b0:60a:67fb:146 with SMTP id r127-20020a0de885000000b0060a67fb0146mr551414ywe.17.1710273427660; Tue, 12 Mar 2024 12:57:07 -0700 (PDT) MIME-Version: 1.0 References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-14-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 12 Mar 2024 12:56:54 -0700 Message-ID: Subject: Re: [PATCH v4 13/36] lib: prevent module unloading if memory is not freed To: Luis Chamberlain Cc: Vlastimil Babka , akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: F29F3180010 X-Rspam-User: X-Stat-Signature: kpmbugszd1yj1g3bo8kba9spm5j58iuf X-Rspamd-Server: rspam01 X-HE-Tag: 1710273428-662834 X-HE-Meta: U2FsdGVkX19r4Xg+0HnOdQKfZSRhXxw2lYDIMrrJEg/9YudIgnyPVkbIQoAsXHY/sqsvCTTJQ+KGhNbTMeVO07jG9ahaAVKBsepLwTGhKBvfWKLP4nT2MyDBLazk3RgWHI/GwScGuyUTo0lvSYGSfXTJBxHNmuPy1Qtl6+i1vJYlgTIFW8b+HKtJZUMBXiH/nbtMtQ8eacPq1/vODdYBs+sLPRzWIwGM9f0Cncz++Q5DySWmBxlwzDXSnHQPnmhbD0elDODi9aYPKYejnAOXfcm/PU9EGlYl8qtdjtAI4P0Oal7i7RpmDpvjX3WVhtJ5HQP8XdrB2gCNNPwgvAw+3b+qnUnstXUmxANcOS9uPj2UskRLSqn/ilR//Iy1FbL80UWwmh2jWsEgw63+7JtVJr6lBHSF3O7nHs9mOjst0X7VZ2Fe5gv6zZZK2GbYx+TlSfCrgUX1HiTrr3CJac8Bayy02t3GUoXwOVAye6oXnVRNRQuWm4lfBQRzbY8Ei5SpjMJ5kg43bu9LOqyNMz9m6G3iBm96KsGFb6E9kx1zWT26lnl5Y+PkCShtrsyYGn6gSVrmMBVQ0OGMdjkT6IJJemh5rASctHszSiH+oDIy1P/od70IBaRpWaOXNdz2sUdE+dc/5c6yZhyhDtJ/L3sjbeGBX8f67jtfCD+5qQpkk1TQtlYv79GiHSBHlXzXX/Y2+GV7ZsYxcLxJeGpQbewGCqKTqlgYLqhdS5Z+1pO/QSEjk1sgOTmX97RFZ0Sk7GMdGEpclNW99F7TjstbUbVrqnmf5XNeR6Pk8Uenji0If9dqa36wQZ1NJAh+iu4cCUMigtkXudZpxraXYKp78RdvB2pIIlPy+zxYoo+FYIVc9ORzl9Ll+xnbu+Xv3+ZYQCrDS003zoHvvWv3YNUcC3ACv5P8dBFVXJLpDrRfhqWKViImWjMDYYnpjIGxb6pic8EO7rxtcGwgLn4VAu3nl0i GzSDW/BG CahTWqYfXjCha+bFJPHcANiryRCLsbP5Q0z4lzQ5CHpuZ5ljCkZFoCRmAhEbagXqvM5Lb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 12, 2024 at 11:23=E2=80=AFAM Luis Chamberlain wrote: > > On Mon, Feb 26, 2024 at 05:58:40PM +0100, Vlastimil Babka wrote: > > On 2/21/24 20:40, Suren Baghdasaryan wrote: > > > Skip freeing module's data section if there are non-zero allocation t= ags > > > because otherwise, once these allocations are freed, the access to th= eir > > > code tag would cause UAF. > > > > > > Signed-off-by: Suren Baghdasaryan > > > > I know that module unloading was never considered really supported etc. > > If its not supported then we should not have it on modules. Module > loading and unloading should just work, otherwise then this should not > work with modules and leave them in a zombie state. I replied on the v5 thread here: https://lore.kernel.org/all/20240306182440.2003814-13-surenb@google.com/ . Let's continue the discussion in that thread. Thanks! > > Luis