From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11554D0E6C5 for ; Mon, 21 Oct 2024 17:43:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F0426B0085; Mon, 21 Oct 2024 13:43:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A0396B0088; Mon, 21 Oct 2024 13:43:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7682E6B0089; Mon, 21 Oct 2024 13:43:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 538256B0085 for ; Mon, 21 Oct 2024 13:43:04 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C077AA1AF9 for ; Mon, 21 Oct 2024 17:42:35 +0000 (UTC) X-FDA: 82698329784.21.20B0854 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf10.hostedemail.com (Postfix) with ESMTP id 8D193C001C for ; Mon, 21 Oct 2024 17:42:55 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=k5a6GRkr; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729532531; a=rsa-sha256; cv=none; b=JLus1yMRFMb8GLzL4TSGxVlRquQgMxpKPF4wzFKw6SYL+gdS4hduamEWIlA+Y2jA5CQf/+ FUng/26jH2f4jQA9F/mPJjfayziZ35BqEzsHBNSGQ9ayJXTGK//KAgNyXuX2kVXOF/1Sb7 46dv5u+oSZ0U27TYg8FPk/Az+oYmT/4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=k5a6GRkr; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729532531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6DjVGnLTN9kUcdL8TccpaP5Id+H8u32nkEyO4u0gYkQ=; b=xD88b1dKQHVMgSoD1FCciR+AX/djZwN1Otz6uLCeJfiGF1d99+3JeTeWoRmjlaUokRE+d1 /pmlyUzrS+VKYcEbaFmjW+rrPimXK0MbZcXTigAKlgESihy0U8jPUl45He2HloTQq7zXvu W/G1eNAFDQY0DLMa7jDRZpoCINA409c= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-4608dddaa35so29091cf.0 for ; Mon, 21 Oct 2024 10:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729532581; x=1730137381; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6DjVGnLTN9kUcdL8TccpaP5Id+H8u32nkEyO4u0gYkQ=; b=k5a6GRkr/hr7HLqDIAFC5A5vAjskcNObbhBnrwfTrGXLvsC6SulNCPd5u7HPTmFTJS VfMMgXhbE0ZwhaWjo0iBiNwsWeh2EmHBbenWbuHliZdOCcCdVeqXyqIY9PgsxAEFyjBv ILE0epQkxfgdYsPP6VU/dBKUKe5HuTPNPrPS5rcEobSW2Dqjlr2siDFH/nYrZ5uNDL2U AkTZFf28X6Eix+TglvJQr3PnFbEalIAj/7k47TDRpyrTr6LpEl1jdNHrNRamkXDY7iM3 eUgEFaGDCFz1taH+CtyYacaUpoC8EUVH5Y1yOM/88q9pdjedEgZOXccoiglc9LMKbjmL zngg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729532581; x=1730137381; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6DjVGnLTN9kUcdL8TccpaP5Id+H8u32nkEyO4u0gYkQ=; b=D2wCmMc+RQWPJkkEt+Fv5bMxxHZNFFu7bfmFBMNT8m2bq0ptyUgzf1cpaX0+1Z4XFL zRphjlSjdwfiKGesWRG3GzGabGVH0llZE5z/I5urvK3wrcEHGTKGDt8UFxQ/QKavtbhR HFq9z6EQef0lxieoPQIOXvrwG1pqNrohDWKMYXGGRZGfx+lOJiFaEwyA9be8xqlBN5+h EdKljMxcfwQsawO+5CEd8MuOiu2TnAwF+ccTYJ4u0iygHU73xQw2lx3kx2S1uTNfhUpO 4u/KjrCi2X45iS71qmQdPcUYq3DzOVI3AGKLQ644TAYrdF2EpRAgZEqyIQHtLjDjthfS 776w== X-Forwarded-Encrypted: i=1; AJvYcCX3HD9+XtfRV/r1PyW4Es6dIXHGrZUh7LSUQSJnWqz8q4sE/Yzaa6EY6q0yhc4tCu2Ov2XXE1t9FQ==@kvack.org X-Gm-Message-State: AOJu0YwwMmQN08eewbE8wkV3Hot3rSDMmDhe6vbTGo9qNe3JolWrjbot drUUBGM1nE/gRD9j1M2H0RbK0gX/cIxPSWFDClMsrkPoFJlgd1xpclk3Z7inl9lrh6TXEkr0tu3 dQ7/sblywgwwV6ynpe59evu/GtdfFt3ouS+pi X-Google-Smtp-Source: AGHT+IEkqBJK0hz4CfpISudeuR3akBK9MtupqQ0Zk8vNkbdxQ+Cfwyom+/AiKRL6qoO/74+7S5Qy+Fn93EfW+9Z2ffM= X-Received: by 2002:ac8:5d86:0:b0:460:44db:eb4 with SMTP id d75a77b69052e-461007e824emr107331cf.0.1729532580803; Mon, 21 Oct 2024 10:43:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Suren Baghdasaryan Date: Mon, 21 Oct 2024 10:42:48 -0700 Message-ID: Subject: Re: [PATCH] slub/slub_kunit:fix a panic due to __kmalloc_cache_noprof incorretly use To: xiaopeitux@foxmail.com Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, yuzhao@google.com, xiaopei01@kylinos.cn, gehao@kylinso.cn, xiongxin@kylinos.cn, Vlastimil Babka Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 8D193C001C X-Rspamd-Server: rspam01 X-Stat-Signature: nt6k6ycpjcizfkbh7kjupp7d9bsjrhiq X-HE-Tag: 1729532575-440248 X-HE-Meta: U2FsdGVkX18bSo2sjzjqasCfhgvmxqqXy46XzlVMACc93/pYJoWD09iSGfdPt32GAOzoTSS9kfPAjZ+NUI6TxP5gQO8TCEDXr9IdbJoJK7ZaabaJcdpy0a4Wm1CefKi9J6ryRPGvPcoLKsyb2OsfdpGvNmEXZgxTUnmTvIfl8Opsd1wHnZ9tVKuNcpow4vtpbMdeHHR4jEI6IcoBe0bHKsBFa34nQIdhnLOEqGrFfPTJUDngl1vBfexWsRb6kXXyCLPcsXgqGiWmlyGZY85+7cHWKtEdNHTY0qW5XNknzSalAJk8X/edoVn1uxhsbEaTzzSidLpwgkgDuckbwD1BVAy36IeL6LkNB55Q66JHPr4JGzj/5Pq0HCph3onxl7rzknZh2ol8D/or6+iVi2K5W+lVoR809m9wzbYb9i4S3Ws/5mLMyne3wj2Ogq5x7PF7+5CAuXDfQFAmAWnx/kczD9ogvbwFvWZQHQ4bZBwPM8sglPCzkvQ6xbPK8qTm7jSrhByx1Zvt6DStGE0d7rwGWUrp7FeAAOlch3eiy4+p/EkFBwb9xT4fm046Sz3mIs4oStaRpYKfsbiX5aBDLkOj8dvMCH8zFGTL0lXsJSiOsi69lt38wsUR9emLBSimwdBSwwJeiFH3F9zxboG9rJ9Wd6bq+td/HGfqn1dQj+R9mciyEom5hHF4y8gm2rVF9HOmesGWmHS8hGoBufg1sEUs3uAFqmaETcKZXLgCQF8SO3ZlIR/J7+g+A9QzIyvC5jCR1fP3Ji0P6N+hPko7DMCaHhgXbhSfCvg+PC2fBfL0+tOoOW3FxRzmYUFonMzjqsmEuPO0An47c3ko5TJoaNxc+MU0GLZxhgJAuYAxd+u4VmuAsvMIPM4ZwA2PfepGPOqV9QlX7CZDWUpTZiI8F+xW8R7r9KRCeKQelzAay9gyP9U3QXpiPonAp5x3HJQOIFbCpQI7l0LlaH4LqQj3tXi KskkoCDP h/NXIlpxd0xL1bfF/hUilYPzIdaP0yW53f2xkKsgT0wDKSyg4AdttwBNjBQY0eFLqEYDHXtNc3TK0+X9SjZQHs5vQwLwPhbXzZAuuAYZiW0hxdv8AFN5p+YKfuyPbybmDf2/5IxxnVj176jbaY5wTvKWLIdxrkqy9zVDI8miH/HfsCBi43cndZYQBCmh4avxT8dq2NFwG9gYTN/SkA/M10242H82zTF1hg9kQJQhWWIslEp3I++qDZh3h9aSOPFJBdLip6IJkoIgXXGT/yCWHNMEYy1HNFePn6ZehRXIUsMZLnKyOxUpeUHalCWqq2ZfnQykB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Oct 20, 2024 at 11:59=E2=80=AFPM wrote: > > From: Pei Xiao > > 'modprobe slub_kunit',will have a panic.The root cause is that > __kmalloc_cache_noprof was directly ,which resulted in no alloc_tag > being allocated.This caused current->alloc_tag to be null,leading to > a null pointer dereference in alloc_tag_ref_set. I think the root cause of this crash is the bug that is fixed by https://lore.kernel.org/all/20241020070819.307944-1-hao.ge@linux.dev/. Do you get this crash if you apply that fix? > > Here is the log for the panic: > [ 74.779373][ T2158] Unable to handle kernel NULL pointer dereference a= t virtual address 0000000000000020 > [ 74.780130][ T2158] Mem abort info: > [ 74.780406][ T2158] ESR =3D 0x0000000096000004 > [ 74.780756][ T2158] EC =3D 0x25: DABT (current EL), IL =3D 32 bits > [ 74.781225][ T2158] SET =3D 0, FnV =3D 0 > [ 74.781529][ T2158] EA =3D 0, S1PTW =3D 0 > [ 74.781836][ T2158] FSC =3D 0x04: level 0 translation fault > [ 74.782288][ T2158] Data abort info: > [ 74.782577][ T2158] ISV =3D 0, ISS =3D 0x00000004, ISS2 =3D 0x000000= 00 > [ 74.783068][ T2158] CM =3D 0, WnR =3D 0, TnD =3D 0, TagAccess =3D 0 > [ 74.783533][ T2158] GCS =3D 0, Overlay =3D 0, DirtyBit =3D 0, Xs =3D= 0 > [ 74.784010][ T2158] user pgtable: 4k pages, 48-bit VAs, pgdp=3D0000000= 105f34000 > [ 74.784586][ T2158] [0000000000000020] pgd=3D0000000000000000, p4d=3D0= 000000000000000 > [ 74.785293][ T2158] Internal error: Oops: 0000000096000004 [#1] SMP > [ 74.785805][ T2158] Modules linked in: slub_kunit kunit ip6t_rpfilter = ip6t_REJECT nf_reject_ipv6 ipt_REJECT nf_reject_ipv4 xt_conntrack ebtable_n= at ebtable_broute ip6table_nat ip6table_mangle 4 > [ 74.790661][ T2158] CPU: 0 UID: 0 PID: 2158 Comm: kunit_try_catch Kdum= p: loaded Tainted: G W N 6.12.0-rc3+ #2 > [ 74.791535][ T2158] Tainted: [W]=3DWARN, [N]=3DTEST > [ 74.791889][ T2158] Hardware name: QEMU KVM Virtual Machine, BIOS 0.0.= 0 02/06/2015 > [ 74.792479][ T2158] pstate: 40400005 (nZcv daif +PAN -UAO -TCO -DIT -S= SBS BTYPE=3D--) > [ 74.793101][ T2158] pc : alloc_tagging_slab_alloc_hook+0x120/0x270 > [ 74.793607][ T2158] lr : alloc_tagging_slab_alloc_hook+0x120/0x270 > > [ 74.794095][ T2158] sp : ffff800084d33cd0 > [ 74.794418][ T2158] x29: ffff800084d33cd0 x28: 0000000000000000 x27: 0= 000000000000000 > [ 74.795095][ T2158] x26: 0000000000000000 x25: 0000000000000012 x24: f= fff80007b30e314 > [ 74.795822][ T2158] x23: ffff000390ff6f10 x22: 0000000000000000 x21: 0= 000000000000088 > [ 74.796555][ T2158] x20: ffff000390285840 x19: fffffd7fc3ef7830 x18: f= fffffffffffffff > [ 74.797283][ T2158] x17: ffff8000800e63b4 x16: ffff80007b33afc4 x15: f= fff800081654c00 > [ 74.798011][ T2158] x14: 0000000000000000 x13: 205d383531325420 x12: 5= b5d383734363537 > [ 74.798744][ T2158] x11: ffff800084d337e0 x10: 000000000000005d x9 : 0= 0000000ffffffd0 > [ 74.799476][ T2158] x8 : 7f7f7f7f7f7f7f7f x7 : ffff80008219d188 x6 : c= 0000000ffff7fff > [ 74.800206][ T2158] x5 : ffff0003fdbc9208 x4 : ffff800081edd188 x3 : 0= 000000000000001 > [ 74.800932][ T2158] x2 : 0beaa6dee1ac5a00 x1 : 0beaa6dee1ac5a00 x0 : f= fff80037c2cb000 > [ 74.801656][ T2158] Call trace: > [ 74.801954][ T2158] alloc_tagging_slab_alloc_hook+0x120/0x270 > [ 74.802494][ T2158] __kmalloc_cache_noprof+0x148/0x33c > [ 74.802976][ T2158] test_kmalloc_redzone_access+0x4c/0x104 [slub_kuni= t] > [ 74.803607][ T2158] kunit_try_run_case+0x70/0x17c [kunit] > [ 74.804124][ T2158] kunit_generic_run_threadfn_adapter+0x2c/0x4c [kun= it] > [ 74.804768][ T2158] kthread+0x10c/0x118 > [ 74.805141][ T2158] ret_from_fork+0x10/0x20 > [ 74.805540][ T2158] Code: b9400a80 11000400 b9000a80 97ffd858 (f94012d= 3) > [ 74.806176][ T2158] SMP: stopping secondary CPUs > [ 74.808130][ T2158] Starting crashdump kernel... > CC'ing Vlastimil. This patch essentially reverts Vlastimil's "mm, slab: don't wrap internal functions with alloc_hooks()" change. Please check why that change was needed before proceeding. If this change is indeed needed, please add: Fixes: a0a44d9175b349 ("mm, slab: don't wrap internal functions with alloc_hooks()") > Signed-off-by: Pei Xiao > --- > include/linux/slab.h | 1 + > lib/slub_kunit.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 10a971c2bde3..0149d36cd311 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -827,6 +827,7 @@ void *__kmalloc_cache_noprof(struct kmem_cache *s, gf= p_t flags, size_t size) > void *__kmalloc_cache_node_noprof(struct kmem_cache *s, gfp_t gfpflags, > int node, size_t size) > __assume_kmalloc_alignment __alloc_size(4= ); > +#define kmalloc_cache(...) alloc_hooks(__kmalloc_cache_noprof(__VA_A= RGS__)) > > void *__kmalloc_large_noprof(size_t size, gfp_t flags) > __assume_page_alignment __alloc_size(1); > diff --git a/lib/slub_kunit.c b/lib/slub_kunit.c > index 80e39f003344..4bf38f52dbbd 100644 > --- a/lib/slub_kunit.c > +++ b/lib/slub_kunit.c > @@ -141,7 +141,7 @@ static void test_kmalloc_redzone_access(struct kunit = *test) > { > struct kmem_cache *s =3D test_kmem_cache_create("TestSlub_RZ_kmal= loc", 32, > SLAB_KMALLOC|SLAB_STORE_USER|SLAB_RED_ZON= E); > - u8 *p =3D __kmalloc_cache_noprof(s, GFP_KERNEL, 18); > + u8 *p =3D kmalloc_cache(s, GFP_KERNEL, 18); > > kasan_disable_current(); > > -- > 2.34.1 >