From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3496C77B7C for ; Wed, 25 Jun 2025 15:22:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D5DB6B009A; Wed, 25 Jun 2025 11:22:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AD3C6B009E; Wed, 25 Jun 2025 11:22:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39D226B00A1; Wed, 25 Jun 2025 11:22:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 292E56B009A for ; Wed, 25 Jun 2025 11:22:15 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A3B5B14043A for ; Wed, 25 Jun 2025 15:22:14 +0000 (UTC) X-FDA: 83594288988.22.60A6EBC Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf26.hostedemail.com (Postfix) with ESMTP id BA943140017 for ; Wed, 25 Jun 2025 15:22:12 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=008EEpoM; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of surenb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750864932; a=rsa-sha256; cv=none; b=yFBTLD6GmI/QGkVd+PWNz+ROa4+4VORLrF1Mqv/2q84zj3s8tKfKpu1y6EZmoJRUqagh9h S1US7DHUO06BwVbxezjTHWJJTAdvJ0eg3A3J3rEBnJ/ZB3h7DBy4glVrnIaOwZA5TTO29u HsWBKquq3K3KYSxiYznNyXy/3NfLC78= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=008EEpoM; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of surenb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750864932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nJ5P0u/6xcg1NtaqnGcLvqTOCLTnaVcDdgVW1OPXhxk=; b=wFqj8HzTGx2FI39eBcnmQUL1PHeNhHK79IgJ6x95aizoUM3wATrkHfIEo/nqlxaAKItJMt T5wVcCYnKk2hHlQx6DEuUY5R3TQebZEkjhL5YHCAtlXZtT5+DCNsVFcxcA2x0p3vqcEgDs u2QLKcHTYBTgExHW/77DgTVbGRQHoKA= Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-47e9fea29easo430981cf.1 for ; Wed, 25 Jun 2025 08:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1750864932; x=1751469732; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nJ5P0u/6xcg1NtaqnGcLvqTOCLTnaVcDdgVW1OPXhxk=; b=008EEpoMFHDHm20P4eS9ylXG51lorss15IAZfcp4fKioeeTzedIVzZwu+cc508zBqQ CKk1Eds/ayCNZyjEWE7jeGPY7+H75c5BfP4sCVRxay0dv/mj5yTJrG0c0zV8LgasThhp 4DGmPc10dsI9m37a+CSD3QuBuM0A3nrSsnzlNvYZwdKFDtuamdYquwwbDPaO4hmbQ490 8QmW49V2DFUrX3+/rAMnhC6GKGVp9yOqsHYo54nwgfVziFZVurijGRIUUawGyDWRQweW N1v+n1LmnV+wwDU5qCDmdz9/+oRwcIPyEWXjWs3X5d/EJtmcahcIlCrR7XM1lKn1j+BV pPvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750864932; x=1751469732; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nJ5P0u/6xcg1NtaqnGcLvqTOCLTnaVcDdgVW1OPXhxk=; b=MOyQ/oh8QoYI4m2REeuw2JnTkhUCcyVDiiXfYRz83PlnPJ64mG0NylTbN3HGWQDV50 xw/9v7+TmjRspyuKRN/42NUoIq30n2qAl29jgI+VSIMBMQwbmKCpN/cY/MrGo7Qauy64 l/SbPE98sBQ0XkuwGdm0QKdCLhLVGyfaGN7IcCzpX5INvwkFcn120J0W3PRy2HCOOwgW DG6XUYARpg3N2MXpFokRLf2nGTakKwDV1z/VopDQoq5Y+3IJunDppcyoQ9dqkgjpSNXK /LfLnmoGKIUFCw06L8PYojo2qOE4DbcogDgjvC5Ox2pqCRQIglNwcAWqP7Mpy+xWn2yW VJeg== X-Forwarded-Encrypted: i=1; AJvYcCXjjVmBaB4vCj+0EoxXnZxJTH8l4P1me3314ruG4of62VOPlD/TdHhINj2TOU7mTvIjZrOJcE49uw==@kvack.org X-Gm-Message-State: AOJu0YzVratuy94Xqa8RX5/OMhDhlysqqZXXGPmb2NkcIBTbMpVtgXTV f8s+t3wqegWCenPr9ZbIlIyPRt0gev2jkYuW2BuPa7L2luU5W4yrNFh0lPbwUtsnl2f2CnWr+ve tHoXN9kFSA1qW0GaYunKlBYn56zPOEzb3LfCqXlDQ X-Gm-Gg: ASbGncsFIzXih8hqX0GDZ3mr0ZsKaV7NtNaL1gmrW50i4+jVbVZDKanS4Gj+X9n7FdA 3pe2pD01BqsK3fEFuNRrNKv4nLtNE2xrcUJhCm9dms9IRjPD/ms/pTeQqnUMMTqEy0UVHFcvy7E xd4PpULdSYlKpRB91DJRBvOL3ifXmgWaj3XnEX7q7Z3w== X-Google-Smtp-Source: AGHT+IG8U6qG5KYMo+nkavpDTx/PPdha23r+RnimIC8ktx5xvsAvgguafO1U53hsdch5/27popiTWWkJKAGkT/NKfVc= X-Received: by 2002:a05:622a:85:b0:4a6:f9d2:b547 with SMTP id d75a77b69052e-4a7c236b037mr3595081cf.20.1750864931337; Wed, 25 Jun 2025 08:22:11 -0700 (PDT) MIME-Version: 1.0 References: <20250624193359.3865351-1-surenb@google.com> <20250624193359.3865351-7-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 25 Jun 2025 08:22:00 -0700 X-Gm-Features: Ac12FXxttU6uD8NTsD-TnCGNT9pqqB3547DZqQ19Bc1hh7qCrrhXbmy4EDhP4xU Message-ID: Subject: Re: [PATCH v5 6/7] mm/maps: read proc/pid/maps under per-vma lock To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, david@redhat.com, vbabka@suse.cz, peterx@redhat.com, jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, tjmercier@google.com, kaleshsingh@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: gnfnekgs1zcjftjqy7kgjg6hyczor431 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BA943140017 X-HE-Tag: 1750864932-506885 X-HE-Meta: U2FsdGVkX1+lYK8mKCscbXajzsKUFvarz2VMh2JXQ+do07yUPKKCrXQlEp+pEuhLkpLFxrX4uBH15qiKhZVjotn7tQVyywXJEnH9YeUS1xBuJxLFJQyZDVrtbvMyQfO9k96QcT2KELfj8F7VBtRrOsMzdOv8MaQcY0jrdmBDmQkEZO5FDt245YVTQekJmqcTWUXfqBQ25mD7yhaJmmGxHpaql9BhrNXi2dqnSgrxWK0v26CwZQYOmpeKQh9f35P7euxFsTHcG4zbBaKOopRdEZsAne0XNHLn0fd9Ev4950ObYwRpin349pVN01lSseC6xtTeeLuoJXv2SDLr0aBdBUvYxApmGvVM9SSlTRZjyPBYVvSrbrvRKv/zaZbiEi7VmzXbas6XTsuP6ggHzlCTn9u40hKyrMTcNx4H6vdGbKpVYUyqPepZOrweoGmgWjuI87GfmbEiaitvm0SDD++Efws2BVeUFjgtggLAYlV7NOubYkL792vnQh9OABz9L/NF8Ekjpv5n+siHXl0P2sVoLYDlfE4+8QfuwekYBhIr5QItDtYB66rqM3CPLetnhJYAeTHcEe+MBrpCnCnBOFuo05SBJC8omeL16EErmiSte75SqLv/4q8T56TxjTU/e1B/lvm0gf3EicpYdSN3wXVwiUVj8pMIli+sEal8fyDad/RrxPErXU93jS/ezKWUnAcB5nwohYOzTKhUvHvUqBdNcL1lQ1REPlOJoV6HB1/OIp/ywjFsK4znkiuA4HRG4ZzNKSPb9DdhS/VMh/SDOQ8w4xiAr0sfh6WQtrGaOGxQzjO8qs3xmBCVzf2ed4vAb3LMmgFGQC0aKh6BlAmCOWUzv/WxmMBkIBoFK6cn2TCHuTL46rMY8iVMYz3hqY0qLFAyJGcpCVv9ygwOoOhuVnD5hzErFFuEFdyWX1zz62PF2WjwJ/Qoy/Xt7fEu1VJwDgAFjHxKyuQFrMaJAyRPLkt 9RVFNnZe cvNSLM+/nhXL29PD3pGd+HiC90gUuPrji/pRxX93PJP3lG4KI0wnwZrlkVIOlALDPla9NcHmxI8xgDe8X5FbFnyGzZt/Gf6CR9Rw5KHpQsTHQQabpz6ZYI1FoZ4pDcFJbjXW3ztRj37BT1wYC4TTNbtU/RJ8BzCSSdTOhnhLmct+9BqwyesP8nLIBamnyOu/T2qvHZeteQP4JNHzekUV42zuksdvdDejPzUJo2UJ/t5MhiY4+++A82lFEqQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 25, 2025 at 5:30=E2=80=AFAM Lorenzo Stoakes wrote: > > This patch results in some spam :) there's a stray mmap_assert_locked() i= n > anon_vma_name() that triggers constantly. Ah, damn! This was triggered before and I completely forgot to fix it. Thanks for reporting it! > > Andrew - I attach a fix-patch for this, could you apply as at least a tem= porary > fix? As mm-new is broken at the moment with this patch. Yes please.Andrew, if you would prefer me to respin the series please let me know. > > Suren - could you check and obviously suggest something more sensible if = you > feel this isn't right. This is exactly what I was planning to do but it slipped from my mind. > > I'm not actually sure if we'd always have the VMA read lock here, maybe w= e need > an 'assert mmap lock or vma lock' predicate? For now this is the only place that needs it. Maybe we can wait until there is more demand for it? > > Worth auditing other mmap lock asserts that might have been missed with t= his > change also. I'll go over it once more but this was the only reported issue with the previous version. Thanks, Suren. > > Cheers, Lorenzo > > ----8<---- > From 1ed3bd12d43be1f8303fd6b7b714f5ef7e60728a Mon Sep 17 00:00:00 2001 > From: Lorenzo Stoakes > Date: Wed, 25 Jun 2025 13:28:36 +0100 > Subject: [PATCH] mm/madvise: fixup stray mmap lock assert in anon_vma_nam= e() > > anon_vma_name() is being called under VMA lock, but is assert mmap lock w= hich > won't necessarily be held. > > This results in the kernel spamming warnings about this on startup. > > Replace this with an open-coded 'mmap or VMA lock' assert to resolve. > > Signed-off-by: Lorenzo Stoakes Acked-by: Suren Baghdasaryan > --- > mm/madvise.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index c467ee42596f..0530d033b3dd 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -108,7 +108,8 @@ void anon_vma_name_free(struct kref *kref) > > struct anon_vma_name *anon_vma_name(struct vm_area_struct *vma) > { > - mmap_assert_locked(vma->vm_mm); > + if (!rwsem_is_locked(&vma->vm_mm->mmap_lock)) > + vma_assert_locked(vma); > > return vma->anon_name; > } > -- > 2.50.0