From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBF58C3ABC3 for ; Tue, 13 May 2025 02:07:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AAB1E6B000A; Mon, 12 May 2025 22:07:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A31C76B0083; Mon, 12 May 2025 22:07:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AB606B0085; Mon, 12 May 2025 22:07:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6BE636B000A for ; Mon, 12 May 2025 22:07:10 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8B5A712111D for ; Tue, 13 May 2025 02:07:10 +0000 (UTC) X-FDA: 83436247020.08.58E0E2A Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf05.hostedemail.com (Postfix) with ESMTP id A5B97100006 for ; Tue, 13 May 2025 02:07:08 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=q9J46ynx; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747102028; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UzRAnbN9Lymdk0TM2EzYmiDcQp+9mVqvObeLahsWnwI=; b=UAN8SPbiqUq85+csNvk6tRT2haH/1UT22vYcTTWM4t8z8Ie+AWvj6ZZXyWJDMDt4OH3cm3 3XOBbNSpUWgbnLQLJs637wuscUdn/JuOdhn41vFF05Ac2QfkYON7X4Rz/ZeUc90DmDkgl1 xc6Gkva85obJYX3caf/4GsNS7DlfxhM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747102028; a=rsa-sha256; cv=none; b=OVgviLkAlIEfFOk3zfNWVgGwX3zME9v3p8BtJSNy2Wa2gHUE/wfBWNcUW0M3djPmErNF0A P9C4LyZCwcWls1FcEfivNboX5AIkPUz6R2XFo2lTN9CV8ZiXUjfhd2bi5J0mxDb5te1e7C kPlYsJV2Ol9kDVoz/wfYq+gthfI9L3I= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=q9J46ynx; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=surenb@google.com Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-47e9fea29easo117991cf.1 for ; Mon, 12 May 2025 19:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747102028; x=1747706828; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UzRAnbN9Lymdk0TM2EzYmiDcQp+9mVqvObeLahsWnwI=; b=q9J46ynxqQAsDjPpW/sDGsKVVMje0Aa+kKZVyOAd5HeZ+g9f3MvWRFU6yebiX1eCHo 8x5jeC9Mb9FafhiHkEdZDnL7xgnyNTTGRZsQjCPruhx3NM4Q724mwgJC8H4nKS62K2Hi XpjeAr0/3K5tDadU089BIEmd7VI2nYJX3o7ii3tCTe2UuntQS/8uQDCYYSeAImt+nqAW k9F1RI6evMffqRpblUWQtjZPy3ynVJOr25CvqvXGNxJMP7vqtsl8x26LBLQIBZ7+M1Nn UDE1GHTNHtzd0+y1zfLoKiUJQB2NWZ4BnQ2xa7B/r/CrYWpstFh0w/gf97n5Xxf2Lmuh ufrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747102028; x=1747706828; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UzRAnbN9Lymdk0TM2EzYmiDcQp+9mVqvObeLahsWnwI=; b=T3nP0PxdH6nrF8V+jP65WmYLohJ0dWKoDuC4d3hVvDYsdGMnipexZRQCmYT2BtqPPZ 8YAZh1DkCC/scClTyBiyJOp2SsbMXbYFTkcuO9g05RHsF0cPjj0HnNk+QYjBXAtzEOtc HD7F6hiXfEO8/UND5daFj68a0YOpdw4Q8VnRGTyjVfFvk67hozzyneiGDtMoGnDBSOQV DABhDDGDQ+cX95r46kuUS8SbpCx4h3c+AjayoLutZnRIOub8X8bkIiH4IET/7qQjtaj8 81aNWubXerNvUmumoVdbT5Qg6MKqRJn4leP9Xm9cPrAmRWyQWz8Myw8x1D+Uo5X3DKbR BFzw== X-Gm-Message-State: AOJu0YwWdFHp3GkgeXn4phu9h29OmZM0QBGGHV+4Tchgp+IzihggyMPL O9F7vsHszQjc2P1XaqPE3PahgC/hzxTHpA+xHz3D/1MEVYViFF3RvLxfuEUcHvyTMs2RflNqreB rhvhSRGLIsRM1b4lF0fCCRe1l3DL6tWw6n/Fc+dgg X-Gm-Gg: ASbGncvyQn9giYxMrsBmVzlHh3MmmvtwfeSP/5qjvGhuv7fucguO7EJFgwNzQot+zUH qor4EWrFY5ayUlyBgSMwHxneWzJSQ6nUX00RJZZ2MuoY9qtEF8d5dacQvnO7neMds0TCQAXzBEl jfNk71OmWgq82PE1uALqGC/8AagIa0WuA6U50yZ4GzJo+OQsX/2YBm2V6Tdhj1 X-Google-Smtp-Source: AGHT+IEU+tz8kS0xzxED6EeFjxS2KiuR+PRmDtdQtl6rs7lkxRxnS/QXxks5DnKt059vgDfS32R+O3mSk7zUZN23QG4= X-Received: by 2002:a05:622a:1447:b0:486:c718:1578 with SMTP id d75a77b69052e-494880c8025mr1858441cf.22.1747102027336; Mon, 12 May 2025 19:07:07 -0700 (PDT) MIME-Version: 1.0 References: <20250512194249.14501-1-cachen@purestorage.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 12 May 2025 19:06:56 -0700 X-Gm-Features: AX0GCFvvwjShCkASO50oxS57gTTX_u-sj8Skpr8AwLP8tK77orFXfGw6yGvvnnk Message-ID: Subject: Re: [PATCH v3] alloc_tag: check mem_profiling_support in alloc_tag_init To: Casey Chen Cc: linux-mm@kvack.org, kent.overstreet@linux.dev, yzhong@purestorage.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: m78ztxoh97mq3z6jifhk779eehq8tyhq X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A5B97100006 X-HE-Tag: 1747102028-605931 X-HE-Meta: U2FsdGVkX19xnm9ZcSHyyCvUOuasyLVnvNMRE7/SRDuiJ9XS7wTmaWpR2X9HPbvhOyedUm4kjQei3RDRbe70+7P1X9FzJdZ5Q9A9JUHnxDJ0KsHHRS4d6Ln3EdLyjehCKsvJ6+tCHlazfI2rckkNxIe5eQDPOzVI6VmXnXzKyDL30+3YtpFBGWjkLyZdAyrmkyWGapJzy34QzbEvdkcb5/KNkYr8y5Dl6HkahGLQ8xYwx7/qyn2buuFuLI4HP57LN8jTCmVVaHw5y96NtnhVKFTWE/VCy1XtOBgCtcfYvfexJYL4gEVNJkglIzwedQZpaUUodtBFSYuK/cHiRW9bczH5SLEPI7qSKWhLToFsvEUJDbdZ9ZmzkO5D9p+K2GYwffgAlk2k901mrYL84E8AdCIV49ngAnwilBhWygThRb80s10+6eC4CEDjcF6hod32WxlHFVKYnV895bEQk/MDxhjKHejYd287WUax5TlXIZu07g3wxUz1MQE4iXLqCaS+rW+Oul6etprqBbag/QtuqntbD/yAkcgXKlp/81jm3uRe6EWbiGN+S1mt0ujSoayKRNjyz/ucwyXeULfydU5zcMJpvbFIyeI3BhUy9S1aPxuDw5m+dy9ecwWNvuDteyXihcQVzh0UH9zkeeu/xA+iDdlDFGNLzu+FCG2XoXc65IAy7KXAGJdeHBKTtEHd958NrJsFjae9fdqxli67FAaRy12KPMKlKjMsXWRZAQh7axrK8R++Eg65O8napcf8KEL4LSykD3jOIv+BU4EypsiXdf5ogs0kh2jpp0YsXNg2k2Zkd+sfK2zO3oPOpm8caWz4A5RQOKuBJ/i/8Vhzf9MPMT+5Y2f8/Y0kg1Zi//A46w4UPd4LipCUsbO2YInyNcK08SkBiH0eUl7xU/J3uKv0N++KmIz4xjBxiYlFQI8qh1l0VhDWNf04jBHaBthVesEd1ucOOaIckezZBHiwlZY V72umMps i5QB/NtBPwb/1cMd8elkBT9LOrLlJ24SEGpIrrfqHoIg5lkbmXqkPaBB1ueQjLyJN5YNjcGtRN5JjwPIhpYsTz96kda+Slq15NHHDCI5ZNixPhi8/84FyC4jYioLhzGtkZIL4d9rpRoSb1XGW5GJ4ivVfi6aJhyJz9rtXrUGfRgdtsZo0ClF0FTNvXgA/DJ/OsSkJf0mQSSnqHRdm6qL0LS7kfC5+9pqLJno2OI24bf3Rf8hBx4nRENjvUW9NuvbNXdhIaERM9CVEnmOUbhWLSNzghuQIFMTWgmIoTdY+BcnVorVVIcEr2SwNj73wMpaVFPIf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 12, 2025 at 2:02=E2=80=AFPM Casey Chen = wrote: > > On Mon, May 12, 2025 at 1:53=E2=80=AFPM Suren Baghdasaryan wrote: > > > > On Mon, May 12, 2025 at 12:42=E2=80=AFPM Casey Chen wrote: > > > > > > If mem_profiling_support is false, for example by > > > sysctl.vm.mem_profiling=3Dnever, alloc_tag_init should skip > > > module tags allocation, codetag type registration and > > > procfs init. > > > > > > Signed-off-by: Casey Chen > > > Reviewed-by: Yuanyuan Zhong > > > --- > > > lib/alloc_tag.c | 34 +++++++++++++++++++--------------- > > > 1 file changed, 19 insertions(+), 15 deletions(-) > > > > > > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > > > index 25ecc1334b67..7c798778669c 100644 > > > --- a/lib/alloc_tag.c > > > +++ b/lib/alloc_tag.c > > > @@ -244,17 +244,6 @@ static void shutdown_mem_profiling(bool remove_f= ile) > > > mem_profiling_support =3D false; > > > } > > > > > > -static void __init procfs_init(void) > > > -{ > > > - if (!mem_profiling_support) > > > - return; > > > - > > > - if (!proc_create_seq(ALLOCINFO_FILE_NAME, 0400, NULL, &alloci= nfo_seq_op)) { > > > - pr_err("Failed to create %s file\n", ALLOCINFO_FILE_N= AME); > > > - shutdown_mem_profiling(false); > > > - } > > > -} > > > - > > > void __init alloc_tag_sec_init(void) > > > { > > > struct alloc_tag *last_codetag; > > > @@ -762,19 +751,34 @@ static int __init alloc_tag_init(void) > > > }; > > > int res; > > > > > > + sysctl_init(); > > > + > > > + if (!mem_profiling_support) { > > > + pr_info("Memory allocation profiling is not supported= !\n"); > > > + return 0; > > > + } > > > + > > > + if (!proc_create_seq(ALLOCINFO_FILE_NAME, 0400, NULL, &alloci= nfo_seq_op)) { > > > > I suggest keeping file creation as the last step so that we don't have > > to remove it if later steps fail. > > > > If the file creation is the last step, how could it clean up codetag > type registration ? As we miss codetag unregistration function, I > think codetag type registration should be the last step. I see. Ok, keeping it here sounds reasonable. Implementing codetag_unregister_type() just for this failure case would not make sense. Please go ahead and address the other nits and I think it will be good to go. > > > > + pr_err("Failed to create %s file\n", ALLOCINFO_FILE_N= AME); > > > + shutdown_mem_profiling(false); > > > + return -EAGAIN; > > > > Why EAGAIN? I would just let it fall through returning 0 (after moving > > this to the end as I suggested in my previous comment). > > > > return 0 is fine to me if this fails. EAGAIN sounds fine too. > > > > + } > > > + > > > res =3D alloc_mod_tags_mem(); > > > - if (res) > > > + if (res) { > > > + pr_err("Failed to allocate module tags\n"); > > > > The error message is a bit misleading here since we are not allocating > > module tags but reserving virtual space for them. Maybe: > > "Failed to reserve address space for module tags" > > > > Sounds good! > > > > + shutdown_mem_profiling(true); > > > return res; > > > + } > > > > > > alloc_tag_cttype =3D codetag_register_type(&desc); > > > if (IS_ERR(alloc_tag_cttype)) { > > > + pr_err("Failed to register codetag type with desc %s\= n", desc.section); > > > > pr_err("Allocation tags registration failed, errno =3D %d\n", ret); > > > > Sounds good too. > > > > free_mod_tags_mem(); > > > + shutdown_mem_profiling(true); > > > return PTR_ERR(alloc_tag_cttype); > > > } > > > > > > - sysctl_init(); > > > - procfs_init(); > > > - > > > return 0; > > > } > > > module_init(alloc_tag_init); > > > -- > > > 2.49.0 > > >