From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34CDBC3DA60 for ; Wed, 17 Jul 2024 21:20:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DE486B00BA; Wed, 17 Jul 2024 17:20:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78E7E6B00BC; Wed, 17 Jul 2024 17:20:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 631846B00BD; Wed, 17 Jul 2024 17:20:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 40B386B00BA for ; Wed, 17 Jul 2024 17:20:48 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B5535140C96 for ; Wed, 17 Jul 2024 21:20:47 +0000 (UTC) X-FDA: 82350514134.06.9444E7F Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf22.hostedemail.com (Postfix) with ESMTP id EF11EC0020 for ; Wed, 17 Jul 2024 21:20:44 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=uPd1HOBe; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721251191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iDomwZb/fc3YsUCpbkqYfZvOlKX/5b5hghEnjDL2cek=; b=hoPEzU7HoSVn1n51b1IDFbQ1QYnCs7FfF9zZ5BKIRQe9VfI6wrmZrEW5AZ0u82/JI94myh b4bX0mPINQTp8tFNZmUa7E5nFnRkpBOQjvXlgcpZ3Bd5hOwqA6J/gyrh36l9eRppdmHNEQ 0oahnecDXl+3B+RTFTIPrFR/4mcQ/6M= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=uPd1HOBe; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721251191; a=rsa-sha256; cv=none; b=O0Qzk8x0WVcvWGONycE/KsBM/mRp3S3wkHNTv3fUf5sKYyThN+2en967e3HvrZ2KKS8Ec3 QZYAUguc7Sh1EmB1DIMJ2OWcG3KsvTZC+gaGqnyeyy98hfN+YhpqCsVyfsJDjhpLhv5FKp xEpT3bu+xX83ugzt3WElSSIWM65Gd+s= Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-643f3130ed1so760447b3.2 for ; Wed, 17 Jul 2024 14:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721251244; x=1721856044; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iDomwZb/fc3YsUCpbkqYfZvOlKX/5b5hghEnjDL2cek=; b=uPd1HOBeHmB0MqIsBBpaHasSCc9de73DDKjDhZQoJ2t1hoO6WU4/A9ksD989fSupHA PW2w/IFrxJ2+IhEFQ6i60E6qBzwbEnBre+uhqffRly6QqcM6dzQ55HFOvld/18KclsZP G0YJm8fr/RDDa+JhCZAuZgKWOmYFwXoK4LP1RaEgAnOP7O2KxfdOxeaY0j+rqx+zITUL mgPHepY6uqMzSGrDDW7Dra9TlxnXIB7umBX5FOy6bVERnMqG48ZVFpJp20q0ZhgHGVIZ MDAy4DmYqdR8QBfOPW29gMtttAhDGW8o8QGRAOrofCbGm1QKsk2lBsC/B4IVX5+PU2Qq hlWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721251244; x=1721856044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iDomwZb/fc3YsUCpbkqYfZvOlKX/5b5hghEnjDL2cek=; b=sy3Z33CKnC0ihPW1Z3FfjM6QRZZHueF2sDBMLFG0T2ECF94ku4+u3Me8vlOyh9UjGl O9DAm22QErkUn3yZt5eH8LrUOZRyp+zOVDpWu9PXEyIHG34Q6tDlyK5stYPRUJjsaseO p1PE2KOMgrC+c9SzqwKJmFS7L0rT8I17VMvl71j+vMgUZOLtHaAOTxxQwsPkaFE1yIGW lcy+cr/0tzYWCN4tvAc5dslmCmONquIqnreiUy5Z9ahlECt9jfu9XeG3FbWFyKNUTvx+ 2g3cJmMlIP6QrwHm2qvVUwUoXcegok+8HlsBAY8i+rtWAiLqDtgxHWIoH2VjK6oTvtqr HlqQ== X-Forwarded-Encrypted: i=1; AJvYcCUymq9aRnxt6EkP/bOITCU0Zepje8VVA/kXXn1Y9FM9F67D5962L8XB1aZMp46H7jbsIgKMXlcXY/GwcT4p2hvl1qE= X-Gm-Message-State: AOJu0YySueMuEya2RKGJd6nMeuPWeUGFXAF+O7HikWF8HcVMZrP35O3b 2TisVGsaY5n4OHYJ4aKziUqR6Zz2WgZJuekCj2Wy2je1GHOcTySlYTDKLUe4XH/Q7tAuFcM9XKo iCU8Mzbnw1isJ/6hwTgL8+6x2JMZvfWzYhzT+ X-Google-Smtp-Source: AGHT+IHvh+zZptdIi7QTNMIlQtyKdeLrO9w6heg5nNqbR+6kQu+2nSZ0aayp9MC02kdU+AFI0BgHhA8AB6eUBgbTawM= X-Received: by 2002:a05:690c:6d8f:b0:648:3c1d:36d6 with SMTP id 00721157ae682-664fde7f6aamr42200297b3.10.1721251243681; Wed, 17 Jul 2024 14:20:43 -0700 (PDT) MIME-Version: 1.0 References: <20240717181239.2510054-1-surenb@google.com> <20240717181239.2510054-2-surenb@google.com> <16286915-1350-4e6b-a0f6-deec02b7fa92@suse.cz> <10865b0a-175e-4b90-9042-7b63b1ea19f8@suse.cz> In-Reply-To: <10865b0a-175e-4b90-9042-7b63b1ea19f8@suse.cz> From: Suren Baghdasaryan Date: Wed, 17 Jul 2024 14:20:30 -0700 Message-ID: Subject: Re: [PATCH v2 2/2] alloc_tag: outline and export free_reserved_page() To: Vlastimil Babka Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, hch@infradead.org, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel test robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EF11EC0020 X-Stat-Signature: sefo8e1gy5ek6kjmkafuczcfktxmwkn8 X-Rspam-User: X-HE-Tag: 1721251244-102081 X-HE-Meta: U2FsdGVkX1+kXyqU593ziJTIFyKn8bwu73ZKtiCPJzKAK89xRKFiLwKEzVa4Z50LfRqGCcb3acEnixJHBl8x8ARc71PNmH+409CTiWvMYnfkEV7/HDq0zM5erYbQ2H+u4T0OwyYiHCeUtopMQTg7Ce2y2v9CBV9NBqKlJ6ZukTxBHduX9sqjkZk0WFaJm7wq+LC+BAWe0pk6HmBomO4JP3SYR3aRUUw0UFJ7sjd5aOUssDcKHpH4CVG1l0HOsQyk+tLOZONYKEjcUPG+uG8tsr86B6VlvylY9leYySjzT1BrDgH7GBMUDWDZjinSuVZMjLegOVZ+0S3HQz671u42huHsT+Sp/0MXaXZcNruwXnvtxV6uZCRJOI6NRpjzAlKxP7SL8oc0+5ZVSVyQFVy3soJtJEbYsYbiass6CKKYZDIKWLECkNCA7tHhhyF4X3TyZQ7KmTc5wRSa3OcbHmgyP7EEevny/p+VOXbe3OHRkXjeAhZYzpUgwAVZ9N/87DhamAUcbRof7rqJoCpoiC4Bffx9e8Qd29YpS/jFO5RzJXI3oFwsmlhkOjcRQZFw0x/XsYFyDOzZpwWGMj8uwE+R5CiUHTw4mm6yHEh8f87bih1iWE52m9wjKDzEo2zcONPFXt4LhPuMcqOYdWhU9eqY8pKlkjDV0ANBRbbds0ha7xOJq4z3anr3AzBboXYpH+M9/3QiTuCb+eGj2Xw2TDjxpAry2kNoS4lBu7Mv+6dNNtQ1+xACBxRWcYpAXWctpQTgqAt2S4Y1aXO3kUaPdYP5hG3dr6uGR2+9WLsf7DxEZwOTtkFLkUoZIOcWd/6KavJv1QKjwHpfAbSkQNLXSwR2eW7w3VAXFGLHj7RaqvovRqbMjRp0jiTM5tBYpoS8ny5W8JHAMybXlkfTNGB64Nsfp7xvD+aaASVa2jQfHLJmdfo6WIEwG/dW19ro1wBv8OCJr1y/coteV2ibTQkx8Ms 9FMyhUTU N+My6vWa8TqpCiI7BATaVsZ1XYK9hqXHpdqKZD/yKIwyg0TT37eT9ePAGA1BkC75bqdLLouLQ6+veZTsCnr/JN2xqRYzirYiElSN1/GO5nr1vXWZHXOHb8m+SrbFWW+HpcrBipRZKCgoDUw6JE1risWJ8zhFG8FFlMP9NIB7/psN/CXPAeZ2vFLh03W7cx0TZ2y0ppFC90AEXOxBp9wp3mZBS77ATkTnsBJpRsXphf/cxIK9A/QFfJI34mzrrXMCGo3P8xrkU3At4WwMJaMeWqxHLqyqRJtVuFMKnMSgaU2m3dMSNb4oVNuASQSNR9T7T76VQ+Z3YZNumc1d6RVR70sfo2BHbeb6ZPFn+pZ2wJUS5Xga9IGCOB0ImlDxMolGpgkNL X-Bogosity: Ham, tests=bogofilter, spamicity=0.002695, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 17, 2024 at 1:19=E2=80=AFPM Vlastimil Babka wr= ote: > > On 7/17/24 10:04 PM, Suren Baghdasaryan wrote: > > On Wed, Jul 17, 2024 at 12:36=E2=80=AFPM Vlastimil Babka wrote: > >> > >> On 7/17/24 8:12 PM, Suren Baghdasaryan wrote: > >> > Outline and export free_reserved_page() because modules use it and i= t > >> > in turn uses page_ext_{get|put} which should not be exported. The sa= me > >> > result could be obtained by outlining {get|put}_page_tag_ref() but t= hat > >> > would have higher performance impact as these functions are used in > >> > more performance critical paths. > >> > > >> > Fixes: dcfe378c81f7 ("lib: introduce support for page allocation tag= ging") > >> > Reported-by: kernel test robot > >> > Closes: https://lore.kernel.org/oe-kbuild-all/202407080044.DWMC9N9I-= lkp@intel.com/ > >> > Suggested-by: Christoph Hellwig > >> > Suggested-by: Vlastimil Babka > >> > Signed-off-by: Suren Baghdasaryan > >> > >> Acked-by: Vlastimil Babka > >> > >> Are these two patches now stable@ material as 6.10 build is broken on = ppc64 > >> with alloc taging enabled? > > > > I tested them with that specific configuration mentioned in the bug > > report and with several usual ones I use. > > Yeah, I guess from now on all such fixes should have > > > > Cc: stable@vger.kernel.org # v6.10 > > Right. BTW I have just realized that the way you did Patch 2/2 and outlin= ed > the whole free_reserved_page() (which is fair, it's an init-time function= ), > mem_alloc_profiling_enabled() didn't stay inlined so Patch 1/2 is in fact > not necessary anymore? Yeah, I think you are right, currently no module has reasons to use mem_alloc_profiling_enabled() directly. That might change in the future but we can add the export at the time it's needed. I checked and ppc64 build passes with just this patch. Let me post v3 with just this patch and Cc stable@. > > >