From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0142DC0015E for ; Thu, 6 Jul 2023 00:49:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74CE58D0002; Wed, 5 Jul 2023 20:49:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FCAA8D0001; Wed, 5 Jul 2023 20:49:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59CFA8D0002; Wed, 5 Jul 2023 20:49:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4AE378D0001 for ; Wed, 5 Jul 2023 20:49:59 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 118CE1A0336 for ; Thu, 6 Jul 2023 00:49:59 +0000 (UTC) X-FDA: 80979354918.02.F6C9080 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf01.hostedemail.com (Postfix) with ESMTP id 38A5E40009 for ; Thu, 6 Jul 2023 00:49:56 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=EIAi6itQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of surenb@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688604596; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uS0XZ1fUS0VGPojYqzvpfVl4CXPI8Do8FblmEQ8ODms=; b=xFTKbHT0nqxJWwE7Kx3pPbUNBorfo4tFftbo5WxTdnbhv3WE8QEeKqYbkwcAVNvGS+LPrV ZlUYR4P4a74JCHqMJVIow+wBpTAUoYrdMpFMdNl8m8VpFBdqz1p31Cp/rdvHA3t9aVmP/i uOTUe+aNgR15Cj7bU+fjpZo+FieKhxc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=EIAi6itQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of surenb@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688604596; a=rsa-sha256; cv=none; b=6UoYMmfF9aSFyuH8orLxWegXgdWEXcUblUtGx4qeOjQjTsOc1Dgo6t5KgWNpZ57FpHnFcF Mjix/sib9FVm/AGukzDrvsGsSy1/y0uZfiGGRv3pKPdUKhCIxj+G3CZ9ReH/EkoS4ORhq8 5A2LsLTvku7ntu/0SI7+bt1XUtYrzTI= Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-c15a5ed884dso90229276.2 for ; Wed, 05 Jul 2023 17:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688604595; x=1691196595; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uS0XZ1fUS0VGPojYqzvpfVl4CXPI8Do8FblmEQ8ODms=; b=EIAi6itQYEmH6xFZ4o9n4NzNBBUltsEavCtIyk/jEAlvRTjak+IwP9IekJezSBDiFP rag/e41OhG9t9xYdYtU2rb0z3vz4vWCpb2R3Jhr6laoakm5drAfmUicusk6sG0tWQ32K Zpkj/e0ViWHHp6TEGfIOLOwx+2dv6SDMdAguax94iUKkb79YK+U9jNvJy0ZAep8QXWZU Mx5+rdGhWx6Xl+8PHphq1cULfnKYHtodg6hKjwk5dxm7SLwCYtez1/U8W4PryMOdrAYQ ynEP0SBWRn3FeEu98EO9Kyjsapq36Nvsmh1X0nVvDEpDoSZgWE01iqvx1ipoxAZUKnEG kR9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688604595; x=1691196595; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uS0XZ1fUS0VGPojYqzvpfVl4CXPI8Do8FblmEQ8ODms=; b=WpFpu0Wrk5thM7JPaWGGlJ5jzmbz/vAH86Tl8171DxUbz5jzqRffJ9b9ZbyntZnlCV nYLsbo2A0+4ADQiicLGL+xXQRrrGofwKfIlhyttcPeJkOusNAVHN9IPcPZFcA4k60BI2 76fpxr8KtMVxV5o3SQa1Y2x4tq6DTPr5c2zlAEqpfusbe2Q31Ugt3Z82NT7QvC3xWsSo GvUwqvPZ0/uPyxP2n3Hz9221Y81trNlsCKDxYoJzqne4rGPWhxqS1Snwdkha6u18ZK1K fn7VBICKAl4Y50tGx51WXcE7qp+dAdcf84ZwM52ch8NhF+dWapXtonpXTJhM7XgcCgmE 9wjA== X-Gm-Message-State: ABy/qLabNkdXREUvaVshsk+a+OitkTMtK7lZ8x6f1g2aA3fzPtA60IKr ReClZrFw24FO5LexHGqcyADAzdiXHxPgK+eRgwiYiw== X-Google-Smtp-Source: APBJJlHpt9JQ+AIigpgGbyrUOJU9M9UGcUJA4d6s+0oOFsqwkgrKB/j6NACCn3Myn8DaEFaYZKMfK4zc8Jfpe5uDn4g= X-Received: by 2002:a05:6902:513:b0:bc1:dfa5:8399 with SMTP id x19-20020a056902051300b00bc1dfa58399mr418671ybs.13.1688604595099; Wed, 05 Jul 2023 17:49:55 -0700 (PDT) MIME-Version: 1.0 References: <20230705171213.2843068-1-surenb@google.com> <20230705171213.2843068-3-surenb@google.com> <3cdaa7d4-1293-3806-05ce-6b7fc4382458@redhat.com> <20230705172424.e505f5013bfdf44543d9c6be@linux-foundation.org> <20230705174440.9adb53f2e362056867135b84@linux-foundation.org> In-Reply-To: <20230705174440.9adb53f2e362056867135b84@linux-foundation.org> From: Suren Baghdasaryan Date: Wed, 5 Jul 2023 17:49:44 -0700 Message-ID: Subject: Re: [PATCH v3 2/2] mm: disable CONFIG_PER_VMA_LOCK until its fixed To: Andrew Morton Cc: Peter Xu , David Hildenbrand , jirislaby@kernel.org, jacobly.alt@gmail.com, holger@applied-asynchrony.com, hdegoede@redhat.com, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: prg8jg8re3hxs9wx3g3domb4nb5feprr X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 38A5E40009 X-HE-Tag: 1688604596-544991 X-HE-Meta: U2FsdGVkX1+bhgf9RODa/vnEbcZ7gaKy35c6WmXiiANalJEC4da6U0TOZjqJbkgSwumHaQbzWfuMWQBft8UMrFMlF+aWslXgpYr4Z5wwNuMBYMTy2KasJPgqQ3k41p3RhXgBfu0VmJPaQggHAbCuOSxZlzkdGUrrEgwJ/dDazYG1ezVlsivj7NnvxQw8JVUCWDNk9czlWQKCeztN1C1rhYoWJHZKADLfzhfLStxjWwrXuIfoiXEuGyNp/eC7p7wauUwyEozhG5W2GE0/trgWZhOCyFNJuCiYgPG/GUI6GUqoFWzcrK6NRzNIfmxZSvrft5ignWt4eMMCqKXBr4A2ENdFRd1Sro5VqaomCNLDA6QQelORDWl8PlLOV71A7FNYr0HygeoJB4T/cvoCszwyZUkZq+wMLcXONr2bsgfOjzylve6UqCl31XD9EucF0TQz1AI4Rcf4GxOlcg/SlQIs3whR+tfMeElS2aBIsCnf1Iw0CBR3Qe5CaEhyKIjWFpQzuLip0A0X50O7I0INwW7dZIgrLxl6jf49XoJndXz5LYhfEkADQcoKV8zk9Sfpkyrd2IFweu9Ks0B6rZ5Dzj+3fUMsyPVeI+09bt6OIGo4YtL0QijhqLNO4ZSOh+tIlIHc3I2tpXSEqe+zQwNUtA+f2x59+2CtkZC9cEuAGtgpWx0ausSHJC0o8cnsIbjRL2/VAY7UwErhk2Rgfx6q6udXhDE2g2Zrh/KIjlMQvKLGImlrfGbTO6Y2EwpSJc3ArbKtAUTKD/vaORJOIxVT70uAHcEVQyH0O308aQI8ysThRaCgcTQ83+0KvCd5nyU+PcuzH2h8iqoN2llRBDRHJ28mWph4WeS54J0mpBsAOhUPo6jhqWbFUOQ6ng+eI2qFBF068GNPucb3m0SJRPASr2sTu0B+ZY/rytvbs/96gySQowXAQqeEoIohAShq/SBUuhFD/6EnfRyzAGOaLS/x6p0 q2b/cW/9 tV9tsU3vM+r0uPZsmXX33HD4tK1DCK4RPtsRQaP7jlH3tJaEUFyjWZEDh0GGX89A91gjJ3jnkCM8SgcNHLmwI4JIBYkfwiRC/soljAPvgM3y6gaV6ftOYGR3YS0vu8ocHk85rhYWY2aE0ISGHoWdQn0wvQhtoQrOd4XvlWi2mMb71AwcLaaGGD2NG93zuI37x0OfD0ahtxsIaQus541drrW4LpK9IT2G8krgNi2+4tiYQlfNx3n9AxeeFk/iHZx1Zroizm1WWvdxXvARWgBuEtsKA6I83ymCiI100+WKI+AaXyaEaSUe1HI5CT9Sp0WVJcfNHWJCpLuVcE786pOoCBIPK0jyeFbh8CB9PL6etFp2N2mEAafWkWhIEHq+W5mMtM+cdpMB3vX667JX9bmwcA8sXhfMKulVbVT431QL39zK4i0U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 5, 2023 at 5:44=E2=80=AFPM Andrew Morton wrote: > > On Wed, 5 Jul 2023 17:32:09 -0700 Suren Baghdasaryan = wrote: > > > On Wed, Jul 5, 2023 at 5:30=E2=80=AFPM Suren Baghdasaryan wrote: > > > > > > On Wed, Jul 5, 2023 at 5:24=E2=80=AFPM Andrew Morton wrote: > > > > > > > > On Wed, 5 Jul 2023 13:33:26 -0700 Suren Baghdasaryan wrote: > > > > > > > > > I was hoping we could re-enable VMA locks in 6.4 once we get more > > > > > confirmations that the problem is gone. Is that not possible once= the > > > > > BROKEN dependency is merged? > > > > > > > > I think "no". By doing this we're effectively backporting a minor > > > > performance optimization, which isn't a thing we'd normally do. > > > > > > In that case, maybe for 6.4 we send the fix and only disable it by > > > default without marking BROKEN? That way we still have a way to enabl= e > > > it if desired? > > > > I'm preparing the next version with Liam's corrections. If the above > > option I suggested is acceptable I can send a modified second patch > > which would not have BROKEN dependency. > > I think just mark it broken and move on. At some later time we can > consider backporting the fixes into 6.4.x and reenabling, but I don't > think it's likely that we'll do this. Uh, ok. I'll send the next version shortly with the patch fixing the issue and another one marking it BROKEN. Hopefully in the next version we can roll it our more carefully, removing BROKEN dependency but keeping it disabled by default? >