From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A97FC4338F for ; Tue, 3 Aug 2021 22:09:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 02B39600EF for ; Tue, 3 Aug 2021 22:09:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 02B39600EF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5DCEA8D000E; Tue, 3 Aug 2021 18:09:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5659D8D0005; Tue, 3 Aug 2021 18:09:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 407778D000E; Tue, 3 Aug 2021 18:09:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id 1F4818D0005 for ; Tue, 3 Aug 2021 18:09:56 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BD392181355D6 for ; Tue, 3 Aug 2021 22:09:55 +0000 (UTC) X-FDA: 78435162750.19.ABD079F Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf26.hostedemail.com (Postfix) with ESMTP id 6C54420061EF for ; Tue, 3 Aug 2021 22:09:55 +0000 (UTC) Received: by mail-yb1-f181.google.com with SMTP id x192so1159587ybe.0 for ; Tue, 03 Aug 2021 15:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6FiAIaMy2C3duPSFo6M7ujpZbEN7hAllZgdmnRkqo6w=; b=vVjM6WashkbHD78Q7dI62gTPTYZh3xyul9cjLIOm7ASBkb5EvLaD+/U8ompMvFBmxN xe0Ll6jDyk2e2Uf5GIAThESVRTLjS10Su7BDD/phMLLQMdxjAMZdZ2qSj9/tKiWngymU IIUEwKYfZMONug9gYWV1tdnmrvPy2gnLYw5aWjC5wtu8if+nABdReDQX2v4SM4FCh/NS vXnwI0QppM+RM5gGwDox1KYEQpDFT0FdF//xhF7DzXprTyvoP5R9HJXGtVp65qpJdFpJ zGzxXsfY0WBSDwHb4mKfzAZeSmW7PEfB5zHQQ/H5LkFgJRyqoi+h0TIEN+8r7D8NVO13 bXpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6FiAIaMy2C3duPSFo6M7ujpZbEN7hAllZgdmnRkqo6w=; b=r7fb2p8Nw5TZvnnYL8BmZzFnPPl7uCQ648wNWauukfC7mG5YI6UmGYmO0RrX5L5W0k YQQOUyBauK8buT3zpdVrMJ+m0F97LpN1Xbeg67BP4zVHnCQ9m7x6bSd2P2EBMH7pGF1o DseYy3+v8NwxqKo4SmPemSCXtabI+hYe1p0PC4yRnn9rv0qL7W4j8GaaVCeRgx6QF9dn ldC6nfMFBoIuI/BLrdaOeFgJgJ+fsZAbXq6u+XA0aKtFAUrAXSq3aqCXBUuxZRfbGFUw +fRfkGS52pOTuti/X8YET/pHmP/tDqzlLuJ5i2EMhcdGe2Qijysvnrudcgb8BOsi2nfC AaHw== X-Gm-Message-State: AOAM530U6334QiFkB5nsSMf5mJ2TVVilCOSbBDRtadZaEA1tSwJcO+HZ 6dRNoe3e0Cif4bIFnSEwjw7OD9EUDa59Y7163pe/tA== X-Google-Smtp-Source: ABdhPJyGshMLYtVaVG5xK6igxtN1nsvJlI+CR/QJ1sJxl0p/Bb4EbVUZJ9xHTg+hAYJNjoZTnMShcj9hfWwjLbG/WTQ= X-Received: by 2002:a25:bc2:: with SMTP id 185mr30284331ybl.23.1628028594501; Tue, 03 Aug 2021 15:09:54 -0700 (PDT) MIME-Version: 1.0 References: <20210802221431.2251210-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 3 Aug 2021 15:09:43 -0700 Message-ID: Subject: Re: [PATCH v4 1/2] mm: introduce process_mrelease system call To: Michal Hocko Cc: Andrew Morton , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , David Hildenbrand , Jann Horn , Shakeel Butt , Andy Lutomirski , Christian Brauner , Florian Weimer , Jan Engelhardt , Tim Murray , Linux API , linux-mm , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6C54420061EF Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=vVjM6Was; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of surenb@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=surenb@google.com X-Stat-Signature: 6zr5cefqjwjetmb9wogxdz65bbuwpo7t X-HE-Tag: 1628028595-881828 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 3, 2021 at 10:27 AM Suren Baghdasaryan wrote: > > On Tue, Aug 3, 2021 at 1:39 AM Michal Hocko wrote: > > > > On Mon 02-08-21 15:14:30, Suren Baghdasaryan wrote: > > > In modern systems it's not unusual to have a system component monitoring > > > memory conditions of the system and tasked with keeping system memory > > > pressure under control. One way to accomplish that is to kill > > > non-essential processes to free up memory for more important ones. > > > Examples of this are Facebook's OOM killer daemon called oomd and > > > Android's low memory killer daemon called lmkd. > > > For such system component it's important to be able to free memory > > > quickly and efficiently. Unfortunately the time process takes to free > > > up its memory after receiving a SIGKILL might vary based on the state > > > of the process (uninterruptible sleep), size and OPP level of the core > > > the process is running. A mechanism to free resources of the target > > > process in a more predictable way would improve system's ability to > > > control its memory pressure. > > > Introduce process_mrelease system call that releases memory of a dying > > > process from the context of the caller. This way the memory is freed in > > > a more controllable way with CPU affinity and priority of the caller. > > > The workload of freeing the memory will also be charged to the caller. > > > The operation is allowed only on a dying process. > > > > > > Previously I proposed a number of alternatives to accomplish this: > > > - https://lore.kernel.org/patchwork/patch/1060407 extending > > > > Please use the msg-id based urls https://lore.kernel.org/lkml/20190411014353.113252-3-surenb@google.com/ > > Will do. Thanks! > > > > > > pidfd_send_signal to allow memory reaping using oom_reaper thread; > > > - https://lore.kernel.org/patchwork/patch/1338196 extending > > > > https://lore.kernel.org/linux-api/20201113173448.1863419-1-surenb@google.com/ > > > > > pidfd_send_signal to reap memory of the target process synchronously from > > > the context of the caller; > > > - https://lore.kernel.org/patchwork/patch/1344419/ to add MADV_DONTNEED > > > support for process_madvise implementing synchronous memory reaping. > > > > https://lore.kernel.org/linux-api/20201124053943.1684874-3-surenb@google.com/ > > > > > The end of the last discussion culminated with suggestion to introduce a > > > dedicated system call (https://lore.kernel.org/patchwork/patch/1344418/#1553875) > > > > https://lore.kernel.org/linux-api/20201223075712.GA4719@lst.de/ > > > > > The reasoning was that the new variant of process_madvise > > > a) does not work on an address range > > > b) is destructive > > > c) doesn't share much code at all with the rest of process_madvise > > > >From the userspace point of view it was awkward and inconvenient to provide > > > memory range for this operation that operates on the entire address space. > > > Using special flags or address values to specify the entire address space > > > was too hacky. > > > > > > The API is as follows, > > > > > > int process_mrelease(int pidfd, unsigned int flags); > > > > > > DESCRIPTION > > > The process_mrelease() system call is used to free the memory of > > > a process which was sent a SIGKILL signal. > > > > This is not really precise. The implementation will allow to use the > > syscall on any exiting or fatal signal received process. Not just those > > that have been SIGKILLed, right? For the purpose of the man page I would > > go with exiting process for the wording. > > Ack. > > > > > > The pidfd selects the process referred to by the PID file > > > descriptor. > > > (See pidofd_open(2) for further information) > > > > > > The flags argument is reserved for future use; currently, this > > > argument must be specified as 0. > > > > > > RETURN VALUE > > > On success, process_mrelease() returns 0. On error, -1 is > > > returned and errno is set to indicate the error. > > > > > > ERRORS > > > EBADF pidfd is not a valid PID file descriptor. > > > > > > EAGAIN Failed to release part of the address space. > > > > > > EINTR The call was interrupted by a signal; see signal(7). > > > > > > EINVAL flags is not 0. > > > > > > EINVAL The task does not have a pending SIGKILL or its memory is > > > shared with another process with no pending SIGKILL. > > > > again, wording here. I would go with > > EINVAL The memory of the task cannot be released because the > > process is not exiting, the address space is shared > > with an alive process or there is a core dump is in > > progress.. > > Ack. > > > > > > > ENOSYS This system call is not supported by kernels built with no > > > MMU support (CONFIG_MMU=n). > > > > > > ESRCH The target process does not exist (i.e., it has terminated > > > and been waited on). > > > > > > Signed-off-by: Suren Baghdasaryan > > > --- > > > changes in v4: > > > - Replaced mmap_read_lock() with mmap_read_lock_killable(), per Michal Hocko > > > - Added EINTR error in the manual pages documentation > > > > > > mm/oom_kill.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 58 insertions(+) > > > > > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > > > index c729a4c4a1ac..86727794b0a8 100644 > > > --- a/mm/oom_kill.c > > > +++ b/mm/oom_kill.c > > > @@ -28,6 +28,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -1141,3 +1142,60 @@ void pagefault_out_of_memory(void) > > > out_of_memory(&oc); > > > mutex_unlock(&oom_lock); > > > } > > > + > > > +SYSCALL_DEFINE2(process_mrelease, int, pidfd, unsigned int, flags) > > > +{ > > > +#ifdef CONFIG_MMU > > > + struct mm_struct *mm = NULL; > > > + struct task_struct *task; > > > + unsigned int f_flags; > > > + struct pid *pid; > > > + long ret = 0; > > > + > > > + if (flags != 0) > > > + return -EINVAL; > > > + > > > + pid = pidfd_get_pid(pidfd, &f_flags); > > > + if (IS_ERR(pid)) > > > + return PTR_ERR(pid); > > > + > > > + task = get_pid_task(pid, PIDTYPE_PID); > > > + if (!task) { > > > + ret = -ESRCH; > > > + goto put_pid; > > > + } > > > + > > > + /* > > > + * If the task is dying and in the process of releasing its memory > > > + * then get its mm. > > > + */ > > > + task_lock(task); > > > > Don't we need find_lock_task_mm here? > > Yes, we do. Will fix in the next rev. > > > > > > + if (task_will_free_mem(task) && (task->flags & PF_KTHREAD) == 0) { > > > + mm = task->mm; > > > + mmget(mm); > > > + } > > > + task_unlock(task); > > > + if (!mm) { > > > > Do we want to treat MMF_OOM_SKIP as a failure? > > Yeah, I don't think we want to create additional contention if > oom-killer is already working on this mm. Should we return EBUSY in > this case? Other possible options is ESRCH, indicating that this > process is a goner, so don't bother. WDYT? After considering this some more I think ESRCH would be more appropriate. EBUSY might be understood as "I need to retry at a better time", which is not what we want here. I posted v5 at https://lore.kernel.org/patchwork/patch/1471926 with suggested changes. Thanks, Suren. > > > > > > + ret = -EINVAL; > > > + goto put_task; > > > + } > > > + > > > + if (mmap_read_lock_killable(mm)) { > > > + ret = -EINTR; > > > + goto put_mm; > > > + } > > > + if (!__oom_reap_task_mm(mm)) > > > + ret = -EAGAIN; > > > + mmap_read_unlock(mm); > > > + > > > +put_mm: > > > + mmput(mm); > > > +put_task: > > > + put_task_struct(task); > > > +put_pid: > > > + put_pid(pid); > > > + return ret; > > > +#else > > > + return -ENOSYS; > > > +#endif /* CONFIG_MMU */ > > > +} > > > -- > > > 2.32.0.554.ge1b32706d8-goog > > > > Thanks for the review! > > > -- > > Michal Hocko > > SUSE Labs