From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46BF6C3271E for ; Tue, 9 Jul 2024 01:12:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADD166B009C; Mon, 8 Jul 2024 21:12:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8D476B009D; Mon, 8 Jul 2024 21:12:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 955726B009E; Mon, 8 Jul 2024 21:12:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 750296B009C for ; Mon, 8 Jul 2024 21:12:03 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 18E88121687 for ; Tue, 9 Jul 2024 01:12:03 +0000 (UTC) X-FDA: 82318437726.05.A374ED3 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by imf22.hostedemail.com (Postfix) with ESMTP id 57634C0007 for ; Tue, 9 Jul 2024 01:12:00 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RER2n1lR; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720487480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c/Fb5WdZaI9jnQ9LZ7NxKgwHJ2tSaNsUuKqsQduTjY4=; b=f8zJADOqO0k4KLPsUlsPEv+ur6WVwIqixro/+Irn6gVvfr5oGgUcDScO05xga1do6fy/f8 vhz3xwPIWnMQ3DVfmo+8jyQTFtnPlT/D4q1u2LXdPqzH8M6f0Dnz3hRRv33YI/5ax5NcaN 7sUTsUaxYO7bJUvcNlVywQ+OW3gdBfU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RER2n1lR; spf=pass (imf22.hostedemail.com: domain of surenb@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720487480; a=rsa-sha256; cv=none; b=f2v2VEeqAMCqQ3tdMLtPkXEp/efX+x8kX+cxqL7GudnK26JSvfaHUr4OwGDcHzDyjya4EP Oxzm7ermxzGNJFgyozt3ZDiq/vcSq4bpEoiMrhdiy6m/gna2kqUN+fz6nk2vvkwUxEwips UlCutxlFs+zL/RtXXcZTQ1DqIn7BsF0= Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-6325b04c275so42996617b3.3 for ; Mon, 08 Jul 2024 18:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1720487519; x=1721092319; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=c/Fb5WdZaI9jnQ9LZ7NxKgwHJ2tSaNsUuKqsQduTjY4=; b=RER2n1lRRfRB7x3UkpcW2xfrurbXfipEOF92c3TBMsRP3ueYIM1Kpdkb2FE9cXoc2R Syx0N3L+EKqLTbLQt62q5Wg8JxW4tVez9zs5a91p3GKDskrzPsybvGue6ncSFU1tPsaB QFcbrvcq7HgS/yfb64VcId2dulGS2Az3scxw/DgkC9GaQJPE8tOjpfsCy8+GIGoPBRCi qqC5znkihlZx5wndj0I1AQcDDy6eB9DNySh7Xb9psODdsNAf0ThjqOaFEdLUpHxurfjf xWj47+BwUJK3F84/wRMZx5tl5RANclHzkO1LbZZVjLtStpxLQZ8iR8pU1GwwOA86+eTK 5g7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720487519; x=1721092319; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c/Fb5WdZaI9jnQ9LZ7NxKgwHJ2tSaNsUuKqsQduTjY4=; b=Ib4bLDG7AGqWodtejyS3QHpktnEWrUIVXUu8GVj3/Xi3Wmov4+zlXGbCsexrnvh62K 1URAsbPLn4ucpf9DMf4Iwu5eDMxEQaCC4hgmlZ/b/QYEjVho3qQ3bYJgPqJnLnsfHWTd QZij8a4Z+6fIHQa/FN+2cnm2T8KFoGsPKw2dqdDPOzd/vI/AQ2ga/G58rJuNgxqhoSEX 03Yt3rELLoQCdLPI5952E5PiseJ9J5QTvikZnkfTidCqGVLaxTISmXvTCBFWJoiYWO5e T6SfyYN45tO8np+c+dDCgvEjUlS0kH/vgJ0248RKaOpzdG9WVuB+ZAdY6AQlQZHuVLut VjvQ== X-Forwarded-Encrypted: i=1; AJvYcCXr7kONTXlDRdyixQvBTjmD5r/Mh+9GWXS//YU5IU8/hFdqzSTCqI7I43+iXisF9xbBhr0dRVUcLHI6BrG/kcTzS5w= X-Gm-Message-State: AOJu0YwRoWbEGmHYo3vty1g+66Qo2Q6Cf8VFt20wQI/ww/fFCAQxhstX 10pvm59V+6Lqq+O91sG2DFmwuYl4f8Fld5txPBHNXxkgf8cvCtr8kcvhulU298ch+oVs5Mg9yXk IZx7FcmqFqmbLP6LAxvpf64T6f/tgwCo2FRd5 X-Google-Smtp-Source: AGHT+IHENx7kQydr+wUv3AkNmXsWTBHZVEOCayL1qjN6tW39ihSmF+lN2t2SdV8b2OWRs9FgaivUY65wbnjFdgb1WkI= X-Received: by 2002:a81:430b:0:b0:63b:d0df:ffe5 with SMTP id 00721157ae682-658f11a576emr15765267b3.45.1720487519080; Mon, 08 Jul 2024 18:11:59 -0700 (PDT) MIME-Version: 1.0 References: <20240708063236.1096395-1-alexs@kernel.org> In-Reply-To: <20240708063236.1096395-1-alexs@kernel.org> From: Suren Baghdasaryan Date: Mon, 8 Jul 2024 18:11:46 -0700 Message-ID: Subject: Re: [PATCH] mm/memcg: alignment memcg_data define condition To: alexs@kernel.org Cc: Johannes Weiner , Andrew Morton , linux-mm@kvack.org, open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 57634C0007 X-Stat-Signature: dyxdunpbh77rp76xohe8ai6dyminaa1f X-Rspam-User: X-HE-Tag: 1720487520-914938 X-HE-Meta: U2FsdGVkX1949vFJK0AkdqdbLLA1fAKwXHx8pDp+pR4a/dNduVPDZnjfTa/U2mf2zadp9NppuxkoBNpLQrOW34ta1w+Ln1S64ZBzB61SkXPr/weo/5+oBlPVzBDeyuhr3U8oSGjgtoQ1Ei0LKrOIImCuDqIh+rhAIUf4soj8/96gRYbKXWXjG3Y/PqMh2+nMOfbnQ8ZA3TDeU+ZOSm0vLFmVVQrykRVPljbL/3NqjSC8b5wVfyOA2Kd2w8Bmmmnvu2L+eMJk5G3ASPIVaJMyoaFZgPmiCk5oMa1ioAOFdJXyh4mMXENHcKVdfmbQDBh5KqQL7UbQt2BTXVLVd5v9xbim9LZw8I/OnHk47mm2d270oWZJPVpoF4igsKVPCvkQGxgefq10T+keqnVNOrQBmSbZNb9GtSITDVBpx/T1Qcn7hprB4vdfvk9jAiPPK4mGp6rtGu34jkD2a9mgFynYe+BdeX7Hfp7UPt5VOcVwlB1B4T9noxEiZv/aBG7V4e00MPELFbWb61eNOzwJoFMa/mHLS4k0nr/bIwJOh2yuj5h9h++l1JEMLp1nqZEhpaBKG9GFPdxLhF8pyqVdGoUJgQxi2eFlQtR6Ik6SPltiXE+n4AEWaGJe1VEL3wj5yh8WJM8gDblywltuxYt0oQpEQ+YKRNmv+5MDXICl6ndel6j24uSy8kfTs1h88t+RsjfqkWnWUdcPzVyy67Ey1qfzUHLiz4j8ObPTmdDhDwFwZItULiDXO7WWYhrXe7+hsYooVQLLLEWik2ekzrGtRL3wCyvPEgzgHst3nVmbMG0E8l5nWo+wF2bNy1Ga+aTuFH6QA1bT35tlRRldKO+syzK1wOfJcIDaZy/t2zkFHLVSYV5k+HTH/ix4Rl4hjQDlFCHmjGmA74APLCqcdHcGbO37A+4olFlJaHiXZuGYJmKf+RpSbViPeGzbf1jErU7kM1MDsWn7Z08NYrbIKe784r0 QHmlamuE M6+bLBPNaZdbqFgPiq4MFx9vLrK2RnMChH80nwM518PRWbh9yEW+Tvw/yUvnQ3wxFqPBW49ryQhvbiONvz1Owhy5O5tz2yHUCdhnmiDxJ0nvsVokc4Gy3d6rLgiOHOsLGf9L+D9slghNlaXADNpnua2iFjaSpzvloJx9mt4uV6dYRI9M4Z/E7zoFzWRAwAYWrmqwi6Hzoltt540vhC7hidobh7RdLlb8gjG7ssvglgM8P99PdUdHp72YC9hYSUQykdlMEo8E9F/jRJFBM7lcMZlFDsFUH3BNdPHEnR8iowvBPaW0euHPRWdaqcf3Hd0xSlUB4Aa0uGG6/ELg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000696, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jul 7, 2024 at 11:27=E2=80=AFPM wrote: > > From: "Alex Shi (Tencent)" > > commit 21c690a349ba ("mm: introduce slabobj_ext to support slab object > extensions") changed the folio/page->memcg_data define condition from > MEMCG to SLAB_OBJ_EXT. The code works well, since config SLAB_OBJ_EXT is > fold into MEMCG in init/Kconfig. > > But many related functions that deal with memcg_data still defined under > MEMCG instead of SLAB_OBJ_EXT, and FOLIO_MATCH with memcg_data are define= d > under MEMCG too. That looks weird and incorrect with memcg_data raw > meaning. > > So let's put memcg_data under MEMCG config to alignment the definition > with FOLIO_MATCH and its usage in functions. > > Signed-off-by: Alex Shi (Tencent) Hi Alex, I believe your change breaks this condition: https://elixir.bootlin.com/linux/v6.10-rc7/source/mm/slab.h#L101 for the cases when CONFIG_SLAB_OBJ_EXT=3Dy but CONFIG_MEMCG=3Dn. page.memcg_data will not be there to match slab.obj_exts. You can test that by setting CONFIG_MEM_ALLOC_PROFILING=3Dy and CONFIG_MEMC= G=3Dn. Therefore sorry but NAK. > --- > include/linux/mm_types.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index ef09c4eef6d3..c067db6fa711 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -180,7 +180,7 @@ struct page { > /* Usage count. *DO NOT USE DIRECTLY*. See page_ref.h */ > atomic_t _refcount; > > -#ifdef CONFIG_SLAB_OBJ_EXT > +#ifdef CONFIG_MEMCG > unsigned long memcg_data; > #endif > > @@ -343,7 +343,7 @@ struct folio { > }; > atomic_t _mapcount; > atomic_t _refcount; > -#ifdef CONFIG_SLAB_OBJ_EXT > +#ifdef CONFIG_MEMCG > unsigned long memcg_data; > #endif > #if defined(WANT_PAGE_VIRTUAL) > -- > 2.43.0 > >