From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5C6FC433DB for ; Wed, 3 Feb 2021 01:56:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 32AAD64F78 for ; Wed, 3 Feb 2021 01:56:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32AAD64F78 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 822416B006E; Tue, 2 Feb 2021 20:56:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D3E46B0070; Tue, 2 Feb 2021 20:56:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EACD6B0071; Tue, 2 Feb 2021 20:56:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 5B0D36B006E for ; Tue, 2 Feb 2021 20:56:04 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1D584824999B for ; Wed, 3 Feb 2021 01:56:04 +0000 (UTC) X-FDA: 77775291048.24.quilt80_3800f8f275cf Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id EF5FA1A4A0 for ; Wed, 3 Feb 2021 01:56:03 +0000 (UTC) X-HE-Tag: quilt80_3800f8f275cf X-Filterd-Recvd-Size: 4814 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Wed, 3 Feb 2021 01:56:03 +0000 (UTC) Received: by mail-wm1-f48.google.com with SMTP id m1so3847281wml.2 for ; Tue, 02 Feb 2021 17:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eqb0FQEG710LFOVTd7yEl7tin1eRbeirJikh0ogVzXs=; b=r4yYUo1RncgQIJ2OFCrbLrZmrY2T3kRRqBaZl+AROnou29V143R2jumKvvg19DLqCo F2V2aPSyfbh5iMz1kj+xBVJV5f3HQGt+xLXfaqUjvnBhUO3hfL/56qlxZDAIdOsWeEHT hgLIVPKdps71ba9B4KnrfwhUrjd8IWTghGyuq5RgmBTA4yN6F/I1hI7BqhdUhBiri6p5 ti5ok3BitGiRKghlbB49tORC5hYAZPVoOOMlJELLKjTmtecV3vwGP9LPTSn9fwZ9iS2Z UEGUrjUGisH5nTtUYi/e4DuidkIQ991KCpyjJd8/CkA6Vn08ScJOtArwZ6K7oU0ZTpcH gASg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eqb0FQEG710LFOVTd7yEl7tin1eRbeirJikh0ogVzXs=; b=FO+a1t/UR8O7lY81SfjR/swiG+Agjw15AepULSJF/6pCheR08KB+A7ApjVG6cPiNhO 7zwnF6Meyazn6XxCrpK6AQs1OhrcI8o1zB3aj/QMJ9U5IK1d4tiHL0QQ8YZmIHQRYMRT jDruJmAjHn5ka47O4PnIYg7hHxDAJYcInUr2qLsKkhwgYeHl/D9xqwaEctCJtpdtA5Wu 83NSaJL3op4pdxSQSfV3vbFAyJjNFlG5jH4VE71HETW9uL6i5GyhALrOD2Vrw8CKXNk8 YAwhrFqd7VyCbsnjyO7FpV3wrAOphMCvLoQuv2q81wJfex+YUcL1QMO1aMurOw8OZyAG ozCQ== X-Gm-Message-State: AOAM531MbhgXJJpZNJvsLS1yb+v+mvuDcocdw+52P89q17NvbmbXwhMx GUQg4vrNYQAbNdZtB2TljKCTGFcAaGRh14oHwuTNfg== X-Google-Smtp-Source: ABdhPJy8V/ouw2lofMtSb/Jdw++5KWj9ruCBYLUqtDkkx9ZA4byJWPoR5Az0VDn+L4rTDLhOT5LbVZqAi5I9Yc52fww= X-Received: by 2002:a1c:acc9:: with SMTP id v192mr665311wme.22.1612317361941; Tue, 02 Feb 2021 17:56:01 -0800 (PST) MIME-Version: 1.0 References: <20210203003134.2422308-1-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 2 Feb 2021 17:55:50 -0800 Message-ID: Subject: Re: [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error To: Minchan Kim Cc: Sumit Semwal , Andrew Morton , Christoph Hellwig , Liam Mark , labbott@redhat.com, Brian Starkey , John Stultz , =?UTF-8?Q?Christian_K=C3=B6nig?= , Chris Goldsworthy , =?UTF-8?Q?=C3=98rjan_Eide?= , Robin Murphy , James Jones , Hridya Valsaraju , Sandeep Patil , linux-media , DRI mailing list , "moderated list:DMA BUFFER SHARING FRAMEWORK" , linux-mm , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 2, 2021 at 5:31 PM Minchan Kim wrote: > > On Tue, Feb 02, 2021 at 04:31:33PM -0800, Suren Baghdasaryan wrote: > > Replace BUG_ON(vma->vm_flags & VM_PFNMAP) in vm_insert_page with > > WARN_ON_ONCE and returning an error. This is to ensure users of the > > vm_insert_page that set VM_PFNMAP are notified of the wrong flag usage > > and get an indication of an error without panicing the kernel. > > This will help identifying drivers that need to clear VM_PFNMAP before > > using dmabuf system heap which is moving to use vm_insert_page. > > > > Suggested-by: Christoph Hellwig > > Signed-off-by: Suren Baghdasaryan > > --- > > mm/memory.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/memory.c b/mm/memory.c > > index feff48e1465a..e503c9801cd9 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -1827,7 +1827,8 @@ int vm_insert_page(struct vm_area_struct *vma, unsigned long addr, > > return -EINVAL; > > if (!(vma->vm_flags & VM_MIXEDMAP)) { > > BUG_ON(mmap_read_trylock(vma->vm_mm)); > > Better to replace above BUG_ON with WARN_ON_ONCE, too? If nobody objects I'll do that in the next respin. Thanks! > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >