From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51090C4332F for ; Fri, 21 Oct 2022 01:58:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C24778E0002; Thu, 20 Oct 2022 21:58:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD4EA8E0001; Thu, 20 Oct 2022 21:58:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9DAD8E0002; Thu, 20 Oct 2022 21:58:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9B0C18E0001 for ; Thu, 20 Oct 2022 21:58:55 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 717401601F8 for ; Fri, 21 Oct 2022 01:58:55 +0000 (UTC) X-FDA: 80043298230.01.2A8B15C Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf29.hostedemail.com (Postfix) with ESMTP id 23C26120015 for ; Fri, 21 Oct 2022 01:58:54 +0000 (UTC) Received: by mail-yb1-f177.google.com with SMTP id j7so1695150ybb.8 for ; Thu, 20 Oct 2022 18:58:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZncWdL3mM95UrAjtlnMYK6cfS00d+HEAMrkP+Zaf3vA=; b=ETCDQ1V0Rav1JUKf7JrFXd/bCduUcFQSGNKFTEgHoxSvIBzuBRYzSFf5jfF8MfgzNS 655pcJShWcEHHLby6HitiQxsf2tdeTpbHml6ZpXhrXN0hec/Tq6PbCOMdN2WUdVGrp99 I/oMpE8qoZwo+YYe6hG9kY2kjw1eo0qnDlEBHd2kfm7+T71jN4FH0P+AxEt2ZJ2Yz2Ne U1iEAgwV2/K0iBNG0n6pgDll8zJMPZEGjUXkDJM2B78l3mR9XaKGv+cXh9jXerF2Ed+n LN+BMVqANeeZ++6dvFeFgZ4bI511bPfP45wQko6FQgvJRz7QeGzO9IEWDVQ+QXQAYNYU O1Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZncWdL3mM95UrAjtlnMYK6cfS00d+HEAMrkP+Zaf3vA=; b=xv3ErpTeXH+UWTu9FyjMvLJpIT0flKr5W4RqGbOy7yRwKjczMw3hVctmmbinq/CoE/ xh31fMFiVdv/RZqt9ZBOiwS5BP/mNjBoDsjij4zL4flLmZL7tZKw2akmZvSdvtcM2o2u 2hwEJXtjgfrpSgIdRoIsuTMXz6yr1Ph/0TUOvCg6FMUJdUqQ5OurKWMU56U1UrFd0Wpl Emi3CUGtT9b915//2hB+HgZyhiVWNEGtLGlZvUZSKxIqkeqVErKVAnDTDF/VGIqA5ZpJ GFpwGyTl+aDjvxCa7vM7/DybVzLZORvZRyweEQXTLfunHoX8WByAx4BDKggykYquKQQO T6SA== X-Gm-Message-State: ACrzQf2faX0OIlm69sUQ8+W1xMIty4kBOTl6THNpsG1klUJDNonScQSf B+X1iSAjXPpAHXYIBfqLoaOOv3McJbHjxwfYJQunjA== X-Google-Smtp-Source: AMsMyM7jN901gwP4uzMwLACtoi7zo6/ph3pmTGVePx+cdgkV2tfQtbyhDzKyhFUYYlMwepHes801wEytwuvP3P4sVUI= X-Received: by 2002:a05:6902:1244:b0:6bd:6409:9591 with SMTP id t4-20020a056902124400b006bd64099591mr14512504ybu.431.1666317534121; Thu, 20 Oct 2022 18:58:54 -0700 (PDT) MIME-Version: 1.0 References: <0000000000009fa63105eb7648d8@google.com> <00000000000031aec805eb76a2d4@google.com> <20221020182155.ecd44ee984b1aeb2e5a2e8ed@linux-foundation.org> In-Reply-To: <20221020182155.ecd44ee984b1aeb2e5a2e8ed@linux-foundation.org> From: Suren Baghdasaryan Date: Thu, 20 Oct 2022 18:58:42 -0700 Message-ID: Subject: Re: [syzbot] BUG: sleeping function called from invalid context in vm_area_dup To: Andrew Morton Cc: syzbot , bigeasy@linutronix.de, bpf@vger.kernel.org, brauner@kernel.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, tglx@linutronix.de, linux-mm@kvack.org, David Hildenbrand Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666317535; a=rsa-sha256; cv=none; b=qZ1TmELeHBDp2loqXt5WgKCRVXmWYkqo7x7WqkbtGPA3w+9a3S4ryLDonC9IlrsE6iZKOs GrIwW+UhFN3WPoq1UwgOBDJdPX7PAWzlQwrRFRJHDQoer/TJc4d/mPRuTRDeFvTyuO7g3m WwUrOjwdssawR/m5Di70Grm4a/P0SEg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ETCDQ1V0; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666317535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZncWdL3mM95UrAjtlnMYK6cfS00d+HEAMrkP+Zaf3vA=; b=ip4aIrD9H8tWRyZVjbXiR/FigSXteWAa2Xj4V8dmkOftiKYAuz2SMUhokGXPzu0+ImPlku 61rpwj+gbFVXD3YOhpRXMfMwXyR7Lsiu4dgMOeE6QyJgR8SXKXtnZMJhX0kLHktMQ2+8is 8jF5ZhbJFDVcL9KVLntk4wJFOtzAyyM= Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ETCDQ1V0; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com X-Rspamd-Server: rspam04 X-Rspam-User: X-Stat-Signature: uafekrdqnax3wnjrh1rkg734ja5oqxsj X-Rspamd-Queue-Id: 23C26120015 X-HE-Tag: 1666317534-905014 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 20, 2022 at 6:22 PM Andrew Morton wrote: > > On Thu, 20 Oct 2022 05:40:43 -0700 syzbot wrote: > > > syzbot has found a reproducer for the following issue on: > > Thanks. > > > > HEAD commit: acee3e83b493 Add linux-next specific files for 20221020 > > git tree: linux-next > > console+strace: https://syzkaller.appspot.com/x/log.txt?x=170a8016880000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=c82245cfb913f766 > > dashboard link: https://syzkaller.appspot.com/bug?extid=b910411d3d253dab25d8 > > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=109e0372880000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1770d752880000 > > > > Downloadable assets: > > disk image: https://storage.googleapis.com/syzbot-assets/98cc5896cded/disk-acee3e83.raw.xz > > vmlinux: https://storage.googleapis.com/syzbot-assets/b3d3eb3aa10a/vmlinux-acee3e83.xz > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > Reported-by: syzbot+b910411d3d253dab25d8@syzkaller.appspotmail.com > > > > BUG: sleeping function called from invalid context at include/linux/sched/mm.h:274 > > This is happening under dup_anon_vma_name(). > > I can't spot preemption being disabled on that call path, and I assume > this code has been exercised for some time. Indeed, it is unclear why copy_vma() would be called in atomic context. I'll try to reproduce tomorrow. Maybe with lockdep enabled we can get something interesting. > > I wonder if this could be fallout from the KSM locking error which > https://lkml.kernel.org/r/8c86678a-3bfb-3854-b1a9-ae5969e730b8@redhat.com > addresses. Seems quite unlikely. > > > in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 3602, name: syz-executor107 > > preempt_count: 1, expected: 0 > > RCU nest depth: 0, expected: 0 > > INFO: lockdep is turned off. > > Preemption disabled at: > > [<0000000000000000>] 0x0 > > CPU: 0 PID: 3602 Comm: syz-executor107 Not tainted 6.1.0-rc1-next-20221020-syzkaller #0 > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022 > > Call Trace: > > > > __dump_stack lib/dump_stack.c:88 [inline] > > dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 > > __might_resched.cold+0x222/0x26b kernel/sched/core.c:9890 > > might_alloc include/linux/sched/mm.h:274 [inline] > > slab_pre_alloc_hook mm/slab.h:727 [inline] > > slab_alloc_node mm/slub.c:3323 [inline] > > slab_alloc mm/slub.c:3411 [inline] > > __kmem_cache_alloc_lru mm/slub.c:3418 [inline] > > kmem_cache_alloc+0x2e6/0x3c0 mm/slub.c:3427 > > vm_area_dup+0x81/0x380 kernel/fork.c:466 > > copy_vma+0x376/0x8d0 mm/mmap.c:3216 > > move_vma+0x449/0xf60 mm/mremap.c:626 > > __do_sys_mremap+0x487/0x16b0 mm/mremap.c:1075 > > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > > do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 > > entry_SYSCALL_64_after_hwframe+0x63/0xcd > > RIP: 0033:0x7fd090fa5b29 > > Code: 28 c3 e8 2a 14 00 00 66 2e 0f 1f 84 00 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48 > > RSP: 002b:00007ffc2e90bd38 EFLAGS: 00000246 ORIG_RAX: 0000000000000019 > > RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fd090fa5b29 > > RDX: 0000000000001000 RSI: 0000000000004000 RDI: 00000000201c4000 > > RBP: 00007fd090f69cd0 R08: 00000000202ef000 R09: 0000000000000000 > > R10: 0000000000000003 R11: 0000000000000246 R12: 00007fd090f69d60 > > R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 > >