From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4CABCE7AA9 for ; Fri, 6 Sep 2024 03:27:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79B076B007B; Thu, 5 Sep 2024 23:27:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74B636B0085; Thu, 5 Sep 2024 23:27:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 613226B008C; Thu, 5 Sep 2024 23:27:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3A8A86B007B for ; Thu, 5 Sep 2024 23:27:19 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EC1C3A8E0F for ; Fri, 6 Sep 2024 03:27:18 +0000 (UTC) X-FDA: 82532877756.26.4712CA6 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf19.hostedemail.com (Postfix) with ESMTP id 2BE351A0007 for ; Fri, 6 Sep 2024 03:27:15 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="UgGa81/s"; spf=pass (imf19.hostedemail.com: domain of surenb@google.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725593138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MCJ8hEVau+Kqq/+vO449Dp7HXhBGlpfc8/wWuzjXhhI=; b=scV0RFbV+GHLg6OTatbZYRGZy+nXmpvorfMzoe076q7paTYlMseWyspav3LUeuurOQV6Lj 8KKSGzqf9PfsyXH9av0SACb/76zPE5DzUshrNcviet3816UNaDT4wkr27p+kkf1ZuKV4rr YZ4ydY0IClqoPRPY78kM9lkswVG5eao= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725593138; a=rsa-sha256; cv=none; b=dQmzyL/iAvJdKEyIRzzbRrhCUn1KNCPagbLp+CWNpmvLefhkd2/gO4ebW6SSXBFS3YBs67 mXQXSxEohmN3UB0VEpYbvrnZxp8hvFUTygVWou5V5ILLUjSPuXVkfRwRT2mcpJn8afSsZC 8U3YAQHF4OvzPhrnbnlHsXhYwvsl3R4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="UgGa81/s"; spf=pass (imf19.hostedemail.com: domain of surenb@google.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-202018541afso65335ad.1 for ; Thu, 05 Sep 2024 20:27:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725593235; x=1726198035; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MCJ8hEVau+Kqq/+vO449Dp7HXhBGlpfc8/wWuzjXhhI=; b=UgGa81/sI6+66MfH4HzxfcGvgPiGB8YvSCXo790+F2Uw7xVz8L8wv7BnGA5f48UiIC iLmZyoueacT4Cj2vfiTlKiLe14jk7DJeN+051OBE6snAE4ZxEwxuV17XMH2GhtumIqje O7O4+xOBN/mwv0m+iW+0F4/p3yk520r5hdpIidGA36UTmDmsEnqY2E3Rfqmy+nnRax4C 21uAKVgVO4qjV+yg0X/tKIh2znv4NjP61r4YXNOkToAKxyD0GvE+kGab+1SSw5wlmymn uQwI8Rw/F+5/cZRvI9v7xzQ7EbjzmitPkryLKUN1APeoBk7Dtr6Danrf0zTaKqt0lZ9H ZS+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725593235; x=1726198035; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MCJ8hEVau+Kqq/+vO449Dp7HXhBGlpfc8/wWuzjXhhI=; b=W16vfCh0ukIoimgw41oHk56Z3NM6Ux4QacYnNxQXxSKG+ispYcbP3RAQixxZz80ufu s3pTKbKOuRhnr78/ddzN7ElmiBC28Sg0Va9NaBVZ2HtC/DONkCG6reqAX3ffUDwRBLWe +i59BT863v8VpnhqDKptBT8B3zUBNg4ElTuTFI3tXbe5od91VUP8i/gQ9/O66T1/J/3t nA4aa4Xt48QbiofHHiPQEnTss9Nd7GgzLIB7KvdxnxTrC1sczj4csjy5sLlbIiEYtqHW ocTDt3lwtPoZnfTmzOA44REhD91W91TX733o0BglbNuSc+1HNn+9kDL4NDl4pUfBrGKJ PiNQ== X-Forwarded-Encrypted: i=1; AJvYcCWkBmK7sk+V6/xmpr1itm+c8oEvkK1PXL6xD4IWohyJRa5SfzOMDO+Jblv6veNMMvVrXtsJh49C2w==@kvack.org X-Gm-Message-State: AOJu0YyIvLsbAiwQ/JzgvYM3Xhc563ob0PNdxZHwn8mJmJcU+6/zzJN1 mj1zJAfX/4ad2D1ZbBy2WcgSabk33HysFJHRzFRHgwMxivkHhTTZEzAsTrp2FzIupE/Im1U8CGh PHNG/i8Up/WUAhbENIbIp1UyJqJzpS5yYIrPk X-Google-Smtp-Source: AGHT+IEIWepPJHe1y4opznzQE+6YAR0JiWUKSdr6mVlt+6uHnt4Nw+NMAUw/nAkr0CVlx+juQQARPA5vN91bCM35cTU= X-Received: by 2002:a17:902:cec5:b0:201:e646:4ca with SMTP id d9443c01a7336-206f2b2f6bbmr765485ad.14.1725593234164; Thu, 05 Sep 2024 20:27:14 -0700 (PDT) MIME-Version: 1.0 References: <20240903213649.3566695-1-yuzhao@google.com> <20240903213649.3566695-3-yuzhao@google.com> <20240905162524.72c5bbefa075adb466ea6057@linux-foundation.org> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 5 Sep 2024 20:27:01 -0700 Message-ID: Subject: Re: [PATCH mm-unstable v1 3/3] mm/codetag: add pgalloc_tag_copy() To: Andrew Morton Cc: Yu Zhao , Kent Overstreet , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2BE351A0007 X-Stat-Signature: fm5bf1ehxnh8i8rwz355xh671xchtcph X-HE-Tag: 1725593235-735840 X-HE-Meta: U2FsdGVkX1+WH73Ax0qxg21Wg/LsIQiwltVPpcZSlWTxmROIfj1SmqHAXr1KHvQnPx44pR/THdiu4Z4lszKX174tM2jBKJjeF7ztZ3kGrHR7skugaYFpjGJWVZXNr1Fw/4f0MM/mYv76fTW/7On4NtlRMxRoyu7O85lmGxVo41K/Of2gDLCLrtbgnAtM8iO5ffubnDoRf3EOB5HJXsFiTNx7Ype/Ax3V283zPR7Vn8WESh0lUCJb/7VFjxbLLLUhq/mrZ6WD7Lq7eodb9LXxSZNpde1sJ5JRreBVA7O0SvcXXiaNiFH+GdDuQvwx/PztGom8d1z842ptrzrQ8oYt2pPaIZB9GQLPjpLI0sFBjHDIqODO3v0Rw5hnicV4XixQImWAkaFkqkPCv6KPB4s0iRBeFRAqzhndBL1JhmTJD/Fa32IOk2iRBpaPyGbPbq4cMhR7OHur05WxdKabWEY1tNGiFr/68GKixxLrAQkslkIFgdz0cwqhKj7F7g0V5sAB98bttVQaaiFq5GhO3tbWbzpnhvdXXKWd0jDa935V7wNaRlNm89Z2VserO3Wz+O52ENfeyK/B1WZgazTjcUVsoHzMd3LUlzdAnrKM7TklwBGuXfVxgGa2DfNHd9O4gS3adCt/gp8wbII3qvkfu81qZorYh+3VuzXn3QypqFEa69iq2ZcUNWmMq4L7H7TrzBQvfVqFduwBOt5DzfnBXYzGylT8k+iBeKSruyksBmKDbhYbl/BgYC8Rv2C81FT5puWvH2CVoIsyL8g+qkHx7cLgO/JBtMv6PPxF1DgnA6tQoStFHeWEHniuuJDf4iP+g0LbFmla3g/Vq3vyZ71ALK3V+W+4paInll40tDuCYI49vzSTFkVz+JJChlNwu4YBmmXXZdVjKCsUXLFIjxHlRnfmHOkxCmsSN+1fm8GCVO8UifmRPLw3q7zD7qfecwm/C0c8z5p34bjP+fy5xmVOTtS OsnE8HFT ghfUsLdUsjJI0e1mwJNR3xu31oK5oTWIBBviwGwJ5FD49WAUAv9wGmpdikvIlmmWOZ++PhWLPnep59/edM0qnyxwJZkfDAt4qMKVT5eJWEa9+6ZwLpxHUMh8kcQvMnw0F59uRjDEYKZ4FNrAWMYR7U/1DMIwxarhr4Gg413V3Km5Q8HtFhhyejqdKSNqKHM/zas5YHs3vcc0kKJi3VMUkYbvQuh9Uo92j+qd9vyNggDtidLQQ2KdVQlaiqqJpnW8rVtFLoIrt7pTRyuwl91OE3uWCmSwmOGk9ZDLjPNfX+SPu34DCGnrWviSiarNbmn2NzYBp X-Bogosity: Ham, tests=bogofilter, spamicity=0.012110, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 5, 2024 at 5:03=E2=80=AFPM Suren Baghdasaryan wrote: > > On Thu, Sep 5, 2024 at 4:25=E2=80=AFPM Andrew Morton wrote: > > > > On Tue, 3 Sep 2024 15:36:49 -0600 Yu Zhao wrote: > > > > > Add pgalloc_tag_copy() to transfer the codetag from the old folio to > > > the new one during migration. This makes original allocation sites > > > persist cross migration rather than lump into compaction_alloc, e.g., > > > # echo 1 >/proc/sys/vm/compact_memory > > > # grep compaction_alloc /proc/allocinfo > > > > > > Before this patch: > > > 132968448 32463 mm/compaction.c:1880 func:compaction_alloc > > > > > > After this patch: > > > 0 0 mm/compaction.c:1880 func:compaction_alloc > > > > > > > I'm thinking that [2/3] should be backported? > > Yes, should be CC'ed to stable #6.10 > > > > > And possibly this one, but for that we should identify a Fixes:, please= . > > I think for this one Fixes: dcfe378c81f7 ("lib: introduce support for > page allocation tagging") would be the most appropriate. > > I'll review all 3 fixes later today. Looks good to me. Both [2/3] and [3/3] should be sent to stable 6.10. Acked-by: Suren Baghdasaryan > Thanks!