From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFDDEC5AE59 for ; Thu, 5 Jun 2025 20:07:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 860296B00C9; Thu, 5 Jun 2025 16:07:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 809976B00CA; Thu, 5 Jun 2025 16:07:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F7F86B00CB; Thu, 5 Jun 2025 16:07:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4FACB6B00C9 for ; Thu, 5 Jun 2025 16:07:18 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EDC3E5FA2E for ; Thu, 5 Jun 2025 20:07:17 +0000 (UTC) X-FDA: 83522431314.04.91A6E6C Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf06.hostedemail.com (Postfix) with ESMTP id 20A9F180002 for ; Thu, 5 Jun 2025 20:07:15 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="s/w2Vvvh"; spf=pass (imf06.hostedemail.com: domain of surenb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749154036; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2sI85PnRD/H1VD0SWJ2TxVpQOSb5woFTa/ecxkd8n2o=; b=YM1ZxjA2PaEqrl6zeqPdMi+CGgC7okCSZNpZzO9vL5fAA38aQrW2A+pUkDTqIWivEsTR5/ eoIjLAQ5LVLuoJWFKuNt+sWqVeKZgmO/vF0PzJ1OLFwrJwSIRllA15Rk9M/2e4ycp7uPf9 17/V8PnRIPoHXyYX+BS0ESotCpnxGKw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="s/w2Vvvh"; spf=pass (imf06.hostedemail.com: domain of surenb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749154036; a=rsa-sha256; cv=none; b=HQLEmPLLIrIJlChUw9tO3QTa0bpP6j8d2oHRpG93peu2ldsRAyVx3X/bQpSqBCYmiC/97j YH+r5ezf697vtLEMvrx3tX/OpJC4T5CNJxCuRL2KEDsnEoQHQWRg1VbtqIWOT8gNgX00qq xpFWIV7uSFuIHAippvdO1X91zZ2Tp6I= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-4a58197794eso16631cf.1 for ; Thu, 05 Jun 2025 13:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749154035; x=1749758835; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2sI85PnRD/H1VD0SWJ2TxVpQOSb5woFTa/ecxkd8n2o=; b=s/w2VvvhKMm9wY+kDSKEgkFaR8i0TaXrRUsP3zKy9x/QjfacuAmgcP88toHKlLW3qJ UIrCZuXrckaWfhB7NVl0VnhmfRY0iW//YPDo+50ZChIXDZ4pCC0MrrTzPhTtxuNz7tOa pZNwmDhsDUwZCrL6r1+OvvUnGsoOf5x5z/4pvjYLrxrp9f8PY9vccBjap/gRRM4k4Qa/ wNeg5obPGi3Ow6zpPA3MEZk0/KZpDh3XBQm6cYxOg1/R2/etYwnx2NHjt/wVLLkLCHlq k5poJQq7l+1B2qiQaFmyOWMxKkwKVheHLNTKP12ctjvaLYAResF/ay54WNUrCNSzf47/ v0wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749154035; x=1749758835; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2sI85PnRD/H1VD0SWJ2TxVpQOSb5woFTa/ecxkd8n2o=; b=BEjvb79Kww9d8Z6fJY2BMm/rEQM6PsmYk7As9nlXJP63TcMw7aHzaWnW7YkFJOmCYZ HelhXYNveXnrz3l/o8tJ8LeUQH0mCPqweyNePHLp3vYx3yVf3bWIQpyR9fQsh/4gEKwV DSrCCvFaNm7HgSbgOrI7xBounfz4Asvy+vZMFw1WyTzx/MOBXQEYyNZYhyap/f95uMLx UtCnIVdJjTdfjovRIakCfzZ91waouJOmQFNoJD7p9GS8RYROpJ4Ru70vC6XYmtC1TH/H X5FaDPsCNxr3VNedD0D1YLPvOPzcu72D97yd0W6G0Uq/JdB0lV9/OUFWfXaawpiEeetr mQxg== X-Gm-Message-State: AOJu0YzqzPZEHA9A3mSz055IkTBcdXbpsqPWChtEo3GI/+qD+2F3vYIs ntRAV27d5S0goRqDiqwG8KMNRkkYw9IFLTaP7EuiVOodFRhkCS0ZMCsYIt3D0p7MZ+sZ50N+6tE EeeaN7D2ONhW2+uwRFiGGxkkIoRZCruLZAihYgt+G X-Gm-Gg: ASbGncvTB6/AqM9XpR+2sHDLa6VuuTalE0rPjOHM+y/296t9HDERtgq3TWA1ApHJ1Ha 9zimjYu8TonzZx4QJPu3lh1Iiy4iOi0W7RcKE8CjCZywwnKgkorOZ76u+Z8QKMUSqOTBFtvcvtl 0CRg/iB/cnkmohj/PbviRA2UG33BT/o93M4fNSCUIKaxhKCMFqiPeQGuVBGQeuf75d6wyfOII/+ A== X-Google-Smtp-Source: AGHT+IHJWtphLIKqUEERrC6tgsR6ijS4DXj3iyBCsZHxf6uy73PxLXTaGQ/hx2jQQuNQuCZ2Y4rx/7Z241tW2Hkucxk= X-Received: by 2002:a05:622a:8c7:b0:4a4:3206:de08 with SMTP id d75a77b69052e-4a5baa7b7d6mr795181cf.16.1749154034730; Thu, 05 Jun 2025 13:07:14 -0700 (PDT) MIME-Version: 1.0 References: <20250605190128.2287011-1-cachen@purestorage.com> <20250605190128.2287011-2-cachen@purestorage.com> In-Reply-To: <20250605190128.2287011-2-cachen@purestorage.com> From: Suren Baghdasaryan Date: Thu, 5 Jun 2025 13:07:03 -0700 X-Gm-Features: AX0GCFsUpp9LrE4AK0wyhNdIr9VIHJe8eyhvEzEDpuM1K_FfkOK7PgxL8kwpLhA Message-ID: Subject: Re: [PATCH 1/1] alloc_tag: remove empty module tag section from linker script To: Casey Chen Cc: linux-mm@kvack.org, kent.overstreet@linux.dev, yzhong@purestorage.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: gxrq5g6eizstjh3gkd9xfar58jkotyc4 X-Rspamd-Queue-Id: 20A9F180002 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749154035-728617 X-HE-Meta: U2FsdGVkX18zH89kqnLEvvWEbveiVYeYBQg4NaNTYGt4crauZo2maKY5Geu3bgPtw9Vr0kLriGvBvpg8OEL7E/1GFe1S+XPYHZHu2USEwQhjPIajvGGH/qLvnFxheEOZ53gNMj93upIYiADu9qLizlRhJaLl0ufO2sd+0566r8eEjukKgJh2t3eRsYX226aivg0AhaqG0S68/+saQt4UivKfQwdoDU05FpTPK8hRtIu5iOkrJLojH6unlePUsxAR7m38H5u4a+kl7y9xYmKXiqCEQ9+s0HaBlaQB7xDJ9cZsAaiGJ+HWgQV+GmW2csAnw/MlJKrwsmzH+p5+uqy/SyYtxQjgEvU+LFln+c/784eNX33DsCY8cT8oD2v770hqwF6/ctzyVDamlnGkGNW5H6OS1gKf8HXrRYH+peT199Y2ql9BNgBn0dipkxUoTVh2UnugHa57yDtSyviJp/c0uuK5+gJJGMeXo9QuNg+SptE2oVN9o8xMyd51PZcUlqAEy5W5KM+WQY1N54wvzGNFQ4ZVwEz2ENow0KkYQn/aXU58nON5VupV9aIW/IWktQXvAXKMPKT3dcZ93StnSWLXoTZ0qYP98VosGt81nxJFcPsGe3BF1PTZkFXkJ5MIu9BM3v7FzZMhUnlpsWhVEamf4qV9uYPHSkQLIW1dkgDOwoFXOFaTznqMumR0BiOzchTi0DszqkVR41NN4Z4eI+STkschsM0TIQfV7/ftQMgJ/ki/ZQ3O+ucrNEI44p75dZvgBKY9TrDSxOkPLk4QhL6q+4wp/UExw3YjBgRE49uY2+kjWQl5RdE9oIilya2klxJT9fNadfP3fH36Sisa4Cdw0KkFV1Nw9gM1R+4ArpfXCcPizNSAssP2QQ6rozNylEwOTMAdhdpS8dgLtjgjiR3LqzyTBdY9+ehSjcFl0DzSARQASZFLzQKBXMtALFRKexYHusEaPTZOOJ4HV/ewbx9 VaoSX3Rk LB+SEGXEQgcq1jLXia39a41p5cHz11cp1vgpTaZdcCHktnc/91NIbfNp2JWAInbyNDw5A/wPGsrsa/Kx9h5ZRg+1bcuhIochQmW6JECSvHvIIvROYR6vArebaUK/ImU4nCBDoEzl/m3jxDYCqcRBeTnOm98vT/2OUcYCgx9hWtu3g44j3N/Vvx21t4p+5lryD81+6OKjEKyKPGrBa6XFblmTXIkpzN1y9JwBL4Pxi9eR4GwCOEOC0fMARjBqCBufw1lc5oACrUjo3Iw6rnN7gzncu3P6Cc5zSmt1LomgxQRyF7JbfK34nfH/g1ZmSmUKe9hHGPc5P6OVIgxQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 5, 2025 at 12:01=E2=80=AFPM Casey Chen = wrote: > > The empty MOD_CODETAG_SECTIONS() macro added an incomplete .data > section in module linker script, which caused symbol lookup tools > like gdb to misinterpret symbol addresses e.g., __ib_process_cq > incorrectly mapping to unrelated functions like below. > > (gdb) disas __ib_process_cq > Dump of assembler code for function trace_event_fields_cq_schedule: > > Removing the empty section restores proper symbol resolution and > layout, ensuring .data placement behaves as expected. Hmm. I'm not sure why an empty .data section would cause such an issue. Is that expected behavior? To clarify, codetags are designed to support different types of tags, not only allocation tags which we currently use. It so happens that allocation tags can be still used after module unload, therefore they are placed into MOD_SEPARATE_CODETAG_SECTIONS(). If some other tags are added in the future and their lifecycle is the same as modules (IOW after module unload they can be unloaded too), then they would be added into MOD_CODETAG_SECTIONS() but until then this section is empty. > > Fixes: 22d407b164ff ("lib: add allocation tagging support for memory allo= cation profiling") > Signed-off-by: Casey Chen > Reviewed-by: Yuanyuan Zhong > --- > scripts/module.lds.S | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/scripts/module.lds.S b/scripts/module.lds.S > index 711c6e029936..c071ca4beedd 100644 > --- a/scripts/module.lds.S > +++ b/scripts/module.lds.S > @@ -50,17 +50,12 @@ SECTIONS { > .data : { > *(.data .data.[0-9a-zA-Z_]*) > *(.data..L*) > - MOD_CODETAG_SECTIONS() > } > > .rodata : { > *(.rodata .rodata.[0-9a-zA-Z_]*) > *(.rodata..L*) > } > -#else > - .data : { > - MOD_CODETAG_SECTIONS() > - } > #endif > MOD_SEPARATE_CODETAG_SECTIONS() > } > -- > 2.34.1 >