From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 248CFC4345F for ; Tue, 23 Apr 2024 02:14:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FA5C6B0083; Mon, 22 Apr 2024 22:14:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AA376B0087; Mon, 22 Apr 2024 22:14:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 872326B0088; Mon, 22 Apr 2024 22:14:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 691A76B0087 for ; Mon, 22 Apr 2024 22:14:17 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0FDC4140524 for ; Tue, 23 Apr 2024 02:14:17 +0000 (UTC) X-FDA: 82039176954.08.F28997C Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf27.hostedemail.com (Postfix) with ESMTP id 807AA40005 for ; Tue, 23 Apr 2024 02:14:14 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=rVkLIMK0; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713838454; a=rsa-sha256; cv=none; b=4XrnbM4FeG25zkhWdQ4N4AZ2SlXnBLn9gtREkFhZuSfhzxKEhM9RV0vtmiF1IgE4ZI8eGA zg9Kn7dIGMV0/W9Ffv4c0afMXF3+iZyq/UQB02aEhK2lM3BfbHpcNY1mHSRE5c5cIGCs1S 1TRucikGSyna/Nt3MXqna1Ef3MBQbAM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=rVkLIMK0; spf=pass (imf27.hostedemail.com: domain of surenb@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713838454; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mpECJfr+9B5j7YbKuUViEqVcNFU43HSu/zAM9fBbuao=; b=013IbsqA2eajpCc2BIrfMURK5PuZ5pcYdIskWzUqDjSRSScE3Y8uF/tjj0YsI6NWfd4YAc VhxGGn4vM3C/DcsH1a4wAEEmXGf5XuqgOUoZpxTxb12FP9UyTVlY4FsnltmaGXqeRTDeIK z4WPYav0hRooQCNUWqsPDWikhRg+83E= Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-dc742543119so5034353276.0 for ; Mon, 22 Apr 2024 19:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713838453; x=1714443253; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mpECJfr+9B5j7YbKuUViEqVcNFU43HSu/zAM9fBbuao=; b=rVkLIMK0dKtjMPi3pIg/GtE0b6RqBtlGDLOB//ZuqacU79w6D6RjBFatBLC9VwaieL LUnUl8rEYyRa1iLXlSjO+qC5oF2EGedQZV5cHF55odUEL5M7H28ogYRSKHMJXm7n/MIk C5ecqsZlfGz4ik96i4bCGPUi/1vXydrYMzPD5Dfn0lhjUTgsXQXDl1EeIV2dUP0fQY9K a2QQ8VB7dWKf60jvdxjx1ifh+Dc7etF86ITzlEnOdE8SpDGi9YhtbFlwkmRsJX67yngt 6mhaD2K0lNDzFhW9JqmagnQ5wvULJwliYg/uRH8yArH5Oa5ob/hPM9n9ppTL6KNezg1y 627A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713838453; x=1714443253; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mpECJfr+9B5j7YbKuUViEqVcNFU43HSu/zAM9fBbuao=; b=HJZlnXOIvumW90+FZqXy/XS/ztnPN/AtioxkOlduruGm9ZgozXKeAm/jbSzWM+v2bX sYeekn1StVIWvjyif4jFRpD145kViz0fKxZMB4dHYjvIebFRyOzx/DGirZ1W5lXs9qWR 4f8lBGcO9uV5/tTEBwLVznpCBRp3kJP3hJzaqBNGyXUzvTQLAle1Mliv1wn32m9hVVVL PCpQR52BOZY7xPGDhXkapSy8oDLe60RLI5jAEuis81NJ1FCa5rPeZuaZi7XSsCx3RxMP iVoal9L91Ixp9Oalp5doKeZ+hgZW6ekjnAQszfuhvBMvh3fTUZ42lqI18xWRhKdbfTRJ Cvpg== X-Forwarded-Encrypted: i=1; AJvYcCXVp6fGmILAdIfLzgy6RdReEjc31+CtS/h2ad/3cuOx4dl0T6VV7w2eV/azWuqSO5CGVGwa4toKvt+mOc2UNmh6/Gc= X-Gm-Message-State: AOJu0Yxq0CJ/n1GruTxh1JaRZlwQmL4PFhDRT2AyRsTjNfWAlubLMMHt GBujQ0no5swYwMaZluEeyWNCnLjt7Vvb5rbFPw/0ReLvnRQjP3V2lw//wpgriVzcyVY3GZlFxcB XKU4UY0/KO97UD94GD3DCWbKdoAFAEbOphbnP X-Google-Smtp-Source: AGHT+IEETGKP7ih/gauNNEH6U2W0p4647O5QfjYzJ9TVkLjofINRl6tVYtReOchfpAvQpsEGYzZ1zxmjlID1lODHuY8= X-Received: by 2002:a05:6902:cc1:b0:de4:6e20:aeb4 with SMTP id cq1-20020a0569020cc100b00de46e20aeb4mr12034286ybb.18.1713838453305; Mon, 22 Apr 2024 19:14:13 -0700 (PDT) MIME-Version: 1.0 References: <20240422231730.1601976-1-sashal@kernel.org> <20240422231730.1601976-10-sashal@kernel.org> In-Reply-To: <20240422231730.1601976-10-sashal@kernel.org> From: Suren Baghdasaryan Date: Mon, 22 Apr 2024 19:14:00 -0700 Message-ID: Subject: Re: [PATCH AUTOSEL 6.6 10/29] memblock tests: fix undefined reference to `BIT' To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Wei Yang , Michal Hocko , Mike Rapoport , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 807AA40005 X-Stat-Signature: 1pfhho3f6b43ssz5roqnn6kzbjfqdddy X-Rspam-User: X-HE-Tag: 1713838454-387994 X-HE-Meta: U2FsdGVkX180YmrgqlSYCNVGfDee+/8tR8t+GnB+F6M4ua1BBR9kXVLDtPhaLuuPHbZOfTK24Z9tqPeeCO1ptVfrAXCIeL707qRSr87ao/dyGvu2nmd/UYTPprvqTABWBEJBL+N/0fsVXYRWSxKlnILVbPw/hpr6qtPycLW/2g8znX/xyrUtPKPbgYDjZ5fN1cmFtPsXUjr64Cv1xUefrXFpOnJ4QeHDEJCAJukX6a3BeuguGMPo0pKA7hkzF5WyWI3fwFRJXcwUKF6jEgLbwAjVJWgTqmbOmXJI8Qiw8IFn9ESjksPHjHaS6f8bZ47rVXOAaqhQ7G3/hi6JYxjxTFhb6vfihsNxttwoOL5UTdJtFEEl2rCZEN44toTN5/hQ5FxRGY5BYyW/UJUx6G2fPO2FpYeQC0FS6ski7lcWdowDa1uLmd2g09uzlz7CLjf7KEtZzIIwwBmcA3z86dhqaOnfyYdmESMWb9XSnydCGT4dvxDbeM1ERKUbI9Rs3+zvs0ceiGRTINpU5MgZnLyICmOKUGqB3KkKDIdRCLf7bn1uRKEinsgOQlSsuPSZBLODX/aq0jNcHkDI7Kh4S2NtL4nECOKvNk1RThqSU+oqxQfOouu/Zrrr9LBb78Vo27xMqMuJfBD0kQ+mrUDRwT7kkAVuyT+2T99APQLFE10xmy77Z0tCyF9fnIE/lNa3DuFodKmk6/E+TeZWNA6jZTkcuKYEg203ZjswL/z3JVIcxw2lf2k3NEud0ubRRT8MNdjCMCAzVg3iZPcRzpX9PaJR3HaHrS/60SYjAdXPeZavwLhvBYAftmu2WL3wVMrntAifH9eU7ZsEeJ2D9An1new95Tp0PpTuuyYzvckahrwAhP1HvfOLg5ciWRj8cWRpLSfx6j7JpCOVylcasWQUuX/5ofAEK8pFFltuVyuH8BMn8et8rzoa7pw3Fwhmrc0/eHbbRsnTfqFIoBYk9wEXsLP b+RpEnWn NjZXxAod6Ry8qO1QIM0k6HILhcGn5hDvm4EEFBBH2Set0I2gGGZqd0Ymov+f2tyGoqegH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000083, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 22, 2024 at 4:56=E2=80=AFPM Sasha Levin wro= te: > > From: Wei Yang > > [ Upstream commit 592447f6cb3c20d606d6c5d8e6af68e99707b786 ] > > commit 772dd0342727 ("mm: enumerate all gfp flags") define gfp flags > with the help of BIT, while gfp_types.h doesn't include header file for > the definition. This through an error on building memblock tests. > > Let's include linux/bits.h to fix it. > > Signed-off-by: Wei Yang > CC: Suren Baghdasaryan > CC: Michal Hocko > Link: https://lore.kernel.org/r/20240402132701.29744-4-richard.weiyang@gm= ail.com > Signed-off-by: Mike Rapoport (IBM) > Signed-off-by: Sasha Levin Sasha, are you backporting 772dd0342727 ("mm: enumerate all gfp flags") to 6.6 and 6.8 kernels? Just checking because I didn't see any emails about that and can't find it in stable branches. If not, then this fixup is not needed there. > --- > include/linux/gfp_types.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/gfp_types.h b/include/linux/gfp_types.h > index 6583a58670c57..dfde1e1e321c3 100644 > --- a/include/linux/gfp_types.h > +++ b/include/linux/gfp_types.h > @@ -2,6 +2,8 @@ > #ifndef __LINUX_GFP_TYPES_H > #define __LINUX_GFP_TYPES_H > > +#include > + > /* The typedef is in types.h but we want the documentation here */ > #if 0 > /** > -- > 2.43.0 >