From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61017C27C4F for ; Sat, 15 Jun 2024 03:55:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2C9F6B02A9; Fri, 14 Jun 2024 23:54:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A09B6B02B6; Fri, 14 Jun 2024 23:54:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45FAD6B02A8; Fri, 14 Jun 2024 23:54:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 48B496B02A9 for ; Fri, 14 Jun 2024 23:50:44 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DB99C160974 for ; Sat, 15 Jun 2024 03:50:43 +0000 (UTC) X-FDA: 82231746366.22.94B3EF6 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf30.hostedemail.com (Postfix) with ESMTP id 2174E80002 for ; Sat, 15 Jun 2024 03:50:41 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WFDcR6t6; spf=pass (imf30.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718423440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GMvh4LLu7+iHaH8H77qbd16ndaMtLZL9+Jqv+C5DkQg=; b=7Y5yV3IatmjB3FX1+60quK92sAp3Mld+xdoe3YBm/a4JxcQNok3epoEYnK0+dOA7iFWoyw XlSDxaRXXMcK5wtfhdEpXWDISF62UEdlnF51FsacUQhfANoR/pTpJmBYzHk64sT8ftKkaV DvuiFQWoG4w3PGLDneq45teim0t13NQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WFDcR6t6; spf=pass (imf30.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718423440; a=rsa-sha256; cv=none; b=g9ChCGwg0t4NGQhEnD6os0dfEnDhQuLKkUwTGDQcUUfhZ2L4IgDPez+lRHZXhys4ZtyZXK WYReOaw3AWkSUK4fXSgJqrDeAKsZrU94mO9dlUZs0A2cZ8yTw2kfvq7V2QT/DDLJCtYE4d USdCFQQID7wLuCL4SNzjzdHlAbEqek4= Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-dfea5f628e9so3247889276.3 for ; Fri, 14 Jun 2024 20:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718423441; x=1719028241; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GMvh4LLu7+iHaH8H77qbd16ndaMtLZL9+Jqv+C5DkQg=; b=WFDcR6t6bkl4y8cOsFXkqkNvkgTkWQcW4idvvHuTBgxnmzWWgKA5k04D7PLwKiKNVT Za2ztRxkcQWoSId4sXV6Hv1IhkMMetj3kxvCBjVcF0DDVfF9aEwdWGCw9iDku1CeDShy Oh264ElRfOZW45a0Tec2AV+K7yfdNKq+XU3TCYFcSZzGTJTyZjKWlvrxB9N3XKHMyRik 6e/xTGCiVaB0Cyv4lu6I4TQtPnlTYkxN7Vy5TCCbHiKCKtCUCpzLk8GQmffsXTAIf/m5 s6dPXYRv05Yi/gOa8ODOmpHBPATv1ImQMBGHUKADrjKVh44awSh42MjBqD7chiz3T9+p wmvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718423441; x=1719028241; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GMvh4LLu7+iHaH8H77qbd16ndaMtLZL9+Jqv+C5DkQg=; b=q4weQ9AB5vf13xnEO+g3oXy6R2kj1UjyATXCDxDAoyyLwzyr7nRTKuyNzQfHvYk21r lq/Z5+1DuHg5WXduii3xAgX2rOhOdfMi1f7SsNYIGb45K/YmKpKxBT1bWN196/03jIoi Lul05bG6eOhESIdTYWOPUGi8rXOHIb3WW2kpeBwM184La8TCsQE2wTsPDZeza61xzT/L RgJ+tVRAghsqv6t6ZeNfSHCfaqsEOPopd22X5Q4fPHNAHr4lZoi0kdR/jZrpaIW4Pn7Q LRtYNuOp65/2+WjZMaWc8k44j5HvA7+5wGohnOro/c1EbGLFIadSP88q7+6VfVSRpkOI aeuA== X-Forwarded-Encrypted: i=1; AJvYcCU/CJJ5FqN6Vy3wzMLh7Q0OwpkgphamBzEQUBDxRg2rwf2W0oprynHdTK6uaPCpsZ5Ng2/pWbo3VJSk9vUAEowtTRk= X-Gm-Message-State: AOJu0YxQboyfGHNV/FWq0ySM0wf1DfE8tc/jX2XreKOd0k5/SUasFEHj CZ6I9mY0yy0olzKyIXGtgXARuTtd01Lr3++fnYPMRIGYj5P0+FSqo1tS0Phdu6WvqcYsVu3ULva bxR2MnnzGd/8Z38gbz+kwvmw7ZXBmAqKsz7r2 X-Google-Smtp-Source: AGHT+IGLnx1xEu9b8B+6aEjKgrUM0EqAS3CIvalcy4j+YTnXsL71vY+LM+uwuGvau9J41l82mCbnLlylllrH3NHGj8Q= X-Received: by 2002:a25:b206:0:b0:de5:4a92:435f with SMTP id 3f1490d57ef6-dff1543ff94mr4328265276.46.1718423440846; Fri, 14 Jun 2024 20:50:40 -0700 (PDT) MIME-Version: 1.0 References: <20240614230504.3849136-1-surenb@google.com> <20240614181950.d5cd06acba24339401c98d6d@linux-foundation.org> In-Reply-To: <20240614181950.d5cd06acba24339401c98d6d@linux-foundation.org> From: Suren Baghdasaryan Date: Fri, 14 Jun 2024 20:50:27 -0700 Message-ID: Subject: Re: [PATCH 1/1] mm: handle profiling for fake memory allocations during compaction To: Andrew Morton Cc: kent.overstreet@linux.dev, vbabka@suse.cz, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 2174E80002 X-Stat-Signature: hua5q9f6sadchi6gng3ek58ka7gp688d X-HE-Tag: 1718423441-207581 X-HE-Meta: U2FsdGVkX1+pebznrItSkl43FJbbc7iDD3++pyj2d0oJHhNsRuODGlvFvOE73bkMidDQMEoGDKEBWeX8WITpLW1hLFNumEJXfKgxb234TZGArGAOb38T1pZ71p+QwTSXzyzSu7kbKC3jHxusPlOiFgrJ/RTguvlKDQIE0252Fv0T34BUHR/MbGiTrsTntNOBfpxd4pzE/C6+aB89GH245BLPTuGnk7jduIkYDziIzTxR8tnYmSXlWeGwEh80dbz7UqiQEbGNLXerS0sqqhiv97y1/1U7MNQPWH2dZ5uNBRRmgcx/CSvoq9VMtjIEhgc/7IYwp5pDrKkLauWEOSxJtRZOzl1QiaTQDcN39w1CXcQPsReGnsjPe+QbMBRJPsiT+P6AfkeVVakTqbXqC/iAMJs0jrsUd874Z/xMnT+yESntIv/m4sBEj0k6ABExEDMeHcVdZ7VSKY4c/R1pNGZSliLcttAWxdYUqkJxTCUGIgN6G7YDUud5JRuillIUoUxyWy8s9s65WNUXnagnR3uHmtgvOA7qM2zihWReKKt05XG1iCcT4Jp9OOShLZChSTiH0kCdWBjYPbwqO5LRUq5EFl+kz/b2CB0ZAzfb4m2nu57T/aKRb3pNuTww1yyJB5jRHeTkLr8L7F8e9o7UIz+vui3xTf6OjKcKL0wXI9Yk4jAgbu0C81XZKy+00PkeK9/XRlclIgZtvGG5IbnNTtbrOkxAqJvvLvpoxXDPeMM3M5uFj1r+QO2Wf4OmeJKB8Jjy0ZCjmBPTWx4rtQXXYBBeuBUVzoIvDWHnUsjQ9OTBd8wttJUrXTC3uzC0fvbyaLiwW1HAIEsl4nxUNeM8AwQ1O9fMZhFTEpyxCb4t5HfAd8YVC9jrIc/f2eldZsfTmpekOWY6Vg82wTq8HcCppXC1p3sdqO6nBxAkN2rU5x7fT10S+SG1QEEgzutFVI2m8/g/9Wcnrf7gdrfSmkAMZ4R XuwrZXoy KOD7+bu45Ehxo6p0ieLXRwyuDS0JvlvTsHVUySmdIzOag4q1r+Bm6B44OfkheeMry5ZdfLjwc4hWxhnWlrPOmauIZOzpY5OTPNXIqnbjuKNvDJHf2xIleeWmafvf4Ubi9/6q9x1gNaJ61NeA3Yvf/Hca4N55TYUko1LllNM/4oUCZzP7uM9koDvR7BH4CPpASPHbq8SszRkbWevnEfjPAd8ekiShmZTEQDeVgn4qODGIE/XnHNjvUcYIdsQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001567, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 14, 2024 at 6:19=E2=80=AFPM Andrew Morton wrote: > > On Fri, 14 Jun 2024 16:05:04 -0700 Suren Baghdasaryan = wrote: > > > During compaction isolated free pages are marked allocated so that they > > can be split and/or freed. For that, post_alloc_hook() is used inside > > split_map_pages() and release_free_list(). split_map_pages() marks free > > pages allocated, splits the pages and then lets alloc_contig_range_nopr= of() > > free those pages. release_free_list() marks free pages and immediately > > frees them. This usage of post_alloc_hook() affect memory allocation > > profiling because these functions might not be called from an instrumen= ted > > allocator, therefore current->alloc_tag is NULL and when debugging is > > enabled (CONFIG_MEM_ALLOC_PROFILING_DEBUG=3Dy) that causes warnings. > > It would be helpful to quote the warnings for the changelog. And a > Reported-by:/Closes: if appropriate. This was not really reported anywhere but if someone hit this condition (it requires compaction to be running) then the warning would be generated. > > I'm assuming we want this in 6.10-rcX? Yes please. Otherwise someone will report that they are getting this warning when the system is under memory pressure and CONFIG_MEM_ALLOC_PROFILING_DEBUG is enabled. > > Please help in identifying the Fixes:, for anyone who might be > backporting allocation profiling. I think we can mark it as Fixes: b951aaff5035 ("mm: enable page allocation tagging") but it's really a separate patch which covers a corner case. Please let me know if you want me to send a v2 with this tag added. Thanks, Suren. >