From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5DF1C48BC3 for ; Wed, 14 Feb 2024 20:31:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6380E8D0019; Wed, 14 Feb 2024 15:31:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E7D28D0001; Wed, 14 Feb 2024 15:31:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 460EA8D0019; Wed, 14 Feb 2024 15:31:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 327DA8D0001 for ; Wed, 14 Feb 2024 15:31:07 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0BFDCA0E1D for ; Wed, 14 Feb 2024 20:31:07 +0000 (UTC) X-FDA: 81791553774.21.165D2B1 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf20.hostedemail.com (Postfix) with ESMTP id 91E8E1C002B for ; Wed, 14 Feb 2024 20:31:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZfyguRJg; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707942663; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NcEj/SyVb+AY5aiDL6vEY+YAlLL1EeaxcCrjK4Q+5oY=; b=gCqXkWE/dPeH45lJtS3aB7Uqf7YYi9DjkFDaJxt6/PEL964n0cmLDjp1BmaUe21hV+PpRk yKEyVNltqfFwyiEJ6NlOzL1RRgMpf+SMOYcy+SxZbYiuTFjjTYV5qwxm2q9UF6toRVu8gx IOi9SyJZY5L2/7P4i3WryzvZs1/AY00= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZfyguRJg; spf=pass (imf20.hostedemail.com: domain of surenb@google.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707942663; a=rsa-sha256; cv=none; b=bQytEJG71q719Gd+UlYhcluHnEh1iaTvMcjTwyl7ihLy4A4v2BKI2Lq0IHfqo69cc7l62y vQpAsWararni7YdUZcef6/GhVHD6tK1It8OJ/ZyOHuHmzdkG2CiBbDgfwCP43qzMnV1hxm SZ+fAKlEkflIqAufuGvzaWbhN9R+Au4= Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-dc6d8bd612dso82707276.1 for ; Wed, 14 Feb 2024 12:31:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707942662; x=1708547462; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NcEj/SyVb+AY5aiDL6vEY+YAlLL1EeaxcCrjK4Q+5oY=; b=ZfyguRJgDkWuONXjple/UxqpG7iKZ8C4yovo32VdzxbXXtOqvpkpA6W48zgZWY+gQT ydz8+m1ymZ5+sfAEHXFJf8jJ/NsGuJWvq7j4a/AteI7ml3eAT/CcH7YKpNqH6iYX6nxR 4Qts0htDujvPq3m9HvIfcjgqJVVphk3NyBveH1/nh+dV8QVIryNka8w1DUss4A3VCtQy z7hwjjS61yie/LewnMrLL8tpOXcMuLM4KijiWHPV4VoRqybEZPzsD+rHiwRST6lMc+25 CIt79Zz7vbja9NdsZKnWgIZTGo6jrYbKXOgK2WAUsIhciEaLGD++TeGacgibhznfWDGb Gscg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707942662; x=1708547462; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NcEj/SyVb+AY5aiDL6vEY+YAlLL1EeaxcCrjK4Q+5oY=; b=ph1PscHcu32XVilV48k0AT3szO0vGmSgSf0P7/oNvHADNceJJDrotlDZPRtKGp8yau e6BaJSevjicbfUosALfXWPJLnVwh9EA73RS6IcmYgAqzRfyUS1MSUGMlyDFXVUCsF55E Gq1WxaeMtROF+ULMMdVda4FHcBmM9c/XgBmStviEmoADjD/8hGBumrjyYwlUiep/+NWK BM7gMRrAIZCU6UZqQNMNSh2FofQBFt6r9TpT35sXlVPAIxF/FBZoCN8Ta6e09XqaecC0 tDSOsHsvWZ39aE6fBCjFh+gkpsCRcZRLLKtAQR/Pxz2UTMHMYsNS4Qh+VO1M1wUyRtt9 ML0g== X-Forwarded-Encrypted: i=1; AJvYcCXUWG/dHK+XoOhtgZHLnoXWHhQhh38Y4xxiz8DKQSE4OosnTaAlu5bv+K4MDccV1Mz6pOuuJm/2qBq9VhrJX02sCzU= X-Gm-Message-State: AOJu0Yw84E4+U34Y3oOEsfeQbacop5JvJd47vzqd2heNuu2livJ/efdb r7GeMEZlZJ+oNXNWKC/7l1aL8buWACGcEGqvcslbRUqf5ubnHHw7hUcFKYLXubgXV4KrEQ7Gqw5 tSTIaBGgr9zV7ezbs69upFN4ONjjOOJ2TBpFo X-Google-Smtp-Source: AGHT+IFqoJj5aCwpmg00G6ZaLb2aiZ8b3im8fm6yEl4ijg46+lI254clzZhzLZ0Iv0kb6bhFH6lVLC2hnoLSZAsSoRU= X-Received: by 2002:a25:4115:0:b0:dc6:bbeb:d889 with SMTP id o21-20020a254115000000b00dc6bbebd889mr3283052yba.52.1707942662262; Wed, 14 Feb 2024 12:31:02 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <4f24986587b53be3f9ece187a3105774eb27c12f.camel@linux.intel.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 14 Feb 2024 12:30:49 -0800 Message-ID: Subject: Re: [PATCH v3 00/35] Memory allocation profiling To: Yosry Ahmed Cc: Tim Chen , akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 91E8E1C002B X-Rspam-User: X-Stat-Signature: ksjdzj48ymu59tmkax9omxje614qk7sh X-Rspamd-Server: rspam01 X-HE-Tag: 1707942663-344430 X-HE-Meta: U2FsdGVkX187MU3LGob8CCE8LU4iVeV06ZSPlRUDnFtqr1Cn74CUZQLvhDq7qgolWvxVFlivhM8n3VEMd0MvOANVNSK6G48jiatFChPrGM72uQtGdAoN4GN4HFYs7VKUOhrMd9S7mHdgewTgysS0QQMZxXR1xKvzMqpr+QzuVuOfJjoqcsetyMVKFJOFOw8cozefTFqmezc2N5qxsUHpFsuZ+zoXD1Sudy3u2ji6YuIQ7Xiajpo0lBNZCmdQKOdZE6GiRH4il+VBBhf6mtdo/ZZhWrCTYQYJu8hjvAaqCCtks4HpltxvslRmrosh5m0v0KzUUAtLXdGqpdPqT4ZPyFREejAXDT+RZRkjCvVojGdpF5XqbclfwxL4OHTclTAzzViJ/7c7eyR7CxYldXnCA70zzkzBY7N0x3zvoe/8J8OtbkyS5YI3EsgaLPjOCD1GGfJGkbGmv6XJyFUgD8cyI/xDsmiDDpcYhoep/nznU001UWegJXhiHiOUqaa8JfxJrFUa09MlLnALw4xSFFcDT1s/KqUJmakYyfWe2PB8qpGOd1NLukf6nRvUx/U1tMyJt4ewG6uvZK28SFRv8SdyR+fTwiAboeQE6AKGgy3wUj/OU+ar5Mi2Q5fzCDluLnlUDuwacItE4MD39bWLsuMoZfaMvnfKKWO54FzPQW0NYQSVlQYTWEQOvA/1OWBBNaTTLYkEa3K3zKHskYntSq4Nc4dEacu1xUDinryCY5tMOE+81HhAhVamMBRn92+k2AUj70C2vbUjIB5C5M4bHcNbUlxq98PaAyDwa8EfYauSZHr7cnSq7m0WMiV9ZLekRTR6d8GPodERTJVp53sZ7bz7DsCPhM8UueK9L6Z8UB/+JjjAYvxxGa6jgOP6YOVRYUYiWJvUBpffH9gje0LD004rb0zoj4y3+O2AalguXK8Thz11jUe3Dhs6KmVz8QEuCgn0k8WZ7ihIPiomizLiThm YNKjPOjn G3+mGnUw8TchgNrgVhTZRIQgp8LMHogfk9tcIFRcfa2jBbce3Z2GScJPaq48dAFyD8ANb5KNPXENwT2tr/GlA7qC/X6bVc6eXNNCJFs2ZbNsM5a1AFJfTpTKl/51C08BuwWghtCb1wLx4srMxixirsIuqa4LES9OvxbJ7zNmX3FUR0AV1ZsJluCywG90AG3Xvn/G4eNYi+hj00bqDgsr0wN92HlkzWgyycg2Y5rHoFuCGqwXxEhgBZhS6z6YIhU/UabEQ3XzQUt8ME6WsYelQnJ7JSWuHDEL56Vr4xmwX22tm+7RB7tGo1mtyzAzHGGcYJ2Yt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 14, 2024 at 12:17=E2=80=AFPM Yosry Ahmed wrote: > > > > > Performance overhead: > > > > To evaluate performance we implemented an in-kernel test executing > > > > multiple get_free_page/free_page and kmalloc/kfree calls with alloc= ation > > > > sizes growing from 8 to 240 bytes with CPU frequency set to max and= CPU > > > > affinity set to a specific CPU to minimize the noise. Below are res= ults > > > > from running the test on Ubuntu 22.04.2 LTS with 6.8.0-rc1 kernel o= n > > > > 56 core Intel Xeon: > > > > > > > > kmalloc pgalloc > > > > (1 baseline) 6.764s 16.902s > > > > (2 default disabled) 6.793s (+0.43%) 17.007s (+0.62%) > > > > (3 default enabled) 7.197s (+6.40%) 23.666s (+40.02%) > > > > (4 runtime enabled) 7.405s (+9.48%) 23.901s (+41.41%) > > > > (5 memcg) 13.388s (+97.94%) 48.460s (+186.71%) > > > > (6 default disabled+memcg) 13.332s (+97.10%) 48.105s (+184.6= 1%) > > (7 default enabled+memcg) 13.446s (+98.78%) 54.963s (+225.18%= ) > > I think these numbers are very interesting for folks that already use > memcg. Specifically, the difference between 6 & 7, which seems to be > ~0.85% and ~14.25%. IIUC, this means that the extra overhead is > relatively much lower if someone is already using memcgs. Well, yes, percentage-wise it's much lower. If you look at the absolute difference between 6 & 7 vs 2 & 3, it's quite close. > > > > > (6) shows a bit better performance than (5) but it's probably noise. I > > would expect them to be roughly the same. Hope this helps. > > > > > > > > > > > >