From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06444EEAA66 for ; Thu, 14 Sep 2023 18:54:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F4566B02D7; Thu, 14 Sep 2023 14:54:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A4966B02D9; Thu, 14 Sep 2023 14:54:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56C346B02DB; Thu, 14 Sep 2023 14:54:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 452846B02D7 for ; Thu, 14 Sep 2023 14:54:56 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1DD131A06A3 for ; Thu, 14 Sep 2023 18:54:56 +0000 (UTC) X-FDA: 81236104992.03.84D3936 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf01.hostedemail.com (Postfix) with ESMTP id 5C73D40012 for ; Thu, 14 Sep 2023 18:54:54 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="ix8V8/nd"; spf=pass (imf01.hostedemail.com: domain of surenb@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694717694; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xk68pDIYGaQdkXvAFGGLllJihcyDuXFD/cYt4QPp8FY=; b=sKF5F1dqz/thMVWpe7s3Nxd2+XhKVRubmL8hpc2l74v2qF3FALeuffQa7Od/719SqgD2bl n+P7+nZV/VUZhk90x0nFTpMhJxvpYYdvSRmCRfOMCMlVDvSIR9p84HDrLT9U4WPc6Yz000 6wD89YKZgfBCVBe2aNYTpcdWESDB62o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694717694; a=rsa-sha256; cv=none; b=WBxeqPdR7yLjaz5Xzgz86hGpqYamuhvn2MdNFdx6V5t25N8os4D3+b4D10hBPbsq3vVURW BUeKWkdxXRk9h18cmMAOCzDQzSHa7GaRcRIi0dakC2tlnEkGY5nKqMAogx1Ix2KFnCZTr0 2BOFvxxApUcR91vuR/ZblXGQbTGonhA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="ix8V8/nd"; spf=pass (imf01.hostedemail.com: domain of surenb@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-d7b91422da8so1310540276.2 for ; Thu, 14 Sep 2023 11:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694717693; x=1695322493; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xk68pDIYGaQdkXvAFGGLllJihcyDuXFD/cYt4QPp8FY=; b=ix8V8/ndHL31LhflegKi7TIwVqlvYANJizFrjZo37LcmCQSIQ/TNhqsJKWZg/efLbi nu2PwNoxTAbNekxXVzjts2KfHSaJ3KtIbIImTeKOk2qTPskyQgC3nkTzO0Yy+hJhc1kH wloj7F/7SIpwX3QYrbS1a8hn1RQiGnfhT19IzMgmF2hURT9u+XL3/V2lbDQNXkGfphhc hTIEySR9NFhFudFmgbDggH5uaJBTq/lTM3lXuHAg+V7jlFo7p74i5JUNgZdlYgPay2C1 0T4PwbNT2hZhFDX/E9M9peUB0TblksijpqIU0RhiO6yZByHVoNW4B2ADq3D2J/Q5Aanv NMzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694717693; x=1695322493; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xk68pDIYGaQdkXvAFGGLllJihcyDuXFD/cYt4QPp8FY=; b=UCJ42exC7ip5u/ida/DTt5+OB2LdY911FM4jt3mCJr1nfcoz0PQSFhRQtL/lkHNwf7 wXaW6O3/An6F0tmGBF3ZvdDPnqETL7sbjM+wzCX4dIDm9RTmkKkYixC3sDUG85zuJY1w o1q8MUTRqPZNSfxbXjTFPEWvxJa7c7mDtkQtMc+j8omtjxl0Kdac+umySuMqrRoxfx8N HBlMAw90wEebmlTb74inazx0zr1jagBUqd+UKHYxhOKbbIbgaSW2JTK57wVmDm4JHZfz MEvlQVFahPsTVzNOLArOONuYcceiknPsdgAa5Xp+k8I8JezY9QP4h6zF20QX5l681/KK Pqpw== X-Gm-Message-State: AOJu0Yy7JCBhBIJuho+j+JqCJX7TqhdmcYkCWo297BMBRKjBbFBufpQS jyqC4uyc5ALEJVV1T6Q4bKUw1+Cs5Kq9XV8p/7wRqQ== X-Google-Smtp-Source: AGHT+IFDSlM9UKN9NkhsgECpx2pe7a3wkf2X3yhc6Mo4knngCi6hulry2K96aodnp7ogl7xysjTEerrZmm/bc4LuwBI= X-Received: by 2002:a25:4293:0:b0:d7e:8175:4fa9 with SMTP id p141-20020a254293000000b00d7e81754fa9mr6102142yba.4.1694717693268; Thu, 14 Sep 2023 11:54:53 -0700 (PDT) MIME-Version: 1.0 References: <20230914152620.2743033-1-surenb@google.com> <20230914152620.2743033-3-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 14 Sep 2023 11:54:42 -0700 Message-ID: Subject: Re: [PATCH 2/3] userfaultfd: UFFDIO_REMAP uABI To: David Hildenbrand Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: t6hscfw5xh3rxtjgufn8ioc51idt7ngi X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5C73D40012 X-Rspam-User: X-HE-Tag: 1694717694-617602 X-HE-Meta: U2FsdGVkX18HNKns8cdePgqCSbK7ot6tVB7+9z8u1fMn944sgiEmFK8mmth6g9V3J1Uy/2jX/fYcQFudfy0NNtS4qSHFqbE+DHhLFbr2hUSvc5ckGKah3yAXjXw2yevzoUWWcq/5cEoUNXA2EqMAZYTRQuweEFJk2Oexfqdpxzso1qnPqxkYGl8TkkFCKG7MRKI4Q2UeVkNbiokOrQPnEbB9e1EAQ0BWmbwA1aFcNCG2ikidUISDtXwpoKsOumzS5XCf5aPf74k/9IfFl230SZ+02ywpIW394YHOUvjU9SS9vqe51M1tFu4rWHNEScT/wrb0L4wFl8fIVHE+3CJJYvJ5vN+eROlUw5iATChS6yKzWGN2CoHW38+29hmLDrgtSpWktZ5Sv3sac6VQ327CwKphe91JghXhxEWRPFpJiLatoNZPDhWkV9FgexsIzegsg9W3ttR0+GQWcG23zJNTKDR/ZfbnX9JlqoYfrirDsXqP8TUezdB2RU+iUjPuEibdpYLk94ce4SCHFbxc9/2qMSxiqzPZRe/J6omxutVuAN0J0FS/ArENxE0Uajz54jR08XOnzTHFD/QtCtidByXYXcOcTOcewzJSy5Pd2gWjEME+aGsargRfJ2b0+/CueXgKwrjV6GA1Pqv2FZuUaGl7i6TUKeSDMrIsy6sFkQbtwoJ7n8VNgsKcqIYDA8JecHsxhg/7+DjF2TuWaE+L4yiNG1d+iEVcr4lBd+lgy0dxsgs4I9aXxgMhmBaCLmrm562Kbp+STQ7lXcnOCaWNYwYvMBSFTCjuX1O2zNz/L/iLnSVYkb58h9quQFGPM0CcAARrzy9+7jiw3L38627OSAZhrr/RpMT6Hh6O6zZ+29uE/HkA5FtCQmhtfF1oKHN2SucG2NUoJaOhpqeImhwWULm6xNThjLJHnOMxJMOksgpxAly0fRBI/SQRwq17kQwqjUZzt6Uo9GDpmcR5EcnKYBO /AhnvuBV A7eQyKvImxnjo3vHkrGNqA83cvH8hQ0MpJYBKAhJiKya1g5VdyHo6DyL02A3ACGVdgj7MWNQovyQsVj0vLRDXY8h1C0A5LYuuhkag3feWCW7DMJqUG1Ce4xMS/dfa46xUa0Imj3GV/GzTRfnJg55wIBwrzFM9dzdmGFiWr+J7eGVkjVQj6tN+LrbCJbQsk95Jrv8Bg21l5KmpBcIpp/gKQjT2h+ycB6K4AOCgLJMuD9Zze0MTCVo686ZTVwCUT9cTy2yoooFeYSuNo2+REecS1OWIWzPVTNVhQ1/+M2PaFRiU9hE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.077030, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 14, 2023 at 11:47=E2=80=AFAM David Hildenbrand wrote: > > On 14.09.23 17:26, Suren Baghdasaryan wrote: > > From: Andrea Arcangeli > > > > This implements the uABI of UFFDIO_REMAP. > > > > Notably one mode bitflag is also forwarded (and in turn known) by the > > lowlevel remap_pages method. > > Sorry to say, but these functions are unacceptably long. Please find > ways to structure the code in a better way. Thanks for the comments, guys! I'll address them and will try to break the functions into smaller pieces. > > -- > Cheers, > > David / dhildenb >