From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACF21E7717D for ; Fri, 13 Dec 2024 04:22:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 148B36B0088; Thu, 12 Dec 2024 23:22:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A8F56B0089; Thu, 12 Dec 2024 23:22:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E63E76B008A; Thu, 12 Dec 2024 23:22:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C63866B0088 for ; Thu, 12 Dec 2024 23:22:48 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 779EAAF14D for ; Fri, 13 Dec 2024 04:22:48 +0000 (UTC) X-FDA: 82888638840.01.9257964 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf17.hostedemail.com (Postfix) with ESMTP id 8F3C64000F for ; Fri, 13 Dec 2024 04:22:27 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Waxg39wT; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734063754; a=rsa-sha256; cv=none; b=Ua/uMOhEAHLQfvoWgu/tGquIhifHiTzu0vqo7BbCxqhVS1z8ClanRnmx6pmBGwtwpYJCYM HAbyxiCk051uifceAYYVNPHkJPSWLrDAUvMCGx3Mm8u7yXoUHZ24+voSTkKcPbufKjhuQJ 0zhiYeXDmoUClkpQnKEYKq3Qn96Wi94= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Waxg39wT; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734063754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2zusNDVE9tIk+XAMjo2wDNCl3eBQntRzpxBDCfZphJ0=; b=0oigZXUgW+KDCn2JZzGH8QIA4ygyOHp7rGhM+LGgxYbQP2OtjXLPEPSMjU7zx8zli3iT/G mb5Fx54uUceQ3Qqt71ic5WDXNc8UmBimCkLeXssFVd9NcROrdAcaojGsfPRnt9sL0iRDWb VuyPfusi351CY9d3E9mGW16Ag+Rd4Ok= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-4679b5c66d0so96481cf.1 for ; Thu, 12 Dec 2024 20:22:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1734063766; x=1734668566; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2zusNDVE9tIk+XAMjo2wDNCl3eBQntRzpxBDCfZphJ0=; b=Waxg39wThsj4UdOe4EQm31sLi1bk7RktPNkJJ3pzjH50x8ZCLTQitWXrOOYc4iLffV K2olOP1KOHcQYu6cnlFmTfxxCQPEj3Mq65mrfSpBbOtEgJSVcEz2+M9tkrtu5HfvM5n/ 1G4Xw7iMKTbY0lvb73TY3XKQdxIffhoVPA/IC1epES7xbHeUkxki//pkpxdelmt+BxJy DYPI5ZNnBQok2zdNW3RaST7GZqyjc+t6MGwYy761DVdOAP5irv4RXVnYxFWh64ibpRhB IxAlXBi1p+KlIj55a1Uiopf3A0Affjzyx12daR6iJBxneRbC3MF6kREyMWE3ospc2DLt 6cRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734063766; x=1734668566; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2zusNDVE9tIk+XAMjo2wDNCl3eBQntRzpxBDCfZphJ0=; b=KO+9nArJMwbFZG69EiRiF2fIdFrl13mxikhppfv069/gJPhJvZdP4MjvivMwsbnlEt uiXgdp8xl2K/y/CI5AiDswke8ZzzjRkoMz9TaYCiDFwk/I9DR8conbogZDuYhWGdx0U+ MlsGIOYuBtx9HUxLZKrMd+mnRV7MZqSdiGiyF51x0ebmMIKufMzToe34M6fr18QksGmK suaXPVuZ10+IeeZhBozViby8FQce58a6NRS0tYmDhrNR9CXbWnCJmtU4tNkKPDgv5Xwb uX5cKMHXLIcQJWWii2jgd6TA+zsadQCWpiujc0wQLHgXdLgBoiB3RMsLjgqGr9MpP7qb lifg== X-Forwarded-Encrypted: i=1; AJvYcCXt3EqAyQWRCDXSe5gze6x0KnCJQx7f0Hp7E12QW3HaKp6+FjHVq6MRTp9gJ8EypKT2lx5/JTQ24g==@kvack.org X-Gm-Message-State: AOJu0YyBUpx7UmjjOaQTedu6Pe4x/7h4vlCUoKqhkFF/nE73Nr/KkQtR 8kYoZRy09OJrBgqBwuvexxtADQldceyYo7eRKIpoK2c8DP8MpE2UvzAHoYYl+7LKAXQup0zsCHe RpRkefH8Hb15JtpEwScpTcsUuKH5cKklqMs0/ X-Gm-Gg: ASbGncuEczAuQ12ry1cxgRKJ517R/sJYaJsJ8be4AvhMZMsHZ2HH6a5LMVeHNcOgwMg NAyZSyJP0E9d5Fb+bKBsnVcU0gCZmOy8bDz2h9w== X-Google-Smtp-Source: AGHT+IHUjsjX9/4hhtNsDvYlspKvkzYig7wPXadi+PWScjnds/jNc+sQHm8865fCSk/cwCPwuMUgBfUr39sbO0iN8jA= X-Received: by 2002:a05:622a:250e:b0:467:462e:a51b with SMTP id d75a77b69052e-467a4275a11mr2308501cf.14.1734063765511; Thu, 12 Dec 2024 20:22:45 -0800 (PST) MIME-Version: 1.0 References: <20241213013332.89910-1-00107082@163.com> <20241212201212.c61bfebbbdb51b3c8bfeed11@linux-foundation.org> In-Reply-To: <20241212201212.c61bfebbbdb51b3c8bfeed11@linux-foundation.org> From: Suren Baghdasaryan Date: Thu, 12 Dec 2024 20:22:34 -0800 Message-ID: Subject: Re: [PATCH v3] mm/codetag: clear tags before swap To: Andrew Morton Cc: David Wang <00107082@163.com>, kent.overstreet@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lkp@intel.com, oe-lkp@lists.linux.dev, oliver.sang@intel.com, yuzhao@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8F3C64000F X-Stat-Signature: 1esaus7pb6ss4jm7b64jr4woaztnq43b X-HE-Tag: 1734063747-672475 X-HE-Meta: U2FsdGVkX1+zd1NIaI4IiXpKJSWxShHeYfqL0TFM7QVpi21Cyw7vn8yR7/GtwstsHSQuO1ZL1McTrfe3Y645Zms6pkYkgEriw19WxvdT3qTl+Zdctf5TSDY2WjfggUhJrCnX60hAToR6fmLiR6dUzywHfKcyW9gMtBqGB5je02nOnFPoXcDOUmiL3pzjW2msClJlA2m3g+cniWv4wFxR9P0+D0Mz1HpOnPcnCxm6kUWRTCHeOjD4vr3qOqYf1f+bgXhx6lxvrAAEEoepChcTopxRxPz1tlAAIs8BX1n5fTcxBEDy4DMwm1OaC3MryPpswxdvnokgibc4H+BW8yeeXBH8ZEXxlbWuBTcxSpIvj2R5e/R8dnJffRaM6QSrumZ9Vg6XgijAsh4Qenyn1WznM2VP/Fj/2l/Zt14qHM5tSzhdaMUplg+cjaD7kisuDDE5zx/Sbvyr90y3ivaQiahrY26ocrDk6fFYjeSM3DRy0wUVTng+vwDlX/jDGsF4yQp7GQ57IRGOiMV1vKdt9TX+TZ9cIFeR2kotsTG9iogw2bB3Rtyv/t15sRtkPyfS9bC0Bvm94134MExRtENyfdOWsFeabJ5X+/srggJcnpr3A9A8w/0OXMnXpkpdD9Mdv/PO3QmI3XGYf9gVR4wKhaSbVJJSqkv3j1H3QXVmFfnEhaCdP/93buLBk5yd6zbNRn88Yx9l0Vm8TNZ079pnn8hnPe1PLpPynaOpEJJ/tmecWZf3uVICj0KH5qYfV2VyXIuR4PoDvooNE6mibdimGUy5aTmZ3+o2XPDu5UOpbO24fgPZkgP43yI41sAgBAHCY6+2fYBXsmjyBpxSLVQose75NfgCNtCqdFuDrBKf2k9iIEREfdSPkHbXDGp1CJfL33FPBw6XsI4KL1yjLw3hSm+zHhTTXRo9MyQ7bwwNiAH3rmU3CIv49baWIr+aRWut7y8g/XEAJp9qnOLXqYxOLBm d5AvgcUr nciAppOET0XLaUmYTRv/1vJJQdF/nUO0RAI78EmgrPKG+B6Rdznr/jZEjVrnLAHqIbpoBvWgYC046zB/nbIr3RNLiEZpfkdONzIB/2JwgFcFNgJJ7LtSaoXrJy3hO/SLuyYfWe7ePwBGdJz3QaOoaY/5l2Uv29YZzkAvhpDOqelJTjFHFXMTu6/ECPkI7alaZceXYuH3LQJtiKzpfNFwHD7UdE3v0UHk25uFM3n5R+radUoYW8+xID4IAg6EEXcXOQvWDbICjgxkUGHMxC1ArUJChB80/5L/3SIJ2xcY8A27tu/N9bQyqc1gKMPXbMNwiqrzwg5+QoxY6zBVi54jA6f0MJMVO+ou8OquWMKAz2YAHqhAIXmMCiatm369CqHp1/HoV8W4LJXbgLq2q0iYnIKeNNw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.440365, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 12, 2024 at 8:12=E2=80=AFPM Andrew Morton wrote: > > On Fri, 13 Dec 2024 09:33:32 +0800 David Wang <00107082@163.com> wrote: > > > When CONFIG_MEM_ALLOC_PROFILING_DEBUG is set, kernel WARN would be > > triggered when calling __alloc_tag_ref_set() during swap: > > > > alloc_tag was not cleared (got tag for mm/filemap.c:1951) > > WARNING: CPU: 0 PID: 816 at ./include/linux/alloc_tag.h... > > > > Clear code tags before swap can fix the warning. And this patch also fi= x > > a potential invalid address dereference in alloc_tag_add_check() when > > CONFIG_MEM_ALLOC_PROFILING_DEBUG is set and ref->ct is CODETAG_EMPTY, > > which is defined as ((void *)1). > > > > Signed-off-by: David Wang <00107082@163.com> > > Reported-by: kernel test robot > > Closes: https://lore.kernel.org/oe-lkp/202412112227.df61ebb-lkp@intel.c= om > > This points at > > 51f43d5d82ed ("mm/codetag: swap tags when migrate pages"), which had > Fixes: e0a955bf7f61 ("mm/codetag: add pgalloc_tag_copy()") > > e0a955bf7f61 ("mm/codetag: add pgalloc_tag_copy()") had > Fixes: dcfe378c81f7 ("lib: introduce support for page allocation = tagging") > Cc: > > And I'm thinking that this fix should have > Fixes: 51f43d5d82ed ("mm/codetag: swap tags when migrate pages") > Cc: Yes, that is correct. Sorry for missing that. >