From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C18C46CD2 for ; Sat, 27 Jan 2024 18:02:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 670416B0074; Sat, 27 Jan 2024 13:02:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 620886B0078; Sat, 27 Jan 2024 13:02:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C14D6B007B; Sat, 27 Jan 2024 13:02:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 39A126B0074 for ; Sat, 27 Jan 2024 13:02:46 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D57AE1603E4 for ; Sat, 27 Jan 2024 18:02:45 +0000 (UTC) X-FDA: 81725861490.30.00F0743 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf21.hostedemail.com (Postfix) with ESMTP id 0CB121C0009 for ; Sat, 27 Jan 2024 18:02:42 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Xl8kY88g; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of surenb@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706378563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bhiFcVZmiXVUvji49USxdoSuM/ho0pSL5Ac9zd/G2Qs=; b=B5H4z3lLKs8Ze3CsR1jreF0MvpMlgR11fylwD9mWwIaZlg/CSQTPHlsZgCUrHoXZht1AbS go7TCTUiDzJgLFpWuKcU/ITVcm9kafTyblHea9rIGeRKg9rCplkXeWtb4jE4IxT2ubmiC4 HkgBdxG0+amdG96YG+zaaWiz0uLjaXg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Xl8kY88g; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of surenb@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706378563; a=rsa-sha256; cv=none; b=7jS9fz99ukvfxx0vyNtiBEIEkW0PhRXKDJfRMF1qiV07IU1K4O2c6uM5zAUBKN9aMUX5SQ iBrJH/qyRiNUzAcoMhN0jsDbDS2q0PGEGiDm8xiyLygzNhPfJZQ4ommAJBVf2JVnRwfGOy XkJwbOuu9bni9Biy8Z+IwV0mvbuy/44= Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-602cd92a75bso14232687b3.2 for ; Sat, 27 Jan 2024 10:02:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706378562; x=1706983362; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bhiFcVZmiXVUvji49USxdoSuM/ho0pSL5Ac9zd/G2Qs=; b=Xl8kY88gsDrZx/r22tUt65HLAMOcBf77ZgRxUem9J8DWwOc0REAS1BspRTGKxwmSLx 2gESElLLi78jdQ6XAJMpsM0JP06XxgpOn5DfZeLhYWnAeFsHGmcsx4wKYklZPZ7PhKbt 7qj+f0v/Fvz7jBeNc4hFIwhQUZFIJvSsvxBugvco5epNELh4HrLmLnze7nw1nk9lwsqJ x/HxRKqInhA1oIY9gTaBZLgGWgNeqQlpkHYQm84N9muLQ6rsirzargNF22+J5UDgJttd PR+LjjyJSjS7Na+5ppOI3aXlK6PSkVywS+E1lGvXCwlOeATde8rIWMVIiIfQUhiAmrl7 mQEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706378562; x=1706983362; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bhiFcVZmiXVUvji49USxdoSuM/ho0pSL5Ac9zd/G2Qs=; b=rbWqg0gyXSsaZu5sGO5XO6XWFrr+ehv8E3InLnGYFtQPC9nRRAuymsaDBVxBdpC6gL hr72FPZ8t2pekoCfVFUY8njy/yTPMeWKq3h30dOG1C3X7hqXQBIWPcXjn0WF+9XtuMJV UJ+bWR9riCzxzz3bIaVpt4xDo3ijLwfNwFAECarKiu24jSRDsaCqUE1mXpW+puV2EhWu X2eOdHjXou7JHHUQslc/iFPj5HJMBHMHsmzQKYuOK/nwoDNztsa52DojmCrIWuZbEKWr AZJkeRDc6A4zpsJltIG2DzKuBikjhEKEO6RpZPO1DfzCZvU+MNZFzrEZot7BScq0KpV5 BOQQ== X-Gm-Message-State: AOJu0YxEMfLLyWhMC1f+N/pSKNfb46yt7swF/WzHfCm4LFY6fdQ5jwSV FnLfR2p83kQ5FymeZND7wVf39Lm0wTbTiNVcFmNN2Nu4c7BExGeqVDQWWN5P+GuC62Uv+9SwFfM BE0dbWiHVfSRW+hLCfw3tSGZ4ba3uzK+6y8ha X-Google-Smtp-Source: AGHT+IFt7D7fcQfZUWWTB7lckMEwB+zTiuLppRMJKogQRIcWErOVAUcur86HZHUuAw5T7y0qoeOFQNXAK9pJ8B0GKjA= X-Received: by 2002:a81:4cce:0:b0:602:c7e7:4721 with SMTP id z197-20020a814cce000000b00602c7e74721mr1341417ywa.98.1706378561680; Sat, 27 Jan 2024 10:02:41 -0800 (PST) MIME-Version: 1.0 References: <202401251829.0m6Eo4LI-lkp@intel.com> <68dc8592-6a5d-4cbe-bb8c-e0f4b5517684@paulmck-laptop> In-Reply-To: From: Suren Baghdasaryan Date: Sat, 27 Jan 2024 10:02:29 -0800 Message-ID: Subject: Re: [linux-next:master 1589/1892] fs/proc/task_mmu.c:143:45: sparse: sparse: incorrect type in argument 1 (different address spaces) To: paulmck@kernel.org Cc: kernel test robot , Matthew Wilcox , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: wyygydcjaf71nwrayjfie9mr93h86omi X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0CB121C0009 X-HE-Tag: 1706378562-51915 X-HE-Meta: U2FsdGVkX18ia3pTxkNg6ksfZyBysinU0OMnpz/gsjS4u/f3X8XHhY+BwcVYmnPm8kkKJJzI0oxl9l96r7L+RNfMYkSlrlBbJByUkGV0d25W0mP8PAsvP2VEq8CWc5le5ACa+0iXIdGQGqh2xCoW3Jdofkgn7+NPl2IqAu2rqxcKWn31QXLqktL1K8PZ7wyXqf6zI5SHkogR3sS21kgKiDjurw8O5dUFxMgN/YJYSkvdvve8JJXnZpH2kZsoXKYDzGHK31n/tnWgUrU0+QmXb6dQpyCk3q+MxyDPd/gAC8n3rvuM/JXbMkExFSFfUcloY8PdcF4swHzxRPOIgxdqhdP66dnPETZE0NN/IFFJMmXTLpiKsygrrTTi6Qy2BOn/+k1yKXEzGBTd4WVQrhtIBV6XorGvreTrktuw6zlXjVcvTV1YQ3eoIA5lVbX289s/KYeUSrXWFXXeFYAlp3gomK+u/ihG6/AB4vGk/pt7PkbGUGSBRMWHKPLPzwN/GKToV3ui7DRzlMZgk6ci2VGAOy3Pobln3Wla7Q1//CNjeSPBoE6k579J10wjd1cuSOxCmTPwpKMcCMr6kb0gDPI27BMovJfXvVIgSVqJvb+T08OUSR7RnOCO/wAsFnrgJuNJ1qKbkT0qvIXd6A6ZekGcGfJwmlG8sEOKOXmTRmWghDP+Zxk8MIqMt914JhTI+kb3tll6gtL9PAZgPyGnyJ4wr4oZa3oJMa1WNqhA704h77LFzUZjQQNM1IjwNiP+6PGoII2rOKSRG78Il/qVQ095QK0YteAiK0UH/Xfhe4c5Mq0mUncHOmOAAwxDWBMt3+ae/lT/iL08Cp9CRs1muAwOTI5qw/ifnfaIYKvVYgkApK/8TD64ne4iHN1iFzuqiLbVTAm9OHvXhmUAMTX+XGzdRffCUVLvmHgr0j9EaFFkcSm1yxmQ5zC85PhfG6lg/V4EqnkUZg4DrzlKL5LMZx+ jvCmXHee KzwWuCZunLupjRPzF9/UrC9IDVLbiLWUJHEwmr3vZLkrz1AyJLr/tLN5Ybf9lzljTHcfJAJZeO8IHLVklbmOXRbZh1Zf9yOCEJgq2cnTFYM2XVLDINGK13VRWJpkoojKvTIEiE1M8ObQ/MSVVFGFSXeATVFiQgfCGdZ8luACaPjXqeHXkbtSAaEqOO8XobJgRH9fP+O5TSwq9VjdMszeJoGR7jPJR+Iecr8026MXPijWNSQVuzHC+QqM9N53uWgSUeV8XZk4Wf9Pvd3obXaMoOTBIT/6C8J8K4SgOYSzLZdKq3SHIP+udUMy1iKWZ6RqfNls7EEM5OsBcfH1H2OS2W9HbhM+RsrMadhePJKLfxuqBqkcYy7SJBRwfUBz10bPNqTAY1qisUsltkaqCmSm5LaEiv3ZqnZ8i+fGW2hlza3CZY3trJVGZjQz8hA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 11:27=E2=80=AFAM Paul E. McKenney wrote: > > On Fri, Jan 26, 2024 at 08:55:38AM -0800, Suren Baghdasaryan wrote: > > On Fri, Jan 26, 2024 at 2:22=E2=80=AFAM Paul E. McKenney wrote: > > > > > > On Thu, Jan 25, 2024 at 06:24:05PM -0800, Suren Baghdasaryan wrote: > > > > On Thu, Jan 25, 2024 at 4:35=E2=80=AFPM Paul E. McKenney wrote: > > > > > > > > > > On Thu, Jan 25, 2024 at 03:17:17PM -0800, Suren Baghdasaryan wrot= e: > > > > > > On Thu, Jan 25, 2024 at 2:44=E2=80=AFPM Paul E. McKenney wrote: > > > > > > > > > > > > > > On Thu, Jan 25, 2024 at 01:27:34PM -0800, Suren Baghdasaryan = wrote: > > > > > > > > On Thu, Jan 25, 2024 at 2:23=E2=80=AFAM kernel test robot <= lkp@intel.com> wrote: > > > > > > > > > > > > > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/n= ext/linux-next.git master > > > > > > > > > head: 01af33cc9894b4489fb68fa35c40e9fe85df63dc > > > > > > > > > commit: 0c30c4cd953025979b7689e49844837f762303ec [1589/18= 92] mm/maps: read proc/pid/maps under RCU > > > > > > > > > config: x86_64-randconfig-121-20240125 (https://download.= 01.org/0day-ci/archive/20240125/202401251829.0m6Eo4LI-lkp@intel.com/config) > > > > > > > > > compiler: clang version 17.0.6 (https://github.com/llvm/l= lvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) > > > > > > > > > reproduce (this is a W=3D1 build): (https://download.01.o= rg/0day-ci/archive/20240125/202401251829.0m6Eo4LI-lkp@intel.com/reproduce) > > > > > > > > > > > > > > > > > > If you fix the issue in a separate patch/commit (i.e. not= just a new version of > > > > > > > > > the same patch/commit), kindly add following tags > > > > > > > > > | Reported-by: kernel test robot > > > > > > > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202401251= 829.0m6Eo4LI-lkp@intel.com/ > > > > > > > > > > > > > > > > > > sparse warnings: (new ones prefixed by >>) > > > > > > > > > >> fs/proc/task_mmu.c:143:45: sparse: sparse: incorrect t= ype in argument 1 (different address spaces) @@ expected struct file [n= oderef] __rcu **f @@ got struct file ** @@ > > > > > > > > > > > > > > > > Uh, this is a problem. > > > > > > > > I missed that get_file_rcu() is used only with mm->exe_file= and > > > > > > > > vma->vm_file is not really RCU-safe. It's freed via a call = to fput() > > > > > > > > which schedules its freeing using schedule_delayed_work(...= , 1) but I > > > > > > > > don't think that constitutes RCU grace period. Paul, Matthe= w, could > > > > > > > > you please confirm? In the meantime I'm going to ask Andrew= to remove > > > > > > > > my patchset from mm-unstable to be safe. > > > > > > > > > > > > > > Sadly, no, schedule_delayed_work() does not imply an RCU grac= e period. > > > > > > > > > > > > > > There is a queue_rcu_work() that schedules work after a grace= period, > > > > > > > which could be combined with a timer to get the delay. > > > > > > > > > > > > > > Another approach would be to use get_state_synchronize_rcu() = before > > > > > > > the schedule_delayed_work() in fput(), then do cond_synchroni= ze_rcu() > > > > > > > in delayed_fput(). This would require adding an unsigned lon= g to > > > > > > > struct file to keep track of which grace period a given struc= t file > > > > > > > needed to wait for. > > > > > > > > > > > > > > Perhaps something like this: > > > > > > > > > > > > > > -------------------------------------------------------------= ----------- > > > > > > > > > > > > > > void fput(struct file *file) > > > > > > > { > > > > > > > if (atomic_long_dec_and_test(&file->f_count)) { > > > > > > > struct task_struct *task =3D current; > > > > > > > > > > > > > > if (likely(!in_interrupt() && !(task->flags &= PF_KTHREAD))) { > > > > > > > init_task_work(&file->f_rcuhead, ____= fput); > > > > > > > if (!task_work_add(task, &file->f_rcu= head, TWA_RESUME)) > > > > > > > return; > > > > > > > /* > > > > > > > * After this task has run exit_task_= work(), > > > > > > > * task_work_add() will fail. Fall t= hrough to delayed > > > > > > > * fput to avoid leaking *file. > > > > > > > */ > > > > > > > } > > > > > > > > > > > > > > file->f_rcu_seq =3D get_state_synchronize_rcu= (); > > > > > > > if (llist_add(&file->f_llist, &delayed_fput_l= ist)) > > > > > > > schedule_delayed_work(&delayed_fput_w= ork, 1); > > > > > > > } > > > > > > > } > > > > > > > > > > > > > > -------------------------------------------------------------= ----------- > > > > > > > > > > > > > > And this: > > > > > > > > > > > > > > -------------------------------------------------------------= ----------- > > > > > > > > > > > > > > static void delayed_fput(struct work_struct *unused) > > > > > > > { > > > > > > > struct llist_node *node =3D llist_del_all(&delayed_fp= ut_list); > > > > > > > struct file *f, *t; > > > > > > > > > > > > > > llist_for_each_entry_safe(f, t, node, f_llist) { > > > > > > > cond_synchronize_rcu(f->f_rcu_seq); > > > > > > > __fput(f); > > > > > > > } > > > > > > > } > > > > > > > > > > > > > > -------------------------------------------------------------= ----------- > > > > > > > > > > > > > > Note that if you called fput() on a long sequence of struct f= ile > > > > > > > structures, the cond_synchronize_rcu() would be a near-noop a= lmost all the > > > > > > > time, actually blocking at most about every once per every fe= w jiffies. > > > > > > > After all, once a grace period has been waited for, it covers= all of > > > > > > > the struct file structures that were passed to fput() during = a given > > > > > > > RCU grace period. > > > > > > > > > > > > > > Still, it would add the occasional delay. And it would incre= ase the > > > > > > > size of struct file, though there are workarounds for that, i= f size > > > > > > > is an issue. > > > > > > > > > > > > > > Thoughts? > > > > > > > > > > > > Thanks for the suggestion, Paul. I'm worried about this occasio= nal > > > > > > delay but otherwise this seems like a nice and simple approach. > > > > > > > > > > One potential saving grace is that the more heavily loaded the me= chanism, > > > > > the smaller a fraction of the cond_synchronize_rcu() calls will d= o > > > > > a delay. > > > > > > > > > > > = Do you > > > > > > guys think that making *all* files RCU-safe with this approach = is > > > > > > warranted? For my particular case I need only vma->vm_file to b= e > > > > > > RCU-safe but maybe there are other cases which would benefit fr= om > > > > > > this? > > > > > > > > > > To this, I can only give an unqualified "I don't know". :-( > > > > > > > > > > But if there is some condition that can be sampled on a per-file-= structure > > > > > basis, you could use that to invoke cond_synchronize_rcu() only w= hen > > > > > needed. Or send only those file structures that need the extra d= elay > > > > > through queue_rcu_work(), perhaps by accumulating a list of them. > > > > > > > > Thanks Paul! You gave me enough food for thought. Let me see if I c= an > > > > come up with something usable. > > > > > > Do we have the same problem with the task_work_add() path in fput()? > > > > Yes, I think so. It's called with TWA_RESUME, so the file will be > > freed when the task returns to user mode, but that again does not > > guarantee that RCU grace period is over. > > That one is going to be annoying, as there doesn't seem to be a nice plac= e > to hide grace-period latency. The fget() function and friends want an > FD, so I am not seeing an obvious way of grabbing an explicit reference. Yeah, the more I'm thinking about this, the more I'm leaning towards simply write-locking the VMA to stabilize it for the duration of outputting its data. This would make the code much simpler, we don't need to make any VMA members RCU-safe, we don't need to take a VMA snapshot, we don't introduce any regressions in potentially more important areas and it solves the problem we want to solve. The problem is: /proc/pid/maps reader blocking a more important writer. With the VMA locking approach, the only time this can happen is if the writer tries to modify a VMA while we are printing its information. And even then it will be blocked only for a short duration because once we are done printing that VMA's info, we unlock it. I think it's worth at least trying. WDYT? > > Now the fget() code path is protected by RCU. But maybe that does not > apply in the case where the file is closed but still mapped? > > Thanx, Paul > > > > > Cheers, > > > > Suren. > > > > > > > > > > > > > > Thanx, Pa= ul > > > > > > > > > > > > > > fs/proc/task_mmu.c:143:45: sparse: expected struct= file [noderef] __rcu **f > > > > > > > > > fs/proc/task_mmu.c:143:45: sparse: got struct file= ** > > > > > > > > > fs/proc/task_mmu.c: note: in included file (through in= clude/linux/rbtree.h, include/linux/mm_types.h, include/linux/mmzone.h, ...= ): > > > > > > > > > include/linux/rcupdate.h:781:9: sparse: sparse: contex= t imbalance in 'get_vma_snapshot' - unexpected unlock > > > > > > > > > fs/proc/task_mmu.c:264:22: sparse: sparse: context imb= alance in 'm_start' - different lock contexts for basic block > > > > > > > > > include/linux/rcupdate.h:781:9: sparse: sparse: contex= t imbalance in 'm_stop' - unexpected unlock > > > > > > > > > include/linux/rcupdate.h:781:9: sparse: sparse: contex= t imbalance in 'smaps_pte_range' - unexpected unlock > > > > > > > > > include/linux/rcupdate.h:781:9: sparse: sparse: contex= t imbalance in 'clear_refs_pte_range' - unexpected unlock > > > > > > > > > include/linux/rcupdate.h:781:9: sparse: sparse: contex= t imbalance in 'pagemap_pmd_range' - unexpected unlock > > > > > > > > > include/linux/rcupdate.h:781:9: sparse: sparse: contex= t imbalance in 'pagemap_scan_pmd_entry' - unexpected unlock > > > > > > > > > fs/proc/task_mmu.c: note: in included file (through ar= ch/x86/include/asm/uaccess.h, include/linux/uaccess.h, include/linux/sched/= task.h, ...): > > > > > > > > > arch/x86/include/asm/uaccess_64.h:88:24: sparse: spars= e: cast removes address space '__user' of expression > > > > > > > > > arch/x86/include/asm/uaccess_64.h:88:24: sparse: spars= e: cast removes address space '__user' of expression > > > > > > > > > > > > > > > > > > vim +143 fs/proc/task_mmu.c > > > > > > > > > > > > > > > > > > 132 > > > > > > > > > 133 /* > > > > > > > > > 134 * Take VMA snapshot and pin vm_file and anon_nam= e as they are used by > > > > > > > > > 135 * show_map_vma. > > > > > > > > > 136 */ > > > > > > > > > 137 static int get_vma_snapshot(struct proc_maps_priv= ate *priv, struct vm_area_struct *vma) > > > > > > > > > 138 { > > > > > > > > > 139 struct vm_area_struct *copy =3D &priv->vm= a_copy; > > > > > > > > > 140 int ret =3D -EAGAIN; > > > > > > > > > 141 > > > > > > > > > 142 memcpy(copy, vma, sizeof(*vma)); > > > > > > > > > > 143 if (copy->vm_file && !get_file_rcu(©-= >vm_file)) > > > > > > > > > 144 goto out; > > > > > > > > > 145 > > > > > > > > > 146 if (!anon_vma_name_get_if_valid(copy)) > > > > > > > > > 147 goto put_file; > > > > > > > > > 148 > > > > > > > > > 149 if (priv->mm_wr_seq =3D=3D mmap_write_seq= _read(priv->mm)) > > > > > > > > > 150 return 0; > > > > > > > > > 151 > > > > > > > > > 152 /* Address space got modified, vma might = be stale. Wait and retry. */ > > > > > > > > > 153 rcu_read_unlock(); > > > > > > > > > 154 ret =3D mmap_read_lock_killable(priv->mm)= ; > > > > > > > > > 155 mmap_write_seq_record(priv->mm, &priv->mm= _wr_seq); > > > > > > > > > 156 mmap_read_unlock(priv->mm); > > > > > > > > > 157 rcu_read_lock(); > > > > > > > > > 158 > > > > > > > > > 159 if (!ret) > > > > > > > > > 160 ret =3D -EAGAIN; /* no other erro= rs, ok to retry */ > > > > > > > > > 161 > > > > > > > > > 162 anon_vma_name_put_if_valid(copy); > > > > > > > > > 163 put_file: > > > > > > > > > 164 if (copy->vm_file) > > > > > > > > > 165 fput(copy->vm_file); > > > > > > > > > 166 out: > > > > > > > > > 167 return ret; > > > > > > > > > 168 } > > > > > > > > > 169 > > > > > > > > > > > > > > > > > > -- > > > > > > > > > 0-DAY CI Kernel Test Service > > > > > > > > > https://github.com/intel/lkp-tests/wiki