From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4597C5478C for ; Mon, 26 Feb 2024 16:09:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36DB9440179; Mon, 26 Feb 2024 11:09:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CEC0440147; Mon, 26 Feb 2024 11:09:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10947440179; Mon, 26 Feb 2024 11:09:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EE887440147 for ; Mon, 26 Feb 2024 11:09:56 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C9BA61A092A for ; Mon, 26 Feb 2024 16:09:56 +0000 (UTC) X-FDA: 81834441192.26.24E3FD0 Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf24.hostedemail.com (Postfix) with ESMTP id 1E3FD180028 for ; Mon, 26 Feb 2024 16:09:54 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=s+dC573K; spf=pass (imf24.hostedemail.com: domain of surenb@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708963795; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q2i9nu0Yj7jZAbH4EMUTPvr2EXed0SrW18ZEoR5sBFQ=; b=DCopszQ7rjqQZiEIiy0al/xDDr9r36iZj46aS1aEnDxrxXQTj+FoC6NJDbfXeXxRtrgIw4 dWpX5VbLzihBp3MybBGtC3AJ3YNO2NZEHTVOGw/zOA2ak8IW9S3hSJislc/3EX80MN1mBZ EyF+joAfKKjlWxEOH89t8LWc2SQjoZI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708963795; a=rsa-sha256; cv=none; b=NBelEG++Ph/iXBa23vpy3TcY5qfkyGU811R3uK5rE/3HZNzxOLZNPnyOhd5BP+BcGzKLVP qTtz9iTJjJfOZX/Yyt0ZcDSIJdrxfqiC1U/IODbdklO+XKUGTPG3R3PkilURC/5SQyrU+n 1E16fdQ1HuTmv7pKcTND/UM86chsN+k= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=s+dC573K; spf=pass (imf24.hostedemail.com: domain of surenb@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f175.google.com with SMTP id 3f1490d57ef6-d9b9adaf291so3025656276.1 for ; Mon, 26 Feb 2024 08:09:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708963794; x=1709568594; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Q2i9nu0Yj7jZAbH4EMUTPvr2EXed0SrW18ZEoR5sBFQ=; b=s+dC573KsEtX3PcpUgLLkmaBVS5n1PkLJXduPTDmNQ4GsvBa6/A9Y53pbVT/KbYAY4 IHssnsYrZ06xoOwtmtnHRd9DxZbSl1Mies79bcp5j63wnyrbHzMlJcmXRWPHmaXey5Ks cwCiriIy3YMm6ry13NWKirKywz6atSTgNI7y4PqOoEQfUSDxtS5G/tGFdbLe6HrkeM36 4BqYwPfgzzh9Feye3H7kbCODpJAs2aigaTL9YnUQFi9npj/PKdnQSPh/ljVd/wWAxHoj LFT9kArznppDnVfIkcGDI+ivH62GoxOtJhQRPmCOrT13YX9oqc1RwdwRQch9JwFbuHcv fKFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708963794; x=1709568594; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q2i9nu0Yj7jZAbH4EMUTPvr2EXed0SrW18ZEoR5sBFQ=; b=hD41JfOUMhnRAc30A3qaADAj6pIKEZftjI4JZl1Uz46EY5AJV75BaGyoZep51cHf7/ ALRjz/10gftWm5lScxNsJHrzoOPPubvs183OXT+BuK/R1wpNxkOXbU++EKa57wJo9tiQ 5DNCsSrmbj9+IbGpuXTTy0S1yqbxStuZI2W5pbUcQ+ITVr4B7L0261dErixvnoQ9cXqD O/zSxvKnjKlPgODH0GCb5mXfVl0tlIET4ZYae2d6/nzgz8BwBZzVd5Zu+qxJ6RHmy9t6 FEiIHXbNvB759bl7tp8BxmVZKDLhN91Qn56eoq/9EkaW2jdZdAeQ6KU4J3b4fm/3BY71 hl6g== X-Forwarded-Encrypted: i=1; AJvYcCWsyuVs8dAu0SvFCQWfJ/8KnsjJ/yX7pJMIeGOWvKfWgPZ52vCNli1W2Z+TYUwnWJsXt3LTOzo9rBYhBcsGzoacNmU= X-Gm-Message-State: AOJu0YyfApnoa8TZixi/nfVsEXffESfypgFUZjUptg6Av/Lae5R1aeyb /iXdGLfwUT0tyer+THz5ttjBe/SgKxIR7TzmZ3lYsajyqot2/AmL51BNjI7DO9w/NXW0NrI1uoq XdVEbAhKbAzodPvr7Ux5gckfsli4BlRaXZPTQ X-Google-Smtp-Source: AGHT+IFiv+y72N/mXVEJcRlho2bUNXrJYvtkNjNCkqw5WfMbaDfjXaMlMUIsggVwW64saHx2yjHtEvViFdZhB2+giI8= X-Received: by 2002:a25:ef4a:0:b0:dcd:3575:db79 with SMTP id w10-20020a25ef4a000000b00dcd3575db79mr4289171ybm.6.1708963793723; Mon, 26 Feb 2024 08:09:53 -0800 (PST) MIME-Version: 1.0 References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-4-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 26 Feb 2024 08:09:40 -0800 Message-ID: Subject: Re: [PATCH v4 03/36] mm/slub: Mark slab_free_freelist_hook() __always_inline To: Pasha Tatashin Cc: Vlastimil Babka , Andrew Morton , Kent Overstreet , Michal Hocko , Johannes Weiner , Roman Gushchin , Mel Gorman , dave@stgolabs.net, Matthew Wilcox , "Liam R. Howlett" , Tetsuo Handa , Jonathan Corbet , void@manifault.com, Peter Zijlstra , Juri Lelli , Catalin Marinas , Will Deacon , Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Peter Xu , David Hildenbrand , Jens Axboe , mcgrof@kernel.org, Masahiro Yamada , Nathan Chancellor , dennis@kernel.org, Tejun Heo , Muchun Song , Mike Rapoport , paulmck@kernel.org, Yosry Ahmed , Yu Zhao , dhowells@redhat.com, Hugh Dickins , andreyknvl@gmail.com, Kees Cook , ndesaulniers@google.com, vvvvvv@google.com, Greg Kroah-Hartman , ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, Steven Rostedt , bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, Christoph Lameter , Pekka Enberg , Joonsoo Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Alexander Potapenko , elver@google.com, dvyukov@google.com, Shakeel Butt , Muchun Song , jbaron@akamai.com, David Rientjes , minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, Linux Doc Mailing List , LKML , iommu@lists.linux.dev, "open list:GENERIC INCLUDE/ASM HEADER FILES" , linux-fsdevel , linux-mm , linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1E3FD180028 X-Rspam-User: X-Stat-Signature: eeiui5rdspmkm7zn5i73qyhcyhajp5o6 X-Rspamd-Server: rspam03 X-HE-Tag: 1708963794-184339 X-HE-Meta: U2FsdGVkX19OYvmTOoJThQz0mp/PD1Vb9Tf82XQEJsUgnCHGXA5xZ/rox/YXzAkJgwG57UTPm29bLs7SNoN6TimoYeg0E9I+1C/q18QV6G/b3wz59dKpzccrCItZRxRrtzJBUVWJ4gjmUkFQ6vdUkCznIcXD+KvFlVao9CFjxQcn0XRWwfCNRWanlqPUXTYisgWPykGAG7OJbj/Q/hEd5QQdKDbit8YBNc70WX3vCviq0THcc6i1Qo3++IKicmjNwBOLBV4pidvWN2kaEsLf4tc0XK5Lj982RdVqYqEmT23As/j54SyNcD844l1HeDcwwCUYNgTSmp43QeDF+wIheGJSO/6Bus4A0kSsbjVqRtXtp9VjbRAcgGhyZu2S1+DFVQuiSd4W3xAIwPGE1Gk61uuUTErJqjNgf9sfPHgq0wmJXLNv4lsdJZsHIbDjdl/AkdflPXCcIL0decrcpgZOFzdXWxob63Id2uWb9yMBPTpqmPHX8+pz0SgQPLCWIpmPJsh6Mh8HLJYsjFl0hnYvPoPqCHSmFiKrR+qRAf5I4OoXzwovXYmw7qqA70kO7ZjPLyWyIhV/W58kh2e/kA6fbGl2g5DWU85MlPmNYOC6cyvEjlYmUOtOR1da23Z1HZKouQckMKlai5gN16wRFlMahKPOcvjo5NGMQxIklOL60cc4+hgIIPI7ElBmBkbK8Qulo553OWp+VMntyMI8vgdLOv918lWXK/zBNY4tyLVCWhHn9MvSizOte/qHQTaYDuC1TS622Y5yeGWGU24BjkAaIYk4WEkx/D2Wj8gHPA7wrlCeb8QRfnNjgqITcCCCCvAk3UGxhqPYZqQoyQDIY8Q+FUT6Lh7pF5JpoiJ4ncznxd+1glA1x+idM5tSaI1SsHahgK7/Y5EGJKxJ9G95mRhumxacGEtGXOF4qRermeYDPf/pAQkBdLBCSMrv0S/0P8LwMb1SRwVxz+6qTH+N6gY 6GZB5XK3 SJHtsn4tmsj7rKTeEwxUAG2j+UQMpamr5bZ/NeKrdBF2H9ySKQiNs9dKZUCV5C668fHhSqC24Ie+AcQS7XHkQqpWjcPCORRWahrke+O81pav2cAzCSiMigmzEBw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 7:21=E2=80=AFAM Pasha Tatashin wrote: > > > > On Mon, Feb 26, 2024, 9:31=E2=80=AFAM Vlastimil Babka wr= ote: >> >> On 2/24/24 03:02, Suren Baghdasaryan wrote: >> > On Wed, Feb 21, 2024 at 1:16=E2=80=AFPM Pasha Tatashin >> > wrote: >> >> >> >> On Wed, Feb 21, 2024 at 2:41=E2=80=AFPM Suren Baghdasaryan wrote: >> >> > >> >> > From: Kent Overstreet >> >> > >> >> > It seems we need to be more forceful with the compiler on this one. >> >> > This is done for performance reasons only. >> >> > >> >> > Signed-off-by: Kent Overstreet >> >> > Signed-off-by: Suren Baghdasaryan >> >> > Reviewed-by: Kees Cook >> >> > --- >> >> > mm/slub.c | 2 +- >> >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> >> > >> >> > diff --git a/mm/slub.c b/mm/slub.c >> >> > index 2ef88bbf56a3..d31b03a8d9d5 100644 >> >> > --- a/mm/slub.c >> >> > +++ b/mm/slub.c >> >> > @@ -2121,7 +2121,7 @@ bool slab_free_hook(struct kmem_cache *s, voi= d *x, bool init) >> >> > return !kasan_slab_free(s, x, init); >> >> > } >> >> > >> >> > -static inline bool slab_free_freelist_hook(struct kmem_cache *s, >> >> > +static __always_inline bool slab_free_freelist_hook(struct kmem_ca= che *s, >> >> >> >> __fastpath_inline seems to me more appropriate here. It prioritizes >> >> memory vs performance. >> > >> > Hmm. AFAIKT this function is used only in one place and we do not add >> > any additional users, so I don't think changing to __fastpath_inline >> > here would gain us anything. > > > For consistency __fastpath_inline makes more sense, but I am ok with or w= ithout this change. Ok, I'll update in the next revision. Thanks! > > Reviewed-by: Pasha Tatashin > >> >> It would have been more future-proof and self-documenting. But I don't i= nsist. >> >> Reviewed-by: Vlastimil Babka >> >> >> >> >> > void **head, void **tail= , >> >> > int *cnt) >> >> > { >> >> > -- >> >> > 2.44.0.rc0.258.g7320e95886-goog >> >> > >>