From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 049BDE9412F for ; Fri, 6 Oct 2023 21:32:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A4358001B; Fri, 6 Oct 2023 17:32:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 755A780008; Fri, 6 Oct 2023 17:32:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61B918001B; Fri, 6 Oct 2023 17:32:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4FB9280008 for ; Fri, 6 Oct 2023 17:32:33 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 385FB1CA454 for ; Fri, 6 Oct 2023 21:32:32 +0000 (UTC) X-FDA: 81316335744.25.CBE19E0 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by imf12.hostedemail.com (Postfix) with ESMTP id 79D8D40014 for ; Fri, 6 Oct 2023 21:32:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ydMpclAp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696627950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n7nhNrrcEioXD0TPvV1pN7kd7gJMiVym43CUY/dMMZM=; b=1KZrFVBUppijDfY/KjLHLwHkXJvFYCmztiRMDU1U20HCM8kuCV1TAbKXtXuFKG2MF8vqAr XFbHG4di6hqc2Vyizu7PvEGFK5+8+P0Nt0rwqJSuBQGu0lM7MJXG8mWrowOr6auERjbDmb EvgAyI/ZyuuNvLRqhUuuTv5/k1t0TKk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ydMpclAp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696627950; a=rsa-sha256; cv=none; b=7jFbvOjiR5XG8FHW6GBvU/GlBWgp9NNBu+ZVT9m6aibuyfJyfW4ldWKH3bcNeqKdlecRnO nkk8gGpTMDNf19ZNw+mvPoT5DrRxmpCzG+KzMzVbnm0VWHuU+8B+fB6Deckuo93Xkp+cO1 q/kEMdImGcXm9agMeU7WvRnCy0IFQ10= Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-5a200028437so32400697b3.1 for ; Fri, 06 Oct 2023 14:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696627949; x=1697232749; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=n7nhNrrcEioXD0TPvV1pN7kd7gJMiVym43CUY/dMMZM=; b=ydMpclApH/4Q5UvP5Z8swOJyHZrxFEfoOFP4mUSYGLaMLrnZRCTX/HEe/zabcm1uW0 Q+bT4WXqxrIHlKSd4PI+2I0vRxwubuh/Z6ZH+10B+O8AYRrg6sDrV/YK/UN12hPsqpNt R03p5D9eQyRIOBHTeBR+PTtyz+MRzsX9pOJixhocERLy1sG3C0Ww4kOWrDOfEVLnrHfo 7Yx6uPeTh597k8Wnvjt0+kYzv1+sZ697LqgMtXB+pbL89E+4/7Q/+lnnZHwCrCu5E8k/ q7aPYp/p8WAVios3CvDbKF2YFb94593CpjXRwAUhAE0PF47W23q63JUNb7x5pnUvRX0p lqgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696627949; x=1697232749; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n7nhNrrcEioXD0TPvV1pN7kd7gJMiVym43CUY/dMMZM=; b=uHtWXfBrZonqZg+0s9i1J9IjWaLf9Vp7TbfOk8zEpUy5+xjvLcAxIXM2SB/YFlbJ96 EZZMFkbIMEXjbA1DhXGWPa3FKDODM1m6mOF0enLfIcHIW5mU037TJ/AtDM0cRuY4QFRz 159xU68F0xrJHdfLbrh+ac8CP9xbZsmUe5rnsBMbfNXG2xQaVwRcUMC3sApPjoksV6ET rtkDlca7FMqYDIsUCgNb/3Om3rq2QKeTLhaCYIEZ23iUQkWzNvUbS0sVN3GFaX+MamN/ 2hfd4GGugfXAvLgyoUnIPtqSL774XLB7S6Vhw8dmY8kS9PVjI/BKu9KPqKCFMCF2C8Ln KylA== X-Gm-Message-State: AOJu0YzcB9uULI1wXmcd9qEM2OgWvUwaIwedrj2gRLl11WlFHxC2iZkU hpoGfR7qhr0LJjDJgACA2N8W46GF4PtbPg1dwXoFCw== X-Google-Smtp-Source: AGHT+IFNpoSi4VeIsa9zfB3rqLPoPdfRSLaaGEwTNK5oWcXngp98EkgmA/haYR4GP0iIgDVJRjgR58wej7BM9q+PMWA= X-Received: by 2002:a81:8494:0:b0:59f:728b:ac0f with SMTP id u142-20020a818494000000b0059f728bac0fmr9816573ywf.6.1696627949389; Fri, 06 Oct 2023 14:32:29 -0700 (PDT) MIME-Version: 1.0 References: <20230929183041.2835469-1-Liam.Howlett@oracle.com> <20230929183041.2835469-3-Liam.Howlett@oracle.com> <20231006140834.07110f7008677c646af1694d@linux-foundation.org> In-Reply-To: <20231006140834.07110f7008677c646af1694d@linux-foundation.org> From: Suren Baghdasaryan Date: Fri, 6 Oct 2023 14:32:16 -0700 Message-ID: Subject: Re: [PATCH v3 2/3] mmap: Fix error paths with dup_anon_vma() To: Andrew Morton Cc: "Liam R. Howlett" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jann Horn , Lorenzo Stoakes , Vlastimil Babka , Matthew Wilcox , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: f9aewtum5htgn3kizh6p6pu5oowkxpsn X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 79D8D40014 X-HE-Tag: 1696627950-262368 X-HE-Meta: U2FsdGVkX1+CvtBUWHQMdgwJfe+1JkM/s+qqVnsOcUgB/t+eTA3Mrr8WjMlhR3MM2+4TuZsUy7Wai2GyRdfi4E+iqwxlKNnMcbohTqj+DAV52EfiXk4l8gnq0LPgmkGA71vGzrpj5KdGMLBczwk3otj3h7uTd02p0NzTmGpoSRYr2H2PBNKuPDdaL7yMMlcDgGseYzqB5RMDgvhtmjkj71uZFTaxrUY658ajs544w+8ZO5qj7K3hFqKx8yZAw3iTIpVp9zqqX2FGMWTvNi0AnCibKQ2JR7dZoZpJWbcVImojkOhRg1Is32rtZ6kjY2OcI+/w7BXQ08aRtihMG5teW/L0uZeOqiFUT+qOUxr/0w/09jWhHuwYYMByqcgjuaIP3GVoVUI1HLNY9k3LHpznZXBzIOgLkvaw1jMbX18bDubJ17/BYtgpNdeAfxRGXbjbgKkN+rjEqRMC6eMhI9niJmCR2eQfq+9Fx+4pUajE0td0gHlgkYy1jLgIMxMsyHyEAn8SrEm1rWwmNSrGVhk5gn5ORfZcGMvDwe8JBqqfopSqc9is31E3B9Gn+FIIoJhWqqD5qpJTOEg5yiceCm3sRl0fuehKOKsBnLHKkIk/FTs005GN2mn1ihs8BKcNcCozzZdiMezZrsYKviFtUU6t1R4TOwBuxiecn0LZE33LeiE+ZxkNdCY7iIqu0r1WRNrpMjEHpGL0cN/6wxgZ4X9r6ZkmJhaVLWVdxmbQ3jC1TKUqs2yZKSxUEJ3gQTNHSwXGKJZxj5ubwRzHABjy0MqmmU1AruYMrNx0fWbOqRT0DNDUCvmvZkResA9BfXgFez1fxPdxOw1NkOrRjjLfAyxPUraXwtQRaGrIDEKy2B/jHwiwPTMiy19K7CcsiCmX5o4igbrxmeluVW7OZrjZS3mSNE6r/Lyzfw944jUFxgfJ87eR/k+3wkzZQoLjc2xYQi85yvZOdS+URNVQnhzjKSs zAPL9zRO iOseLFa+6mjfO0QL31Qk1DUkISfnXtpmsYCWD+h0V2pboAUaDGPaUFTIotIoOXSMgSR02f4PjKqiQo7sQq6P4GxQfs5Wq4x6Hxrv95T12F9rjQgMK/AMlQeCH/qy+YlqQ7ilD6uIB2PL/kzlgTPd6rJ9RD/5IVHw8XlXkxqd9bnZfmrbqu6iRrXf9fwTHh+/+O4C+FmaqMF6KW3l6sLfDH/BMrwK2yMSaO7Dnca06e7mhc2KMlJLSTnG0EARnVUabBhrpKwnv6JgdENNY2WAOdYbT3ONkJ0WzmzlgxXqKzGST4F2679AAT05l6nF2mxytDM0rNO7l9Giy0dV677dLIOI4wflNlg01jrZo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 6, 2023 at 2:08=E2=80=AFPM Andrew Morton wrote: > > On Tue, 3 Oct 2023 09:21:22 -0700 Suren Baghdasaryan = wrote: > > > > @@ -633,7 +641,7 @@ int vma_expand(struct vma_iterator *vmi, struct v= m_area_struct *vma, > > > > > > remove_next =3D true; > > > vma_start_write(next); > > > - ret =3D dup_anon_vma(vma, next); > > > + ret =3D dup_anon_vma(vma, next, &anon_dup); > > > if (ret) > > > return ret; > > > > Shouldn't the above be changed to a "goto nomem" instead of "return ret= " ? > > It looks OK to me as-is - dup_anon_vma() leaves anon_dup=3D=3DNULL > when it returns error. Yes, I realised that after sending the question and didn't want to create more noise than I already did... All seems good.