From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 591EFC3ABBC for ; Fri, 9 May 2025 15:28:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED7696B0131; Fri, 9 May 2025 11:28:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E86176B0133; Fri, 9 May 2025 11:28:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D747E280009; Fri, 9 May 2025 11:28:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B64966B0131 for ; Fri, 9 May 2025 11:28:16 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 325DEB72F7 for ; Fri, 9 May 2025 15:28:18 +0000 (UTC) X-FDA: 83423750676.24.5818FAC Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf14.hostedemail.com (Postfix) with ESMTP id 5D39910000C for ; Fri, 9 May 2025 15:28:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=o7kPUiRQ; spf=pass (imf14.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746804496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V311r9l6O55gp0nuzr0djX7scAYmilyGkTeDqrs0OCc=; b=0ZhevDpRmchuw+VXEzVeOnRKX10TVp7cbsz0fqM4wMcyfJjcdbTxw9SYd1EyL2DNoHsveT fMpGzRd3qfqoemBv0r+R5ip9xWZiF1sR03e9MRMOF9gg0Gc4UBonoW6gDJCjiITJqjJVM9 0/ov2ab12MB/ZcODfsba4KLhwJ3xi6g= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=o7kPUiRQ; spf=pass (imf14.hostedemail.com: domain of surenb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746804496; a=rsa-sha256; cv=none; b=SgD4g+zFBCV9rWYlN5SYX3Py3R9/CEK4XpxCoNLJroZKg/i8AsHCGc/rWbM3+D30AczMMW 9kdrPAg5ktBLvequE0EkmALkgWmqWYlOHlW4EQXxot4sZDfyNdI5zH2tluXCmn/5MeOTG0 Z1Vs3KPfj5qbSPST6wH8SmowbeM+lBg= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-48b7747f881so319701cf.1 for ; Fri, 09 May 2025 08:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746804495; x=1747409295; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=V311r9l6O55gp0nuzr0djX7scAYmilyGkTeDqrs0OCc=; b=o7kPUiRQpPtcY4wLy2WtPo6Bfbnp6t77eVLbwhiWT5xRYVxwYTbytKw4oC/bJRLTz9 lbfKk6bNCgFjKTNuMVN4xxfuqX53bNRWAXoc5c+8GzfyUJmKWq32l1EbihGZbJECIv1M n1GWjMiO5+g0mG/S3Mg5Ok8Yjg9iDrSEUD46vtKFxjCFOd2J2UvuEsnPlpeim8kvh2ey 5H3ySko40ECLSRHkyD9LcT5Viz6BuMSMGIMB006mwfBrWmeT7LVg8cT0c9hn4vL5zMCI TZdQv0wYYEO05ehypuNp3tVUqzB8opRdLqJSAH/sqJksDRDok4Jq3641H4dXFiuWqugi nn3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746804495; x=1747409295; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V311r9l6O55gp0nuzr0djX7scAYmilyGkTeDqrs0OCc=; b=sLPbHvYdeXNt9GPkGWy0m49S5v8kDlowOOTWSIIbtBDPhOTqXJXYxpBpB7g/qZH5JA UErOGPoT6BvhB/UHwbNaw3HnWsL7i957p+1zFASbTtdShsErqtD/uY7/woU4X2Xmlvbz +8kxWEFuNt5/OJodB9qteHMKkq0KySzLQANE49lcc1qx71fZHHuVfz1PUflS9HNFN2ed 7kwduUKtwIxiFuCm4mekxuF3tO/K6pCFpGGvQXWdaZ1Eg+0y/hpnPQ2qu3cGEdWOyqc0 7Yz7SrOl93RUM9afzDSPDrisSq7FF2XAaoteEb4mm3SVKUrzHH8TV0PxwOJY/MLbFEBs 3xVA== X-Forwarded-Encrypted: i=1; AJvYcCWjstxESBC79WuZ8okiXQxlRCNqWk51ZE1OAmvkl7UMh5IfZ2T82TzgC4m0JwfCKG1THEU5CirZ1w==@kvack.org X-Gm-Message-State: AOJu0Yy/S3KIUU5JSrNalvG+GeZ9hgqIG4VtaIji/40QD6tIXJUvQN60 XTZoyIVMUCHZ3zEf8pDry1JhxusgER0VOActxn7rUOhzFJd4q3qpi1KeVstcmMSBPhyxj17xstl cs9Vt7rieWlC/1gczV/drNIG2APlppRx9XMJk X-Gm-Gg: ASbGncuKh8YCLtsA3uV4yIvtHTeHlTVagioVbCZ4C2LgdvowybQYA5FTVgFAOhnWK7W PN8f8Wuu9T3gREjmkwuSFhK7Gw/ZW097trGmjDa08yfpzZXmPkYTCD44Z1TSKBmPX3WBSPeu2vY hwyx3hpSUEVgP/DZ0lGX6O X-Google-Smtp-Source: AGHT+IEf4rn/YGj/XrmQfH/DUtip6Yk+lqBTTCh9YWRX30erKjKuTXT6Tdc+oQtXqJZ+Nw9ORBlAry0gV3ZCDGnL8Qs= X-Received: by 2002:ac8:59cc:0:b0:480:1561:837f with SMTP id d75a77b69052e-49452cae732mr5183091cf.8.1746804494901; Fri, 09 May 2025 08:28:14 -0700 (PDT) MIME-Version: 1.0 References: <20250429014754.1479118-1-Liam.Howlett@oracle.com> In-Reply-To: From: Suren Baghdasaryan Date: Fri, 9 May 2025 08:28:03 -0700 X-Gm-Features: AX0GCFuOglRGV1A6avdyhNrn378-Ve7Y2mRC2kJuq8A5ZPWpN6wHWrZjijO6HaY Message-ID: Subject: Re: [RFC PATCH v6.6] maple_tree: Fix MA_STATE_PREALLOC flag in mas_preallocate() To: "Liam R. Howlett" , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , Hailong Liu , Lorenzo Stoakes , Suren Baghdasaryan , "zhangpeng . 00 @ bytedance . com" , Steve Kang , Matthew Wilcox , Sidhartha Kumar Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 1x5hndwwjtuf94kaugka8b8midnjy9ps X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5D39910000C X-Rspam-User: X-HE-Tag: 1746804496-585302 X-HE-Meta: U2FsdGVkX18JnPGi+VDTve6uFy+Oir8hVy3bYlyJjJu9jx4wpO3IiCW++/TYbPw8+fAMFER8GptxR+9mfRAQXfPV5c987Y1KmLEMuL7l99Qh7RMZzOr0hY/3Pgyq56ujJf9Lyn+9BH6eJ9qg1lcq47Z4eAyI4GtoKLpfpWU8xJoSSRZGG6CrIVzZiShagbh27s6TDEUoXRjDeANXY8C9gInxkecXsyZoA4gVzPBlKVlpN2cAoKUM/9I2IIb4INGjpTSi3tKxra3S1oj9vAmOmfJwF/xjeWUat+zT6CATlJmasnfnUMm8rTEwnczDCgygigytLUHMYGSXx77jkc4IcLFihKTBqg6+y8kUJwMvtKpjjLjJg2hYkUBZWYohsIufXqtqCXisAExDXyaDEb9Ux6w9ApoMWTNCH9ywlz7nxMoZ0D2NC/0snUOmVTXtvHAMZQMP8RKmvodXgPycxk6op+UOS1CxanUpr92G+1OAcCC9vV5c90+d7fW433tjeszXu1zRVMaSE08c5+QC+UqvGiuqh3i4jtirs6C0c8II+xozk8aLrC0LOt/kwBgSV92lOAk5vUA5WsqQj8PkZ30Y01oPIQ010Xn6qKoF3H7e9n4DDNAmT5JbNUb2UMrtcwgaA68e+jfNxQWgEkFOMq+WEnuw1GBzwZAKHiIhMSIK5fmeJ7rMy7HyEyeUYiSagv8EpTizqdDssvLoCd8WwIKNL0uQ3zUuTIqpkWd75SF8dnd7QFcblwMlaH82nvhn25jnRzFP9ZY06l65b+f7pkSMnUpQNEXuBcDRQL1AdWhoPLAqyEGmkarwpV1g7gftatEzRSqwV+N3soYW89QbgDblmIzaZd6hshdqSVwRV07wCgtn+zG9VKQNsp6eqCsJLIJvWyawft4SJUMEHzOMSgXtZZkT4VYpjCL+GoeujUpF6jcXA+xwB48vdf7Lo/uKh/2XXLH6gjznJUbH2J6OCHp DdUpT7Fb rBIfTK5838Y0DSI/DVPKU9DqrGYZkg1XtUzI5Exqq6/osUAnaEVPdTrJeO/DO7VyroQ7Ta9L+ff5ig/jR8Xti3+Cmu2ov0nUJkjRxjuCGX0+yG7wUxyEry1QIqf/v1TLuon38GQ+ksqNVR4b9FuzRMMPW1NpgwTXRsOnShTHq68nptTMnMO1uJfXJbaAFoInA9cWOP1YG7gPcEx1K/t39SkBTkVR+1W89d57EZF+uGMGry+9Hqx9+0Rp0fIVX/yeMHpsaitch2KeYWiZNUmgMwDH+preZVVBfsGrM/V1Q5n2YFO5C+nXnf7Z6mc1/nNBKfSx2vsMJWeIYOViLa25jxhhTBAjMJblUDlIFh463TieaNLdgqt5l5yOUd5+lRl54Sy1HgDKsAbI4wrzMmdcaQVgmVuCc6o56HxbqoMVTOYSqrsKtKIKhPQZqWmvUcN4HWpNG1d7yESrIqWuSa4pCPY3aKbUgi7qXMNda X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 9, 2025 at 8:27=E2=80=AFAM Suren Baghdasaryan wrote: > > On Wed, May 7, 2025 at 8:50=E2=80=AFAM Liam R. Howlett wrote: > > > > * Liam R. Howlett [250428 21:48]: > > > Temporarily clear the preallocation flag when explicitly requesting > > > allocations. Pre-existing allocations are already counted against th= e > > > request through mas_node_count_gfp(), but the allocations will not > > > happen if the MA_STATE_PREALLOC flag is set. This flag is meant to > > > avoid re-allocating in bulk allocation mode, and to detect issues wit= h > > > preallocation calculations. > > > > > > The MA_STATE_PREALLOC flag should also always be set on zero allocati= ons > > > so that detection of underflow allocations will print a WARN_ON() dur= ing > > > consumption. > > > > > > User visible effect of this flaw is a WARN_ON() followed by a null > > > pointer dereference when subsequent requests for larger number of nod= es > > > is ignored, such as the vma merge retry in mmap_region() caused by > > > drivers altering the vma flags. > > > > > > Reported-by: Zhaoyang Huang > > > Reported-by: Hailong Liu > > > Fixes: 54a611b605901 ("Maple Tree: add new data structure") > > > Link: https://lore.kernel.org/all/1652f7eb-a51b-4fee-8058-c73af63bacd= 1@oppo.com/ > > > Link: https://lore.kernel.org/all/20250428184058.1416274-1-Liam.Howle= tt@oracle.com/ > > > Cc: Lorenzo Stoakes > > > Cc: Suren Baghdasaryan > > > Cc: Hailong Liu > > > Cc: zhangpeng.00@bytedance.com > > > Cc: Steve Kang > > > Cc: Matthew Wilcox > > > Cc: Sidhartha Kumar > > > Signed-off-by: Liam R. Howlett > > > > ... > > > > I have a version of this for mm-new and I'd like to send it out. Once > > this is upstream, it will be backported to the stable kernels with > > something that looks a lot like what I sent out here. > > > > Did this fix the issue in the longer running tests? > > - everyone else and of course I forgot to remove everyone else :) Sorry for the spam. > > Hi Liam, > I think the delay is due to the holidays in China. I requested an > update from the partners but they will probably provide it next week. > Thanks, > Suren. > > > > > Thanks, > > Liam