From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25F51C48BF6 for ; Mon, 26 Feb 2024 17:49:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8588F44018D; Mon, 26 Feb 2024 12:49:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DF0744017F; Mon, 26 Feb 2024 12:49:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 657A544018D; Mon, 26 Feb 2024 12:49:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4D14A44017F for ; Mon, 26 Feb 2024 12:49:06 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 19C4F1408D0 for ; Mon, 26 Feb 2024 17:49:06 +0000 (UTC) X-FDA: 81834691092.15.5C34503 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf03.hostedemail.com (Postfix) with ESMTP id 3CFBF20009 for ; Mon, 26 Feb 2024 17:49:03 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=R1a3Pb5l; spf=pass (imf03.hostedemail.com: domain of surenb@google.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708969744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E2MfOrnw8vcrCKgg1+LRA9aXdiQ7KcRVPoPiOl2oNZk=; b=LXZG9cTsjVCMOHYcVDVQtLU/NHIOuwnahjSWKPvqmAnuxW9lFkviACjZQSwLdctWfhkvL5 2WlgDeSgdT58oMNmffFAu3IzQ+CWJBBGNC4CPVlQ0ZClvD0T3tdzkc4HmEHnZclk5+GNnz IlwF3xCvlQ481X4//jh6jbK1+Y3Iu6Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708969744; a=rsa-sha256; cv=none; b=uEJjDzmPd73kc28lzYx2qeQ8Zy0gthY+y04Ngmlac0jqW5py9ilDMwhsQB1aT8eD7MxvzE mmjFCkWPXTl6/YL7Gsd+6Y/xe3ptxmYoyDMc3mDRV6ygNjcUYJ6Rlcl6NYXPlYhQmoXxF7 mdOqSV6YWyUthvsZDOw5UyDIrTnXFk8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=R1a3Pb5l; spf=pass (imf03.hostedemail.com: domain of surenb@google.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2d094bc2244so39060041fa.1 for ; Mon, 26 Feb 2024 09:49:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708969742; x=1709574542; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=E2MfOrnw8vcrCKgg1+LRA9aXdiQ7KcRVPoPiOl2oNZk=; b=R1a3Pb5lBsIlQbh5exulOwTbjFDu3qyGPOUbq2DQh4T7LIZap5GpLp6eOfPUbbhphm W+pzhrbhzwUZH14LoTtyHC3PwkzEo7dqBXn8rnrqrtdA/Ry3/2cajYQrO6zbpSjOYU/p qDeHcz7FUmnvQODCTMV1fT6NK9XvOYa9iDqyQYh+H/9+iSYsC841l7zeBz8fHY7exmUR IQ7D44Q/2GsJXzY9DMmC+FoM/RTw5Nyxw2SvOh3mXUqRVdiZXYkTjAbLgeWtzylVJsX9 GJu2CL2TX2CCnHq4ETw9UcmyxFutc458tiCI/S+41w7HplUwVicnHu0906sB3XTlNMip PxMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708969742; x=1709574542; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E2MfOrnw8vcrCKgg1+LRA9aXdiQ7KcRVPoPiOl2oNZk=; b=aaXXjvkwSLQlmnn7fh7fWWntp51Hi+NGjkvmHB1oSI30K/NIKQIKLop0lTUUbj0MrM NKJ9mEwaqTXLky0lWEXvPmRoU+53KwRbI6Hlsx70pI330Jegg5rfdKwYpUUZN/J6AXbR 1MnB2uW2ZdtDt5VwTysU1RNSkdQAljHDs73S7sjm12I/P1tIDB15ZOc7j8kQLjsu1+GL XZfaMPNCCTPX7y96XxQrzGIbYL7CXMdUnOKM3MkDUo/aCnCgG96wvHOJ8CqeKehhvAG0 3exbgVHA+TK+jykpYkynBpVXXIsa0POXBZNuKqpJs4A7MNTxW47VFdl/B6XxMjzpvQMk 2wkA== X-Forwarded-Encrypted: i=1; AJvYcCXJC199pjlq8loHWt0QNNOe6mSxe3/HunGK7jIT1DMcxggJhmhpCk59YWxoiq3M7BclINZf4k1nYjuUzig4UORp7dw= X-Gm-Message-State: AOJu0YyUGA2CMJ1Ro595RMhiNb350gukdhQhReJIZ3cBp5u3ApCyOf0K uvRNDX1SaMvlxEP0ZVKUEcyIBwR+JNE1QB+WHdO2EB+mwu2F2QQHMh2qTxzrBlJon9FTi6qjL9H PipDJA0HzzqaAxABqXNqeKjzoCNyjLC/O1/mQ X-Google-Smtp-Source: AGHT+IGMkZ+7cEJwol9OFFnPnlkwO7m64F/71T4BMwZRitgeDSyoz1rib12v0dNYQtXiC2DOXiB0AGgmNnmExOErSa0= X-Received: by 2002:a2e:b889:0:b0:2d2:6676:3b0f with SMTP id r9-20020a2eb889000000b002d266763b0fmr6282519ljp.22.1708969741996; Mon, 26 Feb 2024 09:49:01 -0800 (PST) MIME-Version: 1.0 References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-6-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 26 Feb 2024 09:48:46 -0800 Message-ID: Subject: Re: [PATCH v4 05/36] fs: Convert alloc_inode_sb() to a macro To: Vlastimil Babka Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Alexander Viro Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: sjyidpyrcur3bo4xizxwfq4qt1y9d6jb X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3CFBF20009 X-Rspam-User: X-HE-Tag: 1708969743-862419 X-HE-Meta: U2FsdGVkX1+XbMbY1jG2kDmY9kZyOyxv/YTOsnQ4+14W7kzcaWiRvkiIs+lezzlhd3k/Yu8qP+/09PZo2a4+jjrMLA4jL5+VE5tDOmAt9HZ23JjB15br+pOaqoDVKTnzF2a4AVApny0qUUQVuL7OOWUwcMYY0mddAOGSk6iKjavyTSmYeLH9c7lpKZ1Ol0SIe2XGgpmk2sLJ+vTKzcQ+VeGV4XOwa/bRQA4RhseF+530RWZ8gBjXzZgofHMvgtzvontf+yXhNCpRrc1lKPewRLFRB67pn2PqvhpixNM91gQ6MXBHDSwhrIMVa5H+3kAd28oh0kspWTMoFaUJ2Oz/z1q1zwi06C4eDr61oqAudysf2OqTlSqNscIXUo+27SwJoU0yoT63PELf9WacvojryfMhGewW6w2SWs7eT98mKGLP1FG7g/rS2jDpiUyc9iqJAf9WO74NQA+ABkw0W+Zg+D15WIenyPEbY8o2BuvGS+nPeSnFte4R4RXFFpefrpHk1D0o0JuMip1OLBx9cUhcaW99FXFEtguxoFHlzWyhE91KZfS7g5ARDVvnalolb8AyNg5K7zi8JYO2Yc6+2q3pX76g4MXIRgTdg1x01qS8AD51p0ccjIM2E+mtaRYeSVnFrkf/1chLIDKGIZ9zbelyJ/muMIeGf+aOsN9liDtcXcCIbiwyOCQKA4ZiaDg5MmStPTjTLssTysWI4h8WKY374nHwnTuEjvs51BfxUH6yKNyyTxI5EHxjfUCgkq7YZOGfWnGmBQip3IscPbiSXDQHi4ERi0rV0WsQ7yidFvlC338Qzd1BhUGToetOUbnYWh0FRWMvDp++E1xTh2lFsgHPY+oBwZnTbGdm4nuBp2wbeOfjESJFn7bX4f5M6plpKC54VV+VMTEwyypYRy0LspLlty+pmRe5w60Wr7GAqOBtovF98ph/uegV5Np4Mws/HUSJdpNdKeRKVzcafVE9KId UeW1Tror wYO5DNjoOsydRpEYXGwA3QxmVfw3mK9Fy/o2yagQZsPj9WBagcqWlM0inNaGgG2qzexzEq/TCa9nlPkezWjGkIcEO0HGd6uUuoBq6Ag0Gh20V41DXiXb776uLXA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 7:44=E2=80=AFAM Vlastimil Babka wr= ote: > > On 2/21/24 20:40, Suren Baghdasaryan wrote: > > From: Kent Overstreet > > > > We're introducing alloc tagging, which tracks memory allocations by > > callsite. Converting alloc_inode_sb() to a macro means allocations will > > be tracked by its caller, which is a bit more useful. > > > > Signed-off-by: Kent Overstreet > > Signed-off-by: Suren Baghdasaryan > > Cc: Alexander Viro > > Reviewed-by: Kees Cook > > --- > > include/linux/fs.h | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/include/linux/fs.h b/include/linux/fs.h > > index 023f37c60709..08d8246399c3 100644 > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -3010,11 +3010,7 @@ int setattr_should_drop_sgid(struct mnt_idmap *i= dmap, > > * This must be used for allocating filesystems specific inodes to set > > * up the inode reclaim context correctly. > > */ > > -static inline void * > > -alloc_inode_sb(struct super_block *sb, struct kmem_cache *cache, gfp_t= gfp) > > A __always_inline wouldn't have the same effect? Just wondering. I think inlining it would still keep __LINE__ and __FILE__ pointing to this location in the header instead of the location where the call happens. If we change alloc_inode_sb() to inline we will have to wrap it with alloc_hook() and call kmem_cache_alloc_lru_noprof() inside it. Doable but this change seems much simpler. > > > -{ > > - return kmem_cache_alloc_lru(cache, &sb->s_inode_lru, gfp); > > -} > > +#define alloc_inode_sb(_sb, _cache, _gfp) kmem_cache_alloc_lru(_cache,= &_sb->s_inode_lru, _gfp) > > > > extern void __insert_inode_hash(struct inode *, unsigned long hashval)= ; > > static inline void insert_inode_hash(struct inode *inode) > > -- > To unsubscribe from this group and stop receiving emails from it, send an= email to kernel-team+unsubscribe@android.com. >