From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93258C47258 for ; Wed, 31 Jan 2024 18:03:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10CD26B0099; Wed, 31 Jan 2024 13:03:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BD8C6B009A; Wed, 31 Jan 2024 13:03:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC7216B009B; Wed, 31 Jan 2024 13:03:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D9DB36B0099 for ; Wed, 31 Jan 2024 13:03:35 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 874AC808C0 for ; Wed, 31 Jan 2024 18:03:35 +0000 (UTC) X-FDA: 81740378790.30.3235AB9 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by imf10.hostedemail.com (Postfix) with ESMTP id 95A5FC0016 for ; Wed, 31 Jan 2024 18:03:33 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=bjlsfBgW; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of surenb@google.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706724213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JbR5C7qXmrPANeKESbR7Tb/koJLQDFXIVDj0fA4f4cU=; b=k+1wqFEo1BhT8eMXRlDggiJCt5i+efjQ8ANh9e8bPKZMTbZcUUbAncBRHT9R/F9GOh19UO 9x2zvn5wiQXkwskntrNZCjGPNYELSqRIMMAZFViYUXDkWvYQ9e3/OC81moKk5uqzR2CcH/ DtwjXp3RPOm+ukdGrMuDHmm01nAvSrw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=bjlsfBgW; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of surenb@google.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706724213; a=rsa-sha256; cv=none; b=H0JjXfA0PK3RzFbwAgOeN47Budb78GB4P9aXh3J4GCUCCk4TnZgiZOvZZKarpMVxz26tdw rwWNry71ksXikFGHfn1d3HDEeEj1b7uHRltKjdxGDaLCdqguI8+qqh7GZuIq6p+GJUjw6H OSK5cdugsgJ7Y6YNQAGN6IuDHkFegdg= Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-6041012c81fso501987b3.0 for ; Wed, 31 Jan 2024 10:03:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706724212; x=1707329012; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JbR5C7qXmrPANeKESbR7Tb/koJLQDFXIVDj0fA4f4cU=; b=bjlsfBgWKQwJhhRqJKJ40vnQT/Qq4Kl6dCdrFxhWxIKSssI9mA9E95p4xgJJcZXb9F F717aOdEdBPcX4AOC/+Ar3dlrlwxZuETI0XCeFa4o4hl5ynLAgbTrat04T7OeKm9Jaax ImrS3PByZenO+QIgbf5AwqfQdUTLEs+OuiYTJFfResw9+YoMY8OdtfepUOyWzxyRKwWl eQgBZf5HgIMfyV40IP5YlIH4gnCQo0Q+NsyT96sjgE2TETsCkQ6loNVvx5hqHBCNCM2Q FlvmQC2dggdOqsfF+BGuySwyNlI6croLStgTQSJ5Nlv2S7HRaFcXPatI7FlKBuPdr2Vk WumQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706724212; x=1707329012; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JbR5C7qXmrPANeKESbR7Tb/koJLQDFXIVDj0fA4f4cU=; b=OV1aj7b1Rw98fa0fAKEryY3eP//r3Rm2oeUNN/UIPbwSnETwy4viziB7PzCNVSca1q FKxcTxtTISjsoC6TiB51YrF/YT8rh7tnYHoIUparSGO36xOaPDauUTp0+sZoC4ksCvKx 0LMXfUPWzt3MYaJs5o2GYKz9+E/Iofo0+aWG4QL8rT33KsBxNfmADJWDJqC9sDf3aFtp +anJM9K8cDnxhemKcdkmjE+c3tRzXMgT/+KKqdIzidw7laoVcOq5i5hoep+ssRKNC+Oc YWUGYFYnQoteIuWpaV5ozIYDOHaR84Zql2bALtsP2leJaZ/hSYEMqp+YFqx3SQaI2HoV /HPQ== X-Gm-Message-State: AOJu0Yy9ahNNF1jc4WNAdvxSNfGCYLTg1P6UbiGE5/4LmLtUowbVC5bl a+TWcY/vb2pQhG53+7i5MtHn6DEcP0Qga4MY2AiJXo28B7LHprllXwj1wpa59dcp6G6tsWe542Q nX+zzLfEcYM53Gk2fsj4oOS+PRHG2jICs2qI+ X-Google-Smtp-Source: AGHT+IHvG+sScMoNbZKThgAlHEduCUX9gM07y6FFnNiqKwsYRY1SQqqF6IGpHWdV+3UMD/zGuBruw4MCk8bktvSDagM= X-Received: by 2002:a0d:eb48:0:b0:604:1709:a5f9 with SMTP id u69-20020a0deb48000000b006041709a5f9mr868796ywe.18.1706724212303; Wed, 31 Jan 2024 10:03:32 -0800 (PST) MIME-Version: 1.0 References: <1a42e4fc-54a0-49f1-94ba-f075e0ef29a8@moroto.mountain> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 31 Jan 2024 10:03:21 -0800 Message-ID: Subject: Re: [linux-next:master 2565/2825] mm/userfaultfd.c:983 move_zeropage_pte() warn: inconsistent returns 'dst_ptl'. To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 95A5FC0016 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: iijw88wjoyn394rahusccirc8zmzj91g X-HE-Tag: 1706724213-170169 X-HE-Meta: U2FsdGVkX1/W/dil7CeIO0cvPR7hjbPZZO5q84WAApqYGRimnXuqsA3lS/vJx64V74jYxgkota7LBo6dcUr37LWT10PSUk173/FqCWMTz7mKZIB2rYfRiI9T7jQCeYSBQxvq/Jm83E16Teuq8OjrdyLdbAFRi7MQxRvap89astYw0Yt6wGxMs+CbJyMAdZ1d3WsnsRGoH6xLh7+PcMbPykw78nlFQUSvhysvIXRe3kYiFKmr4wFM47NmgY6LI1lBcF2jJ3OsB+h0s5HjnJML9jHUe4gWQSvj5LQPxajXMvcJk9SVamglhpAs6ndnHZbP/xDF+EN5ykz/mHDeMBvVyhUqUD6BM3fGBH7HcBMZrKwCVx40L7ixe+0WdCvDuBZLerw0tsToKjq9RH8poKKpJ31eBu8IlWZzEfFveG0BgbOHXXnMD8Q7MReuEiF/4MT3haG2pWqu3K3EUlNPMF73hOEexKw+f0yZbpqlgJCa6yOpdYjHdITuzylrEFrSnAfaWGmuaWZQSiOl5TmIr+8mWLeuB9UffNSoOG/NfPZuagPS0CTUy01bWRpeQ7y9j4WjZGMEMkWpfldOuChnRp8h7hTkOGoYfWmspM1SWVrqGARbrd2VoGBET33AkWdfV1X9/NL1AT/9slaZ+7bQ9Bfb0G7PjZ04YHLVt30txKp+T/RVJtnXixxYjgM4yrxqI08rIzfvccIy2jrojnxMaxGIU4QfBgkEyIdGeEhc+kSXk6CUfC7D7CR4jO4OR/2+7QFJFEvMj2/gH6D1czz/nOoHtLpHjoDu80bNnmoROn7M/GeuRATeG144LVS/zGrX4AtaHLYk6Aouop6rVozJcTDXjCTaLAAjyAiMmIU875xF09Ha7HSwY/iE6zIujsw2cX1Nc8j7RpX7jtHBwRob1ojf/xxifKWeqnuayoaGKv4LnfIeukM0iTyVNXHthIS6qPoKRZW2Jt70Jg7W6EHGcLA Gj1zMZ9j vYv4HQy6h9mwSfZd9uAB5DZwhgo74v+psV55O+XA123KjWyeKMHL6QeG4uxFnvugenijvYM7K1JTSQTIpllKogEI7QXkXJlgyogYFXr00Co31/uFK/QT8FAy2vCP6fFJGkzgaTzZ3SY3oGyaLZwZcM0N9crGEccp9yE2Cx9/Th6bXFz+AQRC36hQ3NILpE8clnQf1hxkt9ch4QvTGLMfg0qFyYH5BFNYP2a6CL6jWX4dSQ1uQwhsOEM+cT43FP0X3cizJ2CqSsVzfSpS2Dk1WbqYUn0YsDM7mLWNLonIlyUnyslAEIMZX7v0LcfKLlD/+kaLytDPpfolEltoH+qBg7UQkC6zH/dDp3VjxN517qvuK+O63Gs8nNkVqRVky59fgxwaP2ehMmHSR4ayNdqxmjISRE+KPfOzUJfnCUz13ZutTuKmdP+NyLo+4DOUq4XRYPAEOpMpaOGMM4nrU7l0vUjbpin7lwoerzfpWWWM6d/ZdZIoSaGzPIqTnrzOxosyPkR8CdOPjUj98EMQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 30, 2024 at 6:37=E2=80=AFPM Suren Baghdasaryan wrote: > > On Mon, Jan 29, 2024 at 9:13=E2=80=AFPM Dan Carpenter wrote: > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git master > > head: 596764183be8ebb13352b281a442a1f1151c9b06 > > commit: ea4df6a5ea81105879ca5549555e231c4596fbc4 [2565/2825] userfaultf= d: handle zeropage moves by UFFDIO_MOVE > > config: x86_64-randconfig-161-20240129 (https://download.01.org/0day-ci= /archive/20240130/202401300107.U8iMAkTl-lkp@intel.com/config) > > compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 > > > > If you fix the issue in a separate patch/commit (i.e. not just a new ve= rsion of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Reported-by: Dan Carpenter > > | Closes: https://lore.kernel.org/r/202401300107.U8iMAkTl-lkp@intel.com= / > > > > smatch warnings: > > mm/userfaultfd.c:983 move_zeropage_pte() warn: inconsistent returns 'ds= t_ptl'. > > > > vim +/dst_ptl +983 mm/userfaultfd.c > > > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 962 static int move_zero= page_pte(struct mm_struct *mm, > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 963 = struct vm_area_struct *dst_vma, > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 964 = struct vm_area_struct *src_vma, > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 965 = unsigned long dst_addr, unsigned long src_addr, > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 966 = pte_t *dst_pte, pte_t *src_pte, > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 967 = pte_t orig_dst_pte, pte_t orig_src_pte, > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 968 = spinlock_t *dst_ptl, spinlock_t *src_ptl) > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 969 { > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 970 pte_t zero_pte; > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 971 > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 972 double_pt_lock(= dst_ptl, src_ptl); > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 973 if (!pte_same(p= tep_get(src_pte), orig_src_pte) || > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 974 !pte_same(p= tep_get(dst_pte), orig_dst_pte)) > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 975 return = -EAGAIN; > > > > double_pt_unlock(dst_ptl, src_ptl) before returning? > > Thanks for reporting and sorry for the delay! > Yes, this is definitely a bug. I'll post a fix tomorrow morning. Fixed version v2 is posted: https://lore.kernel.org/all/20240131175618.2417291-1-surenb@google.com/ > Thanks, > Suren. > > > > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 976 > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 977 zero_pte =3D pt= e_mkspecial(pfn_pte(my_zero_pfn(dst_addr), > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 978 = dst_vma->vm_page_prot)); > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 979 ptep_clear_flus= h(src_vma, src_addr, src_pte); > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 980 set_pte_at(mm, = dst_addr, dst_pte, zero_pte); > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 981 double_pt_unloc= k(dst_ptl, src_ptl); > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 982 > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 @983 return 0; > > ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 984 } > > > > -- > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests/wiki > >