From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 520BAEB64DA for ; Thu, 6 Jul 2023 01:17:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E20D88D0003; Wed, 5 Jul 2023 21:17:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA9538D0001; Wed, 5 Jul 2023 21:17:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4A898D0003; Wed, 5 Jul 2023 21:17:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B451D8D0001 for ; Wed, 5 Jul 2023 21:17:02 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 829A68045B for ; Thu, 6 Jul 2023 01:17:02 +0000 (UTC) X-FDA: 80979423084.18.12602F9 Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by imf13.hostedemail.com (Postfix) with ESMTP id B031620002 for ; Thu, 6 Jul 2023 01:17:00 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=uH4U4iCZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688606220; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/Sb08cFWgrv3wGlfRFRn6zfHbCpEJzACO/MXH/nqfSo=; b=dNrz2sbAXaSeMv0paxM3ZyIAK/oO40xctAc32K2Bh4PTGAhzZMB5gSLMYy3vzj34UAmehf feruz3J1iAP57Waj1D2gxJ82p67Hbh6qLVrzRCsh0fuUMbX970gjymG2DYrM7v5Cd8uOaG 1Ykw2t+naETQ49ypmmvc6wneZMxOGLs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=uH4U4iCZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of surenb@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688606220; a=rsa-sha256; cv=none; b=z/TI0WtuPN9xA7ar5fhG7IX3Cx/D58iFF2nLBYVb9cccPk60Ipw2exXYuo7iSGiLLB5gEX /n3fb0VZoaFW//IbSDQ6rqOc+y1v492WUudg5BuQjMxdcowW76L8bVZ7ZSsGiIL/fPgEsR WkSpY6hAV5n7OpU0BdnZQ80uwUVE/Hs= Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-bacf685150cso109968276.3 for ; Wed, 05 Jul 2023 18:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688606219; x=1691198219; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/Sb08cFWgrv3wGlfRFRn6zfHbCpEJzACO/MXH/nqfSo=; b=uH4U4iCZ5BA9AW1gHcHpSugIZ7KluY0dTkOmcNZqfd06T2Oso+DF601AaV7geuZk1a 5Wj7ReroDQKjEvQXs42RZ/WoIYfgtS2XflvvoRCcb7tF6EU7/WS9rL/xr+C6jM4F3MxZ fl89BHVgVZT1pnNZu/SlzteXyRVu1aqygIYtFXEfDBLAAXSFRKOXwa4AZtd0J/R374hT 91Q9tfeoX2ISwOl9ZwTU7B+m5SFlaAddVcLdnB9TitQW4IHsqxK1+6t8E7wQ5CfN7rhs B0K1TWwjH+YY1C+GC/Jly4rV5HUSHIbziTv5a+zRBzD1BdnirWModMvd5+Lby37MMQce gh0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688606219; x=1691198219; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Sb08cFWgrv3wGlfRFRn6zfHbCpEJzACO/MXH/nqfSo=; b=gob+1cnlitzIZ1PWJZjaFcTYo3hOpeQr7U2kM6KUoZsjFB3XRpQ/uYOgkyoVHlQmwe HcorUK01TV08M7JuLzBtRTmdBLyQ04oT9qVRSqtdsziMlRokE/lTm43qNiHbVb8nhZLr soy3wfIraHn1aQXua67IEkU3F88CzxzD+37xkotKYmm2C/Ew3dqTl6ZJ9ExG3qFEVgYg QkN4QUFz0RC3/CblFeQlII3X3O7tlj1PbGXLUvfLUjOpPGP6cdSk6N4Jg9kOQlHsvyIE ZVtY5PNHQAtPbcyYvhqdZwtha72sLWjxqsORtrEke11LUWS52ycVUOGUqpZPWHX25XK8 IDmg== X-Gm-Message-State: ABy/qLbN9tH+o9jEwZHAzeNJQQosD/flbLNOet2d/9jpIEc1WmLFOFh3 5hMTL13uOBAOxTM9V6IBLT3D8+LpskMtAiAA5Izlgg== X-Google-Smtp-Source: APBJJlFV9NZNjmlo5zt2nLV7CJf7Oaffqx/acpr3b5jQNuT+4E+yTFrYTvwia1Q3dRHZVJzSNFxi7PrmxXP86KjUHyo= X-Received: by 2002:a25:98c6:0:b0:c0b:7483:5cdb with SMTP id m6-20020a2598c6000000b00c0b74835cdbmr401542ybo.35.1688606219462; Wed, 05 Jul 2023 18:16:59 -0700 (PDT) MIME-Version: 1.0 References: <20230705171213.2843068-1-surenb@google.com> <20230705171213.2843068-3-surenb@google.com> <3cdaa7d4-1293-3806-05ce-6b7fc4382458@redhat.com> <20230705172424.e505f5013bfdf44543d9c6be@linux-foundation.org> <20230705174440.9adb53f2e362056867135b84@linux-foundation.org> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 5 Jul 2023 18:16:48 -0700 Message-ID: Subject: Re: [PATCH v3 2/2] mm: disable CONFIG_PER_VMA_LOCK until its fixed To: Andrew Morton Cc: Peter Xu , David Hildenbrand , jirislaby@kernel.org, jacobly.alt@gmail.com, holger@applied-asynchrony.com, hdegoede@redhat.com, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B031620002 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: newnx6ntpcpd7cyckrz3w6eiay1ie7pt X-HE-Tag: 1688606220-144880 X-HE-Meta: U2FsdGVkX1/KQLzAgnQV3vio/OtbU65NNO0K5g5DJ1GyTpiuoZvwxxY+OFdXVWZyofQO13tgYTHeTsG5Fgmhnj0JBxBSTTV1lev2dzXHoVJ/m6tt+o+TwcPqbfR5TkScHZYDzAhwuEIy6HdEStboDVIzcrppyweLe/IH5mHWqe4I9Kbi3Rcg5BNIzJucaBSwtM0i8g88ko1d5dHPmIO/ijIE0t3w4jrGGbgL4IDKcS6nTiZcUOVxijCMjluAfQkNqMTiB4y909suXqTRcbj/HH0W/JQeMV8QaIkdpidApj+3hJSVzx/D97bE2TgEqhbEEyWg36GvO/Xx+yX2XJ+J3IIWCI74kI/pNiCybslUl1fHNsQeBMbrehjxuoJ5kNdEAwAGCxm/hUJLEVeQED3T6ICx3PUM/au0IgVfy72oILgUBDIUOT68J3/vc9Q+waTwznl/r+ZBR5sQgW/2WggzyIljwhg4PWa1ZHwD4fwIWopwc9giaI7gTrGr45FV34rFSk8sKUWS6VO5c8Kx/n9cm/ws1hwWF6J0CpSMa0nXVnkfEFL2u9jEL3RQUTKjaegeM/4m6dQ+mriAiNTYSDNKD+wQdla1qEkmJtfigFiiJgsxxJYsB/xgIrBBlyDwLvtiW0sc0H0g+zrAJxt0ZVdJqB5xCXpB30YMF9/0OoyznHQVGNB8P2d7w+AKBmPRiGJP1pNl/2X9zEmEeyMoXdnIZdOA4rpJz8XU/e9ijfYL7UtCjfItTXfkyv5CnoUzp4OULeuI7FBbRoj0CzQ/RpMGp31FjGLhb5E5tpe/49HfnNdH4ZEgpk6LhqRiZrkIP5GknZErHHdm4I6o3yZa6AkrNuXSTJcp5moukemyiQFrhnQsWJypbchCJRnzaV8+DAUamx9KDNrS7sZ9YmPUo0el3ROV0Vba0DqOK/h94MO8Ej5/0CrIKHsc9iCal0WykXjrit6Zq672pRWv+9J9tTH Xu1OqM+c G5w3iz8CJfD0iQcWZIMqEKDtt3UC0hw4mMMtu18njZKlsimwwCOGqOCfK+2gFcpdI1teC9JS6qmEAoEvBXaZxkXx7ZSiPnkXk/MlImGny8sAjrjd9a7Qh8FQiTRDEbUDtT76OMydRcE8XIZJJBI6GroCH4ckEXYkLYyyOey7QlYeLA9Me58PP/hZ9y4B2nLBlvyF3izBoTzQVxENh3P69zOC1xearztyR4jIGLzZype4Xkc6LLo+my4kBJN6Ios4rbKWAKNCl56XPNl2RiXIlIjaQ4nxy9rpJ71K3oPNAc/bOxmzvcZoXTOx+eTge0ZmBZ1eZDTBrox0rIMUZOwo4WdSgQaKpuNnOsq+9/RWJyubFmCS74Qc2xtgp565Swq5UKFo8OlBLNwN1OiNgdB50ihedlqjcK28VkC4/m4H7ugvmrOuF8DvSR7SDC3qWSix4zheypJFLy2zwuTBJiwdq6+wGXy/ckJHonhRGL99tLW4ARh4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 5, 2023 at 5:49=E2=80=AFPM Suren Baghdasaryan wrote: > > On Wed, Jul 5, 2023 at 5:44=E2=80=AFPM Andrew Morton wrote: > > > > On Wed, 5 Jul 2023 17:32:09 -0700 Suren Baghdasaryan wrote: > > > > > On Wed, Jul 5, 2023 at 5:30=E2=80=AFPM Suren Baghdasaryan wrote: > > > > > > > > On Wed, Jul 5, 2023 at 5:24=E2=80=AFPM Andrew Morton wrote: > > > > > > > > > > On Wed, 5 Jul 2023 13:33:26 -0700 Suren Baghdasaryan wrote: > > > > > > > > > > > I was hoping we could re-enable VMA locks in 6.4 once we get mo= re > > > > > > confirmations that the problem is gone. Is that not possible on= ce the > > > > > > BROKEN dependency is merged? > > > > > > > > > > I think "no". By doing this we're effectively backporting a mino= r > > > > > performance optimization, which isn't a thing we'd normally do. > > > > > > > > In that case, maybe for 6.4 we send the fix and only disable it by > > > > default without marking BROKEN? That way we still have a way to ena= ble > > > > it if desired? > > > > > > I'm preparing the next version with Liam's corrections. If the above > > > option I suggested is acceptable I can send a modified second patch > > > which would not have BROKEN dependency. > > > > I think just mark it broken and move on. At some later time we can > > consider backporting the fixes into 6.4.x and reenabling, but I don't > > think it's likely that we'll do this. > > Uh, ok. I'll send the next version shortly with the patch fixing the > issue and another one marking it BROKEN. Hopefully in the next version > we can roll it our more carefully, removing BROKEN dependency but > keeping it disabled by default? v4 is posted at https://lore.kernel.org/all/20230706011400.2949242-1-surenb@google.com/ Thanks, Suren. > > >