From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F100C636C9 for ; Wed, 21 Jul 2021 15:43:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA06461221 for ; Wed, 21 Jul 2021 15:43:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA06461221 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 54B416B0081; Wed, 21 Jul 2021 11:43:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D3D06B0088; Wed, 21 Jul 2021 11:43:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 374556B0089; Wed, 21 Jul 2021 11:43:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 179BB6B0081 for ; Wed, 21 Jul 2021 11:43:32 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B3DE7181B04B5 for ; Wed, 21 Jul 2021 15:43:31 +0000 (UTC) X-FDA: 78387014622.15.D2729AA Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf30.hostedemail.com (Postfix) with ESMTP id 61164E0085E0 for ; Wed, 21 Jul 2021 15:43:31 +0000 (UTC) Received: by mail-yb1-f174.google.com with SMTP id c16so3850654ybl.9 for ; Wed, 21 Jul 2021 08:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sSQuChGU6tQxqfm5TWusep8hq6ZmIB+zOQ9/zhsm9m0=; b=RLnulxEIKc6/HHiZPGnMsW/NWTGGd+/02XHxpoueIRWPlwZcUimrZ71r6IThuWxOXg 75KNKayV2leW/+yS0L4WBHTKpKY4j1WS52QVEg124GIyUeTj6KzIJco4wRwNGmCyJ4Tv vi1oSDfpMZTvOEsY7+ixaGnwfvhJwtNjI5sW34qUnmEaXNUr6I9zozPSGkd3uUPfybUy 1whWB2HJyFVLi9nb7TbW2pwIG51esbwS1i32iCl5PtaBmjZInP4f9CabTblWM8gDe0/1 eA4LN4i+dtFecOnHVR1jDRwZAf4wpZpoTupMnRanwXgdBLm7KwfAnfyX7FPam37v0FyK km5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sSQuChGU6tQxqfm5TWusep8hq6ZmIB+zOQ9/zhsm9m0=; b=Y8Nt9qonRSdmFTynL7b/QZHu4usNXikQwJ9AajweRcGFeF0hWv9yOlHvaF5Pu2IzCP 90wgajCj//SdNcFrojFODbYgMNouKJA5Wd8lcd/giN+2qs16/39ndTUzVlmWLjNlrEXT MmRDWyAwsWq+74RuSPiF7EHJegITJva8sEWZ6cZEC3KaMGUH2RXbY7htMZDhw4uJeWgu 5F7eugJ0nduTuG/BwUuJ8emBp3e1wVBhLTsS1q2X9psz96KhLGvDWUzfHdfDVlAUNbJd 0Thi+Crc7o+vVdFwJqATPiai9WAUP87nsnzo16pcLRLN09Hf6cN+LuoqLbnhk2Ch5jmV 2+aA== X-Gm-Message-State: AOAM533AdDYVhX/c+0pGHo+L+AwrligM8WV0E/CMb40WyBS7K1rQGaEv LkGyPB/kA1KbB/ySmD/2pvIVubNZKYNh75AchVj2VQ== X-Google-Smtp-Source: ABdhPJzM/OQSfrNn9MjFL2p5RV9t3hMxfHHij+8DcfFovPESSzpJ5AdB4Nl0Gw/KVUh6Vbgch08Axn4qft8+xWhpwGo= X-Received: by 2002:a25:83ca:: with SMTP id v10mr47053164ybm.84.1626882210451; Wed, 21 Jul 2021 08:43:30 -0700 (PDT) MIME-Version: 1.0 References: <20210718214134.2619099-1-surenb@google.com> <20210718214134.2619099-2-surenb@google.com> <6ab82426-ddbd-7937-3334-468f16ceedab@redhat.com> In-Reply-To: <6ab82426-ddbd-7937-3334-468f16ceedab@redhat.com> From: Suren Baghdasaryan Date: Wed, 21 Jul 2021 08:43:18 -0700 Message-ID: Subject: Re: [PATCH v2 2/3] mm: introduce process_mrelease system call To: David Hildenbrand Cc: Andrew Morton , Michal Hocko , Michal Hocko , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , Jann Horn , Shakeel Butt , Andy Lutomirski , Christian Brauner , Florian Weimer , Jan Engelhardt , Tim Murray , Linux API , linux-mm , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 61164E0085E0 X-Stat-Signature: 8khhgm71perkij4yq1e49azs8iz795jk Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=RLnulxEI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of surenb@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=surenb@google.com X-HE-Tag: 1626882211-825938 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 21, 2021 at 1:02 AM David Hildenbrand wrote: > > On 18.07.21 23:41, Suren Baghdasaryan wrote: > > In modern systems it's not unusual to have a system component monitoring > > memory conditions of the system and tasked with keeping system memory > > pressure under control. One way to accomplish that is to kill > > non-essential processes to free up memory for more important ones. > > Examples of this are Facebook's OOM killer daemon called oomd and > > Android's low memory killer daemon called lmkd. > > For such system component it's important to be able to free memory > > quickly and efficiently. Unfortunately the time process takes to free > > up its memory after receiving a SIGKILL might vary based on the state > > of the process (uninterruptible sleep), size and OPP level of the core > > the process is running. A mechanism to free resources of the target > > process in a more predictable way would improve system's ability to > > control its memory pressure. > > Introduce process_mrelease system call that releases memory of a dying > > process from the context of the caller. This way the memory is freed in > > a more controllable way with CPU affinity and priority of the caller. > > The workload of freeing the memory will also be charged to the caller. > > The operation is allowed only on a dying process. > > > > Previously I proposed a number of alternatives to accomplish this: > > - https://lore.kernel.org/patchwork/patch/1060407 extending > > pidfd_send_signal to allow memory reaping using oom_reaper thread; > > - https://lore.kernel.org/patchwork/patch/1338196 extending > > pidfd_send_signal to reap memory of the target process synchronously from > > the context of the caller; > > - https://lore.kernel.org/patchwork/patch/1344419/ to add MADV_DONTNEED > > support for process_madvise implementing synchronous memory reaping. > > To me, this looks a lot cleaner. Although I do wonder why we need two > separate mechanisms to achieve the end goal > > 1. send sigkill > 2. process_mrelease > > As 2. doesn't make sense without 1. it somehow feels like it would be > optimal to achieve both steps in a single syscall. But I remember there > were discussions around that. Yep, we recently discussed the approach in this thread: https://lore.kernel.org/patchwork/patch/1450952/#1652452 > > > > > The end of the last discussion culminated with suggestion to introduce a > > dedicated system call (https://lore.kernel.org/patchwork/patch/1344418/#1553875) > > The reasoning was that the new variant of process_madvise > > a) does not work on an address range > > b) is destructive > > c) doesn't share much code at all with the rest of process_madvise > > From the userspace point of view it was awkward and inconvenient to provide > > memory range for this operation that operates on the entire address space. > > Using special flags or address values to specify the entire address space > > was too hacky. > > > > The API is as follows, > > > > int process_mrelease(int pidfd, unsigned int flags); > > > > DESCRIPTION > > The process_mrelease() system call is used to free the memory of > > a process which was sent a SIGKILL signal. > > > > The pidfd selects the process referred to by the PID file > > descriptor. > > (See pidofd_open(2) for further information) > > > > The flags argument is reserved for future use; currently, this > > argument must be specified as 0. > > > > RETURN VALUE > > On success, process_mrelease() returns 0. On error, -1 is > > returned and errno is set to indicate the error. > > > > ERRORS > > EBADF pidfd is not a valid PID file descriptor. > > > > EAGAIN Failed to release part of the address space. > > > > EINVAL flags is not 0. > > > > EINVAL The task does not have a pending SIGKILL or its memory is > > shared with another process with no pending SIGKILL. > > > > ENOSYS This system call is not supported by kernels built with no > > MMU support (CONFIG_MMU=n). > > > > ESRCH The target process does not exist (i.e., it has terminated > > and been waited on). > > > > Signed-off-by: Suren Baghdasaryan > > --- > > mm/oom_kill.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > > index d04a13dc9fde..7fbfa70d4e97 100644 > > --- a/mm/oom_kill.c > > +++ b/mm/oom_kill.c > > @@ -28,6 +28,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -755,10 +756,64 @@ static int __init oom_init(void) > > return 0; > > } > > subsys_initcall(oom_init) > > + > > +SYSCALL_DEFINE2(process_mrelease, int, pidfd, unsigned int, flags) > > +{ > > + struct pid *pid; > > + struct task_struct *task; > > + struct mm_struct *mm = NULL; > > + unsigned int f_flags; > > + long ret = 0; > > Nit: reverse Christmas tree. Ack. Will reorder like this: struct mm_struct *mm = NULL; struct task_struct *task; unsigned int f_flags; struct pid *pid; long ret = 0; > > > + > > + if (flags != 0) > > + return -EINVAL; > > + > > + pid = pidfd_get_pid(pidfd, &f_flags); > > + if (IS_ERR(pid)) > > + return PTR_ERR(pid); > > + > > + task = get_pid_task(pid, PIDTYPE_PID); > > + if (!task) { > > + ret = -ESRCH; > > + goto put_pid; > > + } > > + > > + /* > > + * If the task is dying and in the process of releasing its memory > > + * then get its mm. > > + */ > > + task_lock(task); > > + if (task_will_free_mem(task) && (task->flags & PF_KTHREAD) == 0) { > > + mm = task->mm; > > + mmget(mm); > > + } > > AFAIU, while holding the task_lock, task->mm won't change and we cannot > see a concurrent exit_mm()->mmput(). So the mm structure and the VMAs > won't go away while holding the task_lock(). I do wonder if we need the > mmget() at all here. > > Also, I wonder if it would be worth dropping the task_lock() while > reaping - to unblock anybody else wanting to lock the task. Getting a > hold of the mm and locking the mmap_lock would be sufficient I guess. Let me take a closer look at the locking sequence here and will follow up afterwards. Thanks for the review! > > > In general, looks quite good to me. > > -- > Thanks, > > David / dhildenb >