From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DA26C28CF5 for ; Wed, 26 Jan 2022 16:44:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59B626B0073; Wed, 26 Jan 2022 11:44:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 54AA56B0074; Wed, 26 Jan 2022 11:44:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4393B6B0075; Wed, 26 Jan 2022 11:44:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay035.a.hostedemail.com [64.99.140.35]) by kanga.kvack.org (Postfix) with ESMTP id 343E36B0073 for ; Wed, 26 Jan 2022 11:44:23 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DCE1F21260 for ; Wed, 26 Jan 2022 16:44:22 +0000 (UTC) X-FDA: 79073011164.02.7FA4D67 Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf01.hostedemail.com (Postfix) with ESMTP id 6DADA40003 for ; Wed, 26 Jan 2022 16:44:22 +0000 (UTC) Received: by mail-yb1-f180.google.com with SMTP id i10so480955ybt.10 for ; Wed, 26 Jan 2022 08:44:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Hn+3XwLtFaaXewwNrqnpZ08MIqd56MgA4Nzvpzw2Rck=; b=loX2o69cxQhfTbzaEheoHgyXMWaVN9Fl0oxkMMeaymKtyfb/tRiCv15dLMUFO5R39a dNhnFqAWDCbIX+sE7BR0FjCwkUB30+XKHMpTd9eZC30WYqQMKlheE+d7ofFQVLQUPMTR s6KPtRFoUFG+FMLGvY6pIGHj8wQHUQ+2MprOCGocfP+vWo1X5i/plCUlJPz6IhQCidis 8/IlzQItYwp2BZ4jhbVFSHGQCijxmFl5PtNn8evTImkHAcsgwUernq90pBSLiHh/cx4C Rjx3BaQ8VtJbDcDvlfRJU/HiHoLFMoBbQJP473y8eCIoYbSjQYYWu2iTcxf2nkv8Phx6 Ajgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hn+3XwLtFaaXewwNrqnpZ08MIqd56MgA4Nzvpzw2Rck=; b=FIy/aTJCg32rhIBSWmNtTD+Wmdn7f1FShkdBBFVZJ4CHT0cfbEj/PmFVRG68lR1+DD +64ndVz8iDz5j88nNaryUTzIOdJCQZ9A3WMD0pVyDFEw73bsC0UIqu1omebrPDk7Yt2q 6btEPkcmAKspU4929TeMzvW/Uc0uEgFpwQCyxa8I3SI4OrbI9+zsjvrtQfvwSAfCufu+ Loo4VboIQhWfuf6ZYZAWA9jOMVTyD3+jvrLgTaJoYlm6S7EPXlRuXnapRxs4I4LmTn2T /Cl4Ef+fc/JcppxSTvVNMQ3W3NsPAn4cDur2qbczglTURHljr5rqETbGzmQf9dH5dGDk DmYg== X-Gm-Message-State: AOAM531YbOqO0E73KGNm1joPdGT8N9P6wVwxF7JFsEVPqRg9xVHmErMn xpcBbPs1WAweAowIGTEwsfsllk4UdDCBp4dR4aGChw== X-Google-Smtp-Source: ABdhPJw2JTKWqJxocNIGE7jMUaTewzym6lIQKL0wJPFFdukwj6rNoiUYD9bjMcCFI3+js7uX8oXUgDWYPJ/ajAl0bdM= X-Received: by 2002:a25:d7cf:: with SMTP id o198mr36466764ybg.602.1643215461475; Wed, 26 Jan 2022 08:44:21 -0800 (PST) MIME-Version: 1.0 References: <1643093818-19835-1-git-send-email-huangzhaoyang@gmail.com> In-Reply-To: From: Suren Baghdasaryan Date: Wed, 26 Jan 2022 08:44:10 -0800 Message-ID: Subject: Re: [PATCHv4] psi: fix possible trigger missing in the window To: Johannes Weiner Cc: Huangzhaoyang , Peter Zijlstra , Zhaoyang Huang , Ingo Molnar , linux-mm , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6DADA40003 X-Stat-Signature: 8b7i53npmhn87ypd1rs9na4f896uxhy3 X-Rspam-User: nil Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=loX2o69c; spf=pass (imf01.hostedemail.com: domain of surenb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1643215462-464963 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000428, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 25, 2022 at 6:40 AM Johannes Weiner wrote: > > On Tue, Jan 25, 2022 at 02:56:58PM +0800, Huangzhaoyang wrote: > > From: Zhaoyang Huang > > > > When a new threshold breaching stall happens after a psi event was > > generated and within the window duration, the new event is not > > generated because the events are rate-limited to one per window. If > > after that no new stall is recorded then the event will not be > > generated even after rate-limiting duration has passed. This is > > happening because with no new stall, window_update will not be called > > even though threshold was previously breached. To fix this, record > > threshold breaching occurrence and generate the event once window > > duration is passed. > > > > Suggested-by: Suren Baghdasaryan > > Signed-off-by: Zhaoyang Huang > > Acked-by: Johannes Weiner Looks good. Thanks! Acked-by: Suren Baghdasaryan