From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 583E9C61DA4 for ; Mon, 6 Mar 2023 20:25:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B05E76B0071; Mon, 6 Mar 2023 15:25:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB3FD6B0072; Mon, 6 Mar 2023 15:25:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97BE4280001; Mon, 6 Mar 2023 15:25:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 833D36B0071 for ; Mon, 6 Mar 2023 15:25:40 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 40730AB000 for ; Mon, 6 Mar 2023 20:25:40 +0000 (UTC) X-FDA: 80539604040.25.544F8D8 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf08.hostedemail.com (Postfix) with ESMTP id 78AB3160016 for ; Mon, 6 Mar 2023 20:25:38 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mm4oC6jA; spf=pass (imf08.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678134338; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hF7wS3Hx/Pvpcugsib0JQfyCay4rq+Y4wSQiQgHE58Q=; b=3Q9P01emQCUC9OtXzLDJ68JnyDNuD6UShRUQFw19fkK2VboXOMHBjDB4nQ1VlX17jOefiU +MtCFsSGh2Uil6ODdQS8Q0B+/aTwTm+7gYH9rOQR9zUioYX/Kf6kFCOr1ruvBgv8dQnTaG AuXu4/CiNkW1GTURj4/NImKI0BuSQ/s= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mm4oC6jA; spf=pass (imf08.hostedemail.com: domain of surenb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678134338; a=rsa-sha256; cv=none; b=T2Fhpzu6TpEH2h0RWkKz5xuUn21hhxa5ix4ziJjTf0j0AvrK6SFCtCWDrZztzG+Tbh8xN+ 8TvB7vnXmodOGb3V2+CCTTQS/rrWME61lnTyJKEmtRfmzk/0rl8dIGEoQuTYHdWeYox89V sDexLGr17m9hXrWOAcQnN25pKmPX6Ik= Received: by mail-yb1-f177.google.com with SMTP id k199so9484979ybf.4 for ; Mon, 06 Mar 2023 12:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678134337; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hF7wS3Hx/Pvpcugsib0JQfyCay4rq+Y4wSQiQgHE58Q=; b=mm4oC6jA+okjPImEMJZmmO6uLRhBRnDeHNzV1d8O1Qh5/hafaokl8mjkr8c79UlkBN k4drUKORz+wffyx+9YyisfP5mpJImJQsPDv41zOqZG7QkOgo9ri/A5/XDvukiwTsY1A2 KtUQMjA/qFFeEpXLtJpt5gUH2u4dfLnbgQu/CtMDzJH1c3fz5MOdwhGAc24HiP++snNm r1Te6JP4fRv/ob/XR9eV/TIsK4dBpU+dkv3Z52FWkIPRC2czaKV51YKxz4dhn0C6znLk 9MFCBlOUUHEl5/EKZvJ0XYjeKqLAQIDKZ8xVkWg4Cqj6qtXlNAIezz8HeYtOxpAaL4c1 0yUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678134337; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hF7wS3Hx/Pvpcugsib0JQfyCay4rq+Y4wSQiQgHE58Q=; b=qKcBeeYCPLxn6a/6+0Kg9F4HY9J5+uGNRDhzRWH02JRDq53VM9GkNL/cpPNHT3qWbh x3wCOYWsoJ37E3KHbR+B+4A7x8FoAnw1+i4J4PXqf6FG8Vo6ReVraGoBKf04PRPubVYa i/KayipNrBdWDOctc508g+oW9IPJJlwhamAdwsMuBHq+aJx0yuau9upjOpX6ZFt3ij+X KUMDgEptaAAHoed84bS72TisNWaJGYrIcNQ+B/Lr27lxOr2ZOwjhhZ+HSw0HRSW5m+zO 6VQNLBODvcWxY9D1azN+J3d00MoE1EHr1zlm09eC7PnQ4CQly/mJZMQkzWt5OWv2trNe N9LQ== X-Gm-Message-State: AO0yUKWTezWEQCk+tdEUjoZ+BOFJtNxVXbIQAXONAkqF5vFITcKO97tS T1DNbkot7s2A2vxUi0pBnjtcHBpqjM5Lv9+RlvSOlA== X-Google-Smtp-Source: AK7set8n4u10VCWBPTL7wngRuwzFB4EZKZN4IetFL6kNRt6cIBeVlYompKXHsIJ4rDipkAKfK7DTOCV1YSGWRZnP/FI= X-Received: by 2002:a5b:e92:0:b0:ab8:1ed9:cfc9 with SMTP id z18-20020a5b0e92000000b00ab81ed9cfc9mr7085896ybr.6.1678134337360; Mon, 06 Mar 2023 12:25:37 -0800 (PST) MIME-Version: 1.0 References: <20230227173632.3292573-1-surenb@google.com> <20230227173632.3292573-32-surenb@google.com> In-Reply-To: <20230227173632.3292573-32-surenb@google.com> From: Suren Baghdasaryan Date: Mon, 6 Mar 2023 12:25:26 -0800 Message-ID: Subject: Re: [PATCH v4 31/33] powerc/mm: try VMA lock-based page fault handling first To: akpm@linux-foundation.org Cc: michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, michalechner92@googlemail.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: jgjqjwhoeptreh9jnctpa3y51hicixp8 X-Rspamd-Queue-Id: 78AB3160016 X-HE-Tag: 1678134338-98713 X-HE-Meta: U2FsdGVkX1/fGSEk5eP8PrqQWL2qAD4wAon6m0o/jlcIpLQ/y5Qq7Yjlz7bjty6fMKQlUZYXeK1dUuJB6VDRCzuHDvgi50ZAzgcCleu08NDBq4iv4t+Y9FF8GyUBtov/mA191jvJzrYhPpR5Vk2bBr2Jas+iCbl57YbpwLtR20jYx49Pv4i6z/im9wVmE5HKNvZMxKpbU9XFbaUUqmfou1f2ov3a8XMLvgytorBCspBXXTNDBpNdkzMjNqgxbTm1Fc70/LkGU9A0jx02GRRAx1GJBfYZcKmhHpQiF+yd8swCIlSRMni8rP4g5GwValD/zo3IEuiyc3oeee2SY2//Wlq8f28RiZsZfitbKZmGLXrlJwQwarHLrZ8EFLQWH3K+KO17Uf/h9YIRVPhYajDXK1rgsdH1xfUGJtxg2w2ujlvRlzSabWCzSyPD2M1w+K1Gv2O4C5wlPi+DwuoZOI69N4PPdUxM1i7K2gtVAH8ixca7NKvbDJOnY9NnvGZuW8lk9TY34YcYhbrmojeiEbQbhn5JtyVk257otjXw0oid3XeryM0qM4HT4QM97qA2r+ve/Q//ILPbRzO6IsPY3zI+6Pwh4uIJ1sXUo+0g6JBPMQycwz18Y4qQyA7bkuD4eX0kFjHvA+fpDKYnkNEpvGyvCyJjdv9AIiVrcZmFPVAe0mC8SjgzGgncK+s1c+NHGr6mEllWQco/VJt4Bx9CxJJjT9sRd68KW4ZHQTx0QBd7fHBDiHUtJC7g0wNxYWcGE1X0Jz9idJEcYKCmd5WOqJfckb+aWRKTbum37z+gbyAThA9/kxxs3P/1j5MsnA/ZllW97kKp5+puuaiRWYCmCLWP0NqFxdWj3UNAUWhTUijxeyh09N8JG84uind3nS/T6WKUYqe6BpnhRV97E/Ue0U+qPC/UzZ7383gStnoOIL9Wj8ZmFI+ZObO/xZAGbbJ5c4G5BZNxyyprjPbDRr51QIy ckYBdVzl bQ6MWfUVepzn5BLHWsiu1vsvlV3rj13jMNskcIfIJ6cU2NTWBmmfzMsOzcFuWC/7An/M1o7tIJWIxmyIkvqKEQONzjIzoeZcavC9dAZYGIvcST7TNUmwCDj0K29U1KdnuEVbZXbMHxlR763g0fSqyh9C75FG2dCqY/oZWTl8S72lX5binzPGZn3wLOdDzpbaGAyrrtLEeJPEx2RAgk173tCcEAhejAN288rBRHwP9gyaGx5Dm8/IMobDGHZs1OdqUlOlOw6DJwBuZ377vgcgYLHKkcC10GABBbRDnxe97gsDlb1TVVnQM6LWYRPFlD1SzzgatrqXKlDHFLRNU0PWwx0mJTIWg1xll+weZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 27, 2023 at 9:37 AM Suren Baghdasaryan wrote: > > From: Laurent Dufour > > Attempt VMA lock-based page fault handling first, and fall back to the > existing mmap_lock-based handling if that fails. > Copied from "x86/mm: try VMA lock-based page fault handling first" Hi Andrew, Laurent posted a fix for this patch at https://lore.kernel.org/all/20230306154244.17560-1-ldufour@linux.ibm.com/. Could you please squash the fix into this patch? Thanks, Suren. > > Signed-off-by: Laurent Dufour > Signed-off-by: Suren Baghdasaryan > --- > arch/powerpc/mm/fault.c | 41 ++++++++++++++++++++++++++ > arch/powerpc/platforms/powernv/Kconfig | 1 + > arch/powerpc/platforms/pseries/Kconfig | 1 + > 3 files changed, 43 insertions(+) > > diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c > index 2bef19cc1b98..c7ae86b04b8a 100644 > --- a/arch/powerpc/mm/fault.c > +++ b/arch/powerpc/mm/fault.c > @@ -469,6 +469,44 @@ static int ___do_page_fault(struct pt_regs *regs, unsigned long address, > if (is_exec) > flags |= FAULT_FLAG_INSTRUCTION; > > +#ifdef CONFIG_PER_VMA_LOCK > + if (!(flags & FAULT_FLAG_USER)) > + goto lock_mmap; > + > + vma = lock_vma_under_rcu(mm, address); > + if (!vma) > + goto lock_mmap; > + > + if (unlikely(access_pkey_error(is_write, is_exec, > + (error_code & DSISR_KEYFAULT), vma))) { > + int rc = bad_access_pkey(regs, address, vma); > + > + vma_end_read(vma); > + return rc; > + } > + > + if (unlikely(access_error(is_write, is_exec, vma))) { > + int rc = bad_access(regs, address); > + > + vma_end_read(vma); > + return rc; > + } > + > + fault = handle_mm_fault(vma, address, flags | FAULT_FLAG_VMA_LOCK, regs); > + vma_end_read(vma); > + > + if (!(fault & VM_FAULT_RETRY)) { > + count_vm_vma_lock_event(VMA_LOCK_SUCCESS); > + goto done; > + } > + count_vm_vma_lock_event(VMA_LOCK_RETRY); > + > + if (fault_signal_pending(fault, regs)) > + return user_mode(regs) ? 0 : SIGBUS; > + > +lock_mmap: > +#endif /* CONFIG_PER_VMA_LOCK */ > + > /* When running in the kernel we expect faults to occur only to > * addresses in user space. All other faults represent errors in the > * kernel and should generate an OOPS. Unfortunately, in the case of an > @@ -545,6 +583,9 @@ static int ___do_page_fault(struct pt_regs *regs, unsigned long address, > > mmap_read_unlock(current->mm); > > +#ifdef CONFIG_PER_VMA_LOCK > +done: > +#endif > if (unlikely(fault & VM_FAULT_ERROR)) > return mm_fault_error(regs, address, fault); > > diff --git a/arch/powerpc/platforms/powernv/Kconfig b/arch/powerpc/platforms/powernv/Kconfig > index ae248a161b43..70a46acc70d6 100644 > --- a/arch/powerpc/platforms/powernv/Kconfig > +++ b/arch/powerpc/platforms/powernv/Kconfig > @@ -16,6 +16,7 @@ config PPC_POWERNV > select PPC_DOORBELL > select MMU_NOTIFIER > select FORCE_SMP > + select ARCH_SUPPORTS_PER_VMA_LOCK > default y > > config OPAL_PRD > diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig > index b481c5c8bae1..9c205fe0e619 100644 > --- a/arch/powerpc/platforms/pseries/Kconfig > +++ b/arch/powerpc/platforms/pseries/Kconfig > @@ -21,6 +21,7 @@ config PPC_PSERIES > select HOTPLUG_CPU > select FORCE_SMP > select SWIOTLB > + select ARCH_SUPPORTS_PER_VMA_LOCK > default y > > config PARAVIRT > -- > 2.39.2.722.g9855ee24e9-goog >