From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D7E6C77B7F for ; Tue, 24 Jun 2025 14:34:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A6346B00B2; Tue, 24 Jun 2025 10:34:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97DCF6B00B6; Tue, 24 Jun 2025 10:34:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BB3A6B00B9; Tue, 24 Jun 2025 10:34:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7B8FB6B00B2 for ; Tue, 24 Jun 2025 10:34:00 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2F2501D762F for ; Tue, 24 Jun 2025 14:34:00 +0000 (UTC) X-FDA: 83590538640.14.C59A322 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf30.hostedemail.com (Postfix) with ESMTP id 4A07F80016 for ; Tue, 24 Jun 2025 14:33:58 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="bcp/KYYh"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of surenb@google.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750775638; a=rsa-sha256; cv=none; b=1/AswI0rUvUufpFArUYdmVFtBZcwV7gUwhU6MRX1AJDOoJ8nFi+Fr7IWeN2xn7gexxxIsy okXaY5jQS/rs8vk021f0f+g4GpSYIYcNY6ISXnPBNMZdsh9HLMMOU0OgbLGsI+330Vqn4X 1lYJSM1LJWs6uuZ7y0EMQaJ/P8T6Bi4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="bcp/KYYh"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of surenb@google.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750775638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=px+6/25zYVIxF5pbO7IhD5/oS5ucz4FqyHM3nhsWCNQ=; b=U07DLsoI3hS4KXqqJNzJKqT8+iKKrAg23bacsRtkRmGfsxy0Cn8OlBslcraUevfQOWTpjN TN6HWieem0fCmd9nNQAPY5GyWa+d5Jbro/p0lTepsnyB40K+rDuNADXXcj8+mFctzDTv6N YzWSveGldlML6swsV9ITeafpNucJFGE= Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-47e9fea29easo410671cf.1 for ; Tue, 24 Jun 2025 07:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1750775637; x=1751380437; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=px+6/25zYVIxF5pbO7IhD5/oS5ucz4FqyHM3nhsWCNQ=; b=bcp/KYYhtKsskDaV/7YI7WSs6zEFmdO7ImM3zxKcIeJd7C88AfmObJ7pbL4Jh94Zbg fFisDEdIriGzZis8+z6Ggc9LElGraPUdP+YWlthmDAhRnJO0Q6Dy8ahiuWeuk4SzQGJ7 HIyiXotJ6FbacY7LWXC8vTIUuerX3f2vGnHTkHZQZHdmkRGux1a4nOP2jniaPZBvIuGn NQPSKNDnwSHsMjFQCpDtSPxVpTOZhXLc35mXvaZ9jyVUvjJJEA2BkgwXBr/RRr2txhE8 T19hIezYhyl02H1m+mACMmNrI5d/p+f0L9H9bGz29/0KezXjSfDDl/dd+kOXzU2yuWk0 RSIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750775637; x=1751380437; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=px+6/25zYVIxF5pbO7IhD5/oS5ucz4FqyHM3nhsWCNQ=; b=rbPjh3yPL3gbgXBDb4rl2kQ8qptdOOA8DuIsipSkLnKO+JyEP4WMn4qtq8XV7T2rsr slAN5upCFSyaVnmyctbr1RY3iksgRi16lojVkW7C/ff/b+7Vb79roqfqZkxhvglewTbg XqyuUlJ/UCLNM4CuLC3FSmVYwMGOl3U8cduE3vmvz3+PAR5IYXV2cEp9AJD/P963MIRo zua3uTqBjofRlW55Ck14GhdckkWUK/mEhKweUjjLc3BL8kbdTdmOBlwt41268kk63OjP rQ4oxBwMc71CBi0RTN6q4gUV7KaOqpWBmkdhVlwNNtpqaUA8iq2Y9EOqTBIhWU44nzqq Jw5w== X-Forwarded-Encrypted: i=1; AJvYcCXQOEB71IxiwPcowdwwkYHvAptkrih/jqZgaBItb4fM/06H3bdp22mMZmWpAjOtB65xjf7+pZw6lA==@kvack.org X-Gm-Message-State: AOJu0Yzs0f1t6jIXsZZT4uRBlBF8UEEVKLi1DKpgEKJ4Qsj6b6Roytzm dyIDsAi0rqD5SRBJ3yPlz2FQZlEmQ9EBMIvJnAqNi065Wr+5kPpkYqDnAe0YCYfgj0kzIbKLGU4 B4697GBmjcY9kCPyQOtegn8zfy7TxtWuSgh2ZSGkJ X-Gm-Gg: ASbGnctioEGoA1Q8e/l9uWRO+AhD5gbL7Unbh2GjtRnou2+o95F+MTaSApzzRkJrHiJ thTL6j058x3w2c4K0THidFVs2buVGp1HvDivxgzCeXxSYnUDtEbymQp3pSzTBlzWZy3Q68E6ZXx fxwkFRbhqiuV7brtZtly6Oy1Zg0nXUH/8goIomARZ5As8zBpYq8zJ8h2pVQKiQ5quiF04Juuq1/ A== X-Google-Smtp-Source: AGHT+IGLY4ZBK3B6v4Q3itKcyN5ZL8x8XfHH79Wzt7dA2aGWLUgYsOlBtYdOj1HkiKEJTVUwKSwYae0O3YEzIm0vFDQ= X-Received: by 2002:a05:622a:64a:b0:4a5:a8b7:6c12 with SMTP id d75a77b69052e-4a7af8f8945mr4101121cf.26.1750775636917; Tue, 24 Jun 2025 07:33:56 -0700 (PDT) MIME-Version: 1.0 References: <20250624-anon_name_cleanup-v2-0-600075462a11@suse.cz> <20250624-anon_name_cleanup-v2-3-600075462a11@suse.cz> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 24 Jun 2025 07:33:45 -0700 X-Gm-Features: Ac12FXx3Umpvg01gGoeZg2oSTYWEbXBROMjGNj0OAQWs2jH5wC9nlMqBJW92b5k Message-ID: Subject: Re: [PATCH v2 3/4] mm, madvise: move madvise_set_anon_name() down the file To: David Hildenbrand Cc: Vlastimil Babka , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Jann Horn , Mike Rapoport , Michal Hocko , Colin Cross , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4A07F80016 X-Stat-Signature: qqstpkxwaew6w8o47gpt4b1cic3awf31 X-Rspam-User: X-HE-Tag: 1750775638-365069 X-HE-Meta: U2FsdGVkX19nXU5nzsS576ikXmZWnc5oLiqXg/mVJ4k/vsTLRrVNvyLgSN2DQXGPz1pc6LmEmU3CiMl4hmq1Xo/uAE1J7K3+LkvrLtsbVp3BDiDTgqBuElCiQoMTXNNC+27y5LPLn6Mgjlhh9Rwe3gkiPOnoiLaaqUJJDOZPzFHbJOKAX5+InHGRtDsfgntX2neYCJ5wcuE68oIHqLPKEhobSAFKprFHUzJd3+PB1zob+KuqDX9E9LDHQAV86kWbyTXh9FbaquqB6vcUWxl4Fse1uy0t4uaG9C1lF9dsHtiHr9gM+yVSdRQTKs/IkHhvK24I2YTbeOcCxhIH161pYsQXQBuhgH/uzrx2x0RNXUbn2IGLpD/nDYUYZ99Cb80dnJt8WSYfisJYR71F3aP2Grn4vLCDX0Q0PRF1XYUo/qnIGKAErSQ0ygw2Xki/MzeSxgATG/8oQCgyWQ1UNuWl0KHWFFkeGv+cqQSZ83eEUKurWk1w8M2IFyJoe/WVrbJUbO4qpBgGZZSkvVGM58eShsiMTty0uZp53iPrg1OVixlTiNlWCh19fHdaQqCyBRwu84Rrazg43eacC0uZAtSWq8sUeeWnErlQzvwO3SJNCcdONBD35TId7cv2yFJq+srWwqEmxmWIo1TbsQwFHZTcwUIj80wLDnVNecGA8Nq+SMN3ZdV6/0ODwf1Zp1m1y9g6brIB46//jEu2LLBA4EqBlSCPKYkREYc5rugVRGFq1yRiiguSwxw1W+r9icJ7/aBY9NgKaV+mA3+DI2qwoqATdxOMqOzk/aNbVPfc132raQM270RBflcpTTR1bBOg5pEQI8t6ZEyQZCXCfaSrWrJqFTZ/Px7b2kLZWPNv6ckazWhOU8R6ZQLsftzOK807kQOenwC1x8jtlZ95N2r3oLnjETh/SmCu8g/lGLsspyyKXpum00nRwEfYGgoaXdwAddkLBNwkLXOE9XWiPXwb2o2 WLU5twVr tQt8xv3Gl/1K5BHhzoyO02NBaUsOiYMdiGBud/R4PZnHsWpv3SYAXevjaT3uGkELCN0bNMOD1uqtBWJLg04i5XsP4WE1piObfPjKKgywrMx3cTPLD1x5KsG4gG5ebl3QIJU6zHllFOAT2ehqpD5RusM0k+fJv6w4FQ//IypcDiDbz06cYMNRz9CXa7nala2tW9e3fcBRecgFQnCBjYdZmm8Xg+aOEtK85hbakQil1QHRONt8QnvG1drPCMOn3cGCaHR3hPUBUZBSS9213JPXozjIG2f6RbIaRwbrf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 24, 2025 at 7:05=E2=80=AFAM David Hildenbrand wrote: > > On 24.06.25 15:03, Vlastimil Babka wrote: > > Preparatory change so that we can use madvise_lock()/unlock() in the > > function without forward declarations or more thorough shuffling. If you respin the series please add a note that there is no functional change here. > > > > Signed-off-by: Vlastimil Babka > > --- > > mm/madvise.c | 64 ++++++++++++++++++++++++++++++---------------------= --------- > > 1 file changed, 32 insertions(+), 32 deletions(-) > > > > diff --git a/mm/madvise.c b/mm/madvise.c > > index 7e8819b5e9a0f183213ffe19d7e52bd5fda5f49d..cae064479cdf908707c45b9= 41bd03d43d095eab6 100644 > > --- a/mm/madvise.c > > +++ b/mm/madvise.c > > @@ -133,38 +133,6 @@ static int replace_anon_vma_name(struct vm_area_st= ruct *vma, > > > > return 0; > > } > > - > > -static int madvise_set_anon_name(struct mm_struct *mm, unsigned long s= tart, > > - unsigned long len_in, struct anon_vma_name *anon_name) > > -{ > > - unsigned long end; > > - unsigned long len; > > - struct madvise_behavior madv_behavior =3D { > > - .mm =3D mm, > > - .behavior =3D __MADV_SET_ANON_VMA_NAME, > > - .lock_mode =3D MADVISE_MMAP_WRITE_LOCK, > > - .anon_name =3D anon_name, > > - }; > > - > > - if (start & ~PAGE_MASK) > > - return -EINVAL; > > - len =3D (len_in + ~PAGE_MASK) & PAGE_MASK; > > - > > - /* Check to see whether len was rounded up from small -ve to zero= */ > > - if (len_in && !len) > > - return -EINVAL; > > - > > - end =3D start + len; > > - if (end < start) > > - return -EINVAL; > > - > > - if (end =3D=3D start) > > - return 0; > > - > > - madv_behavior.range.start =3D start; > > - madv_behavior.range.end =3D end; > > - return madvise_walk_vmas(&madv_behavior); > > -} > > #else /* CONFIG_ANON_VMA_NAME */ > > static int replace_anon_vma_name(struct vm_area_struct *vma, > > struct anon_vma_name *anon_name) > > @@ -2109,6 +2077,38 @@ static inline bool is_valid_name_char(char ch) > > !strchr(ANON_VMA_NAME_INVALID_CHARS, ch); > > } > > > > +static int madvise_set_anon_name(struct mm_struct *mm, unsigned long s= tart, > > + unsigned long len_in, struct anon_vma_name *anon_name) > > +{ > > + unsigned long end; > > + unsigned long len; > > + struct madvise_behavior madv_behavior =3D { > > + .mm =3D mm, > > + .behavior =3D __MADV_SET_ANON_VMA_NAME, > > + .lock_mode =3D MADVISE_MMAP_WRITE_LOCK, > > + .anon_name =3D anon_name, > > + }; > > + > > + if (start & ~PAGE_MASK) > > + return -EINVAL; > > + len =3D (len_in + ~PAGE_MASK) & PAGE_MASK; > > + > > + /* Check to see whether len was rounded up from small -ve to zero= */ > > + if (len_in && !len) > > + return -EINVAL; > > + > > + end =3D start + len; > > + if (end < start) > > + return -EINVAL; > > + > > + if (end =3D=3D start) > > + return 0; > > + > > + madv_behavior.range.start =3D start; > > + madv_behavior.range.end =3D end; > > + return madvise_walk_vmas(&madv_behavior); > > +} > > + > > int set_anon_vma_name(unsigned long addr, unsigned long size, > > const char __user *uname) > > { > > > > Personally, I would squash that into #4, given that #4 is pretty small ;) > > Acked-by: David Hildenbrand Reviewed-by: Suren Baghdasaryan > > -- > Cheers, > > David / dhildenb >