From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D18AC52D7C for ; Thu, 15 Aug 2024 18:04:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9B3D6B0196; Thu, 15 Aug 2024 14:04:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C49BE6B0197; Thu, 15 Aug 2024 14:04:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B10C16B0198; Thu, 15 Aug 2024 14:04:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9200A6B0196 for ; Thu, 15 Aug 2024 14:04:47 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3A09EA7479 for ; Thu, 15 Aug 2024 18:04:47 +0000 (UTC) X-FDA: 82455255414.18.2CA03B7 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf25.hostedemail.com (Postfix) with ESMTP id 66110A0009 for ; Thu, 15 Aug 2024 18:04:45 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=yHFovaFJ; spf=pass (imf25.hostedemail.com: domain of surenb@google.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723745012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H5ULcUR5IzUEbFCx2TddqIkAP4y49Tv/vG1UVjDgY8g=; b=bJ2gv1ltwtDhf8MERpStPOaO4EnbHhj0Q4zXOXXSZsXLyGE4LqmaQkA48xCUD6vuzuY5IU 0EEZyizmtkF/tIKlzzm4aNUuUwr+YEPOYLAyuAc3oGJPNS+q9a/kCWN5m1pm9xDwgrEnl0 xnQgJ+0W0k1x05MsH6qJ8Tkw3lWgZDE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723745012; a=rsa-sha256; cv=none; b=SNVBjN14WZoieeDvXgeUkHJNBQ2NzwvSjN76YNJ11TR/Ko7I2I3HYNIOGvRBefiYC3Cmk7 Jz+NiT1FhIjxlSsS1sM8Qr6cEiannFJzMl1O+MfZwHlWCODRoLvJv4hHvlxdKbz/Rm2zYQ B/6gHTtA28U+LQWovJypvsRTs/yLRPs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=yHFovaFJ; spf=pass (imf25.hostedemail.com: domain of surenb@google.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-e1161ee54f7so1285969276.2 for ; Thu, 15 Aug 2024 11:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723745084; x=1724349884; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=H5ULcUR5IzUEbFCx2TddqIkAP4y49Tv/vG1UVjDgY8g=; b=yHFovaFJ5CNVcsxgyl4g92fK6F5HKsrXaBv28C/lUIhhBEHPOS3NAxAasz6DIQJaKx HXwwn2WMoN0IJpq2gCZtrLJVCcD3cwr5rVIXRsQz5QRAXQyYFf9zu0wAEynHbC3x95Lf iZftji4Pna6IB4uwR5UwR99sm4hMNYL4p2TQzxI/ihYKquYa91XzbCe+2113L51GFOhS Hppwc9wLxBXs6+Kg4T1+GAhjPDXHZDNZwj3XJ0BisROoECOZ96xeAb0OZX9mpflVMTCL w8jbu8Nx47G/8MKqMtTACrIuXzbF5DKh4tbx7PXqStsy3Mu6oZ29PXHoSyBlOdkWoNaI SfEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723745084; x=1724349884; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H5ULcUR5IzUEbFCx2TddqIkAP4y49Tv/vG1UVjDgY8g=; b=PYItavTk4st/gb6KjIlsu98KzcSmLYkFq0XndXJmqKYt6mgB8FSSydpfVrkOpywvRp Fc1t1TUaI3Hne49PhzFU8wN/yaxJn6G8kz5tjjfw5kD6trI8gXeGf5pXqse0+8haB4G3 CsvAncmCA6s+Fjdj2RPXfvoP9GW2TyKurteisGbUwwq3xMSUj0kuaPu9fVxHx0inJ+nO LbdNBHQ5gloEjoaELCxR8YWmFjf9qjzgoY9+rQF3N1Af8+w53U1I6cEsmT3AwnOfQWiN YzhJBwMi3yjosmg89IPP22zExnRtXAhBL0O5QRH58+J5bmm3IgDdEMvqyg8+I6AmBQgm 0hMA== X-Forwarded-Encrypted: i=1; AJvYcCUB/pHQBnIAqGYj8I8rv+B7etfI6R9KnP8MZOIVRyBFLdag1DZ4oSHKDipUQGKxtx1QZWCS4iuiiP0L3Yrj0ce5OBU= X-Gm-Message-State: AOJu0YyWJOHiV9okKRUNFk0dGqx3QkMO7OtFpDvSQUC+uFWsAYoD866J tcSxBY+i7QP/9tBpe+o594ZfpNfskwYkeUzwj6Dpqcq8ZqqrSEEjkMR55T1mu3w+98tHs3a0MHv ZrZdYoKg28vpHhAgjlrGhMHWBSZcqYTORyT5g X-Google-Smtp-Source: AGHT+IEHZ4aqXuT/wNXL98dHYfWurrnb7OEDVqi2GhnghdJaUI9+8I31F8oLPURFKXgHJiAbMKMgSCgndgenZUkhxDA= X-Received: by 2002:a05:690c:f94:b0:6ae:1e27:c994 with SMTP id 00721157ae682-6b1b6ebe997mr5055047b3.3.1723745083770; Thu, 15 Aug 2024 11:04:43 -0700 (PDT) MIME-Version: 1.0 References: <20240815090324.36065-1-hao.ge@linux.dev> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 15 Aug 2024 11:04:31 -0700 Message-ID: Subject: Re: [PATCH] codetag: debug: mark codetags for cma pages as empty To: David Hildenbrand Cc: Hao Ge , rppt@kernel.org, akpm@linux-foundation.org, babka@suse.cz, kent.overstreet@linux.dev, kees@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hao Ge Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 66110A0009 X-Stat-Signature: kh1ztn4eok79icwpjze63cgdk3un66h8 X-HE-Tag: 1723745085-537865 X-HE-Meta: U2FsdGVkX19PBNJCSUPQFwy9tbl1vKfUbjg5leCVf3d56ul9JED1Na1r7SR0Tr0dXsl01LnSi3GAzdl38PyI1htxQc4j2a68nIgX7gbltIcdDwJ87OzMKNC3XY/llGCcvQ2+p53JCkqUbVjXek4HGG+unGPaJtEH9BAdUCP2IzYHtFb9YdfCnqsCO/LKS0bUOblDctR8qwQcgRHdAvVYTNXJ82JmL3n7rKOTfpnE4nMNKcjANNq97G+VD9bkh1sUUdm4Ogw73odBF7Pl1CQVQr+PvS6xMIH+o8QdeBOXiBEFJUW5CFUUfmgEpjb9c/MSSgO2rVnWHrtbVKLpRI2OBOBX04kIhF3NM6PFgnLUXshJYFAHVhM2G7bJOtq9vvy1bRC3LN+U6X1/MyJyni4gQX6dk5Qenp5z/OUymdV3/+n7VR4RjNSNhvzmTsRVEyN82iy75UI0c4Ya7p+C0H6svBp6WoKOxPEJW2lCKylIhKP21vO171Y/oCJuZddD3cQ+J22gCG1XOlx5/gC37K9SymDySovMkMjRv9pPoT0W0fwT9dJpCF0QfCxvMjUVwEOEAcYfLgGwwqskpo4Y/WfLhF6HqPegzz51oJwiAL+75mm094zPgbt5pf5uNopiNxkl1Q+BcIQRTEmjSUTRCxFxjo/K6Dy6XTCea5ltK7v0omZ0rAG1GDHlESKk+3tOLEQfynKZsasWASP/Qe5iny+A8wMjBd2rbWKsDkRYDdiEsPmzSrpO1zlMajM3zM0Ft+6zofMieTM+cdkxq/jQEwO94+tcMVv7nFevRJWtI/U4xObhYWarZqH4mdCuqLfUNuO219mheUa9AcaFMz9VNscbrbIWczY7KrFLgLNMfUoIObZk2lEV34KslXmMI2kf5sKIq/JCwjuN9AWhFR07J1vktIb9zVkhZ6/XFW5xTm0RYzIvq1+HjefgX9gZ0OfwfQqxvn7JzsKmZiLiFODJ6yj ofPhIhx0 2shrhIM90LJvvV+lHqHnMiJVUyOgKqaoxQs/gfCpWw3RB8DkO4t2HgI70LL2vC8Hdjvb1+j+LoBqIAmE2nWpTw+rp5AEfBe/hkUa4o7NF6/eOWLW5NRc+txkt3ehLODV39h2RlwHIq6HLjDExxudM0IgqVgUNZYEEIfFtxP+Upd90Y/BO5ion/g3lWRncokUn7JzL66FS0Mf9zDfByt9ojcZAgThk3oHveSs+1LjZxgejZPONH5xdF/aydBM6NmGBxNBKjxe3GJYHw/raDkjgWB0gnA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 15, 2024 at 9:39=E2=80=AFAM David Hildenbrand wrote: > > On 15.08.24 11:03, Hao Ge wrote: > > From: Hao Ge > > > > Here are some warnning > > > > [ 1.342603] ------------[ cut here ]------------ > > [ 1.342608] alloc_tag was not set > > [ 1.342623] WARNING: CPU: 0 PID: 1 at ./include/linux/alloc_tag.h:13= 0 __free_pages+0x1a4/0x1b4 > > [ 1.342633] Modules linked in: > > [ 1.342639] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.11.0-= rc3+ #12 > > [ 1.342645] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BT= YPE=3D--) > > [ 1.342650] pc : __free_pages+0x1a4/0x1b4 > > [ 1.342654] lr : __free_pages+0x1a4/0x1b4 > > [ 1.342658] sp : ffff8000833dbcb0 > > [ 1.342661] x29: ffff8000833dbcb0 x28: ffff000b34d9dac0 x27: ffff800= 08175f000 > > [ 1.342669] x26: 00000000000fc000 x25: ffff800082ac6028 x24: ffff800= 08252e000 > > [ 1.342675] x23: ffff0000c0660000 x22: 0000000000000000 x21: 0000000= 000000009 > > [ 1.342681] x20: 0000000000000000 x19: fffffd7fc3ac0000 x18: fffffff= fffffffff > > [ 1.342688] x17: ffff80008105bf68 x16: ffff800081841bb4 x15: 0720072= 007200720 > > [ 1.342694] x14: 0720072007200720 x13: 0720072007200720 x12: 0720072= 007200720 > > [ 1.342700] x11: 0720072007200720 x10: 0720072007200720 x9 : 0720072= 007200720 > > [ 1.342706] x8 : 0720072007200720 x7 : ffff80008237bad0 x6 : c000000= 0ffff7fff > > [ 1.342712] x5 : ffff80008237ba78 x4 : ffff8000820bbad0 x3 : 0000000= 000000001 > > [ 1.342719] x2 : 13c63f521095dc00 x1 : 13c63f521095dc00 x0 : 0000000= 000000000 > > [ 1.342725] Call trace: > > [ 1.342728] __free_pages+0x1a4/0x1b4 > > [ 1.342732] init_cma_reserved_pageblock+0x5c/0xac > > [ 1.342739] cma_init_reserved_areas+0x2b4/0x3f4 > > [ 1.342744] do_one_initcall+0x54/0x368 > > [ 1.342749] kernel_init_freeable+0x23c/0x450 > > [ 1.342755] kernel_init+0x2c/0x144 > > [ 1.342760] ret_from_fork+0x10/0x20 > > [ 1.342764] ---[ end trace 0000000000000000 ]--- > > > > To avoid debug warnings while freeing cma pages which were not > > allocated with usual allocators, mark their codetags as empty before > > freeing. > > > > Reference commit d224eb0287fb ("codetag: debug: mark codetags > > for reserved pages as empty") > > > > Fixes: 4b8736964640 ("mm/slab: add allocation accounting into slab allo= cation and free paths") > > Signed-off-by: Hao Ge > > --- > > mm/mm_init.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/mm/mm_init.c b/mm/mm_init.c > > index 75c3bd42799b..d7d40a8d738f 100644 > > --- a/mm/mm_init.c > > +++ b/mm/mm_init.c > > @@ -2243,6 +2243,16 @@ void __init init_cma_reserved_pageblock(struct p= age *page) > > set_page_count(p, 0); > > } while (++p, --i); > > > > + /* pages were reserved and not allocated */ > > + if (mem_alloc_profiling_enabled()) { > > + union codetag_ref *ref =3D get_page_tag_ref(page); > > + > > + if (ref) { > > + set_codetag_empty(ref); > > + put_page_tag_ref(ref); > > + } > > + } > > + > > set_pageblock_migratetype(page, MIGRATE_CMA); > > set_page_refcounted(page); > > __free_pages(page, pageblock_order); > > See https://lkml.kernel.org/r/20240813150758.855881-2-surenb@google.com Good timing! Yes, it's the same issue. > > -- > Cheers, > > David / dhildenb >