From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39071C48BC3 for ; Mon, 19 Feb 2024 17:17:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8059C6B0074; Mon, 19 Feb 2024 12:17:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B53F6B0075; Mon, 19 Feb 2024 12:17:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A4E76B0078; Mon, 19 Feb 2024 12:17:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5AF806B0074 for ; Mon, 19 Feb 2024 12:17:51 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F10C680559 for ; Mon, 19 Feb 2024 17:17:50 +0000 (UTC) X-FDA: 81809210700.21.7B9ADAC Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf05.hostedemail.com (Postfix) with ESMTP id 25A7A100003 for ; Mon, 19 Feb 2024 17:17:48 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TM6dK0la; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708363069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WTUgtDUhgLo3w13qAUwpQFiIiTT2/XDD2PV7WnKy99s=; b=BDe9/QOTn62gphe57m2RMqNzyfp5xhOWTD9ix9VdsoClVnFLqAEGneJr7G7uCQF/XdVhur aAXV/3h2Qe2GguM4dvNEq61bxCmgTTNVm4r3oyGcuKUF6Od9Os3MtIVfnyipydO2aj/QYH HnIcvEz0RPM08kBoDWKl0kWidr+Vl5c= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TM6dK0la; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708363069; a=rsa-sha256; cv=none; b=u6VpD/79e2iH//e8Bv2d0R2hrCGoLOhMBMYknMMUtxrW/73c8wzdOsxbcn2wKbZ07Cit6q gTH7xiJs0ziI6trdkZictvlhulYNc8F8HHQgYsoZVkqAFzcqVB2RgRPO8ncN4xdlKi6bgA vDrX/KxyiRUEP76sSx3R2JZFXZeOZhE= Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-60821136c5aso9579197b3.1 for ; Mon, 19 Feb 2024 09:17:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708363068; x=1708967868; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WTUgtDUhgLo3w13qAUwpQFiIiTT2/XDD2PV7WnKy99s=; b=TM6dK0la0jlC2VpisxvF/PBElNiYraUYqdiXFrEtuPSmUPMtPHAM35an/GTc/tY1oG tm6D2ixutyNPWpX8lOAHxvjqs89w1D4HPUyBwIDl9140YuDNqwocdxz8/NV/Dc2y721I U5h5qgWYUXXno4OXj7N9I9E9R+uJ0gWzN2ywhzm5/gTfqBtArzlWzOIKbIXHLeQcMHmM utzFpiAIsli25mPFh0M5XgGMI+ANORcn+NecDC+CqanPwghNBzYfYZZT7cIhyUDzWW2n LHKkDbXlZAP2tCzVv95Au0X+h0zu50xtrKk08BscVAk2KLg80jDld6lwYRyAnELhezcE M2bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708363068; x=1708967868; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WTUgtDUhgLo3w13qAUwpQFiIiTT2/XDD2PV7WnKy99s=; b=nZY1idpgDFt66osZFLwa82iR9iQLht/HhMgKD8TX26JxNAegIw2Iyxsf4DaPawubQ9 0DMqKjKxQtFrVZrd+87RJZc8O51fhxj6/uyHApFw2f/xlPZ8sKogU+sdP8EZBXZVwDqh Gss2w5qKx0dtcJ9rVcGYUr6sML7dcWcg9GqtA1okmnOhR3mYptbLEY/dz89Xzu7ktXN8 gD64rizCASAP9O2Esu1ouO/nCMt0jsy7HjJRpPD/yE8RwCQBvVp8/Pl34lz9P833J30r dQgfyxha9Qm/F1l1yP9ScPgZ/i0QCnfrHAROP3HkTt/2BIDVMuvrc2zeMoTe+UQAx/XS Fysg== X-Forwarded-Encrypted: i=1; AJvYcCUHl80tuW0yk3A+K1eLY4JA2+0v/iVZZW3Wvj5rButICx/SYLYMSFrCmUCxpHXLt1m/cS35a0hCG9tS2EgebKpjRL4= X-Gm-Message-State: AOJu0YwDjx1pPhW7EjFv+YED6OIjoki22NF8deIu7Oaw5FuhYBvcuqYU Iqlhmnx/IH5kEDaksdSafCc6AAw8qAIUEQ97OSMaLYUhPzAbNaP/fuCJDhvTjxAYwMGpSNMzMWz /3vpb/oLJ3oZ4BC+i6aNRjjtYkw2HCQB5Sbmu X-Google-Smtp-Source: AGHT+IG9AHtZq/nRnFo+ipW0aGaGM/b0s2YVjCOPysu8kdznAi+vUsM501VBmjXmNGbLKPb0POAqw7+QMoqVeqlQNww= X-Received: by 2002:a81:9b02:0:b0:607:9613:2afa with SMTP id s2-20020a819b02000000b0060796132afamr11401400ywg.0.1708363067747; Mon, 19 Feb 2024 09:17:47 -0800 (PST) MIME-Version: 1.0 References: <320cd134-b767-4f29-869b-d219793ba8a1@suse.cz> <20240215180742.34470209@gandalf.local.home> <20240215181648.67170ed5@gandalf.local.home> <20240215182729.659f3f1c@gandalf.local.home> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 19 Feb 2024 09:17:36 -0800 Message-ID: Subject: Re: [PATCH v3 31/35] lib: add memory allocations report in show_mem() To: Kent Overstreet Cc: Steven Rostedt , Vlastimil Babka , Michal Hocko , akpm@linux-foundation.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 25A7A100003 X-Rspam-User: X-Stat-Signature: oy6yj8bqe43kkaot8wefepzti7fand99 X-Rspamd-Server: rspam01 X-HE-Tag: 1708363068-278874 X-HE-Meta: U2FsdGVkX1/37y470nVL9M3NbiSoJGQqK3jxfjdPoPmAtXSqqc9dGrpYjQI3Hfc24hwOnDkG4msCe9teWCnobSuleyKH9eJfzkU/MskPKA/J2M3rGAZFfYskdqKZsc6AvHZ1oSAjgU4L0sA6ZsrS6yu2wTiWJ5hOHcMOLddb2lnzEnM87+WqYZ6qI0kiocsqxJWLcvRXuq2BNOjkpWSF9lqItlZkvjfomYTb1iZB5yzaQ2Fm903rh91J+xqsSbB3ynBKJSkgU8DHnmyI12LcWUA7ZnccbVG+GpUKdib/wDqWZvXrbD9x/kZHq/dbpjEasJTCvadkeRquMdtMUSB4GM/La5wDtk1PlCXt8T7Spp95UBnViOgHVSvMWhnSMynGwnzllbVQDlzCIhK5DwOGzd4tlZrTu4orNEg18NsZDrZAF1bP8ndBqZL9YIdyCOaShj3X9ZhEif/BMuf4shKrn9tx5ZuTZfTPqELan6T/Zr+PLo8wH5ewTswSyUh9cG99CP4mTar7doYx6Cljbe2KE0yTIQCRJL8lJ4eFi9MpZuH5isSA4jRB6IqcHVQs4ByKI/t7NfR2NxvMm3pmI/SkqgVZm0Gc/a/pHSJaAoTSaF1ClyigEEYtGJ2C9f+p9DrtTS+AqmrK1alOmn8/3ZQ3AX6z1kpE0dA8RBi74TrbM9PwzGMqOvs0LEYnvCqokWdQMF8CblfcaP1oJH37aAWdNVoRDRI462Pws7O90u4sOoYXsX4wPbDpV8T4eyOJwAvogMHj4jGjdL5TUw0hWv/GeH5SMjYIFJgfs7vCuMqnH7ZDhUv9cnz4g5Hi7RGOPHUSiK0CeyM0XNFCka9s3Fu1Eqx0uoHiLmvUZ+euZ2nLJNmKzi+5gm9E0BKCQoacRp7hTt4zZXjB+Gxz//2voHQp4M6+ySJ6UfMH6JLnFQ9J53QvhgxsIbOsfBWW0LIhC6/4LHoytDglmbFxm0FDf2/ yO6W2OAc rAkhEPV1dQWQf5oe7iEjgyJ2OjHo42YqhEfuwYavHsvZ9XtbJ5YcwLuc3eUmy17XnMARB+keL5GMMWy0ake0ypu/GjnU57q41o+oPk0039jv+z0NHv16AqiWFV2uy30SZ1xRVO3J9CiZo1PcQN3rrO2pagSDpSOSxW+QPUq+pk1DccTfpLCN9CemVOZpOM2Y7ApA7RddUUIRWo5vsgOsbGYW+iCNU86r6SJ8w/g8c4FrHr1c/sfh2J9OhysYASzf+I01DyxL1zs+zWedqur7g+e9YRWaaox2TpiDRzu4M407HRq0nKOTCTLaeZKmYAi8rlMqZ2oHChtf5aiWqHhT/FJjSgB03jdWH59rV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 3:56=E2=80=AFPM Kent Overstreet wrote: > > On Thu, Feb 15, 2024 at 06:27:29PM -0500, Steven Rostedt wrote: > > All this, and we are still worried about 4k for useful debugging :-/ I was planning to refactor this function to print one record at a time with a smaller buffer but after discussing with Kent, he has plans to reuse this function and having the report in one buffer is needed for that. > Every additional 4k still needs justification. And whether we burn a > reserve on this will have no observable effect on user output in > remotely normal situations; if this allocation ever fails, we've already > been in an OOM situation for awhile and we've already printed out this > report many times, with less memory pressure where the allocation would > have succeeded. I'm not sure this claim will always be true, specifically in the case of low-end devices with relatively low amounts of reserves and in the presence of a possible quick memory usage spike. We should also consider a case when panic_on_oom is set. All we get is one OOM report, so we get only one chance to capture this report. In any case, I don't yet have data to prove or disprove this claim but it will be interesting to test it with data from the field once the feature is deployed. For now I think with Vlastimil's __GFP_NOWARN suggestion the code becomes safe and the only risk is to lose this report. If we get cases with reports missing this data, we can easily change to reserved memory.