From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F689C5321E for ; Fri, 23 Aug 2024 23:40:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4D69800C8; Fri, 23 Aug 2024 19:40:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFD646B0258; Fri, 23 Aug 2024 19:40:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEC97800C8; Fri, 23 Aug 2024 19:40:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A2B246B0251 for ; Fri, 23 Aug 2024 19:40:00 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 401988023F for ; Fri, 23 Aug 2024 23:40:00 +0000 (UTC) X-FDA: 82485130560.06.4559018 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf09.hostedemail.com (Postfix) with ESMTP id 6D893140022 for ; Fri, 23 Aug 2024 23:39:58 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=oHromA4v; spf=pass (imf09.hostedemail.com: domain of surenb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724456357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kNJQW5kWoiyWIS1wEft5yKL6Uj+ZwBIolJSEzZeq2Uc=; b=ZxNdAxyIc/q3ojDEafDIPTXMHgZkfg6rZO6u1l7rXbIOKDw6Xhut+TMfQbiMOaIqN93k3U WzqLAXuWt1WB6tCf/3vA7tWQxwGjVqvSho99Yy+1WxCZGY1SWaHVO5wIgPRF36lenx3rlW OPB+GyqODoyfyUZzCiGqEVKrCBWOcbs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=oHromA4v; spf=pass (imf09.hostedemail.com: domain of surenb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724456357; a=rsa-sha256; cv=none; b=vSleb+M6O0sMlIWrc7rVekQKxgnDb0kF3L5L/CFgtSLdIqwev5QVfWxfZ/f/+T/Lrv5s+w kCr+gsLHzBO39xnA04DKjL1M52vSU9mlWlYT5nbBpTsI8iS3pgIc5skN1RN7r1BfMFkY0A id1MoRHZ+6Zm168Q0hfAxPXnomtQyyw= Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-454b1e08393so137791cf.0 for ; Fri, 23 Aug 2024 16:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724456397; x=1725061197; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kNJQW5kWoiyWIS1wEft5yKL6Uj+ZwBIolJSEzZeq2Uc=; b=oHromA4v7DJHae0OUeKkvQ4Zer0IzfA/u4RBJDKvZEA6js2i9VtzE3MQxiLiym7dLr 7SoKIEGxxRy3h2dvT8jJ6ivaH6KKjq0w0JfCPHZv7DbqdJPYVwevBNyMzSsvHoQyz9GH y+d19I89+chzr5kFX9b9ekgxYVeigSoflO5q/FdGZDori/KEeVcqRGR7EzyWyC/IaeOP NjZmJOzoIimCX5df1NjtCTg232Omsi4a815L0J+cKUi948yER9QLge3/CjPuOCOt49D6 /vvSdVzwd9H5jFad12YDc+jyWWAbVoqixsX1pOMFSulNBd410blQ+MF38IAZDDiaS5DH cOWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724456397; x=1725061197; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kNJQW5kWoiyWIS1wEft5yKL6Uj+ZwBIolJSEzZeq2Uc=; b=ZrIhrwAXkNHgEjNr94l0uhVF2y+rRc7znw/RJfQGHVZYcunBqwA7x6l9CghWeTcKq9 oPTntTZIIo8TAvNxvsF9j/GRRJMvx27nmMGP0Z3pJsFus0S74KyxPtbfXDb8CrcynSrl PVYD8sO5qbS3O7hsukG/g8KeyP9ltf0AAnyi9E10L0paWiXcbP5QZ0paIefhUEC/tkSl ZkwD4lS3vVYFK1L22ENH72kLgMvhPHdubDty4zdChB90fIrEBnsk0W2hbVG0liVx8Rkv A3DT2bcgQGPx1S+RcYN/rq0WSAOXl/ibeAP7nDmTJtaWJeuWIsmCET79wPQXAQf5QkA9 tp1g== X-Forwarded-Encrypted: i=1; AJvYcCWXRaffrLWGbe0uPIncxDvgMn9U4laz5ReITZHi9fuECEkln6jl/BhlyTF/laweWLsPAtIH+R8vAw==@kvack.org X-Gm-Message-State: AOJu0YzXKr0hNi9d7ary51vZdZOEG5ZBUvUmv2TG5IpsqhCLTj84f1Ji aEsnYl7ns9J501yIBTXU/Uqy33jsrlMMhq1XLkv1cxYs0+LPFfZfBb4G7kGJ2s+Rml0dokLyiBB LZm5Xe6z2zrjcB4OCeHO91kmBRHk78xIR+Jtd X-Google-Smtp-Source: AGHT+IH1hc8yYuEp7WVu5DgIPV+CZe8iSGviZ+TgZTzQmeBssZ8vt+JQIleeid6x86dKtzRWBWqsrOQrdpWs0XSsvzk= X-Received: by 2002:ac8:5f07:0:b0:447:d97f:9765 with SMTP id d75a77b69052e-45642044d31mr1174401cf.16.1724456397170; Fri, 23 Aug 2024 16:39:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Suren Baghdasaryan Date: Fri, 23 Aug 2024 16:39:44 -0700 Message-ID: Subject: Re: [PATCH v2] mm: add lazyfree folio to lru tail To: Barry Song <21cnbao@gmail.com>, Lokesh Gidra Cc: Michal Hocko , gaoxu , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Shaohua Li , yipengxiang , fengbaopeng , Kalesh Singh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 6D893140022 X-Stat-Signature: pq7kgka93fk6d7tcq1c4x9j13sc99ozf X-HE-Tag: 1724456398-787891 X-HE-Meta: U2FsdGVkX1+Ln+PzvXNWheXeVuS+KR/V2mb/MZ+yfjHgglOk9XeuNMKUqjCZwrsSqyR5tdqU0erY1/ZaUsJaeR6JM25dS5XnePpq1Y/c0Xvh2uZ4PfiiefECrFG6f+/ZIgQE8i1ji+XIoSDHQiyLnZpIsVEjzyImkjBMoBSxkF/BJWuJRxUmbWMxEvr73SZxJzEMvu9QTJrZEmKlbmTwItL1w6/F4Y61z4YPcFuJh+sgQHPhTw5Wf9J++UDowgXptqfY/MPqnYRWfH1RsrWOnRh5uisLu5Moixhn4LIL3yw/VkJS48ddL6jBRXH9/KKXLrhKrM3Bw4p2/17QZz+T3MFXU34S/T1VVGifPpXP+c0rg531ViAJw2TemRoOTpn5foW2ctPGfACvmJz38HfVtka2y8zi3Hk+I7xMhk3hhIGnZskbPHbezT9+r7gsce6o0WvNbJVC1+nMmzZNdntfGlJi6mipCtJZV1DjaDXmeDFfIfks5tVGN5Hejak4bDYzIYRUZt+ZxfuEG6cE2QRUIel6iztfPmvisrkBc2FtFT89iBVInK25nV0O3bHp91YpOrBotuWXLSVHJzfsRM4vGWfpdk4iSdsSSC8KicgRNgpQ8jBuo++aJzRfRAWMLUBoNzKSOpzIKwoHp4hdfcNwRPGnqjezKECRFlqTmOCuNvrHOg6YgxnQZIiaZco5ldzHo3WJ/C1OX2eQX+Wpp6yQ0KpyIHDENgtaubQ3CtAuJatvw6iVsW+vOljuiJ3i4+KN3xzFlZ+odPk3dr/SdmyWKLsEZMx0L4Y3SGqZt9Clpw05pccf7LQ3qmkvAVrkqijEJ4ibpozQewg0VPeKSI1R1MbRxgQxgw3w1BNJRsJovqKsUCwToKnfpUQBPJqndIVQc+Rh85y9ZQ3Q8sE+ueFY2raK87yZc2yuwFJN1xqOuWSfXFQycDYSrSYph84nKWAgnLvk3k66oNoYofiWse2 IqWiQL5T Z7kUEQYoBzpvL4UUwqf5NiunZSmSkPr2YGPJhDP72fHGi43ysi6LNKym3mcZAIPTtlzF/9IWfiR1rf0NTuFo6K2oRXJxNGkdeVPvsUZ08oKoCLnjzrFefqZkLd2d2o52xXzxykrHhHWU56lbO80v1NNIkQxwS1B1K/OAYpBONQVSRDg+EUohkkpzg5JWAC0GzE8n9if5zfZac9IQ7qyYXcXxoTx5WEf0uM0djguXESMTw0X8pXEbR2jy1NWJqM4Ja4s/47RPs3Anhl3e9G8iRmnYipVMJovTQFAuyGImEpJhToPuQXe7ThCmbBEUtLG9/0Nf4eA8aeidZtKoUWJykcwCmNdb5qNSQEZ4t X-Bogosity: Ham, tests=bogofilter, spamicity=0.030267, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 21, 2024 at 2:47=E2=80=AFPM Barry Song <21cnbao@gmail.com> wrot= e: > > On Wed, Aug 21, 2024 at 8:46=E2=80=AFPM Michal Hocko wr= ote: > > > > On Fri 16-08-24 07:48:01, gaoxu wrote: > > > Replace lruvec_add_folio with lruvec_add_folio_tail in the lru_lazyfr= ee_fn: > > > 1. The lazy-free folio is added to the LRU_INACTIVE_FILE list. If it'= s > > > moved to the LRU tail, it allows for faster release lazy-free foli= o and > > > reduces the impact on file refault. > > > > This has been discussed when MADV_FREE was introduced. The question was > > whether this memory has a lower priority than other inactive memory tha= t > > has been marked that way longer ago. Also consider several MADV_FREE > > users should they be LIFO from the reclaim POV? > > The priority of this memory compared to other inactive memory that has be= en > marked for a longer time likely depends on the user's expectations - How = soon > do users expect MADV_FREE to be reclaimed compared with old file folios. > > art guys moved to MADV_FREE from MADV_DONTNEED without any > useful performance data and reason in the changelog: > https://android-review.googlesource.com/c/platform/art/+/2633132 > > Since art is the Android Java heap, it can be quite large. This increases= the > likelihood of packing the file LRU and reduces the chances of reclaiming > anonymous memory, which could result in more file re-faults while helping > anonymous folio persist longer in memory. > > I am really curious why art guys have moved to MADV_FREE if we have > an approach to reach them. Adding Lokesh. Lokesh, could you please comment on the reasoning behind the above mentioned change? > > > > > -- > > Michal Hocko > > SUSE Labs > > > > Thanks > Barry