From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ED71C5478C for ; Mon, 26 Feb 2024 17:13:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F111E6B00CB; Mon, 26 Feb 2024 12:13:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9A176B00DA; Mon, 26 Feb 2024 12:13:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC6C76B00CB; Mon, 26 Feb 2024 12:13:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B3D376B00AC for ; Mon, 26 Feb 2024 12:13:32 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7F5314096F for ; Mon, 26 Feb 2024 17:13:32 +0000 (UTC) X-FDA: 81834601464.07.59D93FA Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by imf21.hostedemail.com (Postfix) with ESMTP id AAC721C0023 for ; Mon, 26 Feb 2024 17:13:30 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="jpBYZU/Z"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of surenb@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708967610; a=rsa-sha256; cv=none; b=qduWGvF1BXA+RlgQVzPFOQxDSCN6d8uvRwDdy6XZ7UWUw3h+/Ki0gey8ZHb0WF7t323Zxw /kQc72OwUVGNHlFioO0QTk/J7HpOD9ahqiEhZi0qpe5m+Ffz1OVnrMmzDTL9P4hCuGEe8x y69oKmDhlW05ZY0BFgLuVZi0ZXsO8Hg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="jpBYZU/Z"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of surenb@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708967610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EyV42V4YwospafBlBP85zlF0CzzIrV0ckGMLg38+cps=; b=bMdAATHuz6nCIk7WUZRmJewW1dxQSyKYOT4r66hTQfIPZiNvc66N1Tqmwb10wYr1B1VLmV 0xfPK/3M67o8GTAcM5RywgeUFdqQAMrw/zAg7JWPrIHkA0H8gmgeLqAx6Ps+ucsLCzzUDv TPeTNiAXpAgFShq8qUYSci/ycVQYsC8= Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-dcc86086c9fso3383465276.3 for ; Mon, 26 Feb 2024 09:13:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708967609; x=1709572409; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EyV42V4YwospafBlBP85zlF0CzzIrV0ckGMLg38+cps=; b=jpBYZU/ZuPajDUfbArkKXFUdBuOmtxXeo2WzdCsJJ/vcdDKIBuBy6rsVLHSMiFa96K 9mi+ELWtWcOdjZNZYa+sL87UORoK3cOh22at8wejFlgPyIBa2EtMpW1mLHO8nsLhpqhG 4KugZmeoUCrtNC4B+beZDcm9Qtq/KTTHsg2qx04a38tGTGyHWCK4esnN1ZZpufzP9Ayr S7b+koY/MyRi9xJv3vfhyDBLYg0rIDGOBmXI6dHwvtq8AQDg2bzcIOCXoZ3lAc4anMoe HQOvUEcFxrxLILXPAnMgq5kXa7yMNu3zroiXI4p3xwsi81DVmf35pw+YGQs85Wkn9r1g RyNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708967609; x=1709572409; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EyV42V4YwospafBlBP85zlF0CzzIrV0ckGMLg38+cps=; b=lalK+7+ItWMGZ1qJNSntEnconoy4q7o4mROENTfJIubiKdOShampKeDxRs3k0VVaV0 2MGukynDqY93vfdMLBDY9Js8ro3nrnrVyoHknoyVUmpQBsdVJtA84beD2KZkTyVN97nA wAB5Ppei2FfuZygJkkptO/7hKaF7oLoTLcs3tnWuFW5uOCrNN0EGPu0kVRIk29izFTr1 sWXLehxZ/INQOXlO8ZntIvqJli/NFWvhdWhZob1cML0p7RvWUKnaJhvxvvrulNOh84LK GJbePuoGMrqgYlYN8L5t7MehrdzC3Ea1TcoLhYyt1Ctg/OHTGZh3ZVItnhSYNngGMGoL TfsQ== X-Forwarded-Encrypted: i=1; AJvYcCV5eJMsVPNk+o82i9+NPRhZtd7FZ1uh0Yej/eyYwFe/NFhYsngKS4C+WrW+Y8fOhgTXbnJ2lLfpZHwwiIsZVuZHKHY= X-Gm-Message-State: AOJu0YykXpOWtk08VyH2fv3g6spGNfMUFBrzr0sHlGHqZjgawFoHpPDE SRQGRTdun0H2wUEZa0JLuD2yfuyKZj2fKeHaTZRlox6ys98+lHNw6VdBJs6sPcfk//h2nV0jSp+ SX0MV0+aDqtaOCV6BtoO3lPWZitue84BbMdou X-Google-Smtp-Source: AGHT+IE/7/pQws6CVfL30UNt1mkliSDpCczaElkub3hA0YpEAm7Kcwht1trOE3ZU3RPvAg7BLiFgI/3lAi1UqBVzgIg= X-Received: by 2002:a05:6902:210e:b0:dcd:1f17:aaea with SMTP id dk14-20020a056902210e00b00dcd1f17aaeamr6639276ybb.26.1708967608014; Mon, 26 Feb 2024 09:13:28 -0800 (PST) MIME-Version: 1.0 References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-14-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 26 Feb 2024 09:13:17 -0800 Message-ID: Subject: Re: [PATCH v4 13/36] lib: prevent module unloading if memory is not freed To: Vlastimil Babka Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AAC721C0023 X-Stat-Signature: d6rc8wq7corq19ehwpyok51f4sdcxhbn X-HE-Tag: 1708967610-105965 X-HE-Meta: U2FsdGVkX1+OI7M54eL/C3BDduTmViim3v2gxDcWGRUyDqoX2iAzaWnYC2HkvXy3g4qw1y7gzR42N3Vsz87OkeA0SjXSdki18fT49OSLDpQAB25qzslcJqlEg3jHQNYBHnXkNu5qdZlFWsE0i1sQCikPudMWs98FSmcp2b1A+uF3B5BoubvHA8RToIshhcza76uqmEp/0B0qF7xslkMK6GWO85bfr5eZDXxfVAFb8HaC5N3vhpXEks18si3avwb69ZCoHknQ6GQ2PhN17UZ9iLw/XXVM7x5CcsZETNyphaspC/Nh7OcHA6fZyI/yaZskrWyZhA8wsx+gvQVPJXAz8zz+8JgnhhLSc4SeUSTBHtw2sHBCcgwyOPy091InD4HycAmThnigJcUJGfEjFx5BkEeQ4pbV+W8zOMZZ5VyxqwFDUWzzu/mTCmVSklBqShcDF75Qh/htD0pFgOoOKHhrsMwP1OIL43LZ8W1Nsj6E7Rb/QMOlakFwG46rWdjiQQ623OMdAuEbvMcXK8y/bX9GYcsU7HbhRPBtSnG/UCviAYhOCfCFrIfaCfYytW7yu4CbxU8eQQYRdnJ97QI1BBopH7a+uP0wNMKEAK0PP9EHhlsa8KgqS4cLXBcnqZN2eGbwCbbm6ZkV7yCqKXU+6Jw9hF0D7wBrr3kEl0Jwtq6uz6IM2Vs6LgSfC6H6K3R/ZuPC/590zT/nMOAVvscGdAgjBUOIH08uxakjhelDWxrZvr9P/bVtcg1bIBCGUejod0yOvVt2dZaa9HDQHboezQYberr4hWR3c3sGNSWLYx1wX7edbiG84e6O2C9e8JLpdVYCm1MxWs7KyA9+KVJpV9M24tfej3pVH/NV0jgvlhvrc9Z0tYWxal8UcRMXuqNpE2xxuFlC0eYqj+NGddTeOzB2854Z1dBKbuTvEdvz6USPd5pkOx09XBkEftcmlOxSXa2b0M+Ae5OjULoGt6bEB00 V5k9f6e4 aKwPHiDdErX+FA/AR/qfHnSUSWxqB+ZCVjOlZgeOKJkfrY8yHeGkCDVUMShH+Kb9ShFUM0/T8o0/jvMq3p8eQUrmQobX8X8B1IAilzy+TiGc/Yg+MIGWj2IQVOm3yqqYe/0v/DfqJFg1PO1/aG29P8oKFEruzekYGIumxJi3xooC+sznAbCXhA6P3p+fFPtlaujT9UUZFUl/9X1r/YeJDVwszePkTHOMP4EAPEdpnctXDDODB48LE1L2pSWYtpYQZLH8VjKCqfjNFPEJcvNuS2yp5bbp03KCh0kC43N/Jta4FI7qcSusuIdfgrkZX/EN1Cmr2dI7YV2xkmiY60O5UXP4xv1xn0WZROlSd8tWkSjQNWwlVYQmpfhqtduN00NWpQe1Zl0HhzkxVMGM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 8:58=E2=80=AFAM Vlastimil Babka wr= ote: > > On 2/21/24 20:40, Suren Baghdasaryan wrote: > > Skip freeing module's data section if there are non-zero allocation tag= s > > because otherwise, once these allocations are freed, the access to thei= r > > code tag would cause UAF. > > > > Signed-off-by: Suren Baghdasaryan > > I know that module unloading was never considered really supported etc. > But should we printk something so the admin knows why it didn't unload, a= nd > can go check those outstanding allocations? Yes, that sounds reasonable. I'll add a pr_warn() in the next version. Thanks! > > -- > To unsubscribe from this group and stop receiving emails from it, send an= email to kernel-team+unsubscribe@android.com. >