From: Suren Baghdasaryan <surenb@google.com>
To: Harry Yoo <harry.yoo@oracle.com>
Cc: akpm@linux-foundation.org, vbabka@suse.cz, 00107082@163.com,
cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] mm/slab: mark alloc tags empty for sheafs allocated with __GFP_NO_OBJ_EXT
Date: Wed, 25 Feb 2026 08:04:34 -0800 [thread overview]
Message-ID: <CAJuCfpE6XVE4BswKbPPx_bz7pUy=zSQrm7njmKhZ=ryq12fNQw@mail.gmail.com> (raw)
In-Reply-To: <aZ5dxxgIb7MfuRVW@hyeyoo>
On Tue, Feb 24, 2026 at 6:26 PM Harry Yoo <harry.yoo@oracle.com> wrote:
>
> On Tue, Feb 24, 2026 at 02:11:32PM -0800, Suren Baghdasaryan wrote:
> > alloc_empty_sheaf() allocates sheafs from SLAB_KMALLOC caches using
>
> nit: the plural form of sheaf is "sheaves" ;)
Ack.
>
> > __GFP_NO_OBJ_EXT to avoid recursion, however it does not mark their
> > allocation tags empty before freeing, which results in a warning when
> > CONFIG_MEM_ALLOC_PROFILING_DEBUG is set. Fix this by marking allocation
> > tags for such allocations as empty.
> >
> > Reported-by: David Wang <00107082@163.com>
> > Closes: https://lore.kernel.org/all/20260223155128.3849-1-00107082@163.com/
> > Analyzed-by: Harry Yoo <harry.yoo@oracle.com>
> > Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> > ---
>
> This resolves the issue on my machine.
> and the fix looks good to me, so:
>
> Tested-by: Harry Yoo <harry.yoo@oracle.com>
>
> and
>
> Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
>
> By the way, perhaps it's worth adding a comment on __GFP_NO_OBJ_EXT
> saying "you need to call mark_objexts_empty() before freeing the
> object".
Good idea. I'll post v3 with that comment and spelling fix.
Thanks!
>
> --
> Cheers,
> Harry / Hyeonggon
next prev parent reply other threads:[~2026-02-25 16:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 22:11 Suren Baghdasaryan
2026-02-25 2:26 ` Harry Yoo
2026-02-25 16:04 ` Suren Baghdasaryan [this message]
2026-02-25 16:39 ` Suren Baghdasaryan
2026-02-25 2:50 ` David Wang
2026-02-25 16:04 ` [PATCH " Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJuCfpE6XVE4BswKbPPx_bz7pUy=zSQrm7njmKhZ=ryq12fNQw@mail.gmail.com' \
--to=surenb@google.com \
--cc=00107082@163.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=harry.yoo@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox