From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0110FC61DA4 for ; Thu, 23 Feb 2023 21:16:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 621256B0071; Thu, 23 Feb 2023 16:16:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D2646B0072; Thu, 23 Feb 2023 16:16:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 499C56B0073; Thu, 23 Feb 2023 16:16:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 395436B0071 for ; Thu, 23 Feb 2023 16:16:39 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0E3C11607CB for ; Thu, 23 Feb 2023 21:16:39 +0000 (UTC) X-FDA: 80499815718.20.F948087 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf05.hostedemail.com (Postfix) with ESMTP id 6457B100023 for ; Thu, 23 Feb 2023 21:16:37 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="fOZe/etv"; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677186997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ndbjrFZ9GSZE0VRCf9RR1AX4PdczliTx2DTBUnXjBAE=; b=43FVDaZTQqqrwrXBlMM11hE2aV2d1Kq6UPOq88eqrxDD48w/HLymnAFefIL4NYkrzx9i/q MRUyJdNMgb9cfx81E7qbQ3GUQtXXkINAaI11B/X46QjadgcSluDhrXaeyx7NmqntIONXT+ RusCBam4054c4ltNR6ymIRn83kG9mqs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="fOZe/etv"; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677186997; a=rsa-sha256; cv=none; b=FDcgklMnCTmkopdQ7Y9NJN80eDorlIw5m1RTCDy1pX6tVqXAT8VCZH3tGPQeOkBzP5y8Gd gJK/fuRXPA/rYc7PAVmR/MaJLmWfD6sJeoshBarncQhfNbUVgwkrQ0mOwXD2QeXzxlScN0 QHWFvhsWeSJN61Jq3lCeKp+rixV8fFM= Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-5384ff97993so96143587b3.2 for ; Thu, 23 Feb 2023 13:16:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=ndbjrFZ9GSZE0VRCf9RR1AX4PdczliTx2DTBUnXjBAE=; b=fOZe/etv+sd4bjNAksYDFrOZg/TXHF0ZFee94D/FMNLSiu1oT3zVfj9vXDPN1OXHfC oGpNm/0bUQSCD40wazC4yNQtwIUaBRFGc6ChZr9+zqHL5JCnTHKtfE/y1CKAytTCh8ud YgvLztPGCWRwHZnl00ai1khB8xrR3uwMyFgbBw9S3xWwoIbrtPJIq/IsLnmZNQ95q7Aa DB4GcBJakRFaW2aeyli9AXrO/MPhf8f0AXph6Di7Wamlw9ozMqaHYvh7IuVETCAVYHF2 gu2S4EG23EVj9ag0ipdONVOC95C+FrB0EpQCzvxAEO3UkcRHV5DhFjKHRAP66CsyUt+6 LHZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ndbjrFZ9GSZE0VRCf9RR1AX4PdczliTx2DTBUnXjBAE=; b=5ecpvRMs/XO0oAUmYbfYM5ZjoXfUMw9LGhO4r32d1MG+S+L92Y1oZ78YdlOTOAFHQc TMPBpzFq8NbwmEkGVeu2MFW+ZwuvFP0ZSzbvi+cU24kPUDmUQRwOZ5JFHEzgQCTwEEfB /PupsPA9oE8aBbbusqUu0hBdo3Br/0yKw9WwZOBOmk++ATkr9CCh/p7vAudQ5sXRyiYx Uoq44/dKGZZogH5NirsyKe87o1LYyaxF/UQXp42FaRtMMGzib4Mu98R0kvA9Y8E3aCDG whZ95RWDxDYdnX+6l13ej492LpoOtEzvVprJu9iDK3BWjbppBoq0uQeoFC8XFzGLTsqo 51HA== X-Gm-Message-State: AO0yUKUwuyzf3BgeRdxnVO7d3biVF7/QR/E8NwzXnwd8KNr75KyOBL7J nqiKievRjydmdOJHILX4Hfq9GQNfSya012QRywaYFw== X-Google-Smtp-Source: AK7set+cwRVt+nMfGVc9n+QUpRmsobXIvsJ4diFjxtv+Lveh827iF3Klb3XyKdd370ajPY2MbPYibo7hGyB9Z9jW5Oc= X-Received: by 2002:a5b:b07:0:b0:9fe:1493:8b8 with SMTP id z7-20020a5b0b07000000b009fe149308b8mr2486525ybp.6.1677186996282; Thu, 23 Feb 2023 13:16:36 -0800 (PST) MIME-Version: 1.0 References: <20230216051750.3125598-1-surenb@google.com> <20230216051750.3125598-18-surenb@google.com> <20230223202011.dahh6cidqxhzoxne@revolver> <20230223202844.noant5suylne3dnh@revolver> In-Reply-To: <20230223202844.noant5suylne3dnh@revolver> From: Suren Baghdasaryan Date: Thu, 23 Feb 2023 13:16:25 -0800 Message-ID: Subject: Re: [PATCH v3 17/35] mm/mmap: write-lock VMA before shrinking or expanding it To: "Liam R. Howlett" , Suren Baghdasaryan , akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, michalechner92@googlemail.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6457B100023 X-Stat-Signature: 61agy86gwghsbff7dxo749ee754img7z X-HE-Tag: 1677186997-249309 X-HE-Meta: U2FsdGVkX193a3sdM9DKxwZXOPvc11z3urdNqslB7GMAlruRltXgma87Z/lAXbN2D51LPjL+v5bXY2wlf4hqB96bhJFAEFrKhM1IcCt3YIuYi2/esvYP7nyOFPiNkkvUrR23jRYqN3WPaEBLbyKXG7uc/LMvPtHbeL8c9dTagklWNyjQ2E31/DFsseTznohsgQ2sGsvkdSYWxI0h7ANTWPFe7aGGR9IyOCdFAoFGpIUcxHN7PiHCAAxPPkv6Oz+SdI55Puz4ECrNMAvkfnym5wbihj4iZyV8gLLIjcnGnqxWMW5CYUBXW/xicZCQ3LcU7gag51my4vXOBRJ/JNWhoBSCzb2IvRUTNNQDJu3Rqk6MArkZDn6brpAshTnM6jQNF/esdJ9DWQkTf6/GmkGeRpqFiGv/HbBwWY8wOA0M5mHhlOFFScEnvm0TxUT2BQWtS7POboJ8u4decuE5aWoXjQ0xK2ryH6GXGk5zC7qTnWwlb+813hrZw/o8aaCyAD86cg08zKRiW+FYx0dGkSTibuvDKSF8Jg8mzD9kAfamJ0Pzsal1Iigeyrzah2L0zu2SmY+LXpc2JOHCaAep8ba2l9FjtpG2tnu/2vDtpHnhu2yezk3XEuY5H8YTL3fs8DyktRPdrbVJRcsK1oT1QHA8ZHaGhQCCgvpbpsiYwOkfIwTj8+p8Srf57V9vwc2U3vQdWERgP2/wJH1k18fKAEmLz0hp5sBuNf7dXkus4icqcKy+V0hfbJzJoW9OHxMIF9v0I88JBcmi2n0R7c2p76W3/PakRzEsx8Lc3G1WUJzyXtkJ+KiSQl7sHYj038OR6Oh4oBID0C8xbhm3xEzs8jvqgzNd7Wncp8h6ySNPskiT9eSV0lrhhkE6PdC5CfwlltKUOxkjkJ7psbc0ctvQASGsySxySu7a3cbwI8WmkLO0EYaom4tCvKTZo803CbfDNmdcph8IL09Lf4HUP1G1ET3 qruNWkhO 0SYhiZT49ECTl3SJf6CdnqICUzCSpsV7gQIjnF/RImOc81VORhldlExfwNpyamBiz3lYnEKEtlVlzSzKr70KgMbBjoz2qMdNN2pjJ0DtxI+Sn5ip0VCrNzZYSUchJPh7KYWmoinsw5xIaP9YJHbthAEII++xUrwQGNwduSw7Lxt2EP69h78qi9BODJ0SV/ihEVfN6KAmzgIdW8a/USvWARNaPUKDcn1vkNyhwTyxDW4htIBaHhZhKKgVONwT/SZXn+/i7bjauc5/DX7Gej46syQpXk2OoX/ZvsNvej72TvzVimbY/BG7JkXpAJh4d2RJoL5nKmToklG9Zn9rVSSNXOlvMwQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 23, 2023 at 12:28 PM Liam R. Howlett wrote: > > > Wait, I figured a better place to do this. > > init_multi_vma_prep() should vma_start_write() on any VMA that is passed > in.. that we we catch any modifications here & in vma_merge(), which I > think is missed in this patch set? Hmm. That looks like a good idea but in that case, why not do the locking inside vma_prepare() itself? From the description of that function it sounds like it was designed to acquire locks before VMA modifications, so would be the ideal location for doing that. WDYT? The only concern is vma_adjust_trans_huge() being called before vma_prepare() but I *think* that's safe because vma_adjust_trans_huge() does its modifications after acquiring PTL lock, which page fault handlers also have to take. Does that sound right? > > > * Liam R. Howlett [230223 15:20]: > > Reviewed-by: Liam R. Howlett > > > > * Suren Baghdasaryan [230216 00:18]: > > > vma_expand and vma_shrink change VMA boundaries. Expansion might also > > > result in freeing of an adjacent VMA. Write-lock affected VMAs to prevent > > > concurrent page faults. > > > > > > Signed-off-by: Suren Baghdasaryan > > > --- > > > mm/mmap.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/mm/mmap.c b/mm/mmap.c > > > index ec2f8d0af280..f079e5bbcd57 100644 > > > --- a/mm/mmap.c > > > +++ b/mm/mmap.c > > > @@ -674,6 +674,9 @@ int vma_expand(struct vma_iterator *vmi, struct vm_area_struct *vma, > > > ret = dup_anon_vma(vma, next); > > > if (ret) > > > return ret; > > > + > > > + /* Lock the VMA before removing it */ > > > + vma_start_write(next); > > > } > > > > > > init_multi_vma_prep(&vp, vma, NULL, remove_next ? next : NULL, NULL); > > > @@ -686,6 +689,7 @@ int vma_expand(struct vma_iterator *vmi, struct vm_area_struct *vma, > > > if (vma_iter_prealloc(vmi)) > > > goto nomem; > > > > > > + vma_start_write(vma); > > > vma_adjust_trans_huge(vma, start, end, 0); > > > /* VMA iterator points to previous, so set to start if necessary */ > > > if (vma_iter_addr(vmi) != start) > > > @@ -725,6 +729,7 @@ int vma_shrink(struct vma_iterator *vmi, struct vm_area_struct *vma, > > > if (vma_iter_prealloc(vmi)) > > > return -ENOMEM; > > > > > > + vma_start_write(vma); > > > init_vma_prep(&vp, vma); > > > vma_adjust_trans_huge(vma, start, end, 0); > > > vma_prepare(&vp); > > > -- > > > 2.39.1 > > > > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >