From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81FE7C05027 for ; Wed, 8 Feb 2023 22:52:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC5746B0071; Wed, 8 Feb 2023 17:52:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D75476B0072; Wed, 8 Feb 2023 17:52:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3D0D6B0074; Wed, 8 Feb 2023 17:52:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B39326B0071 for ; Wed, 8 Feb 2023 17:52:11 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 86263AB284 for ; Wed, 8 Feb 2023 22:52:11 +0000 (UTC) X-FDA: 80445624462.15.2618D3A Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf03.hostedemail.com (Postfix) with ESMTP id D1D5520012 for ; Wed, 8 Feb 2023 22:52:08 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=spW3XuyI; spf=pass (imf03.hostedemail.com: domain of surenb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675896728; a=rsa-sha256; cv=none; b=4fJA4PaGSFmj3A/raNUwBTLkY0sJVtyQa1EqAq4r0h7J0JeiaI5ADdzuo8itcTumCNv4FM xqd8QbhaIHpP67Glr869/nOAlmpzwKosFJsnG5YB0y95dEJmFnB6qz8jwVdOhCX/lPU5Lh CYedhFK9awhjqClZ19CC8rmN06Q0I1k= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=spW3XuyI; spf=pass (imf03.hostedemail.com: domain of surenb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=surenb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675896728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lWgdfewcuTEh14INhw6BmK3uAeHTsrDazjd7F3wRM/0=; b=E4J7GQ+0CGCTheYaO00GInMfwAvxvI3Mmj7YHuffWJr/tly/U/pFjTYtcPtBOUwzBfJ5ps ELrfKGTMJEoJxbyP23kAisO8Y4i4c6+h7rigD0mCSH2ujULkpeKwsugKcpAfZi8VP6BdVx G8lGzM1VNFXYZrN0rps/qfu1BS9SJ90= Received: by mail-yb1-f180.google.com with SMTP id n139so219228ybf.11 for ; Wed, 08 Feb 2023 14:52:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lWgdfewcuTEh14INhw6BmK3uAeHTsrDazjd7F3wRM/0=; b=spW3XuyI/ZmenUIo3SlG/R12eVoe/Pf15SlWNRc9gRkynL3q0Ve5gDlvPvxGr5tL4K mcTMicw9Zjz2h6ON6hEbkjYsmis4nZlv92NdKCxPbDkkJwh9cs0FyskIRsVTA9hxPI2Q XQJc66YQLdNEdtTW3vISbX366QltjagIKXbQZQHxwgCIcgHMS8OwhGyPuHJxxHInduG2 Eh9RiDfrCkqOt9ZBReWfrg2MIO7oCvm4C5nfCwSrRKTn9rlv3KBb9kZQNtTt9EXiHxDm nLFyjkFyP02fD3/KFpe3R6jwgkJjnqSazEzy15NdcR13YsvHjSTMczhuq6lbef5aYz28 g1bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lWgdfewcuTEh14INhw6BmK3uAeHTsrDazjd7F3wRM/0=; b=i0jFrek9Cv/IeAb3u3c9CIWE3qW/4/fA53JKuhov0xUqDPqeCjTNUzkJTU+Grb8ltW LHzI2mAH3ng5D58gqaUWQ5sd6d9aCLTV7mcWMtvnVDxo5/pwHmcAnMqgRjCMLj7J2M56 Mn8OA6/B4n8zsRPM80c2sFC38EtfoXI7Y9sk3x0vdOXQiRxe3Neu1QXvRx4FXV29TbMN RlwvqFwmo/Qq8IVnwNbqYOcpSRi7IjwQGivWMnSqyY+FPdbQdcXOhwe4hANWVy/tfTqn 2h8qF0hufCIyl1aMyO2xxp0MP20Aair4v3pWvazH8b6vfwZlwKjnVvH0eR00VExYrfWr +t0g== X-Gm-Message-State: AO0yUKWo4TN16mk5WP7INwrRqKO6sdQou6nOe4vrrPrfslVl1JPM+cNZ Xmww/o+eYENs89TuXhLhJCqTrx1oOvG9yjqc4jfPSg== X-Google-Smtp-Source: AK7set+cBVwl3WKu8ayEG6S7I+s11uOQIyTr0nUdZPy51noECceladhOojkPBxzdODT8q3dVsqZRU1lvg6Kfw5MVNjY= X-Received: by 2002:a5b:3:0:b0:816:c63:dc96 with SMTP id a3-20020a5b0003000000b008160c63dc96mr972144ybp.119.1675896727702; Wed, 08 Feb 2023 14:52:07 -0800 (PST) MIME-Version: 1.0 References: <08e04b5d2fc7a2300a52fb7fff1bc6316a53927c.1675690847.git.quic_charante@quicinc.com> <8f40873d-8a9c-bcec-6742-885478365e4c@quicinc.com> In-Reply-To: <8f40873d-8a9c-bcec-6742-885478365e4c@quicinc.com> From: Suren Baghdasaryan Date: Wed, 8 Feb 2023 14:51:56 -0800 Message-ID: Subject: Re: [PATCH V6 2/2] mm: shmem: implement POSIX_FADV_[WILL|DONT]NEED for shmem To: Charan Teja Kalla Cc: akpm@linux-foundation.org, hughd@google.com, willy@infradead.org, markhemm@googlemail.com, rientjes@google.com, shakeelb@google.com, mhocko@suse.com, vbabka@suse.cz, quic_pkondeti@quicinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: D1D5520012 X-Rspamd-Server: rspam01 X-Stat-Signature: pabhjhtu9naahs77ktazpyp9juqgzymi X-HE-Tag: 1675896728-6120 X-HE-Meta: U2FsdGVkX1+I/QPqny8Fxp87HI1i5B0yR4LyBO8uutw50aoGI21oRXSNbks8rygRyy27/1N55vD79GzeoAFryB7vAKBrssQztuSZoc+jI14jNkTb6/2VL3w52cIU1sPPT1BS5eeqi42FGtuoQml9uK77vfDZfA2RX45IxRB68DzNed1vmWcoifhwl8BK2XBZGEtQmz7HjtBcTHUws2oMWsdaUuTcD/DON77Zknmz/7ADBFdR6xBKYg7xuefrtcwZ0BcamtAbrtkt04W6Ddd/+Bwzu129GoRJKgE9k+UfGZZfub0L0eYZ38u44njr9KvwpFBoNHdoJR7hUFJDcTc3eN+4l79sbJ/6XlCDMpM5WoPKK0WDNcYUQC8biSVmBif/Hx4JqcXULNXUyAiORj1exR4ugD/d0k94yUNha36dCu3f9jCsT20faas8RbH/nrl+u/8Yde4hgFwCJ05UjicCKZFAtIOPuiR01+AYOOM2sr1FfGDnJWjE0w1fVLkO7qwdKO5TDB7nBT4DWgJqhVsfEfx1WcPV+rQVbydlLTeu82iy4Ig5zuyn+tuFJmMMSN9ZDehuDVxD17dDDou+95ZKtd36l7lWwzjUeqqS6a30AYMvtnSj/5YiBVjyaIzVGCGtHyebMr646aDwP8U8FnQg5TtC2z7lUBLLy17miv6nktJE6p1lOqSVIqUP0uwjW8v+XhwOpjk37lb+QAeldL2q3j6rvzjyCwoOjuwzFwWGSRlaBZGgQyc811zLIpX5JoLxBqaLBUcpzfE36Ju3qQtRKnj2FqqvJfmWYkik6chJyr65h5Fz7zIpcaTS6L+aHRUhYuw/BbBeG8hDbTvRj6y+apC24lOS9rwvsWwRX8cN3xF2oQLGLS3spVs42/+/5v1bjpAANNCY7+LJWRgCVsyVUAcoPEBtmHAMhQ2gHv62J6StXFCDIU83EP/FI3qMFsaNK4lGJJPvL0mCAiwsvOd nOY3SqqJ l6a8Uw9snm2kSAPM5bi43EvBl0jX8/Jgay20CW3Q0UAMBp1S3IyiQmXtx4gFJuM4UyxkVZClflRhYbSTivgWIAT39BTrWy0ISuvNxLYOlAi2w9RsZm7IqhNTErnJX8zrcs2Gj4G3Da37mTiOgXgvfcJsxNcvnYjjAb8bGIgV2vn8O7YTOFH3C5o8n2UIcG6cs9ly4eE/BH2Vihg4TstQqB8UvjlM/thfnws9x8jjdN9mFbL2Is4ipVOYC7ZNCufwlUvoO9wkkwxZwLPz7WsUduAsyFYJ/ni7YWnJY/CVmjJIyz/zJabhPRz9xbE1K59aab94KHs3lx9GBBR8Wb/peGU53edzFla2ylFLb X-Bogosity: Ham, tests=bogofilter, spamicity=0.001580, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 8, 2023 at 6:55 AM Charan Teja Kalla wrote: > > Thanks Suren!! > > On 2/8/2023 4:18 AM, Suren Baghdasaryan wrote: > >> +static int shmem_fadvise(struct file *file, loff_t offset, loff_t len, int advice) > >> +{ > >> + loff_t endbyte; > >> + pgoff_t start_index; > >> + pgoff_t end_index; > >> + struct address_space *mapping; > >> + struct inode *inode = file_inode(file); > >> + int ret = 0; > >> + > >> + if (S_ISFIFO(inode->i_mode)) > >> + return -ESPIPE; > >> + > >> + mapping = file->f_mapping; > >> + if (!mapping || len < 0 || !shmem_mapping(mapping)) > >> + return -EINVAL; > >> + > >> + endbyte = fadvise_calc_endbyte(offset, len); > >> + > >> + start_index = offset >> PAGE_SHIFT; > >> + end_index = endbyte >> PAGE_SHIFT; > >> + switch (advice) { > >> + case POSIX_FADV_DONTNEED: > > Should (SHMEM_I(inode)->flags & VM_LOCKED) be checked here too? > > > Is this w.r.t context from shmem_lock() perspective which does set this > flag? If so, Isn't the PageUnevictable check cover this part? And to > avoid unnecessary Unevictable check later on the locked shmem file, How > about just checking mapping_unevictable() before performing > shmem_fadvise_dontneed)()? Please let me know If I failed to get your point. Yes, you got my point and checking for mapping_unevictable() should work fine I think. > > >> + ret = shmem_fadvise_dontneed(mapping, start_index, end_index); > >> + break; > >> + case POSIX_FADV_WILLNEED: > >> + ret = shmem_fadvise_willneed(mapping, start_index, end_index); > >> + break; > >> + case POSIX_FADV_NORMAL: > >> + case POSIX_FADV_RANDOM: > >> + case POSIX_FADV_SEQUENTIAL: > >> + case POSIX_FADV_NOREUSE: > > --Charan