From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A8A8CE7AA6 for ; Fri, 6 Sep 2024 00:03:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8227C6B0089; Thu, 5 Sep 2024 20:03:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AAA06B008A; Thu, 5 Sep 2024 20:03:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64CDE6B008C; Thu, 5 Sep 2024 20:03:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 460FB6B0089 for ; Thu, 5 Sep 2024 20:03:49 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DF5B5A0E95 for ; Fri, 6 Sep 2024 00:03:48 +0000 (UTC) X-FDA: 82532364936.20.88FDB55 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf05.hostedemail.com (Postfix) with ESMTP id F2D25100010 for ; Fri, 6 Sep 2024 00:03:46 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2Rw+18WU; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725580947; a=rsa-sha256; cv=none; b=M+4FQVPFfUNYoLHB8iUukMEb3yYDeRY00zrGMZePecFDU3xSncA1Rj8+VGRrcjJbtCLlCK lyx+WfWfawZVsk2ff0EDVjkFZJpcJq47ArkPC1vboAKSSGGEi0fb2L6PLPhC4nysW6oMFB CfC4zR8qkWfZDZSdHqFycPnE3i60n0U= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2Rw+18WU; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of surenb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=surenb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725580947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JPXmI/TyDF/D9y/43rIHmWzNwquQ5JxVMzVjaWvYv9w=; b=Fca2TFcHjbV7AXj/wdrtnXLB0Jy2JstJIC27IqMOHU/P2nOPBfTegPqZ6XFOnClPeg4Eeh s/nfeUasnw8hilJ/1UrYbwIDAKkqHaRNqqeWXaRB1pbl2SeRE4Iu4QcJRCoIAyvzOoU6Up 8P5UAL0lcWzyayXI+iDDvV/oqiW50b0= Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-4567deb9f9dso69451cf.1 for ; Thu, 05 Sep 2024 17:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725581026; x=1726185826; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JPXmI/TyDF/D9y/43rIHmWzNwquQ5JxVMzVjaWvYv9w=; b=2Rw+18WUzWFhfZomxJ7moBDbNyczz+jU32HpGkmVHvgJjBpPEbqNp+HtHXaAobEE+q wwQwRbtT0msI8+o0wBD8jxIrl/qA+Yhu1Anye76W8n7gGFjpEXbo1PUvyvOwELQLK9iX bW4JFV+uWsh6hEZLLqQ2N4S5FEsDgAohBvjPEITS3derQcGLPuC2z1aCwFCm+DCTUFYE fw8M1gy3eg7sDBRlJ01oykjV8CE/9W1pQXJ6cZrFRDm7KZcHfzZFQMM8F77Zs9M22ziV O9tRrGhb2DAx/QcpvQPtC/cnxP7B0VV8yhv3Y3QShYA8BnX1S5Z2mhma9N0JPHIMwjBg cf3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725581026; x=1726185826; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JPXmI/TyDF/D9y/43rIHmWzNwquQ5JxVMzVjaWvYv9w=; b=JZd94meCtbZ5iztAueVi3nlgRLtJ4YbDVjuQ233kItgUJUZYdlPJP480YuIb7o6xvF tUvPY4GNUUyUOwp+981B9vHcniw6giYhj/s3S7Re6f3n8Jgk/MJvPFnE/4D8JVY50Gcl YYluLUrlvxYdW2hHpmpd1JaWQC8wCDkLtreudLSzRZBlTWQ9Wl8F1e+t4hUaE7hgDXOB 1p76ZpDtcx+SdGokSh5BBepWotEakLINIy3EM3iQ05fp7moodaPWGF/TfaVrrHsBUf+n AXfkWk7p3WiP2axdbL+Z5s7zAtqwdbpQGVkRuuy7WKzl8A4TrMjhEy4QDau05If0nd4J IIiA== X-Forwarded-Encrypted: i=1; AJvYcCVJTnRORug09RAaugte12irZjd8dY7z9gEs8k8eLW5/JsOJOqCg6epMHsnVBN//tpaAGq/qcrh1xQ==@kvack.org X-Gm-Message-State: AOJu0YzRshDowmiA0dkItvP6oeAIvkxK7IciS35cDtmieIU4I58m+iM4 0kWO2dE2YG77178ddPZQoCpcLqPEkgrzTq1Tsm+juBipYY67EOrVvFncjkI4gDLjhZT5AY38SuD HfPreANJ/UmY16ZZaNheLxao+YLg2Ne/Qt4d0 X-Google-Smtp-Source: AGHT+IEMZOh/UzoIimnuqEtAjbzHrbOYH62Ua2jrTuhF/uafkgaZriow6f5Xx4zrd1iIHD53QkVwCDQzgbxVfYoEb7g= X-Received: by 2002:ac8:7d0e:0:b0:447:e2f0:4d17 with SMTP id d75a77b69052e-4580e534e70mr361941cf.7.1725581025736; Thu, 05 Sep 2024 17:03:45 -0700 (PDT) MIME-Version: 1.0 References: <20240903213649.3566695-1-yuzhao@google.com> <20240903213649.3566695-3-yuzhao@google.com> <20240905162524.72c5bbefa075adb466ea6057@linux-foundation.org> In-Reply-To: <20240905162524.72c5bbefa075adb466ea6057@linux-foundation.org> From: Suren Baghdasaryan Date: Thu, 5 Sep 2024 17:03:33 -0700 Message-ID: Subject: Re: [PATCH mm-unstable v1 3/3] mm/codetag: add pgalloc_tag_copy() To: Andrew Morton Cc: Yu Zhao , Kent Overstreet , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F2D25100010 X-Stat-Signature: wyrt3g4b4nn8kiq1wzgkck4mxhwhygr1 X-Rspam-User: X-HE-Tag: 1725581026-879760 X-HE-Meta: U2FsdGVkX18UoVXn8gSR8HXt6apWQCGAwy0PARyIFlhKP1UiS/YrmeQ1/gAOjDmyClV/G8iNaXJkY1YaMSMlFACCTlWWA4Ie+nD0KzisoPeyguE09PCtkD4QDzJoU36bP9z4vzjVGhxcxq5ux1Py/Yyh/GkRSQLMjtmcbrFQajDAzitl5ZGl8mBn9yNBcwJMXJwNqTK5aqmU5Kiv5kePyzUlzUJABYOCS88z5NjUrKnzKmFJbdZ/DlHal5dY4+p3T1dyp0wQtIqV5CbwsS1uqYnQCRjboLFPPeu5Rh+lrIBIPK6M//urCssSl9/cxnfyi2twBtgBa4d5LUY8Eb8BI4HS22hTbYDfqDDQwPjyn7TpR6IbxTRs3PU5B59CNKrZSOU0QtyhYwOD3FRXi1zA8yQh6LGV1w0fkEz1N3Mx2leWWNbudQzK9h4fjOgIuvYRnEXpbLzfwh1kBgUS3uDSwmgtML/EriEwONZiIP/qzOCd06u0uLZh5f2ImWskRAoL6IY0OtMY6utiEwzxdeGyWaUefC49yZCOQr8OOTi+lxegp7oivXn2PH/waLoLnx+IIHq6TqNqO5wu+jH4Z3FrfkJ4qp1Ghz26ARVFWKfW4c60o0hELQtT+J1k6RxM4RrU8G0pftxCsQpKy3hIVrmUHRBZcYYQ50kA2JyUQ0P1BFX9B/6MocQdrTpYsAZt16Dnr9naajEGNiBv2QZvN5EXzCgNZlgpUfKXTeNvGNqMl/vfTeVI0TGu6283SUUGD0O+oNdZokvfNJ3KmW5X2q93jekDUedqJKGnjvPuIri1KN78kxiqn8sbCatkC3eUTg0VjPlyhF//VtYAP2OqCPWnnRC3fCq3hVl/2fSJLL+k+8Y/g/u2RFsY4ZR8V4Pmhs5G+Fk0FU9hRvfyahhw64L/rtcKwDjQlwX48Eu3dvE98onBremrDCCZ+WftHwOukQEN0vf4ihwKQYoFxXmMn2V 7LF9NBwF 30f1k1zw2JlTRixkTenIjWhUEfJWHWPXrXcT8sXSN5zR9L37iYjXFIOiY4ofks9g8Uhgp0PanehuxUs2fzKATjx1gkjfAN2RMCkgA7VTvV9JMhaCmjaNfv1SzVrlnVqRX3jey6f+yZ7VIeyz0dTlfruJhVL0L7LKTNNBYWtcGtQupOW24Fj1nFRwuPCTQP2efoOYFZyAueaV60tzNW00fbe9ZpnzqTAmkZZRylxuXy5xnmLX8HCPMsKC7D8rTGbOFz762QyH7TVCLZUO7duj5EO5FWEYC/iNIxaAK7dElzqWjvec7C6X6npY5Sbipms1vIZvb X-Bogosity: Ham, tests=bogofilter, spamicity=0.031246, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 5, 2024 at 4:25=E2=80=AFPM Andrew Morton wrote: > > On Tue, 3 Sep 2024 15:36:49 -0600 Yu Zhao wrote: > > > Add pgalloc_tag_copy() to transfer the codetag from the old folio to > > the new one during migration. This makes original allocation sites > > persist cross migration rather than lump into compaction_alloc, e.g., > > # echo 1 >/proc/sys/vm/compact_memory > > # grep compaction_alloc /proc/allocinfo > > > > Before this patch: > > 132968448 32463 mm/compaction.c:1880 func:compaction_alloc > > > > After this patch: > > 0 0 mm/compaction.c:1880 func:compaction_alloc > > > > I'm thinking that [2/3] should be backported? Yes, should be CC'ed to stable #6.10 > > And possibly this one, but for that we should identify a Fixes:, please. I think for this one Fixes: dcfe378c81f7 ("lib: introduce support for page allocation tagging") would be the most appropriate. I'll review all 3 fixes later today. Thanks!